Repository navigation
test(agent): cover subscription ack without sequence - #16969
Conversation
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1908 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.69 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T12:55:01.571Z",
"gitSha": "909f250454f5545388ad40d320ba87bee71035d3",
"branch": "christian-byrne/phs-28-doc-subscribed-without-seq",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2046.0190000000011,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.336,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.6,
"heapDeltaBytes": 1037116,
"heapUsedBytes": 70697592,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 9.198999999999998,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.470999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.264999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.574,
"heapDeltaBytes": -2453808,
"heapUsedBytes": 67611792,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 8.246,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2072.5130000000718,
"styleRecalcs": 84,
"styleRecalcDurationMs": 47.283,
"layouts": 14,
"layoutDurationMs": 4.784999999999999,
"taskDurationMs": 1038.77,
"heapDeltaBytes": -6515336,
"heapUsedBytes": 63326744,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 164.221,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.0309999999909,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.107,
"layouts": 14,
"layoutDurationMs": 4.538,
"taskDurationMs": 865.3919999999999,
"heapDeltaBytes": -6587248,
"heapUsedBytes": 63707064,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 147.04399999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1676.631000000043,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.117,
"layouts": 6,
"layoutDurationMs": 1.0610000000000002,
"taskDurationMs": 358.603,
"heapDeltaBytes": 5082764,
"heapUsedBytes": 75603584,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.988999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1680.9200000000146,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.924000000000001,
"layouts": 6,
"layoutDurationMs": 1.2,
"taskDurationMs": 358.763,
"heapDeltaBytes": 5094504,
"heapUsedBytes": 75584568,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.24,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 640.231999999969,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.58799999999997,
"heapDeltaBytes": 17845624,
"heapUsedBytes": 88258460,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 152.903,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 648.0260000000726,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.536999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.74,
"heapDeltaBytes": 18540008,
"heapUsedBytes": 88489172,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 152.578,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.56199999999,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.574999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.4399999999999,
"heapDeltaBytes": -13997304,
"heapUsedBytes": 87399152,
"domNodes": -267,
"jsHeapTotalBytes": 458752,
"scriptDurationMs": 36.236,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.276000000049,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.037000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.9599999999999,
"heapDeltaBytes": -14118964,
"heapUsedBytes": 87632788,
"domNodes": -270,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 34.251,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2158.5329999999203,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.603,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1520.1979999999999,
"heapDeltaBytes": 22575304,
"heapUsedBytes": 88791380,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 737.869,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2145.354999999995,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.292000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1517.6740000000002,
"heapDeltaBytes": 18588828,
"heapUsedBytes": 84761960,
"domNodes": -278,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 738.501,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3548.086000000012,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.56,
"layouts": 60,
"layoutDurationMs": 12.875000000000002,
"taskDurationMs": 1674.169,
"heapDeltaBytes": 9463836,
"heapUsedBytes": 76551736,
"domNodes": -11,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 754.331,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3511.0939999999573,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.347000000000001,
"layouts": 60,
"layoutDurationMs": 12.677,
"taskDurationMs": 1646.117,
"heapDeltaBytes": 11739196,
"heapUsedBytes": 79587372,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 737.777,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3003.598000000011,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.404000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1880.233,
"heapDeltaBytes": 21957272,
"heapUsedBytes": 90000184,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 934.2260000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3052.9880000000276,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.086,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1901.2910000000002,
"heapDeltaBytes": 22373752,
"heapUsedBytes": 90027452,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 960.674,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.793000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.124000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.4,
"heapDeltaBytes": 22294468,
"heapUsedBytes": 88028208,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.05,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.7539999999544,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.699,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.366,
"heapDeltaBytes": 10439148,
"heapUsedBytes": 87392480,
"domNodes": -276,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 33.385,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 619.1929999999957,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.266,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.173,
"heapDeltaBytes": 15159540,
"heapUsedBytes": 87999156,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.91099999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.5380000000041,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.77,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.17,
"heapDeltaBytes": 15170516,
"heapUsedBytes": 87770176,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.27100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2031.6179999999804,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.6000000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.37600000000003,
"heapDeltaBytes": -12100260,
"heapUsedBytes": 60880884,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.002000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.693999999925,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.795000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.587,
"heapDeltaBytes": -8729004,
"heapUsedBytes": 64119296,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.060999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.8770000000022,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.817,
"layouts": 18,
"layoutDurationMs": 5.675,
"taskDurationMs": 803.322,
"heapDeltaBytes": -12456612,
"heapUsedBytes": 60337016,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 100.64,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.104999999976,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.068999999999996,
"layouts": 18,
"layoutDurationMs": 5.282,
"taskDurationMs": 785.612,
"heapDeltaBytes": -10694776,
"heapUsedBytes": 61747132,
"domNodes": -294,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 99.545,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.9310000000141,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.411,
"layouts": 16,
"layoutDurationMs": 14.698000000000002,
"taskDurationMs": 943.3429999999998,
"heapDeltaBytes": -5628592,
"heapUsedBytes": 85852184,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.253000000000004,
"eventListeners": 2387,
"totalBlockingTimeMs": 126,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8331.920999999966,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5548.353,
"heapDeltaBytes": 8866596,
"heapUsedBytes": 84917672,
"domNodes": -268,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2480.8669999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8245.467000000077,
"styleRecalcs": 246,
"styleRecalcDurationMs": 36.142999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5510.682,
"heapDeltaBytes": -12551924,
"heapUsedBytes": 89285644,
"domNodes": -270,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 2486.025,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18191.00500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17413.023,
"heapDeltaBytes": -24317964,
"heapUsedBytes": 179248660,
"domNodes": -6548,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 295.695,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17817.69399999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17214.178999999996,
"heapDeltaBytes": -32232688,
"heapUsedBytes": 176085428,
"domNodes": -6548,
"jsHeapTotalBytes": -7118848,
"scriptDurationMs": 292.11899999999997,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22426.56599999998,
"styleRecalcs": 168,
"styleRecalcDurationMs": 22.16299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22114.119000000002,
"heapDeltaBytes": -23218176,
"heapUsedBytes": 186859936,
"domNodes": -6548,
"jsHeapTotalBytes": -6250496,
"scriptDurationMs": 1001.3140000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21957.75100000003,
"styleRecalcs": 168,
"styleRecalcDurationMs": 19.728000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21618.777000000002,
"heapDeltaBytes": -44857272,
"heapUsedBytes": 168897088,
"domNodes": -6548,
"jsHeapTotalBytes": -7905280,
"scriptDurationMs": 895.4709999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 230,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6428.33799999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.28799999999997,
"layouts": 20,
"layoutDurationMs": 34.916000000000004,
"taskDurationMs": 6334.924999999999,
"heapDeltaBytes": -23552740,
"heapUsedBytes": 175023780,
"domNodes": -6548,
"jsHeapTotalBytes": 10199040,
"scriptDurationMs": 114.53099999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 615,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6308.487000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.779,
"layouts": 20,
"layoutDurationMs": 36.114000000000004,
"taskDurationMs": 6188.955999999999,
"heapDeltaBytes": -33780996,
"heapUsedBytes": 175550328,
"domNodes": -6577,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 112.41700000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 417,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9165.124999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8827.801,
"heapDeltaBytes": 3909932,
"heapUsedBytes": 176537064,
"domNodes": 0,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 144.8790000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9051.67300000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8619.868000000002,
"heapDeltaBytes": 7871024,
"heapUsedBytes": 174525164,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 164.18700000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 33.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 102.83000000003995,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.607000000000001,
"layouts": 2,
"layoutDurationMs": 1.3290000000000002,
"taskDurationMs": 74.232,
"heapDeltaBytes": 2986164,
"heapUsedBytes": 71379116,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.993000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 96.00999999997839,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.244999999999997,
"layouts": 2,
"layoutDurationMs": 0.9300000000000003,
"taskDurationMs": 67.596,
"heapDeltaBytes": 2997144,
"heapUsedBytes": 71822652,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.672000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16969 +/- ##
==========================================
+ Coverage 81.23% 82.79% +1.56%
==========================================
Files 2464 2046 -418
Lines 126966 119487 -7479
Branches 32036 30209 -1827
==========================================
- Hits 103141 98932 -4209
+ Misses 23310 20375 -2935
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| } | ||
| ) | ||
|
|
||
| it('accepts doc_subscribed without seq', () => { |
There was a problem hiding this comment.
🟡 Medium — This test locks in doc_subscribed{ok:true} with no seq watermark as a valid accepted frame, but the consumer mishandles that shape: LayoutFollowerBridge.onDocSubscribed derives catchUpPending from subscribed.seq ?? null, so a seq-less ack leaves the catch-up bypass disarmed and the catch-up frame is later judged stale against lastSeq and dropped, silently losing the only frame carrying what the state vector lacked. Either require a valid seq on successful acks (failures may still omit it), or add coverage for the seq-less ack race in followerSubscription.test.ts, whose docSubscribedFrame fixture always defaults seq: 1.
Raised by 2 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case).
| const sequencedFrame = ( | ||
| type: 'doc_subscribed' | 'doc_reset', | ||
| seq: unknown | ||
| seq?: unknown |
There was a problem hiding this comment.
🟢 Low — Making the helper's seq optional removes the compile-time guarantee that the negative it.for cases actually pass a value, so a future sequencedFrame('doc_reset') call would type-check and pass vacuously — the parser returns null because seq is absent, not because the value under test was rejected. Consider a separate no-seq helper so the invalid-value cases still require an argument.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| ) | ||
|
|
||
| it('accepts doc_subscribed without seq', () => { | ||
| expect(parseServerDocFrame(sequencedFrame('doc_subscribed'))).toEqual({ |
There was a problem hiding this comment.
⚪ Nit — toEqual ignores properties whose value is undefined, so this assertion passes whether the parser omits seq or emits seq: undefined, and cannot catch a regression that leaks the key through. The sibling case for the same wire shape (accepts doc_ops_result without seq) uses not.toHaveProperty('seq'); matching that idiom would actually verify omission.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Read at eb105ef: the new assertion is real, the parser omits seq through the conditional spread at docFrameClient.ts:314 and :339. Nothing to add.
…#18486) ## Summary Keep invalid-sequence parser cases type-safe and make absent `doc_subscribed.seq` coverage verify key omission explicitly. ## Changes - **What**: Requires `sequencedFrame` callers to supply a sequence, gives the absent-sequence case its own fixture, and asserts the parsed frame has no `seq` property. `sequencedFrame` now emits `seq` directly, so `unsequencedSubscribedFrame` is the only omission path and the two fixtures cannot own the same state. ## Review Focus This closes the two residual test-quality findings from Comfy-Org#16969 (comment) and Comfy-Org#16969 (comment). **Corrected — the third finding is not covered, contrary to what this description said before.** The consumer-level concern from Comfy-Org#16969 (comment) is still open. Merged PR Comfy-Org#17611 pins a *different* ordering: a seq-less (or seq-0) `ok` ack followed by `doc_update` seq 1, which is the healthy path. The hazard in that finding is the overtaking order — a seq-less ack sets `ackSeq = null`, so `catchUpPending` stays `false` (`layoutFollowerBridge.ts` `onDocSubscribed`), `isCatchUp` can therefore never become `true`, and once a live frame has advanced `lastSeq` the catch-up at the omitted baseline is dropped by `rejectStaleUpdate` as stale. Nothing tests that. Narrowing the claim rather than adding the test here, because the missing case belongs in `followerSubscription.test.ts` against the bridge and, on the reading above, would land as a failing pin rather than a passing one — which does not belong in a fixture-split PR. Raised and confirmed by @DrJKL twice on this PR; recorded as a follow-up so it is not lost with this description. Local verification: focused Vitest (28 passed), `oxlint` and `oxfmt --check` on the changed file. Hosted CI remains the authority for the full suite. ## Screenshots (if applicable) Not applicable; test-only change.
Summary
Restores explicit coverage that a
doc_subscribedacknowledgement without optionalseqmetadata remains valid.Changes
seqand adds the missing behavioral regression.Review Focus
This is intentionally parser-neutral and remains valid regardless of the invalid-present
seqpolicy tracked separately byphs-27.Source: #16487 (comment)
Follow-up: #16932 (
phs-28)