Skip to content

[backport cloud/1.53] fix(billing): remove the failed-verification retry affordance - #16931

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16123-to-cloud-1.53
Sep 4, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16123-to-cloud-1.53

Conversation

@huntcsg

@huntcsg huntcsg commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Backport of #16123 to cloud/1.53.

Cherry-picked merge commit a39b1ce9fa3727dedcb366f0bec7434ddb847352 onto backport-16123-to-cloud-1.53 from origin/cloud/1.53.

One conflict, in src/platform/workspace/composables/useSubscriptionCheckout.test.ts: cloud/1.53 hasn't yet picked up an unrelated main-side refactor of the vi.hoisted(...) mock-fixture block (a nullableString helper + block-body-with-return style). Resolved by keeping cloud/1.53's own existing structure/style and applying only this PR's actual semantic change on top of it — removing the now-unused mockRetryPaymentAuthentication fixture — rather than pulling in the unrelated style refactor as a side effect of the backport.

No package.json, pnpm-lock.yaml, or test-snapshot changes were part of this commit, so none of those special-case conflict rules applied.

Full suite of the 7 touched test files: 341/341 passing on cloud/1.53. typecheck/lint clean (verified via the pre-commit hook and independently).

"Retry verification" was a no-op that reported itself as a success, so a
failed 3DS challenge put the customer in a loop; this removes the
affordance and restricts `handleNextAction` to the one state it is
correct for.

- **What**: `stripe.handleNextAction()` resumes an *in-progress*
challenge. After a failed one the PaymentIntent is
`requires_payment_method` with `next_action: null`, so the call resolves
with no error and no effect — which `runPaymentIntentAction` read as
success, set `authenticationState: 'processing'`, and let the next poll
re-derive `failed_retryable`. The button came back and the customer
looped. A tester on `test-v2` hit exactly that.

Retry is a fresh attempt, not a re-confirmation of the existing intent,
so the fix is a removal:

- `retryPaymentAuthentication` now requires `authenticationState ===
'requires_action'`; `canRetryAuthentication` is derived for
`requires_action` alone. A failed challenge or a plain decline never
offers to resume.
- On the surviving path, an intent that resolves *without advancing*
past its pre-challenge status is reported as failed rather than
`processing` (`RESUMED_INTENT_STATUSES`). The intent can move between
poll and click, so the assertion is on the returned status, not on the
pre-call state.
- `setAuthenticationRetry` → `setAuthenticationFailed`; its `canRetry`
parameter is gone, since the answer is now always no.
- Preview components (`SubscriptionAddPaymentPreviewWorkspace.vue`,
`SubscriptionTransitionPreviewWorkspace.vue`) lose the retry button, the
`retryAuthentication` emit, and the `canRetryAuthentication` /
`isAuthenticating` props — `isAuthenticating` existed only to spin that
button. The failure alert stays.
- Both dialog hosts (`SubscriptionRequiredDialogContentUnified.vue`,
`SubscriptionRequiredDialogContentWorkspace.vue`) drop the corresponding
bindings, and `useSubscriptionCheckout` drops the now-unused
`canRetryAuthentication` / `isAuthenticating` /
`retryPaymentAuthentication` exports.
- `TopUpCreditsDialogContentWorkspace.vue` keeps the in-page resume,
because `requires_action` is the case it is correct for — relabelled
`completeVerification`, and `topupActionOperation` now selects on
`authenticationState` so a failed top-up still shows its error instead
of dropping out of the dialog.
- `billingOperation.retryVerification` and the now-unreachable
`billingOperation.authenticationManagerRequired` are removed from all 15
locale files. Non-en locales are generated, and `pnpm locale:check`
reports `0 prunable keys` against this diff — the manual removal matches
what `pnpm locale` would prune.

- **Breaking**: none for users; the removed affordance never worked.

**A deliberately removed assertion.** `billingOperationStore.test.ts`
previously asserted retry was offered for `decline_reason:
'card_declined'` and that `retryPaymentAuthentication` resolved `true`
there. That is the incoherence this ticket dissolves — a decline is not
a resumable challenge, and `handleNextAction` can never satisfy one. The
test is kept and inverted: the decline detail is still surfaced, retry
resolves `false`, and Stripe is never called. Every other assertion
about the `failed_retryable` presentation (error text persists, polling
continues, Stripe is not relaunched automatically) is preserved.

**The test that would have caught this** is `reports a resume that
returns an unmoved intent as failed, not processing` in
`billingOperationStore.test.ts` — `handleNextAction` resolves `{
paymentIntent: { status: 'requires_payment_method' } }` with no error.
Every pre-existing test mocked either a clean success or an explicit
error, which is the gap the defect shipped through. Verified red before
the guard (`authenticationState: "processing"`), green after.

**`failed_retryable` still has no in-dialog next step on `main`.** The
design routes it to the declined step, which arrives with #15923 (which
sets `checkoutStep = 'declined'` on a failed charge) and #15944 (which
renders it). Neither exists here, so this PR stops at the removal rather
than inventing a step those branches own. `verificationRecoveryActive`
is left alone for the same reason.

**Overlaps in flight.** #15923 touches `billingOperationStore.ts`, both
preview components, `SubscriptionRequiredDialogContentUnified.vue`,
`useSubscriptionCheckout.ts` and `en/main.json`; #15944 touches the last
two; #15942 touches `SubscriptionAddPaymentPreviewWorkspace.vue`.
Whichever lands second will need a rebase.

The store field is still named `canRetryAuthentication` even though it
now means "the live challenge can be resumed in page". Renaming it would
touch the store, the top-up dialog and ~20 test assertions, and widen
the conflict surface with the three open branches, so it is left for a
follow-up.

- `TopUpCreditsDialogContentWorkspace.vue` gained a dedicated "Start
over" control for `failed_retryable` (`ddaf8761c5`,
`9966ba07`→`31b3547774`, `4700fe8a43`), addressing the
permanently-disabled/spinning verification button dante01yoon flagged in
review. `isAddingCredits` excludes `failed_retryable` so a fresh attempt
isn't locked out.
- `SubscriptionAddPaymentPreviewWorkspace.vue` /
`SubscriptionTransitionPreviewWorkspace.vue`'s "Complete verification"
button now also excludes `failed_retryable` (`ed0cfefea4`) — the
retry-removal simplification had dropped that exclusion, so a stale
`actionUrl` from an abandoned challenge could show the button next to
the failure alert.
- Fixed a `displayState` masking bug (`ff8d647278`): a genuinely new
server-issued challenge (fresh client secret) was being permanently
masked as `failed_retryable` once an operation had failed once, so the
one case where resume used to work stopped working. The mask now only
holds while the secret is unchanged.
- Fixed the topup verifying-step watcher not observing `canTopUp`
(`0ccad0db74`), and a naming cleanup dropping the `isPolling` alias for
`isAddingCredits` (`5a0ff6d33a`).
- **"Start over" no longer discards the operation client-side**
(`bdd50937ea`): `startOverTopup` now calls a new `dismissOperation`,
which sets a `dismissed` flag instead of deleting the operation. Polling
continues and a late success/failure still resolves normally;
`dismissed` only excludes the operation from the `topupActionOperation`
/ `isAddingCredits` selectors a dialog reads. A server-side cancel
(BE-10064/BE-11559) would let a dismissal actually end the operation;
noted in a code comment for when that lands.
- **`RESUMED_INTENT_STATUSES` inverted to `UNMOVED_INTENT_STATUSES`**
(`bdd50937ea`/`bf2632f764`): now a denylist of the three statuses that
mean the intent didn't move (`requires_payment_method`,
`requires_action`, `canceled`) instead of an allowlist of "advanced"
ones. An unlisted or future Stripe status — including the
previously-ambiguous `requires_confirmation` — now resolves
optimistically to `processing` and lets the next poll's server-derived
`authentication_state` correct it, rather than reporting a live payment
as failed.

**Regression coverage**: this fix is entirely covered at the Vitest
unit/component level (`billingOperationStore.test.ts`,
`TopUpCreditsDialogContentWorkspace.test.ts`, and the preview component
tests) rather than with a new Playwright spec. A 3DS challenge
round-trips through Stripe's own hosted UI, which isn't something this
repo's Playwright setup drives end-to-end today (no existing spec
exercises a real or mocked 3DS challenge); the unit-level coverage
exercises every branch of the actual state machine this PR changes
(`displayState` masking, `canRetryAuthentication` gating, the dialog's
step transitions) more precisely than an E2E spec could without a much
larger mocking investment. dante01yoon accepted this rationale.

**Screenshots — outstanding, explicit merge gate per dante01yoon**: I
can't produce the requested AS-IS/TO-BE captures myself — driving a real
3DS challenge needs a live Stripe test environment and cloud backend
connectivity this sandbox doesn't have. Per review, this PR should not
merge until someone with that access posts into this description:
- **TO BE (subscription previews)** — button gone, alert intact (a
rendered component state; doesn't need a real challenge).
- **TO BE (top-up `failed_retryable` + "Start over")** —
`TopUpCreditsDialogContentWorkspace.test.ts` already mounts exactly this
state (doesn't need a real challenge either).
- **AS IS (the loop on `main`)** — needs the live environment; this is
the one that shows the actual defect.
@huntcsg
huntcsg requested a review from ltdrdata as a code owner September 4, 2026 04:52
@huntcsg huntcsg added the backport Backporting a PR onto a release candidate label Sep 4, 2026
@huntcsg
huntcsg requested review from a team and comfyui-wiki as code owners September 4, 2026 04:52
@huntcsg huntcsg added the backport Backporting a PR onto a release candidate label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1890 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/04/2026, 04:56:13 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 140ms TBT · 82.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.2 MB heap
vue-large-graph-pan: · 57.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 33ms TBT · 174.4 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 481ms TBT · 166.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 515ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 57.2 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 41ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 925ms
canvas-mouse-sweep: script duration 168ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.6 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -156
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 360ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 459ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.9 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 588ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.8 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -184
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1658ms
large-graph-pan: script duration 827ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 78.2 MB
large-graph-pan: DOM nodes -134
large-graph-pan: event listeners -74
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1676ms
large-graph-zoom: script duration 763ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.9 MB
large-graph-zoom: DOM nodes 1
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1939ms
legacy-node-drag: script duration 970ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.1 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 573ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.4 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -154
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 405ms
subgraph-dom-widget-clipping: script duration 139ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 519ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.4 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 38ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 855ms
subgraph-mouse-sweep: script duration 115ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.9 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 12
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 977ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 140ms
subgraph-transition-enter: heap used 82.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5754ms
viewport-pan-sweep: script duration 2699ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.5 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -74
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16509ms
vue-large-graph-idle: script duration 265ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.2 MB
vue-large-graph-idle: DOM nodes -6550
vue-large-graph-idle: event listeners -7476
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 168
vue-large-graph-pan: task duration 20586ms
vue-large-graph-pan: script duration 898ms
vue-large-graph-pan: TBT 33ms
vue-large-graph-pan: heap used 174.4 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 32ms
vue-node-resize-workload: style recalc duration 90ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6030ms
vue-node-resize-workload: script duration 122ms
vue-node-resize-workload: TBT 481ms
vue-node-resize-workload: heap used 166.3 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7469
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 97ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.4 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-04T05:07:02.407Z",
  "gitSha": "bfa5fdf52125fb95dfd18bab715dc8c6191fbbd0",
  "branch": "backport-16123-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2015.2370000000133,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.305000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.993,
      "heapDeltaBytes": -11469372,
      "heapUsedBytes": 58231700,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.05,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2023.0160000000978,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.566,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.3690000000001,
      "heapDeltaBytes": -8877388,
      "heapUsedBytes": 61678160,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.390000000000002,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1939.6339999999554,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 41.404999999999994,
      "layouts": 14,
      "layoutDurationMs": 4.424,
      "taskDurationMs": 957.926,
      "heapDeltaBytes": -7180540,
      "heapUsedBytes": 63340380,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 176.288,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1855.4449999999179,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.771,
      "layouts": 14,
      "layoutDurationMs": 4.247,
      "taskDurationMs": 891.185,
      "heapDeltaBytes": -8533280,
      "heapUsedBytes": 61710320,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 159.362,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1731.2009999999987,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.584000000000003,
      "layouts": 6,
      "layoutDurationMs": 2.358,
      "taskDurationMs": 362.07500000000005,
      "heapDeltaBytes": 4404812,
      "heapUsedBytes": 74185912,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.057999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.2050000000545,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.774,
      "layouts": 6,
      "layoutDurationMs": 1.017,
      "taskDurationMs": 357.038,
      "heapDeltaBytes": 4696540,
      "heapUsedBytes": 74461424,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.452,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 678.3450000000357,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.2989999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.75199999999995,
      "heapDeltaBytes": -8058740,
      "heapUsedBytes": 62515464,
      "domNodes": 18,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 160.27599999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 630.7859999999437,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.09,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.68499999999995,
      "heapDeltaBytes": 18797076,
      "heapUsedBytes": 88299212,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 165.089,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2060.2349999999774,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.371000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 638.202,
      "heapDeltaBytes": 10461252,
      "heapUsedBytes": 86290968,
      "domNodes": -267,
      "jsHeapTotalBytes": -1654784,
      "scriptDurationMs": 36.38999999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2011.6460000000416,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.6530000000000018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 536.9049999999999,
      "heapDeltaBytes": 22223260,
      "heapUsedBytes": 87271752,
      "domNodes": -276,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.00600000000001,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2467.8279999999972,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.236000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1716.58,
      "heapDeltaBytes": -20553884,
      "heapUsedBytes": 80555128,
      "domNodes": -272,
      "jsHeapTotalBytes": -868352,
      "scriptDurationMs": 839.357,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2289.527000000021,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.540000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1598.6960000000001,
      "heapDeltaBytes": 17401144,
      "heapUsedBytes": 83352660,
      "domNodes": 4,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 814.2850000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3579.69300000002,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.017000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.434000000000001,
      "taskDurationMs": 1704.8910000000003,
      "heapDeltaBytes": 8151012,
      "heapUsedBytes": 75506392,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 769.66,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3544.693999999936,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.393999999999997,
      "layouts": 60,
      "layoutDurationMs": 12.025999999999998,
      "taskDurationMs": 1648.0710000000004,
      "heapDeltaBytes": 8132360,
      "heapUsedBytes": 75322660,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 756.0880000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3145.1170000000275,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.753999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1960.1160000000002,
      "heapDeltaBytes": 21914236,
      "heapUsedBytes": 89145300,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 975.683,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3106.6210000000183,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.7209999999999965,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1917.5990000000002,
      "heapDeltaBytes": 18227172,
      "heapUsedBytes": 85029940,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 963.6229999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.6540000000032,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.4540000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 573.4429999999999,
      "heapDeltaBytes": -15346008,
      "heapUsedBytes": 86969572,
      "domNodes": -273,
      "jsHeapTotalBytes": -831488,
      "scriptDurationMs": 33.762,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.6480000000893,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.067999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 571.69,
      "heapDeltaBytes": 22255928,
      "heapUsedBytes": 87943800,
      "domNodes": -270,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.002,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 582.6729999999998,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 9.359,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.43600000000004,
      "heapDeltaBytes": 14789920,
      "heapUsedBytes": 87337200,
      "domNodes": 14,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 139.59700000000004,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 584.2350000000351,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.514,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.78999999999996,
      "heapDeltaBytes": 14794488,
      "heapUsedBytes": 87578952,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 137.99,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.774000000003,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.653000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 549.771,
      "heapDeltaBytes": -7082504,
      "heapUsedBytes": 65166980,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.533999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.68799999994,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.719999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.27,
      "heapDeltaBytes": -8989240,
      "heapUsedBytes": 63676984,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.275,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1753.3030000000167,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 37.84700000000001,
      "layouts": 18,
      "layoutDurationMs": 5.464999999999999,
      "taskDurationMs": 866.227,
      "heapDeltaBytes": 1713376,
      "heapUsedBytes": 74322124,
      "domNodes": -298,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 114.53499999999998,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1756.2060000000201,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 38.92,
      "layouts": 18,
      "layoutDurationMs": 5.192,
      "taskDurationMs": 843.5839999999998,
      "heapDeltaBytes": -10621108,
      "heapUsedBytes": 61881936,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 114.73899999999998,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1434.53599999998,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 32.138,
      "layouts": 12,
      "layoutDurationMs": 15.327999999999998,
      "taskDurationMs": 976.8220000000003,
      "heapDeltaBytes": -5404108,
      "heapUsedBytes": 86835224,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 33.17199999999999,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8633.475999999973,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.765,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5811.606000000001,
      "heapDeltaBytes": 9157056,
      "heapUsedBytes": 84481584,
      "domNodes": -265,
      "jsHeapTotalBytes": -380928,
      "scriptDurationMs": 2698.813,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8368.911000000026,
      "styleRecalcs": 244,
      "styleRecalcDurationMs": 31.592000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5697.173000000001,
      "heapDeltaBytes": 23505996,
      "heapUsedBytes": 88542508,
      "domNodes": -274,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 2699.794,
      "eventListeners": 20,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17424.07800000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16724.104,
      "heapDeltaBytes": -26416948,
      "heapUsedBytes": 175104740,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2609152,
      "scriptDurationMs": 279.578,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16882.655999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16293.351999999999,
      "heapDeltaBytes": -32655232,
      "heapUsedBytes": 175563064,
      "domNodes": -6552,
      "jsHeapTotalBytes": -1708032,
      "scriptDurationMs": 250.68400000000003,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20972.848999999995,
      "styleRecalcs": 166,
      "styleRecalcDurationMs": 16.670999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20505.385,
      "heapDeltaBytes": -36980096,
      "heapUsedBytes": 176076352,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7360512,
      "scriptDurationMs": 902.491,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 35,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21096.15300000007,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 17.129000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20666.336000000003,
      "heapDeltaBytes": -18342976,
      "heapUsedBytes": 189738920,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3026944,
      "scriptDurationMs": 893.244,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 30,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6202.331000000015,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 91.50000000000003,
      "layouts": 20,
      "layoutDurationMs": 28.825000000000003,
      "taskDurationMs": 6055.793,
      "heapDeltaBytes": -43308124,
      "heapUsedBytes": 174082464,
      "domNodes": -6548,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 115.446,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 573,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6114.015999999992,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 88.67200000000003,
      "layouts": 20,
      "layoutDurationMs": 34.556000000000004,
      "taskDurationMs": 6004.519,
      "heapDeltaBytes": -28066044,
      "heapUsedBytes": 174610748,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10133504,
      "scriptDurationMs": 127.87599999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 389,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 117.9419999999709,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.447000000000001,
      "layouts": 2,
      "layoutDurationMs": 1.162,
      "taskDurationMs": 85.88800000000002,
      "heapDeltaBytes": 3229560,
      "heapUsedBytes": 71969820,
      "domNodes": 132,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.01,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 452.3309999999583,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 18.107000000000003,
      "layouts": 3,
      "layoutDurationMs": 0.8200000000000002,
      "taskDurationMs": 108.07300000000002,
      "heapDeltaBytes": 5053368,
      "heapUsedBytes": 73494296,
      "domNodes": 121,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.7090000000000005,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48081 70624 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.8% 255
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: c822589e-e0d7-424a-82b2-1d4d45a8f300

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@huntcsg
huntcsg enabled auto-merge (squash) September 4, 2026 04:53
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 4, 2026
@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...platform/workspace/stores/billingOperationStore.ts 88.46% 3 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.53   #16931   +/-   ##
=============================================
  Coverage              ?   83.34%           
=============================================
  Files                 ?     2023           
  Lines                 ?   117185           
  Branches              ?    32511           
=============================================
  Hits                  ?    97669           
  Misses                ?    19158           
  Partials              ?      358           
Flag Coverage Δ
e2e 66.58% <0.00%> (?)
unit 76.70% <96.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 90.18% <100.00%> (ø)
...nents/SubscriptionRequiredDialogContentUnified.vue 59.63% <ø> (ø)
...nts/SubscriptionRequiredDialogContentWorkspace.vue 100.00% <ø> (ø)
...ponents/SubscriptionTransitionPreviewWorkspace.vue 93.08% <100.00%> (ø)
.../components/TopUpCreditsDialogContentWorkspace.vue 87.50% <100.00%> (ø)
...m/workspace/composables/useSubscriptionCheckout.ts 92.43% <ø> (ø)
...platform/workspace/stores/billingOperationStore.ts 93.13% <88.46%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

deepme987 pushed a commit that referenced this pull request Sep 4, 2026
…ret-bearing steps

CodeRabbit's second review flagged that the i18n/-prefix check on the
custom `branch` workflow_dispatch input doesn't establish a trusted
ref: anyone able to create and dispatch an i18n/* branch could still
point checkout at code that exports OPENAI_API_KEY/PR_GH_TOKEN. Same
gap already closed on the sibling content-pipeline workflow (PR
#16906) by switching to github.ref_name, which is the ref GitHub
itself resolved the dispatch against and can't be spoofed the way a
free-text input can. Applies the same pattern here: drop the `branch`
input, use github.ref_name for checkout/concurrency/push,
persist-credentials: false plus permissions: contents: read on
checkout, and push via an explicit PR_GH_TOKEN credential.

review.test.ts: add the requested invalid-JSON reviewer response case
(parseVerdicts' JSON.parse throw path was untested).

Vercel `comfy-home-v1` check failure is unrelated: it's also failing
on unrelated open PRs (#16929, #16930, #16931) with authorization/team
errors, and `pnpm build` succeeds cleanly on this branch.
@huang47

huang47 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@christian-byrne this backport looks legit to me, will approve it, please take a look when you get a chance

@comfy-pr-bot
comfy-pr-bot merged commit 76609db into cloud/1.53 Sep 4, 2026
118 of 119 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16123-to-cloud-1.53 branch September 4, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants