Repository navigation
[backport cloud/1.53] fix(billing): remove the failed-verification retry affordance - #16931
Conversation
"Retry verification" was a no-op that reported itself as a success, so a
failed 3DS challenge put the customer in a loop; this removes the
affordance and restricts `handleNextAction` to the one state it is
correct for.
- **What**: `stripe.handleNextAction()` resumes an *in-progress*
challenge. After a failed one the PaymentIntent is
`requires_payment_method` with `next_action: null`, so the call resolves
with no error and no effect — which `runPaymentIntentAction` read as
success, set `authenticationState: 'processing'`, and let the next poll
re-derive `failed_retryable`. The button came back and the customer
looped. A tester on `test-v2` hit exactly that.
Retry is a fresh attempt, not a re-confirmation of the existing intent,
so the fix is a removal:
- `retryPaymentAuthentication` now requires `authenticationState ===
'requires_action'`; `canRetryAuthentication` is derived for
`requires_action` alone. A failed challenge or a plain decline never
offers to resume.
- On the surviving path, an intent that resolves *without advancing*
past its pre-challenge status is reported as failed rather than
`processing` (`RESUMED_INTENT_STATUSES`). The intent can move between
poll and click, so the assertion is on the returned status, not on the
pre-call state.
- `setAuthenticationRetry` → `setAuthenticationFailed`; its `canRetry`
parameter is gone, since the answer is now always no.
- Preview components (`SubscriptionAddPaymentPreviewWorkspace.vue`,
`SubscriptionTransitionPreviewWorkspace.vue`) lose the retry button, the
`retryAuthentication` emit, and the `canRetryAuthentication` /
`isAuthenticating` props — `isAuthenticating` existed only to spin that
button. The failure alert stays.
- Both dialog hosts (`SubscriptionRequiredDialogContentUnified.vue`,
`SubscriptionRequiredDialogContentWorkspace.vue`) drop the corresponding
bindings, and `useSubscriptionCheckout` drops the now-unused
`canRetryAuthentication` / `isAuthenticating` /
`retryPaymentAuthentication` exports.
- `TopUpCreditsDialogContentWorkspace.vue` keeps the in-page resume,
because `requires_action` is the case it is correct for — relabelled
`completeVerification`, and `topupActionOperation` now selects on
`authenticationState` so a failed top-up still shows its error instead
of dropping out of the dialog.
- `billingOperation.retryVerification` and the now-unreachable
`billingOperation.authenticationManagerRequired` are removed from all 15
locale files. Non-en locales are generated, and `pnpm locale:check`
reports `0 prunable keys` against this diff — the manual removal matches
what `pnpm locale` would prune.
- **Breaking**: none for users; the removed affordance never worked.
**A deliberately removed assertion.** `billingOperationStore.test.ts`
previously asserted retry was offered for `decline_reason:
'card_declined'` and that `retryPaymentAuthentication` resolved `true`
there. That is the incoherence this ticket dissolves — a decline is not
a resumable challenge, and `handleNextAction` can never satisfy one. The
test is kept and inverted: the decline detail is still surfaced, retry
resolves `false`, and Stripe is never called. Every other assertion
about the `failed_retryable` presentation (error text persists, polling
continues, Stripe is not relaunched automatically) is preserved.
**The test that would have caught this** is `reports a resume that
returns an unmoved intent as failed, not processing` in
`billingOperationStore.test.ts` — `handleNextAction` resolves `{
paymentIntent: { status: 'requires_payment_method' } }` with no error.
Every pre-existing test mocked either a clean success or an explicit
error, which is the gap the defect shipped through. Verified red before
the guard (`authenticationState: "processing"`), green after.
**`failed_retryable` still has no in-dialog next step on `main`.** The
design routes it to the declined step, which arrives with #15923 (which
sets `checkoutStep = 'declined'` on a failed charge) and #15944 (which
renders it). Neither exists here, so this PR stops at the removal rather
than inventing a step those branches own. `verificationRecoveryActive`
is left alone for the same reason.
**Overlaps in flight.** #15923 touches `billingOperationStore.ts`, both
preview components, `SubscriptionRequiredDialogContentUnified.vue`,
`useSubscriptionCheckout.ts` and `en/main.json`; #15944 touches the last
two; #15942 touches `SubscriptionAddPaymentPreviewWorkspace.vue`.
Whichever lands second will need a rebase.
The store field is still named `canRetryAuthentication` even though it
now means "the live challenge can be resumed in page". Renaming it would
touch the store, the top-up dialog and ~20 test assertions, and widen
the conflict surface with the three open branches, so it is left for a
follow-up.
- `TopUpCreditsDialogContentWorkspace.vue` gained a dedicated "Start
over" control for `failed_retryable` (`ddaf8761c5`,
`9966ba07`→`31b3547774`, `4700fe8a43`), addressing the
permanently-disabled/spinning verification button dante01yoon flagged in
review. `isAddingCredits` excludes `failed_retryable` so a fresh attempt
isn't locked out.
- `SubscriptionAddPaymentPreviewWorkspace.vue` /
`SubscriptionTransitionPreviewWorkspace.vue`'s "Complete verification"
button now also excludes `failed_retryable` (`ed0cfefea4`) — the
retry-removal simplification had dropped that exclusion, so a stale
`actionUrl` from an abandoned challenge could show the button next to
the failure alert.
- Fixed a `displayState` masking bug (`ff8d647278`): a genuinely new
server-issued challenge (fresh client secret) was being permanently
masked as `failed_retryable` once an operation had failed once, so the
one case where resume used to work stopped working. The mask now only
holds while the secret is unchanged.
- Fixed the topup verifying-step watcher not observing `canTopUp`
(`0ccad0db74`), and a naming cleanup dropping the `isPolling` alias for
`isAddingCredits` (`5a0ff6d33a`).
- **"Start over" no longer discards the operation client-side**
(`bdd50937ea`): `startOverTopup` now calls a new `dismissOperation`,
which sets a `dismissed` flag instead of deleting the operation. Polling
continues and a late success/failure still resolves normally;
`dismissed` only excludes the operation from the `topupActionOperation`
/ `isAddingCredits` selectors a dialog reads. A server-side cancel
(BE-10064/BE-11559) would let a dismissal actually end the operation;
noted in a code comment for when that lands.
- **`RESUMED_INTENT_STATUSES` inverted to `UNMOVED_INTENT_STATUSES`**
(`bdd50937ea`/`bf2632f764`): now a denylist of the three statuses that
mean the intent didn't move (`requires_payment_method`,
`requires_action`, `canceled`) instead of an allowlist of "advanced"
ones. An unlisted or future Stripe status — including the
previously-ambiguous `requires_confirmation` — now resolves
optimistically to `processing` and lets the next poll's server-derived
`authentication_state` correct it, rather than reporting a live payment
as failed.
**Regression coverage**: this fix is entirely covered at the Vitest
unit/component level (`billingOperationStore.test.ts`,
`TopUpCreditsDialogContentWorkspace.test.ts`, and the preview component
tests) rather than with a new Playwright spec. A 3DS challenge
round-trips through Stripe's own hosted UI, which isn't something this
repo's Playwright setup drives end-to-end today (no existing spec
exercises a real or mocked 3DS challenge); the unit-level coverage
exercises every branch of the actual state machine this PR changes
(`displayState` masking, `canRetryAuthentication` gating, the dialog's
step transitions) more precisely than an E2E spec could without a much
larger mocking investment. dante01yoon accepted this rationale.
**Screenshots — outstanding, explicit merge gate per dante01yoon**: I
can't produce the requested AS-IS/TO-BE captures myself — driving a real
3DS challenge needs a live Stripe test environment and cloud backend
connectivity this sandbox doesn't have. Per review, this PR should not
merge until someone with that access posts into this description:
- **TO BE (subscription previews)** — button gone, alert intact (a
rendered component state; doesn't need a real challenge).
- **TO BE (top-up `failed_retryable` + "Start over")** —
`TopUpCreditsDialogContentWorkspace.test.ts` already mounts exactly this
state (doesn't need a real challenge either).
- **AS IS (the loop on `main`)** — needs the live environment; this is
the one that shows the actual defect.
🎭 Playwright: ✅ 1890 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-04T05:07:02.407Z",
"gitSha": "bfa5fdf52125fb95dfd18bab715dc8c6191fbbd0",
"branch": "backport-16123-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.2370000000133,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.305000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.993,
"heapDeltaBytes": -11469372,
"heapUsedBytes": 58231700,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.05,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2023.0160000000978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.566,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.3690000000001,
"heapDeltaBytes": -8877388,
"heapUsedBytes": 61678160,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.390000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1939.6339999999554,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.404999999999994,
"layouts": 14,
"layoutDurationMs": 4.424,
"taskDurationMs": 957.926,
"heapDeltaBytes": -7180540,
"heapUsedBytes": 63340380,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 176.288,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.4449999999179,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.771,
"layouts": 14,
"layoutDurationMs": 4.247,
"taskDurationMs": 891.185,
"heapDeltaBytes": -8533280,
"heapUsedBytes": 61710320,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 159.362,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.2009999999987,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.584000000000003,
"layouts": 6,
"layoutDurationMs": 2.358,
"taskDurationMs": 362.07500000000005,
"heapDeltaBytes": 4404812,
"heapUsedBytes": 74185912,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.057999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.2050000000545,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.774,
"layouts": 6,
"layoutDurationMs": 1.017,
"taskDurationMs": 357.038,
"heapDeltaBytes": 4696540,
"heapUsedBytes": 74461424,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.452,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 678.3450000000357,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.2989999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.75199999999995,
"heapDeltaBytes": -8058740,
"heapUsedBytes": 62515464,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 160.27599999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 630.7859999999437,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.09,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.68499999999995,
"heapDeltaBytes": 18797076,
"heapUsedBytes": 88299212,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.089,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2060.2349999999774,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.371000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.202,
"heapDeltaBytes": 10461252,
"heapUsedBytes": 86290968,
"domNodes": -267,
"jsHeapTotalBytes": -1654784,
"scriptDurationMs": 36.38999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2011.6460000000416,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.6530000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.9049999999999,
"heapDeltaBytes": 22223260,
"heapUsedBytes": 87271752,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.00600000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2467.8279999999972,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.236000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1716.58,
"heapDeltaBytes": -20553884,
"heapUsedBytes": 80555128,
"domNodes": -272,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 839.357,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2289.527000000021,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.540000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1598.6960000000001,
"heapDeltaBytes": 17401144,
"heapUsedBytes": 83352660,
"domNodes": 4,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 814.2850000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3579.69300000002,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.017000000000001,
"layouts": 60,
"layoutDurationMs": 12.434000000000001,
"taskDurationMs": 1704.8910000000003,
"heapDeltaBytes": 8151012,
"heapUsedBytes": 75506392,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 769.66,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3544.693999999936,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.393999999999997,
"layouts": 60,
"layoutDurationMs": 12.025999999999998,
"taskDurationMs": 1648.0710000000004,
"heapDeltaBytes": 8132360,
"heapUsedBytes": 75322660,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 756.0880000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3145.1170000000275,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.753999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1960.1160000000002,
"heapDeltaBytes": 21914236,
"heapUsedBytes": 89145300,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 975.683,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3106.6210000000183,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.7209999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1917.5990000000002,
"heapDeltaBytes": 18227172,
"heapUsedBytes": 85029940,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 963.6229999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.6540000000032,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.4540000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.4429999999999,
"heapDeltaBytes": -15346008,
"heapUsedBytes": 86969572,
"domNodes": -273,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 33.762,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2028.6480000000893,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.067999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.69,
"heapDeltaBytes": 22255928,
"heapUsedBytes": 87943800,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.6729999999998,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.43600000000004,
"heapDeltaBytes": 14789920,
"heapUsedBytes": 87337200,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 139.59700000000004,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.2350000000351,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.514,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.78999999999996,
"heapDeltaBytes": 14794488,
"heapUsedBytes": 87578952,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 137.99,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.774000000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.653000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.771,
"heapDeltaBytes": -7082504,
"heapUsedBytes": 65166980,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.533999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.68799999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.719999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.27,
"heapDeltaBytes": -8989240,
"heapUsedBytes": 63676984,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.275,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.3030000000167,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.84700000000001,
"layouts": 18,
"layoutDurationMs": 5.464999999999999,
"taskDurationMs": 866.227,
"heapDeltaBytes": 1713376,
"heapUsedBytes": 74322124,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 114.53499999999998,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.2060000000201,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.92,
"layouts": 18,
"layoutDurationMs": 5.192,
"taskDurationMs": 843.5839999999998,
"heapDeltaBytes": -10621108,
"heapUsedBytes": 61881936,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 114.73899999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.53599999998,
"styleRecalcs": 16,
"styleRecalcDurationMs": 32.138,
"layouts": 12,
"layoutDurationMs": 15.327999999999998,
"taskDurationMs": 976.8220000000003,
"heapDeltaBytes": -5404108,
"heapUsedBytes": 86835224,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 33.17199999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8633.475999999973,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.765,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5811.606000000001,
"heapDeltaBytes": 9157056,
"heapUsedBytes": 84481584,
"domNodes": -265,
"jsHeapTotalBytes": -380928,
"scriptDurationMs": 2698.813,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8368.911000000026,
"styleRecalcs": 244,
"styleRecalcDurationMs": 31.592000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5697.173000000001,
"heapDeltaBytes": 23505996,
"heapUsedBytes": 88542508,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2699.794,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17424.07800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16724.104,
"heapDeltaBytes": -26416948,
"heapUsedBytes": 175104740,
"domNodes": -6548,
"jsHeapTotalBytes": 2609152,
"scriptDurationMs": 279.578,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16882.655999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16293.351999999999,
"heapDeltaBytes": -32655232,
"heapUsedBytes": 175563064,
"domNodes": -6552,
"jsHeapTotalBytes": -1708032,
"scriptDurationMs": 250.68400000000003,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20972.848999999995,
"styleRecalcs": 166,
"styleRecalcDurationMs": 16.670999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20505.385,
"heapDeltaBytes": -36980096,
"heapUsedBytes": 176076352,
"domNodes": -6548,
"jsHeapTotalBytes": -7360512,
"scriptDurationMs": 902.491,
"eventListeners": -7469,
"totalBlockingTimeMs": 35,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21096.15300000007,
"styleRecalcs": 170,
"styleRecalcDurationMs": 17.129000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20666.336000000003,
"heapDeltaBytes": -18342976,
"heapUsedBytes": 189738920,
"domNodes": -6548,
"jsHeapTotalBytes": -3026944,
"scriptDurationMs": 893.244,
"eventListeners": -7469,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6202.331000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.50000000000003,
"layouts": 20,
"layoutDurationMs": 28.825000000000003,
"taskDurationMs": 6055.793,
"heapDeltaBytes": -43308124,
"heapUsedBytes": 174082464,
"domNodes": -6548,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 115.446,
"eventListeners": -7469,
"totalBlockingTimeMs": 573,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6114.015999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.67200000000003,
"layouts": 20,
"layoutDurationMs": 34.556000000000004,
"taskDurationMs": 6004.519,
"heapDeltaBytes": -28066044,
"heapUsedBytes": 174610748,
"domNodes": -6548,
"jsHeapTotalBytes": 10133504,
"scriptDurationMs": 127.87599999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 389,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 117.9419999999709,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.447000000000001,
"layouts": 2,
"layoutDurationMs": 1.162,
"taskDurationMs": 85.88800000000002,
"heapDeltaBytes": 3229560,
"heapUsedBytes": 71969820,
"domNodes": 132,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.01,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 452.3309999999583,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.107000000000003,
"layouts": 3,
"layoutDurationMs": 0.8200000000000002,
"taskDurationMs": 108.07300000000002,
"heapDeltaBytes": 5053368,
"heapUsedBytes": 73494296,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.7090000000000005,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.53 #16931 +/- ##
=============================================
Coverage ? 83.34%
=============================================
Files ? 2023
Lines ? 117185
Branches ? 32511
=============================================
Hits ? 97669
Misses ? 19158
Partials ? 358
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…ret-bearing steps CodeRabbit's second review flagged that the i18n/-prefix check on the custom `branch` workflow_dispatch input doesn't establish a trusted ref: anyone able to create and dispatch an i18n/* branch could still point checkout at code that exports OPENAI_API_KEY/PR_GH_TOKEN. Same gap already closed on the sibling content-pipeline workflow (PR #16906) by switching to github.ref_name, which is the ref GitHub itself resolved the dispatch against and can't be spoofed the way a free-text input can. Applies the same pattern here: drop the `branch` input, use github.ref_name for checkout/concurrency/push, persist-credentials: false plus permissions: contents: read on checkout, and push via an explicit PR_GH_TOKEN credential. review.test.ts: add the requested invalid-JSON reviewer response case (parseVerdicts' JSON.parse throw path was untested). Vercel `comfy-home-v1` check failure is unrelated: it's also failing on unrelated open PRs (#16929, #16930, #16931) with authorization/team errors, and `pnpm build` succeeds cleanly on this branch.
|
@christian-byrne this backport looks legit to me, will approve it, please take a look when you get a chance |
Backport of #16123 to
cloud/1.53.Cherry-picked merge commit
a39b1ce9fa3727dedcb366f0bec7434ddb847352ontobackport-16123-to-cloud-1.53fromorigin/cloud/1.53.One conflict, in
src/platform/workspace/composables/useSubscriptionCheckout.test.ts:cloud/1.53hasn't yet picked up an unrelated main-side refactor of thevi.hoisted(...)mock-fixture block (anullableStringhelper + block-body-with-return style). Resolved by keepingcloud/1.53's own existing structure/style and applying only this PR's actual semantic change on top of it — removing the now-unusedmockRetryPaymentAuthenticationfixture — rather than pulling in the unrelated style refactor as a side effect of the backport.No
package.json,pnpm-lock.yaml, or test-snapshot changes were part of this commit, so none of those special-case conflict rules applied.Full suite of the 7 touched test files: 341/341 passing on
cloud/1.53.typecheck/lintclean (verified via the pre-commit hook and independently).