Skip to content

[backport cloud/1.53] fix(load3d): gate camera custom up on explicit useCustomUp flag - #16916

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-15957-to-cloud-1.53
Sep 4, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-15957-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #15957 to cloud/1.53

Automatically created by backport workflow.

## Summary
setCameraState treated any quaternion-bearing state as a custom up and
auto-enabled it, so restoring a node's own saved orbit state tilted the
camera up vector and compounded roll on every save/restore cycle.

Custom up now applies only when the state explicitly carries
useCustomUp, which getCameraState round-trips once a custom up has been
captured. The camera_info producer (CreateCameraInfo backend) sets the
flag. Add the Custom up / Natural up toggle to the menubar camera group
so flagged states can be switched back to the world up.

Need BE Comfy-Org/ComfyUI#14964
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 4, 2026
@comfy-pr-bot
comfy-pr-bot requested review from a team and jtydhr88 as code owners September 4, 2026 03:05
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 4, 2026 03:05
@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
comfy-home-v1 Error Error Sep 4, 2026 3:05am UTC

Request Review

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/04/2026, 03:07:38 AM UTC

Links

🎭 Playwright: ✅ 1890 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 137ms TBT · 82.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.6 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.6 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 68ms TBT · 169.9 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 396ms TBT · 171.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 524ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.0 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 45ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 959ms
canvas-mouse-sweep: script duration 158ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.2 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 377ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.3 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 448ms
dom-widget-clipping: script duration 156ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.0 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 596ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.9 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -75
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1603ms
large-graph-pan: script duration 766ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.7 MB
large-graph-pan: DOM nodes -134
large-graph-pan: event listeners -74
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1665ms
large-graph-zoom: script duration 745ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.7 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1902ms
legacy-node-drag: script duration 953ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.3 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 632ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.3 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -170
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 420ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 513ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.8 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 822ms
subgraph-mouse-sweep: script duration 106ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.5 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 13
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 949ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 137ms
subgraph-transition-enter: heap used 82.5 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5738ms
viewport-pan-sweep: script duration 2547ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.6 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -139
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17582ms
vue-large-graph-idle: script duration 298ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 162.6 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 155
vue-large-graph-pan: task duration 21625ms
vue-large-graph-pan: script duration 922ms
vue-large-graph-pan: TBT 68ms
vue-large-graph-pan: heap used 169.9 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6394ms
vue-node-resize-workload: script duration 113ms
vue-node-resize-workload: TBT 396ms
vue-node-resize-workload: heap used 171.9 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 7
workflow-execution: task duration 80ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.8 MB
workflow-execution: DOM nodes 120
workflow-execution: event listeners 37
Raw data
{
  "timestamp": "2026-09-04T03:19:35.216Z",
  "gitSha": "f3977ba73ff929f16144973e8a0203ebb1b25dc8",
  "branch": "backport-15957-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2053.798000000029,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.601,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 538.663,
      "heapDeltaBytes": -10691060,
      "heapUsedBytes": 59760388,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.435999999999998,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.99100000001,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.216,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.468,
      "heapDeltaBytes": -12059896,
      "heapUsedBytes": 57578284,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.794,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2061.1899999999537,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 50.602999999999994,
      "layouts": 14,
      "layoutDurationMs": 5.074999999999999,
      "taskDurationMs": 1036.4529999999997,
      "heapDeltaBytes": -9006416,
      "heapUsedBytes": 61172960,
      "domNodes": -284,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 169.297,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1855.2740000000085,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.207,
      "layouts": 14,
      "layoutDurationMs": 4.83,
      "taskDurationMs": 881.7420000000001,
      "heapDeltaBytes": -8775696,
      "heapUsedBytes": 60831612,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 147.369,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.2630000000313,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.939000000000004,
      "layouts": 6,
      "layoutDurationMs": 1.0559999999999998,
      "taskDurationMs": 383.06,
      "heapDeltaBytes": 4391328,
      "heapUsedBytes": 75049468,
      "domNodes": 75,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 12.793,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1682.160999999951,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.759000000000004,
      "layouts": 6,
      "layoutDurationMs": 1.095,
      "taskDurationMs": 371.69300000000004,
      "heapDeltaBytes": 4442536,
      "heapUsedBytes": 74553376,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.156,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 676.3219999999706,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.9430000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 453.997,
      "heapDeltaBytes": 18392828,
      "heapUsedBytes": 88146108,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 158.47,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 672.048000000018,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.0969999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.22700000000003,
      "heapDeltaBytes": -7726392,
      "heapUsedBytes": 62901408,
      "domNodes": 18,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 154.285,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.4860000000012,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.380999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 637.9999999999999,
      "heapDeltaBytes": -13990572,
      "heapUsedBytes": 86670256,
      "domNodes": -269,
      "jsHeapTotalBytes": -1355776,
      "scriptDurationMs": 33.376,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2002.7010000000018,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 4.005000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 553.24,
      "heapDeltaBytes": 22173792,
      "heapUsedBytes": 87234004,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.566999999999997,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2268.77300000001,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.561000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1631.03,
      "heapDeltaBytes": -18126856,
      "heapUsedBytes": 83212540,
      "domNodes": -270,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 769.6400000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2245.2670000000126,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 9.579999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1575.8220000000001,
      "heapDeltaBytes": 22119284,
      "heapUsedBytes": 88067184,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 763.135,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3481.2259999999924,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.621999999999996,
      "layouts": 60,
      "layoutDurationMs": 13.001,
      "taskDurationMs": 1680.319,
      "heapDeltaBytes": 7715948,
      "heapUsedBytes": 75014048,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 752.202,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3482.5889999999617,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.311000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.773000000000001,
      "taskDurationMs": 1650.63,
      "heapDeltaBytes": 8151816,
      "heapUsedBytes": 75401696,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 737.799,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3087.492999999995,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.299000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1951.1370000000002,
      "heapDeltaBytes": 21976840,
      "heapUsedBytes": 89775588,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 976.3040000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3009.501,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.155999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1851.8819999999998,
      "heapDeltaBytes": 23762816,
      "heapUsedBytes": 93234312,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 930.028,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.5229999999979,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.265999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 635.2030000000001,
      "heapDeltaBytes": -14850456,
      "heapUsedBytes": 87782724,
      "domNodes": -269,
      "jsHeapTotalBytes": -1355776,
      "scriptDurationMs": 35.967000000000006,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2040.8460000001014,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.5109999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 629.043,
      "heapDeltaBytes": 11079464,
      "heapUsedBytes": 86823944,
      "domNodes": -275,
      "jsHeapTotalBytes": -1654784,
      "scriptDurationMs": 37.952999999999996,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 606.1139999999909,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.368,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 421.42199999999997,
      "heapDeltaBytes": 14821880,
      "heapUsedBytes": 87493232,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 143.08200000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 606.3090000000102,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.728,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.77200000000005,
      "heapDeltaBytes": 14829840,
      "heapUsedBytes": 87360096,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 144.84199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2055.9339999999793,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.828000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 541.0870000000001,
      "heapDeltaBytes": -10360780,
      "heapUsedBytes": 62373008,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.559,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.875999999911,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.898999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.464,
      "heapDeltaBytes": -7277016,
      "heapUsedBytes": 65136328,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.389999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1765.307000000007,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.125,
      "layouts": 18,
      "layoutDurationMs": 5.477,
      "taskDurationMs": 844.1180000000002,
      "heapDeltaBytes": -11693472,
      "heapUsedBytes": 60588352,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 107.973,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.253000000037,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 35.052,
      "layouts": 18,
      "layoutDurationMs": 5.065,
      "taskDurationMs": 799.465,
      "heapDeltaBytes": -10171664,
      "heapUsedBytes": 62110100,
      "domNodes": -294,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 104.11800000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.1639999999943,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 31.015000000000008,
      "layouts": 13,
      "layoutDurationMs": 14.483999999999996,
      "taskDurationMs": 949.0459999999998,
      "heapDeltaBytes": -5568864,
      "heapUsedBytes": 86515336,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 31.761999999999997,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 137,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8392.622000000018,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 40.57899999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5784.201999999999,
      "heapDeltaBytes": -12020068,
      "heapUsedBytes": 88696428,
      "domNodes": -271,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 2583.548,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8280.213000000003,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 38.648,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5692.580999999999,
      "heapDeltaBytes": 27999812,
      "heapUsedBytes": 92916392,
      "domNodes": -269,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 2510.6810000000005,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17816.16600000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17487.502,
      "heapDeltaBytes": -41608096,
      "heapUsedBytes": 161812084,
      "domNodes": -6548,
      "jsHeapTotalBytes": 5238784,
      "scriptDurationMs": 298.148,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17960.247999999978,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17675.531,
      "heapDeltaBytes": -28503204,
      "heapUsedBytes": 179235592,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3428352,
      "scriptDurationMs": 297.489,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21692.59699999998,
      "styleRecalcs": 152,
      "styleRecalcDurationMs": 20.318999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21429.932999999997,
      "heapDeltaBytes": -50876700,
      "heapUsedBytes": 162406544,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7884800,
      "scriptDurationMs": 922.1760000000002,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 113,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22033.839999999942,
      "styleRecalcs": 157,
      "styleRecalcDurationMs": 21.04600000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21819.427,
      "heapDeltaBytes": -3132604,
      "heapUsedBytes": 193932692,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3858432,
      "scriptDurationMs": 922.494,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6481.381999999996,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.33700000000005,
      "layouts": 20,
      "layoutDurationMs": 25.373000000000008,
      "taskDurationMs": 6444.982,
      "heapDeltaBytes": -18338368,
      "heapUsedBytes": 184993808,
      "domNodes": -6548,
      "jsHeapTotalBytes": 19161088,
      "scriptDurationMs": 118.807,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 368,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6400.579999999991,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.42599999999999,
      "layouts": 20,
      "layoutDurationMs": 24.917999999999996,
      "taskDurationMs": 6342.381999999999,
      "heapDeltaBytes": -28962728,
      "heapUsedBytes": 175523100,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4853760,
      "scriptDurationMs": 107.63700000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 424,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 113.26199999996334,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 14.203999999999999,
      "layouts": 2,
      "layoutDurationMs": 1.225,
      "taskDurationMs": 77.18700000000003,
      "heapDeltaBytes": 3148264,
      "heapUsedBytes": 71500148,
      "domNodes": 128,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.8759999999999994,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 129.90300000001298,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.376,
      "layouts": 3,
      "layoutDurationMs": 0.8740000000000002,
      "taskDurationMs": 81.895,
      "heapDeltaBytes": 3212524,
      "heapUsedBytes": 70690952,
      "domNodes": 112,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.409999999999999,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 4, 2026
@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #16916   +/-   ##
=============================================
  Coverage              ?   83.34%           
=============================================
  Files                 ?     2023           
  Lines                 ?   117191           
  Branches              ?    32520           
=============================================
  Hits                  ?    97667           
  Misses                ?    19176           
  Partials              ?      348           
Flag Coverage Δ
e2e 66.61% <25.00%> (?)
unit 76.69% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/load3d/menubar/CameraMenuGroup.vue 95.55% <100.00%> (ø)
src/extensions/core/load3d/CameraManager.ts 90.96% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit aaa0cca into cloud/1.53 Sep 4, 2026
110 of 111 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-15957-to-cloud-1.53 branch September 4, 2026 03:29

This branch had an error being deployed

1 failed deployment
Preview – comfy-home-v1 — e5393604 Deployed Sep 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants