Repository navigation
[backport cloud/1.53] fix(load3d): gate camera custom up on explicit useCustomUp flag - #16916
Conversation
## Summary setCameraState treated any quaternion-bearing state as a custom up and auto-enabled it, so restoring a node's own saved orbit state tilted the camera up vector and compounded roll on every save/restore cycle. Custom up now applies only when the state explicitly carries useCustomUp, which getCameraState round-trips once a custom up has been captured. The camera_info producer (CreateCameraInfo backend) sets the flag. Add the Custom up / Natural up toggle to the menubar camera group so flagged states can be switched back to the world up. Need BE Comfy-Org/ComfyUI#14964
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1890 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-04T03:19:35.216Z",
"gitSha": "f3977ba73ff929f16144973e8a0203ebb1b25dc8",
"branch": "backport-15957-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.798000000029,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.601,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.663,
"heapDeltaBytes": -10691060,
"heapUsedBytes": 59760388,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.435999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.99100000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.216,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.468,
"heapDeltaBytes": -12059896,
"heapUsedBytes": 57578284,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.794,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2061.1899999999537,
"styleRecalcs": 81,
"styleRecalcDurationMs": 50.602999999999994,
"layouts": 14,
"layoutDurationMs": 5.074999999999999,
"taskDurationMs": 1036.4529999999997,
"heapDeltaBytes": -9006416,
"heapUsedBytes": 61172960,
"domNodes": -284,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 169.297,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.2740000000085,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.207,
"layouts": 14,
"layoutDurationMs": 4.83,
"taskDurationMs": 881.7420000000001,
"heapDeltaBytes": -8775696,
"heapUsedBytes": 60831612,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 147.369,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.2630000000313,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.939000000000004,
"layouts": 6,
"layoutDurationMs": 1.0559999999999998,
"taskDurationMs": 383.06,
"heapDeltaBytes": 4391328,
"heapUsedBytes": 75049468,
"domNodes": 75,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 12.793,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1682.160999999951,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.759000000000004,
"layouts": 6,
"layoutDurationMs": 1.095,
"taskDurationMs": 371.69300000000004,
"heapDeltaBytes": 4442536,
"heapUsedBytes": 74553376,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.156,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 676.3219999999706,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.9430000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.997,
"heapDeltaBytes": 18392828,
"heapUsedBytes": 88146108,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 158.47,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 672.048000000018,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.0969999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.22700000000003,
"heapDeltaBytes": -7726392,
"heapUsedBytes": 62901408,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 154.285,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.4860000000012,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.380999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.9999999999999,
"heapDeltaBytes": -13990572,
"heapUsedBytes": 86670256,
"domNodes": -269,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 33.376,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2002.7010000000018,
"styleRecalcs": 2,
"styleRecalcDurationMs": 4.005000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.24,
"heapDeltaBytes": 22173792,
"heapUsedBytes": 87234004,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.566999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2268.77300000001,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.561000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1631.03,
"heapDeltaBytes": -18126856,
"heapUsedBytes": 83212540,
"domNodes": -270,
"jsHeapTotalBytes": -1130496,
"scriptDurationMs": 769.6400000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2245.2670000000126,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.579999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1575.8220000000001,
"heapDeltaBytes": 22119284,
"heapUsedBytes": 88067184,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 763.135,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3481.2259999999924,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.621999999999996,
"layouts": 60,
"layoutDurationMs": 13.001,
"taskDurationMs": 1680.319,
"heapDeltaBytes": 7715948,
"heapUsedBytes": 75014048,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 752.202,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3482.5889999999617,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.311000000000003,
"layouts": 60,
"layoutDurationMs": 12.773000000000001,
"taskDurationMs": 1650.63,
"heapDeltaBytes": 8151816,
"heapUsedBytes": 75401696,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 737.799,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3087.492999999995,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.299000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1951.1370000000002,
"heapDeltaBytes": 21976840,
"heapUsedBytes": 89775588,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 976.3040000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3009.501,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.155999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1851.8819999999998,
"heapDeltaBytes": 23762816,
"heapUsedBytes": 93234312,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 930.028,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.5229999999979,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.265999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.2030000000001,
"heapDeltaBytes": -14850456,
"heapUsedBytes": 87782724,
"domNodes": -269,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 35.967000000000006,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.8460000001014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5109999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.043,
"heapDeltaBytes": 11079464,
"heapUsedBytes": 86823944,
"domNodes": -275,
"jsHeapTotalBytes": -1654784,
"scriptDurationMs": 37.952999999999996,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.1139999999909,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.368,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.42199999999997,
"heapDeltaBytes": 14821880,
"heapUsedBytes": 87493232,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.08200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.3090000000102,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.728,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.77200000000005,
"heapDeltaBytes": 14829840,
"heapUsedBytes": 87360096,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.84199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2055.9339999999793,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.828000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.0870000000001,
"heapDeltaBytes": -10360780,
"heapUsedBytes": 62373008,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.559,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2016.875999999911,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.898999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.464,
"heapDeltaBytes": -7277016,
"heapUsedBytes": 65136328,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.389999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1765.307000000007,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.125,
"layouts": 18,
"layoutDurationMs": 5.477,
"taskDurationMs": 844.1180000000002,
"heapDeltaBytes": -11693472,
"heapUsedBytes": 60588352,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 107.973,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.253000000037,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.052,
"layouts": 18,
"layoutDurationMs": 5.065,
"taskDurationMs": 799.465,
"heapDeltaBytes": -10171664,
"heapUsedBytes": 62110100,
"domNodes": -294,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 104.11800000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.1639999999943,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.015000000000008,
"layouts": 13,
"layoutDurationMs": 14.483999999999996,
"taskDurationMs": 949.0459999999998,
"heapDeltaBytes": -5568864,
"heapUsedBytes": 86515336,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 31.761999999999997,
"eventListeners": 2381,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8392.622000000018,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.57899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5784.201999999999,
"heapDeltaBytes": -12020068,
"heapUsedBytes": 88696428,
"domNodes": -271,
"jsHeapTotalBytes": -1130496,
"scriptDurationMs": 2583.548,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8280.213000000003,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.648,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5692.580999999999,
"heapDeltaBytes": 27999812,
"heapUsedBytes": 92916392,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2510.6810000000005,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17816.16600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17487.502,
"heapDeltaBytes": -41608096,
"heapUsedBytes": 161812084,
"domNodes": -6548,
"jsHeapTotalBytes": 5238784,
"scriptDurationMs": 298.148,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17960.247999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17675.531,
"heapDeltaBytes": -28503204,
"heapUsedBytes": 179235592,
"domNodes": -6548,
"jsHeapTotalBytes": -3428352,
"scriptDurationMs": 297.489,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21692.59699999998,
"styleRecalcs": 152,
"styleRecalcDurationMs": 20.318999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21429.932999999997,
"heapDeltaBytes": -50876700,
"heapUsedBytes": 162406544,
"domNodes": -6548,
"jsHeapTotalBytes": -7884800,
"scriptDurationMs": 922.1760000000002,
"eventListeners": -7467,
"totalBlockingTimeMs": 113,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22033.839999999942,
"styleRecalcs": 157,
"styleRecalcDurationMs": 21.04600000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21819.427,
"heapDeltaBytes": -3132604,
"heapUsedBytes": 193932692,
"domNodes": -6548,
"jsHeapTotalBytes": 3858432,
"scriptDurationMs": 922.494,
"eventListeners": -7469,
"totalBlockingTimeMs": 23,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6481.381999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.33700000000005,
"layouts": 20,
"layoutDurationMs": 25.373000000000008,
"taskDurationMs": 6444.982,
"heapDeltaBytes": -18338368,
"heapUsedBytes": 184993808,
"domNodes": -6548,
"jsHeapTotalBytes": 19161088,
"scriptDurationMs": 118.807,
"eventListeners": -7471,
"totalBlockingTimeMs": 368,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6400.579999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.42599999999999,
"layouts": 20,
"layoutDurationMs": 24.917999999999996,
"taskDurationMs": 6342.381999999999,
"heapDeltaBytes": -28962728,
"heapUsedBytes": 175523100,
"domNodes": -6548,
"jsHeapTotalBytes": 4853760,
"scriptDurationMs": 107.63700000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 424,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 113.26199999996334,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.203999999999999,
"layouts": 2,
"layoutDurationMs": 1.225,
"taskDurationMs": 77.18700000000003,
"heapDeltaBytes": 3148264,
"heapUsedBytes": 71500148,
"domNodes": 128,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.8759999999999994,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 129.90300000001298,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.376,
"layouts": 3,
"layoutDurationMs": 0.8740000000000002,
"taskDurationMs": 81.895,
"heapDeltaBytes": 3212524,
"heapUsedBytes": 70690952,
"domNodes": 112,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.409999999999999,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #16916 +/- ##
=============================================
Coverage ? 83.34%
=============================================
Files ? 2023
Lines ? 117191
Branches ? 32520
=============================================
Hits ? 97667
Misses ? 19176
Partials ? 348
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15957 to
cloud/1.53Automatically created by backport workflow.