Skip to content

[backport core/1.53] fix(load3d): gate camera custom up on explicit useCustomUp flag - #16915

Merged
comfy-pr-bot merged 1 commit into
core/1.53from
backport-15957-to-core-1.53
Sep 4, 2026
Merged

comfy-pr-bot merged 1 commit into
core/1.53from
backport-15957-to-core-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #15957 to core/1.53

Automatically created by backport workflow.

## Summary
setCameraState treated any quaternion-bearing state as a custom up and
auto-enabled it, so restoring a node's own saved orbit state tilted the
camera up vector and compounded roll on every save/restore cycle.

Custom up now applies only when the state explicitly carries
useCustomUp, which getCameraState round-trips once a custom up has been
captured. The camera_info producer (CreateCameraInfo backend) sets the
flag. Add the Custom up / Natural up toggle to the menubar camera group
so flagged states can be switched back to the world up.

Need BE Comfy-Org/ComfyUI#14964
@comfy-pr-bot
comfy-pr-bot requested review from a team and jtydhr88 as code owners September 4, 2026 03:05
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 4, 2026
@vercel

vercel Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
comfy-home-v1 Error Error Sep 4, 2026 3:05am UTC

Request Review

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1893 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1872 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/04/2026, 03:14:03 AM UTC

Links

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 4, 2026
@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##           core/1.53   #16915      +/-   ##
=============================================
+ Coverage      83.31%   83.32%   +0.01%     
=============================================
  Files           2023     2023              
  Lines         117023   117085      +62     
  Branches       32453    33066     +613     
=============================================
+ Hits           97496    97565      +69     
+ Misses         19171    19162       -9     
- Partials         356      358       +2     
Flag Coverage Δ
e2e 66.60% <25.00%> (+0.01%) ⬆️
unit 76.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/load3d/menubar/CameraMenuGroup.vue 95.55% <100.00%> (+6.26%) ⬆️
src/extensions/core/load3d/CameraManager.ts 90.96% <100.00%> (-0.12%) ⬇️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 607ae16 into core/1.53 Sep 4, 2026
110 of 111 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-15957-to-core-1.53 branch September 4, 2026 03:27

This branch had an error being deployed

1 failed deployment
Preview – comfy-home-v1 — d73ff1ee Deployed Sep 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants