Repository navigation
[backport core/1.53] fix(load3d): gate camera custom up on explicit useCustomUp flag - #16915
Merged
Merged
Conversation
## Summary setCameraState treated any quaternion-bearing state as a custom up and auto-enabled it, so restoring a node's own saved orbit state tilted the camera up vector and compounded roll on every save/restore cycle. Custom up now applies only when the state explicitly carries useCustomUp, which getCameraState round-trips once a custom up has been captured. The camera_info producer (CreateCameraInfo backend) sets the flag. Add the Custom up / Natural up toggle to the menubar camera group so flagged states can be switched back to the world up. Need BE Comfy-Org/ComfyUI#14964
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
comfy-pr-bot
enabled auto-merge (squash)
September 4, 2026 03:05
Contributor
🎭 Playwright: ✅ 1893 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook |
jtydhr88
approved these changes
Sep 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.53 #16915 +/- ##
=============================================
+ Coverage 83.31% 83.32% +0.01%
=============================================
Files 2023 2023
Lines 117023 117085 +62
Branches 32453 33066 +613
=============================================
+ Hits 97496 97565 +69
+ Misses 19171 19162 -9
- Partials 356 358 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #15957 to
core/1.53Automatically created by backport workflow.