Skip to content

fix(crdt): preserve durable link intent across node re-adds - #16866

Closed
christian-byrne wants to merge 1 commit into
christian-byrne/cmp-delete-link-scope-1from
christian-byrne/cmp-delete-link-runtime-1
Closed

christian-byrne wants to merge 1 commit into
christian-byrne/cmp-delete-link-scope-1from
christian-byrne/cmp-delete-link-runtime-1

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Closes the seeded add/delete link divergence.
Keeps A7 named severance terminal.
No schema-v3 migration.

Full context for agent readers

Summary

  • Extends the existing A18 link-identity stamp row with the complete tuple it already owns, so incident links can be rematerialized after a higher-stamped node re-add.
  • Records explicit removed_links and winning disconnects under a separate terminal link_retired row; ordinary input displacement does not masquerade as explicit severance.
  • Revises ADR-022 and adds schema Amendment A19 to follow the accepted private-alpha single-format rule: schema remains v2, with no migration or dual reader.
  • Replaces the known seeded-snapshot divergence with both-order convergence and terminal-retirement assertions.

Stacked on #16819, which is stacked on #16644. The approved parent head was not modified.

Evidence

  • NODE_OPTIONS="--no-experimental-webstorage" node_modules/.bin/vitest run --config vitest.config.ts test/delete-node-lww-loser-removed-links.test.ts test/bounded-writes-liveness.test.ts test/connect-delete-equivalence.permutation.test.ts test/duplicate-link-id.permutation.test.ts test/wire-layout-contract.test.ts — 31/31 passed, including 6,144 connect/delete pair classifications and 12,288 normalized-link permutations.
  • NODE_OPTIONS="--no-experimental-webstorage" node_modules/.bin/tsc -p tsconfig.json — passed.
  • node_modules/.bin/eslint <changed TypeScript files> — 0 errors (repository baseline warnings only).
  • git diff --check — passed.

Risk

R3: changes durable CRDT link bookkeeping and restoration semantics. The focused permutation suites, seeded snapshot forks, wire snapshot check, mutation accounting, and terminal-retirement test cover the affected boundaries.

@christian-byrne christian-byrne added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 3, 2026
@christian-byrne christian-byrne self-assigned this Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 048969b2-80ae-4c08-9ea6-229bfa91a8b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1910 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1889 / ❌ 0 / ⚠️ 3 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 11:04:14 PM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 127ms TBT · 100.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.9 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.7 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 45ms TBT · 171.8 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 169ms TBT · 173.6 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 477ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 55.9 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -149
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 792ms
canvas-mouse-sweep: script duration 129ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 60.6 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -150
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 337ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 392ms
dom-widget-clipping: script duration 132ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 59.7 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 578ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.4 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1441ms
large-graph-pan: script duration 679ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.0 MB
large-graph-pan: DOM nodes -269
large-graph-pan: event listeners -148
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1600ms
large-graph-zoom: script duration 711ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 75.1 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1695ms
legacy-node-drag: script duration 816ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.9 MB
legacy-node-drag: DOM nodes -280
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 547ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.5 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 369ms
subgraph-dom-widget-clipping: script duration 122ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.6 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 457ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.8 MB
subgraph-idle: DOM nodes -294
subgraph-idle: event listeners -196
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 31ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 737ms
subgraph-mouse-sweep: script duration 84ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.5 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -196
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 820ms
subgraph-transition-enter: script duration 27ms
subgraph-transition-enter: TBT 127ms
subgraph-transition-enter: heap used 100.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5072ms
viewport-pan-sweep: script duration 2227ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.9 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13613ms
vue-large-graph-idle: script duration 255ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 157
vue-large-graph-pan: task duration 17379ms
vue-large-graph-pan: script duration 892ms
vue-large-graph-pan: TBT 45ms
vue-large-graph-pan: heap used 171.8 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7471
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 29ms
vue-node-resize-workload: style recalc duration 75ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5098ms
vue-node-resize-workload: script duration 98ms
vue-node-resize-workload: TBT 169ms
vue-node-resize-workload: heap used 173.6 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6922ms
vue-zoom-out-idle: script duration 116ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.4 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -10
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 10
workflow-execution: task duration 90ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.4 MB
workflow-execution: DOM nodes 124
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-03T23:10:42.278Z",
  "gitSha": "26947b6ccff972a7cfb37fbf2cd946d4a179ff90",
  "branch": "christian-byrne/cmp-delete-link-runtime-1",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2024.6210000000247,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.1000000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.037,
      "heapDeltaBytes": -11183796,
      "heapUsedBytes": 58585236,
      "domNodes": -278,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.777999999999999,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2056.8470000000616,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.385999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.95,
      "heapDeltaBytes": -11031744,
      "heapUsedBytes": 58696212,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.276,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1883.2819999999515,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 33.726,
      "layouts": 14,
      "layoutDurationMs": 4.53,
      "taskDurationMs": 803.2980000000001,
      "heapDeltaBytes": -8048876,
      "heapUsedBytes": 62110932,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 138.22400000000002,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1706.7329999999856,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 28.448999999999995,
      "layouts": 14,
      "layoutDurationMs": 3.7689999999999997,
      "taskDurationMs": 779.784,
      "heapDeltaBytes": -5563024,
      "heapUsedBytes": 65050760,
      "domNodes": -277,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 120.321,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.6799999999585,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.520000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.297,
      "taskDurationMs": 332.21500000000003,
      "heapDeltaBytes": 5108808,
      "heapUsedBytes": 75957724,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.115,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.0340000000879,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.453999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.134,
      "taskDurationMs": 342.156,
      "heapDeltaBytes": 4448268,
      "heapUsedBytes": 74496112,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.797999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 582.9830000000129,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.02,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.486,
      "heapDeltaBytes": -8091516,
      "heapUsedBytes": 62645376,
      "domNodes": 18,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 133.689,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 568.0560000000696,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.808000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.358,
      "heapDeltaBytes": -8122116,
      "heapUsedBytes": 62594448,
      "domNodes": 18,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 130.613,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2060.0180000000137,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.355000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 562.3869999999998,
      "heapDeltaBytes": -13517692,
      "heapUsedBytes": 87975412,
      "domNodes": -267,
      "jsHeapTotalBytes": -851968,
      "scriptDurationMs": 35.696,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2066.5859999999157,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.036999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 592.938,
      "heapDeltaBytes": 11553672,
      "heapUsedBytes": 86891060,
      "domNodes": -271,
      "jsHeapTotalBytes": -2723840,
      "scriptDurationMs": 33.562000000000005,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2134.0299999999957,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 9.431,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1418.7510000000002,
      "heapDeltaBytes": 18680620,
      "heapUsedBytes": 84487216,
      "domNodes": -271,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 673.821,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2195.471999999995,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.896000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1463.8240000000003,
      "heapDeltaBytes": -17304844,
      "heapUsedBytes": 85285748,
      "domNodes": -267,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 683.9240000000001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3571.089000000029,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.550999999999995,
      "layouts": 60,
      "layoutDurationMs": 14.047,
      "taskDurationMs": 1627.765,
      "heapDeltaBytes": 9248644,
      "heapUsedBytes": 76994164,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 717.957,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3505.894000000012,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.212,
      "layouts": 60,
      "layoutDurationMs": 13.374,
      "taskDurationMs": 1571.254,
      "heapDeltaBytes": 12770412,
      "heapUsedBytes": 80577536,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 703.922,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2765.7370000000583,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.024000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1674.896,
      "heapDeltaBytes": 22412184,
      "heapUsedBytes": 89830556,
      "domNodes": -277,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 806.6959999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2822.6039999999557,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.493999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1714.2900000000002,
      "heapDeltaBytes": 18976804,
      "heapUsedBytes": 86122620,
      "domNodes": -282,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 825.3829999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.2269999999962,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.576999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 554.131,
      "heapDeltaBytes": -15762544,
      "heapUsedBytes": 87731512,
      "domNodes": -266,
      "jsHeapTotalBytes": -1638400,
      "scriptDurationMs": 31.232999999999997,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.1039999999703,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.9669999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 540.7339999999999,
      "heapDeltaBytes": 10271088,
      "heapUsedBytes": 87479928,
      "domNodes": -272,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 30.869999999999994,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 574.141999999938,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.419,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 357.192,
      "heapDeltaBytes": 14861628,
      "heapUsedBytes": 87580000,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 118.54400000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 576.1699999999337,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.685,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 380.09399999999994,
      "heapDeltaBytes": 15168324,
      "heapUsedBytes": 87836336,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 126.163,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.2599999999647,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.965000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.3710000000001,
      "heapDeltaBytes": -8690384,
      "heapUsedBytes": 64170984,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.484000000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.338999999969,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.536000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.611,
      "heapDeltaBytes": -5341732,
      "heapUsedBytes": 67467052,
      "domNodes": -292,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 8.110999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.6920000000323,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.439,
      "layouts": 18,
      "layoutDurationMs": 4.537,
      "taskDurationMs": 726.696,
      "heapDeltaBytes": -10027116,
      "heapUsedBytes": 62797348,
      "domNodes": -293,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 83.19,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1713.1049999999277,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 31.131999999999998,
      "layouts": 18,
      "layoutDurationMs": 4.587,
      "taskDurationMs": 747.532,
      "heapDeltaBytes": -8750852,
      "heapUsedBytes": 64039692,
      "domNodes": -297,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 85.123,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1199.5749999999816,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 27.761000000000006,
      "layouts": 16,
      "layoutDurationMs": 11.985,
      "taskDurationMs": 820.058,
      "heapDeltaBytes": 21866768,
      "heapUsedBytes": 105747520,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 26.625000000000004,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8197.869999999966,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 34.937000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5069.7789999999995,
      "heapDeltaBytes": -12292564,
      "heapUsedBytes": 88937948,
      "domNodes": -271,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 2223.243,
      "eventListeners": -132,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8250.590999999986,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 34.039,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5073.76,
      "heapDeltaBytes": -8172924,
      "heapUsedBytes": 93320264,
      "domNodes": -269,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 2230.718,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14598.967000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13654.302000000001,
      "heapDeltaBytes": -14565064,
      "heapUsedBytes": 174767428,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1282048,
      "scriptDurationMs": 232.527,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14528.929999999946,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13570.815999999999,
      "heapDeltaBytes": -35104952,
      "heapUsedBytes": 174917368,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2301952,
      "scriptDurationMs": 278.248,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17847.451999999976,
      "styleRecalcs": 156,
      "styleRecalcDurationMs": 19.307999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17472.914000000004,
      "heapDeltaBytes": -25084084,
      "heapUsedBytes": 176663832,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4706304,
      "scriptDurationMs": 868.5200000000001,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 13,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17713.663999999993,
      "styleRecalcs": 158,
      "styleRecalcDurationMs": 19.34899999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17286.052000000003,
      "heapDeltaBytes": -32470712,
      "heapUsedBytes": 183655996,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3764224,
      "scriptDurationMs": 916.4639999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 77,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5259.436000000051,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 68.61899999999999,
      "layouts": 20,
      "layoutDurationMs": 23.698999999999998,
      "taskDurationMs": 5163.9090000000015,
      "heapDeltaBytes": -23246988,
      "heapUsedBytes": 179372336,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13344768,
      "scriptDurationMs": 103.16999999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 192,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5198.869999999943,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.563,
      "layouts": 20,
      "layoutDurationMs": 34.624,
      "taskDurationMs": 5032.301,
      "heapDeltaBytes": -25803164,
      "heapUsedBytes": 184659124,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4792320,
      "scriptDurationMs": 93.178,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 146,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7276.047999999946,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6917.720000000001,
      "heapDeltaBytes": -1437192,
      "heapUsedBytes": 173893388,
      "domNodes": 0,
      "jsHeapTotalBytes": -8388608,
      "scriptDurationMs": 115.483,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7311.083999999937,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6925.5960000000005,
      "heapDeltaBytes": 21072452,
      "heapUsedBytes": 183410076,
      "domNodes": 0,
      "jsHeapTotalBytes": -10485760,
      "scriptDurationMs": 115.97799999999997,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 482.4559999999565,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 23.288000000000004,
      "layouts": 4,
      "layoutDurationMs": 1.734,
      "taskDurationMs": 132.32,
      "heapDeltaBytes": 4917372,
      "heapUsedBytes": 73836264,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.550999999999998,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 72.73299999997107,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 8.918000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.9630000000000001,
      "taskDurationMs": 48.40399999999999,
      "heapDeltaBytes": 2954816,
      "heapUsedBytes": 71657308,
      "domNodes": 123,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 3.3249999999999997,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49228 74274 66.3% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.2% 1185
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.5% 259
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/comfy-multi-player/src/applier.ts 90.69% 4 Missing ⚠️
@@                             Coverage Diff                             @@
##           christian-byrne/cmp-delete-link-scope-1   #16866      +/-   ##
===========================================================================
- Coverage                                    80.76%   80.71%   -0.05%     
===========================================================================
  Files                                         2474     2473       -1     
  Lines                                       128074   128087      +13     
  Branches                                     32700    32678      -22     
===========================================================================
- Hits                                        103440   103387      -53     
- Misses                                       24119    24185      +66     
  Partials                                       515      515              
Flag Coverage Δ
e2e 66.27% <ø> (-0.43%) ⬇️
unit 76.73% <91.66%> (-0.01%) ⬇️
website-unit 56.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/comfy-multi-player/src/mint.ts 42.46% <100.00%> (+3.33%) ⬆️
packages/comfy-multi-player/src/applier.ts 59.46% <90.69%> (+1.70%) ⬆️

... and 51 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

pr-shepherd stage 2 (resolve conflicts): stopped without resolving, escalated as blocked-on-christian #448.

This PR is CONFLICTING against its own base branch christian-byrne/cmp-delete-link-scope-1, and the conflict is confined to a single file, packages/comfy-multi-player/docs/decisions/ADR-022-durable-link-intent.md, across six hunks. Every code file auto-merges cleanly. That shape normally means a routine rebase, but here the conflicting text is the decision record itself and the two sides are opposite architecture decisions, so resolving it either way would silently pick a winner.

This PR reuses the existing A18 rows in __stamps as durable link intent, keeps SCHEMA_VERSION at 2, and adds a terminal ["link_retired", id] row; the code matches, writing ["link", linkKey] and ["link_retired", linkKey] into stampsMap. Its base #16819 instead introduces a schema-v3 __link_state root with kind-specific eligibility and a v2 to v3 migration. Each ADR lists the other design under "Rejected alternatives". The base is also the newer of the two: its head 0fa26a3908 (2026-09-04T01:24Z) postdates this commit c33219d7bb (2026-09-03T22:54Z), it carries an approval from DrJKL, and that head elaborated the v3 eligibility table rather than retreating from it.

One substantive note for whichever design survives, since it bears on the choice. restoreDurableLinks() gates rematerialization on ["input", destination, tuple[4]], the concrete-input register only. applier.ts also carries a promoted-input register ("input", to_node, "grow", <full declared name>) and an autogrow register ["grow", to_node, link_id, rankScope] that no destination-input stamp participates in. For an autogrow link there is therefore no inputWinner to find, the eligibility check passes vacuously, and restoration is gated on endpoint existence alone, which is the gap the base ADR predicts when it rejects stamps-only intent. Would it be worth confirming whether that is intended for this slice and deferred, or an actual hole?

Branch is untouched at c33219d7bb; nothing was pushed, retargeted, or resolved. Next stage is the #448 ruling, then a rebase that reconciles both ADR copies in one commit.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: changes requested

I found two convergence failures in the durable-link state machine. The package's full op-pool property test fails for a connect, disconnect, and higher-stamped connect because retirement is conditional on which operation sees the live incumbent. Separately, re-adding a promoted-input destination restores both the displaced loser and winner because the stored intent does not retain the destination register identity or the metadata needed to rebuild the dynamic slot. Both failures contradict KA-4 and ADR-022's claim that durable registers alone determine materialization.

The schema text also needs to describe the new persisted forms consistently. Section 1 still defines every __stamps value as a three-field StampKey, section 3 says delete_node.removed_links writes no row, and section 4's compaction procedure mints from project(doc) and carries only still-live targets. That procedure drops the hidden intent this change depends on.

This PR targets #16819 at 72952823, and git merge-tree --write-tree 72952823 c33219d7 is clean even though GitHub currently reports dirty. However, #16819 has since advanced to 0fa26a39 with the opposing schema-v3 __link_state design. The rebase therefore needs an explicit architecture decision rather than a mechanical conflict resolution.

Validation on c33219d7: package tests report 870 passed and 1 failed; the focused promoted-input re-add probe fails; root and package typechecks pass; changed-file ESLint has no errors; format, Knip, build, purity, import, pin, profile-claim, configuration-generation, and corpus checks pass. CI has the same package permutation failure. The Playwright shard failure is an artifact-upload 403, and the ecosystem aggregate failure follows a cancelled shard.

if (prev != null) removeLink(doc, prev);
if (prev != null) {
removeLink(doc, prev);
retireLinkIntent(doc, prev, key);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This terminal retirement depends on whether disconnect happens to observe a live incumbent. The required full op-pool property test reproduces the divergence with connect 100@0a, disconnect @0b, and connect 100@0c: applying them in that order retires 100 and makes the higher connect a no-op, while applying 0c first makes both older input claims lose and leaves link 100 live. pnpm --dir packages/comfy-multi-player exec vitest run test/full-op-pool.permutation.test.ts -t "samples reproducible length-3-to-6" fails after 7,795 cases with that minimized counterexample. Please order disconnect retirement against later A18 identity winners rather than deriving terminal state from the currently materialized prev.

const destination = String(tuple[3]);
if (!nodes.has(source) || !nodes.has(destination)) return;

const inputTarget = JSON.stringify(["input", destination, tuple[4]]);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This reconstructs only the concrete target ["input", destination, slot]. Promoted inputs use ["input", destination, "grow", fullName], and autogrow restoration also needs the grow metadata and dynamic slot. I reproduced two promoted connects for one declared input, link 911 at stamp 1 and winning link 912 at stamp 2, followed by destination delete and re-add. Projection restores both links while the re-added destination has no input slot. Please persist or reuse the authoritative input target and enough grow data to rebuild the slot, with re-add coverage for promoted and autogrow links.

removed by a winning `disconnect`, records terminal retirement:

```text
["link_retired", String(link_id)] -> [counter, actor, op_id]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: Please update the normative sections, not only this amendment. Section 1 still says every __stamps value is [base_version, actor, op_id]; the section 3 register table still says delete_node.removed_links writes no row; and section 4 tells compactors to mint from project(doc) and retain only still-live stamp targets. The last procedure discards dematerialized link intent even though ADR-022 now says that re-minting from projection is insufficient.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Durable-link implementation and review fixes landed in the standalone package. Closing this superseded source without merge; preserving its branch and reviews.

Full context for agent readers

Christian requested completion of the standalone migration and retirement of accounted originals. This source remains at c33219d . Its replacement Comfy-Org/comfy-multi-player#206 merged as Comfy-Org/comfy-multi-player@11454e8 .

DrJKL's three inline findings and summary review have individual attributed dispositions, implementation and regression-test references at Comfy-Org/comfy-multi-player#206 (comment) : connect/disconnect/connect ordering, promoted/autogrow restoration, and normative stamp/severance/compaction consistency. Fresh source inspection found no later inline changes beyond September 10. The original changes-requested review remains historical evidence; this closure does not resolve its threads or transfer approval to another commit.

The earlier architecture conflict recorded at #16866 (comment) was reconciled by the standalone implementation's first-class durable link state, not by merging this old stamps-only implementation or adding old-layout compatibility. Do not rebase this source to revive the rejected alternative.

Original failing tests remain recorded at their original revision. Existing replacement test evidence is historical, not newly rerun under the resource hold. Closing this package-only source does not establish authenticated product acceptance, nor close the separate frontend adapter and packaging work.

No source branch deletion, retarget, release or deployment. Glossary: durable link intent is stored link identity/destination data retained while an endpoint is absent; autogrow is dynamic input-slot creation.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-test-unit Touches Agent-related unit/component tests or their support flag-exempt risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants