Repository navigation
[backport cloud/1.53] fix: preserve PrimitiveNode widget value on workflow load - #16858
Conversation
PrimitiveNode now keeps its serialized widget value and control mode after reload. Regression coverage reproduces the stale-target overwrite, the reroute path, and a cross-type leak. <details><summary>Full context for agent readers</summary> Workflow loading creates a PrimitiveNode widget after node configuration, so the target widget copy overwrote the primitive's serialized value. The control widget had the same symptom from a different cause: the restore read `widgetValueStore`, which `LGraphNode.configure` clears in its own `finally` before `_createWidget` ever runs, so `control_after_generate` always fell back to `fixed`. - Capture the serialized `widgets_values` and output type in `onConfigure`, chaining to `super` so handlers installed on `LGraphNode.prototype` still run. - Reapply index 0 after the target widget copy, including the asset-widget path, and consume the capture once the widget is built rather than on a lifecycle callback that several creation paths skip. - Bind the capture to the serialized output type, so a value cannot land on a widget of a different type and reach the backend through `applyToGraph`. - Restore the serialized control and filter values after widget creation. This covers both the `addValueControlWidgets` fallback and inputs that declare `control_after_generate`, which build their own control widget. Only values the control widget offers are written back. - Normalise `widgets_values` through `Array.from` the way base `configure` does, since custom nodes are documented to replace it with an array-like object. - Treat `recreateWidget` with no existing widgets as a first build. That is the only widget-creation path a Primitive feeding a Reroute has. - Remove `getPositionalRestoredWidgetValue`, which had no reachable caller left. - `widgetInputs.test.ts`: 32 passed. Every new test was run against the pre-fix code first and fails there. - `pnpm typecheck`, `pnpm knip`, `pnpm lint` (0 errors): passed. - CI green at `ab37448da5`. Restoration state lives on the `PrimitiveNode` instance rather than in `widgetValueStore`, which ADR 0003/0008 would prefer. The store mechanism could not work as written, because `LGraphNode.configure` clears the restoration entry before the primitive builds its widget. This needs a call: accept the instance field, or widen the restoration lifetime in the store and put it back there. Known gaps left out of scope: `widgets_values_named` is ignored when `LiteGraph.namedValuesRestore` is enabled, and a restored value is not range-checked against the rebuilt widget. Checklist item: #15973 Original review: #15924 (comment) Fixes #16007 </details>
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
🎭 Playwright: ✅ 1889 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-03T22:53:05.808Z",
"gitSha": "bb643d42fd8c8ac8c6cf7ed4122c9640919b0355",
"branch": "backport-16459-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2031.7000000000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.562999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.259,
"heapDeltaBytes": 12964540,
"heapUsedBytes": 82656988,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.011000000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2029.0350000000217,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.202000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.77200000000005,
"heapDeltaBytes": -12088640,
"heapUsedBytes": 58203304,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.601999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1971.1849999999913,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.285000000000004,
"layouts": 14,
"layoutDurationMs": 4.841,
"taskDurationMs": 992.21,
"heapDeltaBytes": -8221408,
"heapUsedBytes": 61441760,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 170.39200000000002,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1835.3049999999484,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.108000000000004,
"layouts": 14,
"layoutDurationMs": 3.9169999999999994,
"taskDurationMs": 873.1610000000001,
"heapDeltaBytes": 8192640,
"heapUsedBytes": 78741748,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 159.795,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1682.0220000000745,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.115,
"layouts": 6,
"layoutDurationMs": 1.177,
"taskDurationMs": 360.18799999999993,
"heapDeltaBytes": 4649232,
"heapUsedBytes": 75264812,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.826000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.5060000000713,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.027,
"layouts": 6,
"layoutDurationMs": 1.102,
"taskDurationMs": 345.1069999999999,
"heapDeltaBytes": 4399124,
"heapUsedBytes": 74703692,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.674000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 661.1669999999776,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.291,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.968,
"heapDeltaBytes": -7866164,
"heapUsedBytes": 62445520,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 161.07399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 626.4450000001034,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.9719999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.33700000000005,
"heapDeltaBytes": -7725268,
"heapUsedBytes": 62762496,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 161.776,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2058.6829999999736,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.856000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.688,
"heapDeltaBytes": -13345256,
"heapUsedBytes": 87215872,
"domNodes": -265,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 32.113,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.8819999999869,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.87,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.7630000000001,
"heapDeltaBytes": -13938736,
"heapUsedBytes": 86766012,
"domNodes": -267,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 31.59200000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2170.1790000000756,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.325000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1573.861,
"heapDeltaBytes": 13828788,
"heapUsedBytes": 79672732,
"domNodes": -278,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 787.9549999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2290.7490000000053,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.944999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1627.237,
"heapDeltaBytes": 23164960,
"heapUsedBytes": 88812424,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 812.5400000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3422.684000000004,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.236999999999998,
"layouts": 60,
"layoutDurationMs": 11.481000000000002,
"taskDurationMs": 1639.2989999999998,
"heapDeltaBytes": 11741476,
"heapUsedBytes": 79135068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 741.664,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3525.1069999999345,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.531999999999996,
"layouts": 60,
"layoutDurationMs": 12.02,
"taskDurationMs": 1675.1079999999997,
"heapDeltaBytes": 8149080,
"heapUsedBytes": 75364984,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 756.5939999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3090.9849999999324,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.6750000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1890.7050000000002,
"heapDeltaBytes": 21149524,
"heapUsedBytes": 88583352,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 953.9139999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3075.2939999999853,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.719999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1876.77,
"heapDeltaBytes": 20004788,
"heapUsedBytes": 86905352,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 923.913,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.757000000055,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.104999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.984,
"heapDeltaBytes": 21820812,
"heapUsedBytes": 86982796,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.408999999999992,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.0410000000875,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.397999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.026,
"heapDeltaBytes": -14971624,
"heapUsedBytes": 87277364,
"domNodes": -268,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 34.042,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.0619999999553,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.114,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.398,
"heapDeltaBytes": 14779576,
"heapUsedBytes": 87552996,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.423,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.4440000000805,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.973,
"heapDeltaBytes": 14848720,
"heapUsedBytes": 87207524,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 139.63299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2033.7329999999838,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.049000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.3740000000001,
"heapDeltaBytes": -8476616,
"heapUsedBytes": 63844932,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.5040000000000004,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.5670000000418,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.67,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.276,
"heapDeltaBytes": -7633428,
"heapUsedBytes": 64529216,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.755999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.6989999999014,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.94,
"layouts": 18,
"layoutDurationMs": 5.582,
"taskDurationMs": 822.679,
"heapDeltaBytes": 6501852,
"heapUsedBytes": 79206900,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 109.139,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.1390000000229,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.596000000000004,
"layouts": 18,
"layoutDurationMs": 5.673,
"taskDurationMs": 849.3980000000001,
"heapDeltaBytes": -9129468,
"heapUsedBytes": 63466612,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 111.75500000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.9490000000296,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.519999999999996,
"layouts": 15,
"layoutDurationMs": 16.009,
"taskDurationMs": 891.3920000000002,
"heapDeltaBytes": -5438548,
"heapUsedBytes": 86531560,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.148999999999994,
"eventListeners": 2381,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8457.417999999961,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.821999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5785.6810000000005,
"heapDeltaBytes": 17976028,
"heapUsedBytes": 93093528,
"domNodes": -271,
"jsHeapTotalBytes": -643072,
"scriptDurationMs": 2652.081,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8376.338000000032,
"styleRecalcs": 246,
"styleRecalcDurationMs": 33.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5861.979,
"heapDeltaBytes": 13611184,
"heapUsedBytes": 89534660,
"domNodes": -273,
"jsHeapTotalBytes": -1429504,
"scriptDurationMs": 2754.1949999999997,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16998.010000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16554.211,
"heapDeltaBytes": -33074140,
"heapUsedBytes": 176687984,
"domNodes": -6548,
"jsHeapTotalBytes": -5345280,
"scriptDurationMs": 277.01000000000005,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16866.110000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16425.628,
"heapDeltaBytes": -33400088,
"heapUsedBytes": 175209720,
"domNodes": -6548,
"jsHeapTotalBytes": -6041600,
"scriptDurationMs": 258.602,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20687.525999999933,
"styleRecalcs": 171,
"styleRecalcDurationMs": 16.947999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20338.778,
"heapDeltaBytes": -22012828,
"heapUsedBytes": 180308760,
"domNodes": -6548,
"jsHeapTotalBytes": 2879488,
"scriptDurationMs": 908.339,
"eventListeners": -7469,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20656.214999999975,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.101000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20220.602999999996,
"heapDeltaBytes": -12326212,
"heapUsedBytes": 189932012,
"domNodes": -6548,
"jsHeapTotalBytes": 2547712,
"scriptDurationMs": 888.189,
"eventListeners": -7467,
"totalBlockingTimeMs": 87,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6230.691999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.478,
"layouts": 20,
"layoutDurationMs": 27.15899999999999,
"taskDurationMs": 6098.989,
"heapDeltaBytes": -51045332,
"heapUsedBytes": 160652424,
"domNodes": -6547,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 111.895,
"eventListeners": -7471,
"totalBlockingTimeMs": 607,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6250.391000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.72999999999998,
"layouts": 20,
"layoutDurationMs": 22.417000000000005,
"taskDurationMs": 6096.418,
"heapDeltaBytes": -34974236,
"heapUsedBytes": 173850388,
"domNodes": -6548,
"jsHeapTotalBytes": 4501504,
"scriptDurationMs": 129.02599999999998,
"eventListeners": -7468,
"totalBlockingTimeMs": 407,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 127.26000000009208,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.776,
"layouts": 2,
"layoutDurationMs": 1.389,
"taskDurationMs": 93.80799999999999,
"heapDeltaBytes": 3150172,
"heapUsedBytes": 71404880,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.703,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 118.26000000019121,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.59,
"layouts": 3,
"layoutDurationMs": 1.746,
"taskDurationMs": 77.03,
"heapDeltaBytes": 3009012,
"heapUsedBytes": 71279420,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.246999999999999,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.53 #16858 +/- ##
=============================================
Coverage ? 83.32%
=============================================
Files ? 2023
Lines ? 117058
Branches ? 33049
=============================================
Hits ? 97544
Misses ? 19165
Partials ? 349
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #16459 to
cloud/1.53— the automatic backport failed on cherry-pick conflicts.Full context for agent readers
Source merge commit: 88fa815 (squash of #16459).
Conflict resolution:
src/lib/litegraph/src/LGraphNode.ts: added the exportedcreateWidgetRestorationStatehelper and replaced the inline restoration block inconfigure()with a call to it. On main the helper computesrestoreNamed: Boolean(named && (LiteGraph.namedValuesRestore || fallbackNames)); the|| fallbackNameshalf comes from Allow nodes to opt in, shadow after configure #16538 (merged after the 1.53 cut, no backport label). This backport usesrestoreNamed: Boolean(named && LiteGraph.namedValuesRestore), which is exactly what 1.53 already does, so non-Primitive node behavior on the release branch is unchanged.src/stores/widgetValueStore.ts: added thesetNodeScoped/clearNodeScopedhelpers, switched the restoration map to them, removed the now-unusedgetPositionalRestoredWidgetValue. Did not bring in main-onlyonValueChange/WidgetValueChangecode.src/extensions/core/widgetInputs.tsand its test applied cleanly.Verification on the branch:
pnpm vitest run src/extensions/core/widgetInputs.test.ts src/stores/ src/lib/litegraph/src/LGraphNode.test.ts→ 55 files, 1232 passed, 1 skipped;pnpm typecheckclean;pnpm oxlint0/0 andpnpm oxfmt --checkclean on the four touched files.