Skip to content

[backport cloud/1.53] fix(billing): price legacy subscription previews from the server costs - #16827

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16517-to-cloud-1.53
Sep 3, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16517-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16517 to cloud/1.53

Automatically created by backport workflow.

#16517)

## Summary

The subscription confirm screens rendered no amount at all whenever
embedded checkout was off — a blank "Total due today" on new
subscriptions and "Unavailable" on plan changes. Resolve the amount from
the legacy cost fields the server always sends.

## Changes

- **What**: `formatAmountDueToday` / `formatRenewalAmount` /
`resolveRenewalDate` in `subscriptionQuoteFormatting.ts` resolve each
figure from the exact quote when the server sent one and from the
always-present legacy costs otherwise.
`SubscriptionAddPaymentPreviewWorkspace` and
`SubscriptionTransitionPreviewWorkspace` consume them. New
`subscription.preview.renewsAtAmount` message for the case where the
server supplies an amount but no renewal date.

### Root cause

#14483 ("consolidate embedded checkout frontend") rewrote both quote
computeds to read only the embedded-checkout field family:

```ts
const totalDueToday = computed(() =>
  previewData?.amount_due_cents === undefined ? '' : formatQuoteMoney(...)
)
```

`POST /api/billing/preview-subscribe` returns two different shapes.
`packages/ingest-types` documents the split on the sibling field:
`payment_method_configuration_id` is *"Present on every successful
preview while embedded checkout is enabled and absent from legacy
previews."* The same holds for the whole family:

| field | contract | legacy preview |
| --- | --- | --- |
| `amount_due_cents`, `currency` | optional | absent |
| `renewal_amount_cents`, `renewal_at` | optional | absent |
| `cost_today_cents`, `cost_next_period_cents` | **required** |
**present** |

So with the flag off, `amount_due_cents` is `undefined` and
`totalDueToday` short-circuits to `''`.
`SubscriptionTransitionPreviewWorkspace` falls through to
`subscription.preview.quoteUnavailable` and prints "Unavailable" twice.

Two things widen the blast radius beyond "someone turned the flag off":

- `embeddedCheckoutEnabled` resolves **fail-closed**
(`resolveFailClosedBooleanFlag`), so a flag that cannot be read is
treated as off and takes this same path.
- `formatQuoteMoney` returns `''` when `currency` is missing, so even
reading `cost_today_cents` while passing the absent `currency` through
would still render blank.

Note the branch here is on the **response shape**, not on the
`embeddedCheckoutEnabled` prop. The shape is what the contract actually
guarantees, it needs no prop threaded into
`SubscriptionTransitionPreviewWorkspace`, and it stays correct if the
flag is on while the backend still serves a legacy preview.
`chargeCents` in the same component already branched this way
(`amount_due_cents ?? cost_today_cents`) — the consolidation just missed
the display computeds.

The renewal **date** is deliberately not synthesized.
`PreviewPlanInfo.period_end` is documented "only for current_plan" and
is absent on a new-subscription preview, so the legacy path shows the
server-provided renewal amount without inventing a date.

## Review Focus

- `LEGACY_QUOTE_CURRENCY = 'usd'` is the one assumption added. The
legacy rail carries no `currency` field because it prices in USD; this
keeps that assumption in a single named constant instead of at each call
site.
- `SubscriptionTransitionPreviewWorkspaceReactivation.test.ts` had a
test asserting "Unavailable" appeared twice for a preview with no exact
quote. That test codified this bug, so it now asserts the legacy amount
renders.
- `cloudSubscribeDeepLink.spec.ts` already drove a legacy-shaped preview
through the real checkout but only asserted the heading, which is how
this reached QA. It now asserts the total.

## Tests

- 8 unit tests on the pure resolvers (exact quote, legacy fallback,
non-USD, missing date)
- 3 component regression tests; verified they fail without the fix and
pass with it
- 1 E2E assertion on the existing flag-off deep-link spec

## Screenshots

Captured in the running app (cloud distribution,
`embedded_checked_enabled` off) — posting them in a follow-up comment.

<!-- Supersedes #16515, which fixes the same bug by branching on the
flag prop and drops the renewal line when the server sends no date. -->
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 3, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 3, 2026 19:32
@github-actions
github-actions Bot requested a review from DrJKL September 3, 2026 19:33
@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1893 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1872 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 07:34:49 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 139ms TBT · 82.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.6 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 150ms TBT · 170.4 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 449ms TBT · 179.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 538ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.6 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -171
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 37ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 861ms
canvas-mouse-sweep: script duration 155ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 60.0 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 356ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 439ms
dom-widget-clipping: script duration 159ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.0 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 599ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.9 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -184
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1602ms
large-graph-pan: script duration 814ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.3 MB
large-graph-pan: DOM nodes -136
large-graph-pan: event listeners -74
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1691ms
large-graph-zoom: script duration 767ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.3 MB
large-graph-zoom: DOM nodes -280
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1895ms
legacy-node-drag: script duration 939ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 84.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 565ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.6 MB
minimap-idle: DOM nodes -274
minimap-idle: event listeners -91
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 410ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.3 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 481ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 73.1 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -231
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 38ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 836ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.8 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -233
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 35ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 920ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 139ms
subgraph-transition-enter: heap used 82.4 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5716ms
viewport-pan-sweep: script duration 2635ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.9 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -154
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16439ms
vue-large-graph-idle: script duration 283ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.6 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 167
vue-large-graph-pan: task duration 20375ms
vue-large-graph-pan: script duration 914ms
vue-large-graph-pan: TBT 150ms
vue-large-graph-pan: heap used 170.4 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 78ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6054ms
vue-node-resize-workload: script duration 107ms
vue-node-resize-workload: TBT 449ms
vue-node-resize-workload: heap used 179.4 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 96ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 139
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-03T19:46:35.194Z",
  "gitSha": "5cae69ff5a5d057fdb12e491251b65ac2967b2d8",
  "branch": "backport-16517-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2089.9080000000367,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.717,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 591.564,
      "heapDeltaBytes": -13204084,
      "heapUsedBytes": 56473116,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 12.848000000000003,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2059.301000000005,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.785,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.45199999999994,
      "heapDeltaBytes": -936272,
      "heapUsedBytes": 68553476,
      "domNodes": -282,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.371,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1805.4690000000164,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 37.677,
      "layouts": 14,
      "layoutDurationMs": 4.109,
      "taskDurationMs": 848.5509999999999,
      "heapDeltaBytes": -6680664,
      "heapUsedBytes": 63822420,
      "domNodes": -282,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 152.60899999999998,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1851.6799999999876,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 36.51,
      "layouts": 14,
      "layoutDurationMs": 4.255999999999999,
      "taskDurationMs": 874.3870000000001,
      "heapDeltaBytes": -8189932,
      "heapUsedBytes": 61907488,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 157.46600000000004,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.6699999999937,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.937,
      "layouts": 6,
      "layoutDurationMs": 1.0990000000000002,
      "taskDurationMs": 357.23500000000007,
      "heapDeltaBytes": 4665020,
      "heapUsedBytes": 74419100,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.596000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.5349999999935,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.067999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.935,
      "taskDurationMs": 353.882,
      "heapDeltaBytes": 4438548,
      "heapUsedBytes": 74225396,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.498999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 623.4550000000354,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.729999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.37800000000004,
      "heapDeltaBytes": -7463840,
      "heapUsedBytes": 63080380,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 158.125,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 629.6579999999494,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.1179999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 433.00899999999996,
      "heapDeltaBytes": -7830308,
      "heapUsedBytes": 62746496,
      "domNodes": 14,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 159.021,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2043.4300000000007,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.170000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 592.994,
      "heapDeltaBytes": 10865948,
      "heapUsedBytes": 85819400,
      "domNodes": -268,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 32.37800000000001,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.549999999953,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 8.305,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 604.234,
      "heapDeltaBytes": 10018996,
      "heapUsedBytes": 85896164,
      "domNodes": -271,
      "jsHeapTotalBytes": -2179072,
      "scriptDurationMs": 35.722,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2159.5049999999674,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.242999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1589.7379999999998,
      "heapDeltaBytes": 18582528,
      "heapUsedBytes": 84098900,
      "domNodes": -273,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 803.5790000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2241.3720000000694,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.266000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1614.1039999999998,
      "heapDeltaBytes": 26760704,
      "heapUsedBytes": 92705964,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 824.859,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3573.914000000002,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.729000000000001,
      "layouts": 60,
      "layoutDurationMs": 11.871000000000002,
      "taskDurationMs": 1703.0379999999998,
      "heapDeltaBytes": 8461504,
      "heapUsedBytes": 75618320,
      "domNodes": -281,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 766.72,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3458.6480000000392,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.682,
      "layouts": 60,
      "layoutDurationMs": 11.705,
      "taskDurationMs": 1679.83,
      "heapDeltaBytes": 10184680,
      "heapUsedBytes": 75931380,
      "domNodes": -279,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 766.639,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3017.7869999999984,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.899000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1887.4650000000001,
      "heapDeltaBytes": 21480532,
      "heapUsedBytes": 89200756,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 929.426,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3033.7279999999964,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.853,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1902.094,
      "heapDeltaBytes": 21943068,
      "heapUsedBytes": 88860848,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 948.403,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2043.374999999969,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.691,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.279,
      "heapDeltaBytes": -14068188,
      "heapUsedBytes": 87577176,
      "domNodes": -271,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 31.567999999999998,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2001.3059999999996,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.8449999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.235,
      "heapDeltaBytes": 22114724,
      "heapUsedBytes": 87742628,
      "domNodes": -277,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.785,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.0849999999641,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.552,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 413.67900000000003,
      "heapDeltaBytes": 14815780,
      "heapUsedBytes": 87413348,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 142.90999999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 604.6660000000657,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.020000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.2,
      "heapDeltaBytes": 14795076,
      "heapUsedBytes": 87293400,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 144.285,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1987.6219999999876,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.120000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.07500000000005,
      "heapDeltaBytes": 2951032,
      "heapUsedBytes": 75322596,
      "domNodes": -298,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.259999999999999,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.1669999999958,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.22600000000006,
      "heapDeltaBytes": 6636108,
      "heapUsedBytes": 77886760,
      "domNodes": -297,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.1160000000000005,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1721.9410000000153,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.08200000000001,
      "layouts": 18,
      "layoutDurationMs": 5.531,
      "taskDurationMs": 828.786,
      "heapDeltaBytes": 7490056,
      "heapUsedBytes": 79104944,
      "domNodes": -297,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 109.32900000000001,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1749.104999999986,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 35.442,
      "layouts": 18,
      "layoutDurationMs": 5.352,
      "taskDurationMs": 844.043,
      "heapDeltaBytes": -337608,
      "heapUsedBytes": 71450808,
      "domNodes": -299,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 112.94699999999999,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.0829999999341,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 35.00599999999999,
      "layouts": 15,
      "layoutDurationMs": 15.78,
      "taskDurationMs": 919.56,
      "heapDeltaBytes": -5563000,
      "heapUsedBytes": 86442760,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 30.392999999999997,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 139,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8368.630999999994,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.571000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5658.117,
      "heapDeltaBytes": -11070276,
      "heapUsedBytes": 89159120,
      "domNodes": -269,
      "jsHeapTotalBytes": -606208,
      "scriptDurationMs": 2607.1389999999997,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8378.784999999993,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 36.411,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5773.6179999999995,
      "heapDeltaBytes": 8933724,
      "heapUsedBytes": 84630484,
      "domNodes": -270,
      "jsHeapTotalBytes": -151552,
      "scriptDurationMs": 2661.93,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16842.965000000047,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16223.354999999998,
      "heapDeltaBytes": -40506164,
      "heapUsedBytes": 175479392,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4182016,
      "scriptDurationMs": 262.069,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17202.562000000056,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16653.727,
      "heapDeltaBytes": -36257380,
      "heapUsedBytes": 173881044,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5267456,
      "scriptDurationMs": 304.103,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20763.878000000033,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 16.925999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20394.53,
      "heapDeltaBytes": -35841864,
      "heapUsedBytes": 177368008,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8314880,
      "scriptDurationMs": 884.507,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 213,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20718.879000000015,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 16.310999999999964,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20355.057,
      "heapDeltaBytes": -28742604,
      "heapUsedBytes": 179938840,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5640192,
      "scriptDurationMs": 942.793,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 87,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6160.865000000002,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.36199999999998,
      "layouts": 20,
      "layoutDurationMs": 22.875000000000007,
      "taskDurationMs": 6032.428999999999,
      "heapDeltaBytes": -6361060,
      "heapUsedBytes": 195989548,
      "domNodes": -6548,
      "jsHeapTotalBytes": 19132416,
      "scriptDurationMs": 107.03800000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 441,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6205.018999999993,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.411,
      "layouts": 20,
      "layoutDurationMs": 22.460000000000008,
      "taskDurationMs": 6076.023,
      "heapDeltaBytes": -24381828,
      "heapUsedBytes": 180292492,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13889536,
      "scriptDurationMs": 106.17399999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 457,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 474.64400000001206,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 23.296,
      "layouts": 4,
      "layoutDurationMs": 1.83,
      "taskDurationMs": 119.62700000000001,
      "heapDeltaBytes": 5309008,
      "heapUsedBytes": 72842356,
      "domNodes": 151,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 11.001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 104.26699999993616,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.035000000000002,
      "layouts": 2,
      "layoutDurationMs": 1.37,
      "taskDurationMs": 71.65899999999999,
      "heapDeltaBytes": 3011640,
      "heapUsedBytes": 71280784,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.297000000000001,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48079 70543 68.2% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.8% 255
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #16827   +/-   ##
=============================================
  Coverage              ?   83.31%           
=============================================
  Files                 ?     2023           
  Lines                 ?   117045           
  Branches              ?    32459           
=============================================
  Hits                  ?    97512           
  Misses                ?    19177           
  Partials              ?      356           
Flag Coverage Δ
e2e 66.65% <ø> (?)
unit 76.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit d3cb3f6 into cloud/1.53 Sep 3, 2026
107 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16517-to-cloud-1.53 branch September 3, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants