Repository navigation
test: finish #16546 review follow-up - #16811
christian-byrne wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe subgraph deduplication tests replace non-null assertions with optional chaining and explicit guards. Existing assertions and test behavior remain unchanged. ChangesSubgraph deduplication test safety
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates subgraph deduplication test access patterns without changing product behavior. The assertions remain covered and no current merge-blocking risk is identified. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description explains the change, review context, affected test behavior, and validation results. It includes the required Summary, Changes, and Review Focus information. Screenshots are not applicable to this test-only change. Full details: End-To-End Regression Coverage For FixesExplanation The changed-file metadata is available and lists one file under Full details: Adr Compliance For Entity/Litegraph ChangesExplanation PASS. The PR changes only ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1912 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.68 MB gzip 🟢 -273 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • 🟢 -27 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • 🟢 -1.61 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 17 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T18:42:24.645Z",
"gitSha": "815bcc3e07e4924fa1ed4605405552376fe8a590",
"branch": "fix/16546-review-followup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2068.0189999999925,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.531,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.1729999999999,
"heapDeltaBytes": -1706116,
"heapUsedBytes": 67665280,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.004999999999999,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.8640000000173,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.284,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.77,
"heapDeltaBytes": -11270584,
"heapUsedBytes": 58467652,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.783000000000002,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.984000000035,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.040000000000006,
"layouts": 14,
"layoutDurationMs": 4.135,
"taskDurationMs": 869.0930000000001,
"heapDeltaBytes": -8597656,
"heapUsedBytes": 61828604,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 158.274,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1888.873999999987,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.111,
"layouts": 14,
"layoutDurationMs": 4.289,
"taskDurationMs": 878.6839999999999,
"heapDeltaBytes": 581212,
"heapUsedBytes": 69774776,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 160.962,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.2210000000155,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.857,
"layouts": 6,
"layoutDurationMs": 1.112,
"taskDurationMs": 369.54,
"heapDeltaBytes": 5087628,
"heapUsedBytes": 75586748,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.199999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.868000000004,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.669,
"layouts": 6,
"layoutDurationMs": 1.1309999999999998,
"taskDurationMs": 385.073,
"heapDeltaBytes": 4771188,
"heapUsedBytes": 75038464,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.660999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 709.3530000000214,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.09400000000005,
"heapDeltaBytes": -7464232,
"heapUsedBytes": 63035596,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 176.433,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 660.9040000000732,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.696000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.05799999999994,
"heapDeltaBytes": 18205532,
"heapUsedBytes": 88019856,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 165.41899999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.110000000027,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.332000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.989,
"heapDeltaBytes": -14270048,
"heapUsedBytes": 87593816,
"domNodes": -266,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 30.94799999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.6920000000018,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.271000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.383,
"heapDeltaBytes": 11471516,
"heapUsedBytes": 86759040,
"domNodes": -269,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 34.297999999999995,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2248.026999999979,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.224,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1627.413,
"heapDeltaBytes": 22408612,
"heapUsedBytes": 88478728,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 821.1579999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2267.2880000000077,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.781999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1625.5169999999998,
"heapDeltaBytes": 16980420,
"heapUsedBytes": 83691884,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 827.6450000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3479.6420000000126,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.487000000000002,
"layouts": 60,
"layoutDurationMs": 11.855,
"taskDurationMs": 1664.992,
"heapDeltaBytes": 8084868,
"heapUsedBytes": 76084204,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.872,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3546.624999999949,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.617000000000004,
"layouts": 60,
"layoutDurationMs": 11.822,
"taskDurationMs": 1673.2930000000001,
"heapDeltaBytes": 8233820,
"heapUsedBytes": 75570352,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 771.532,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3125.8719999999585,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.667999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1877.9749999999997,
"heapDeltaBytes": 18613116,
"heapUsedBytes": 85759460,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 923.492,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3128.259000000071,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.9209999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1920.3040000000003,
"heapDeltaBytes": 27362728,
"heapUsedBytes": 94344680,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 983.264,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.4719999999988,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.204,
"heapDeltaBytes": 10469504,
"heapUsedBytes": 87389000,
"domNodes": -270,
"jsHeapTotalBytes": -3248128,
"scriptDurationMs": 31.284000000000006,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.234999999976,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.692000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.542,
"heapDeltaBytes": 22283336,
"heapUsedBytes": 88043008,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.801999999999996,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.1380000000336,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.666999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.854,
"heapDeltaBytes": 14872156,
"heapUsedBytes": 87769928,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.824,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.8079999999354,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.213999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.384,
"heapDeltaBytes": 14892768,
"heapUsedBytes": 87791080,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 144.289,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.9000000000165,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.301999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.30600000000004,
"heapDeltaBytes": -8004724,
"heapUsedBytes": 64750896,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.138000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.5020000000077,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.334999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.2399999999999,
"heapDeltaBytes": -5590152,
"heapUsedBytes": 67198876,
"domNodes": -293,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 7.2349999999999985,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.3079999999745,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.003,
"layouts": 18,
"layoutDurationMs": 5.644,
"taskDurationMs": 857.168,
"heapDeltaBytes": -12274160,
"heapUsedBytes": 60618696,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 115.02800000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.7710000000416,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.61399999999999,
"layouts": 18,
"layoutDurationMs": 4.898000000000001,
"taskDurationMs": 827.666,
"heapDeltaBytes": -12476812,
"heapUsedBytes": 60369704,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 109.096,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0690000000109,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.117,
"layouts": 15,
"layoutDurationMs": 15.835999999999999,
"taskDurationMs": 903.6319999999997,
"heapDeltaBytes": -9208900,
"heapUsedBytes": 82714144,
"domNodes": 13751,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 30.35,
"eventListeners": 2387,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8619.905000000017,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.433,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5968.8189999999995,
"heapDeltaBytes": -16514352,
"heapUsedBytes": 84928468,
"domNodes": -265,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 2718.923,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8452.668000000016,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5839.205,
"heapDeltaBytes": -11986712,
"heapUsedBytes": 89358964,
"domNodes": -270,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 2694.9809999999998,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17172.938000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16640.05,
"heapDeltaBytes": -34232104,
"heapUsedBytes": 176063776,
"domNodes": -6548,
"jsHeapTotalBytes": -3858432,
"scriptDurationMs": 286.773,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16863.716000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16370.992999999999,
"heapDeltaBytes": -26580892,
"heapUsedBytes": 176726392,
"domNodes": -6548,
"jsHeapTotalBytes": 3117056,
"scriptDurationMs": 296.704,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21303.563999999995,
"styleRecalcs": 178,
"styleRecalcDurationMs": 18.12699999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20877.045,
"heapDeltaBytes": -14051556,
"heapUsedBytes": 190768232,
"domNodes": -6552,
"jsHeapTotalBytes": 671744,
"scriptDurationMs": 920.5,
"eventListeners": -7471,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21378.680999999917,
"styleRecalcs": 165,
"styleRecalcDurationMs": 19.199999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21011.948,
"heapDeltaBytes": -33927488,
"heapUsedBytes": 176649704,
"domNodes": -6548,
"jsHeapTotalBytes": -7266304,
"scriptDurationMs": 902.377,
"eventListeners": -7469,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6071.239999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 95.38200000000002,
"layouts": 20,
"layoutDurationMs": 35.305000000000014,
"taskDurationMs": 5979.728000000001,
"heapDeltaBytes": -36589260,
"heapUsedBytes": 173804896,
"domNodes": -6548,
"jsHeapTotalBytes": 1646592,
"scriptDurationMs": 106.415,
"eventListeners": -7471,
"totalBlockingTimeMs": 579,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6244.043999999917,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.999,
"layouts": 20,
"layoutDurationMs": 24.76800000000001,
"taskDurationMs": 6109.294,
"heapDeltaBytes": -23509132,
"heapUsedBytes": 179477520,
"domNodes": -6548,
"jsHeapTotalBytes": 17506304,
"scriptDurationMs": 115.061,
"eventListeners": -7473,
"totalBlockingTimeMs": 474,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8367.435999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8159.642999999999,
"heapDeltaBytes": 20357960,
"heapUsedBytes": 176823208,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 135.71099999999993,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9043.903,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8594.519000000002,
"heapDeltaBytes": 16237020,
"heapUsedBytes": 174653116,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 135.40800000000007,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 108.91500000002452,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.526999999999997,
"layouts": 2,
"layoutDurationMs": 0.9909999999999999,
"taskDurationMs": 75.15299999999999,
"heapDeltaBytes": 3069968,
"heapUsedBytes": 71779300,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.985999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 107.77999999993426,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.926,
"layouts": 2,
"layoutDurationMs": 0.7719999999999999,
"taskDurationMs": 70.77699999999999,
"heapDeltaBytes": 3028232,
"heapUsedBytes": 71613432,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.921,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Follow-up to #16546 review feedback (DrJKL): prove node existence via the file's established toBeDefined + guard pattern instead of non-null assertions, and assert node-list length before optional access. Test-only, no behaviour change.
|
Consolidated the duplicate follow-up here: a concurrent lane opened #16810 for the same row 3s earlier; it addressed the five remaining non-null assertions in the normalization tests (this PR fixed the thread-anchored one). Cherry-picked those removals onto this branch Full context for agent readersPre-open dedupe ran at 18:19:40Z (title-keyword search across open+closed PRs) and found nothing — the other PR was created 3 seconds later, so the race was unavoidable. Consolidation rather than two PRs: this PR keeps the thread-3 anchor fix (line 79, |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16811 +/- ##
==========================================
+ Coverage 81.12% 82.68% +1.56%
==========================================
Files 2459 2041 -418
Lines 126484 119007 -7477
Branches 31888 31873 -15
==========================================
- Hits 102609 98406 -4203
+ Misses 23360 20421 -2939
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks for following up on #16546. This branch is about 2,300 commits behind main and conflicts in src/lib/litegraph/src/subgraph/subgraphDeduplication.test.ts.
As far as I can tell, main has already done this cleanup. The graph model types now make nodes, links, inputs and rootNodes non-optional, and the current test reads result.subgraphs[1].nodes[0].type, makeSubgraph('root', ['legacy-id']).nodes[0] and result.rootNodes[0].type (after assert.exists(result.rootNodes)) with no non-null assertions left. If you agree it's superseded, could you close this PR? If you still see something missing on current main, please rebase and I'll take another look.
|
Closing — this is already done on The whole change here was the last of three review requests from #16546: remove the final
So the assertion strength is equal or better and the type escape is gone. The diff also no longer applies — the PR has been conflicting since the file was refactored. No behaviour is lost by closing this. |
Summary
Finishes the test-quality follow-up from #16546: the merged head already removed the non-behavioral cursor test and typed the recursive fixture; this PR removes the final non-null assertion.
Full context for agent readers
Changes
Review Focus
The three review requests from #16546 are accounted for:
Non-behavioral cursor test:
Addressed on the merged head: the change-detector test was removed while the scroll-driven behavioral test remains.
Recursive fixture typing:
Addressed on the merged head:
makeSubgraphreturns the recursive fixture type andfindSubgraphnarrows lookup results.Remaining non-null assertion:
Addressed here by asserting the node-list length before optional access, exactly as suggested.
Evidence
pnpm test:unit src/components/maskeditor/BrushCursor.test.ts src/lib/litegraph/src/subgraph/subgraphDeduplication.test.ts --run— 36/36 passed.pnpm lint— passed with existing repository warnings only (0 errors).pnpm typecheck— passed.