Skip to content

fix(ci): pin backend for core 1.51 locales - #16804

Closed
christian-byrne wants to merge 1 commit into
mainfrom
christian-byrne/cifix-16435-i18n-core-ref
Closed

christian-byrne wants to merge 1 commit into
mainfrom
christian-byrne/cifix-16435-i18n-core-ref

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

  • pin core/1.51 locale generation to the ComfyUI backend commit that first selected frontend 1.51.9
  • preserve existing default-branch behavior for main, cloud releases, and manual dispatches

Why

The core/1.51 version-bump PR currently launches today's ComfyUI master. Its newer node registry makes locale collection appear to delete 417 of 9,082 node-definition keys, so the prune guard correctly stops the release.

ComfyUI commit 40b9898582d15a753227712e8c863e466e290e0b is the authoritative matching backend: its requirements change pins comfyui-frontend-package==1.51.9.

Unblocks #16199 after this workflow fix lands and that job is rerun.

Validation

  • actionlint .github/workflows/i18n-update-core.yaml
  • pnpm exec oxfmt --check .github/workflows/i18n-update-core.yaml
  • git diff --check origin/main...HEAD

@christian-byrne
christian-byrne requested a review from a team September 3, 2026 17:24
@christian-byrne christian-byrne self-assigned this Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 3ce4cba9-782b-443c-807b-4484fefd21fa

📥 Commits

Reviewing files that changed from the base of the PR and between 10f2b22 and 4348e9d.

📒 Files selected for processing (1)
  • .github/workflows/i18n-update-core.yaml

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1914 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1893 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 9.68 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 41.1 MB baseline 41.1 MB — ⚪ 0 B
  • Gzip: 9.68 MB baseline 9.68 MB — ⚪ 0 B
  • Brotli: 6.81 MB baseline 6.81 MB — ⚪ 0 B
  • Bundles: 448 current • 448 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (18.1 MB) · Other ⚪ 0 B (16.4 MB) · Data & Services ⚪ 0 B (3.6 MB) · Graph Workspace ⚪ 0 B (1.43 MB) · Panels & Settings ⚪ 0 B (621 kB) · Utilities & Hooks ⚪ 0 B (560 kB) · + 5 more

App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 27 unchanged

User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 117 kB (baseline 117 kB) • ⚪ 0 B

Reusable component library chunks

Status: 15 unchanged

Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 16 unchanged

Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 36 unchanged

Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 296 unchanged

⚡ Performance

⏳ Performance tests in progress…

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #16804      +/-   ##
==========================================
+ Coverage   81.11%   82.68%   +1.56%     
==========================================
  Files        2458     2040     -418     
  Lines      126458   118979    -7479     
  Branches    33693    30054    -3639     
==========================================
- Hits       102577    98378    -4199     
+ Misses      23366    20421    -2945     
+ Partials      515      180     -335     
Flag Coverage Δ
e2e 66.69% <ø> (-0.01%) ⬇️
unit 77.09% <ø> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 426 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant