Repository navigation
fix(ci): pin backend for core 1.51 locales - #16804
christian-byrne wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 11 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 1914 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16804 +/- ##
==========================================
+ Coverage 81.11% 82.68% +1.56%
==========================================
Files 2458 2040 -418
Lines 126458 118979 -7479
Branches 33693 30054 -3639
==========================================
- Hits 102577 98378 -4199
+ Misses 23366 20421 -2945
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
core/1.51locale generation to the ComfyUI backend commit that first selected frontend1.51.9Why
The
core/1.51version-bump PR currently launches today's ComfyUI master. Its newer node registry makes locale collection appear to delete 417 of 9,082 node-definition keys, so the prune guard correctly stops the release.ComfyUI commit
40b9898582d15a753227712e8c863e466e290e0bis the authoritative matching backend: its requirements change pinscomfyui-frontend-package==1.51.9.Unblocks #16199 after this workflow fix lands and that job is rerun.
Validation
actionlint .github/workflows/i18n-update-core.yamlpnpm exec oxfmt --check .github/workflows/i18n-update-core.yamlgit diff --check origin/main...HEAD