Repository navigation
feat(workflow): report publish tag fallback - #16803
christian-byrne wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 13 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1914 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.68 MB gzip 🔴 +178 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +367 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 224 unchanged ⚡ Performance
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16803 +/- ##
==========================================
+ Coverage 81.11% 82.67% +1.55%
==========================================
Files 2458 2040 -418
Lines 126456 118980 -7476
Branches 33692 30054 -3638
==========================================
- Hits 102579 98370 -4209
+ Misses 23362 20430 -2932
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 424 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Full context for agent readers
When live ComfyHub tag labels fail to load,
ComfyHubDescribeStep.vuenow reportsworkflow_publish_tags_fallbackthroughreportError()at warning level before retaining the existing hardcoded suggestions. The event feeds thefailure_kind: degraded/feature_area: workflowalert family and includes only the safe fallback-tag count.The focused component test verifies both the rendered fallback and the exact tags/context. This depends on the telemetry taxonomy in #16784. Open #14173 also touches the component, but only changes the title translation keys near the top of the template; this instrumentation changes the mounted fetch catch and test.
Evidence
NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/platform/workflow/sharing/components/publish/ComfyHubDescribeStep.test.ts— 6 passedpnpm exec oxfmt --check <two changed files>— passedpnpm typecheck— passedpnpm lint— passed with existing warnings onlypnpm knip --cache— passedgit show --check HEAD— passed