Repository navigation
fix: secure remaining UUID fallbacks - #16801
christian-byrne wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe shared ChangesSecure UUID generation
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to UUID generation now uses Web Crypto with a secure fallback and fails closed when unavailable; PSD export and checkout attempt IDs use the shared implementation. No merge-blocking risk remains. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file information and PR description are available, but the PR title and commit subjects are not provided. The check requires those fields to identify the required bug-fix signal. The available description does not replace that required evidence. Resolution Provide the PR title and all commit subjects. Then verify whether a title or subject uses the specified bug-fix language. If it does, confirm whether the PR description gives a concrete reason that no Playwright regression test was added under browser_tests/. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1905 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
📦 Bundle: 9.74 MB gzip 🟢 -7 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • 🟢 -159 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 559 kB (baseline 558 kB) • 🔴 +170 BHelpers, composables, and utility bundles
Status: 22 added / 22 removed / 14 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.6 MB (baseline 16.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 78 added / 78 removed / 218 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-05T18:40:03.015Z",
"gitSha": "08e344e48b9f65f3750e710c9de2ffa6e0916aa5",
"branch": "christian/uuid-1-secure-fallback",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2114.5680000000198,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.289,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 742.553,
"heapDeltaBytes": 3597128,
"heapUsedBytes": 73920188,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 14.528999999999996,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2052.326999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.768999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.85,
"heapDeltaBytes": 155328,
"heapUsedBytes": 69735320,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 13.945000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1958.804999999984,
"styleRecalcs": 82,
"styleRecalcDurationMs": 47.300000000000004,
"layouts": 14,
"layoutDurationMs": 4.6,
"taskDurationMs": 1009.568,
"heapDeltaBytes": 9426500,
"heapUsedBytes": 80222156,
"domNodes": -284,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 174.12800000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1936.9869999999878,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.077000000000005,
"layouts": 14,
"layoutDurationMs": 4.587,
"taskDurationMs": 975.7849999999999,
"heapDeltaBytes": -12242956,
"heapUsedBytes": 58400512,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 166.75300000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.3910000000124,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.772000000000006,
"layouts": 6,
"layoutDurationMs": 1.251,
"taskDurationMs": 414.581,
"heapDeltaBytes": 4745416,
"heapUsedBytes": 75333156,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.719999999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.7700000000077,
"styleRecalcs": 32,
"styleRecalcDurationMs": 21.782999999999998,
"layouts": 6,
"layoutDurationMs": 1.437,
"taskDurationMs": 455.848,
"heapDeltaBytes": 4777468,
"heapUsedBytes": 75388112,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 16.733,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 758.4120000000212,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.157,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.6850000000001,
"heapDeltaBytes": 17853680,
"heapUsedBytes": 88426380,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 174.698,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 704.0030000000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.203000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.95000000000005,
"heapDeltaBytes": 18532520,
"heapUsedBytes": 88419300,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 163.609,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.8749999999618,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.5899999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 753.8009999999999,
"heapDeltaBytes": -15067136,
"heapUsedBytes": 86876040,
"domNodes": -268,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 42.583999999999996,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2064.751000000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 5.69,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.4629999999999,
"heapDeltaBytes": -14786668,
"heapUsedBytes": 87242172,
"domNodes": -270,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 38.161,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2916.5989999999624,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.754999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1834.3649999999998,
"heapDeltaBytes": 27937664,
"heapUsedBytes": 93590204,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 903.445,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2797.4550000000136,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.847,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1827.1519999999998,
"heapDeltaBytes": 15615920,
"heapUsedBytes": 92381856,
"domNodes": -272,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 881.478,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3767.602000000011,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.280000000000001,
"layouts": 60,
"layoutDurationMs": 12.697,
"taskDurationMs": 1811.545,
"heapDeltaBytes": 8030572,
"heapUsedBytes": 75685072,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 808.673,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3826.1280000000397,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.944000000000003,
"layouts": 60,
"layoutDurationMs": 13.232000000000001,
"taskDurationMs": 1870.73,
"heapDeltaBytes": 8258640,
"heapUsedBytes": 75912408,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 836.957,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3172.196999999983,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.253999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2081.0330000000004,
"heapDeltaBytes": 26253744,
"heapUsedBytes": 93556176,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1036.449,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3136.6100000000188,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.334999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2018.094,
"heapDeltaBytes": 24695860,
"heapUsedBytes": 91639500,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 974.1030000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.434000000027,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.7729999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.9129999999999,
"heapDeltaBytes": 21185380,
"heapUsedBytes": 87159020,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 43.14499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2007.9429999999547,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0319999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.8969999999999,
"heapDeltaBytes": 21838176,
"heapUsedBytes": 88479952,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.724999999999994,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.5940000000019,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.257,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.878,
"heapDeltaBytes": 15148144,
"heapUsedBytes": 87657412,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 147.94899999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 657.8739999999925,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.482999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.5199999999999,
"heapDeltaBytes": 15187780,
"heapUsedBytes": 87971220,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 148.37,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.967999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.193000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.011,
"heapDeltaBytes": -1012020,
"heapUsedBytes": 70793216,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 12.658000000000003,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.4040000000323,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.821000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.8169999999999,
"heapDeltaBytes": -2069996,
"heapUsedBytes": 70522312,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.206000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1807.388000000003,
"styleRecalcs": 78,
"styleRecalcDurationMs": 45.793,
"layouts": 18,
"layoutDurationMs": 6.3229999999999995,
"taskDurationMs": 950.97,
"heapDeltaBytes": 6444052,
"heapUsedBytes": 79608452,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 127.04100000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1789.1970000000583,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.193,
"layouts": 18,
"layoutDurationMs": 6.3870000000000005,
"taskDurationMs": 938.9010000000001,
"heapDeltaBytes": -12305204,
"heapUsedBytes": 60378116,
"domNodes": -293,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 126.48500000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1450.7849999999962,
"styleRecalcs": 19,
"styleRecalcDurationMs": 34.57299999999999,
"layouts": 15,
"layoutDurationMs": 16.709000000000003,
"taskDurationMs": 1064.3290000000002,
"heapDeltaBytes": 21983048,
"heapUsedBytes": 105513840,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 37.925,
"eventListeners": 2387,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9244.956000000002,
"styleRecalcs": 244,
"styleRecalcDurationMs": 33.38799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6134.982,
"heapDeltaBytes": 24079984,
"heapUsedBytes": 89045788,
"domNodes": -277,
"jsHeapTotalBytes": 716800,
"scriptDurationMs": 2780.494,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9826.169999999933,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.763,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6475.101,
"heapDeltaBytes": 18200460,
"heapUsedBytes": 93777444,
"domNodes": -266,
"jsHeapTotalBytes": 614400,
"scriptDurationMs": 2879.6589999999997,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17749.86200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17034.518,
"heapDeltaBytes": -41003920,
"heapUsedBytes": 175494564,
"domNodes": -6548,
"jsHeapTotalBytes": 1286144,
"scriptDurationMs": 304.32399999999996,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17690.25099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17116.072,
"heapDeltaBytes": -33647496,
"heapUsedBytes": 180049364,
"domNodes": -6548,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 294.351,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21346.576000000026,
"styleRecalcs": 163,
"styleRecalcDurationMs": 20.71999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21078.095,
"heapDeltaBytes": -37239800,
"heapUsedBytes": 167018064,
"domNodes": -6548,
"jsHeapTotalBytes": -5693440,
"scriptDurationMs": 928.4190000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 71,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22137.643000000025,
"styleRecalcs": 171,
"styleRecalcDurationMs": 23.524000000000044,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21898.688,
"heapDeltaBytes": -29165132,
"heapUsedBytes": 180505444,
"domNodes": -6548,
"jsHeapTotalBytes": -4853760,
"scriptDurationMs": 934.035,
"eventListeners": -7471,
"totalBlockingTimeMs": 105,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6462.380999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.625,
"layouts": 20,
"layoutDurationMs": 26.38800000000001,
"taskDurationMs": 6371.979999999999,
"heapDeltaBytes": -25270116,
"heapUsedBytes": 183960820,
"domNodes": -6552,
"jsHeapTotalBytes": 10874880,
"scriptDurationMs": 121.855,
"eventListeners": -7473,
"totalBlockingTimeMs": 513,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6390.860999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.38799999999996,
"layouts": 20,
"layoutDurationMs": 26.618000000000002,
"taskDurationMs": 6281.438999999999,
"heapDeltaBytes": -23807948,
"heapUsedBytes": 179813048,
"domNodes": -6548,
"jsHeapTotalBytes": 16719872,
"scriptDurationMs": 109.863,
"eventListeners": -7473,
"totalBlockingTimeMs": 460,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6656.619999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6380.848000000002,
"heapDeltaBytes": 8723340,
"heapUsedBytes": 180264020,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 131.857,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9067.389000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8703.969999999998,
"heapDeltaBytes": 1985872,
"heapUsedBytes": 176922860,
"domNodes": 0,
"jsHeapTotalBytes": -8912896,
"scriptDurationMs": 149.90899999999996,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 492.9589999999848,
"styleRecalcs": 21,
"styleRecalcDurationMs": 30.522000000000002,
"layouts": 5,
"layoutDurationMs": 2.4450000000000003,
"taskDurationMs": 151.029,
"heapDeltaBytes": 5112228,
"heapUsedBytes": 72525124,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.259999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 96.8839999999318,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.929000000000002,
"layouts": 2,
"layoutDurationMs": 0.768,
"taskDurationMs": 71.598,
"heapDeltaBytes": 3037480,
"heapUsedBytes": 70504336,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.874999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16801 +/- ##
=======================================
Coverage 81.36% 81.36%
=======================================
Files 2471 2471
Lines 127185 127177 -8
Branches 34630 34622 -8
=======================================
- Hits 103478 103477 -1
+ Misses 23192 23185 -7
Partials 515 515
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified at 8ee234d: checked out the branch, pnpm install --frozen-lockfile, ran the three touched test files (128 passed), eslint clean on formatUtil.ts. Confirmed root vite.config.mts test.include covers packages/** and sets unstubGlobals: true, so dropping the try/finally vi.unstubAllGlobals() in psdExport.test.ts and stubbing crypto to undefined in formatUtil.test.ts do not leak between tests. Version and variant bit math is correct (0x40 in byte 6 high nibble, 10xx variant in byte 8).
On the Review Focus question: fail-closed is appropriate. crypto.getRandomValues is not secure-context gated and shipped in every browser that exposes window.crypto at all, so the throw is unreachable on the plain-HTTP LAN origins this series targets; the only environments that hit it are pre-2013 browsers and Node below 19, and package.json pins node >=25 <26. The old Math.random path silently produced weak ids in exactly the case that matters, so throwing loudly is the better failure mode. The one place the throw would surface at construction time is readonly instanceId = generateUUID() in comfyWorkflow.ts, which is fine given the above.
Findings inline. The issue: is that src/utils/uuid.ts createUuidv4 still carries a Math.random fallback and is reachable in production through ensureNonZeroUuid(this.rootGraph) in app.ts, so the title claim of "remaining" fallbacks is not yet true and there are two independent v4 generators in the tree. Not flagged: <!-- authored-by:agent --> trailer, unconditional crypto.randomUUID() in GraphView.vue (cloud only, always https) and opEnvelope.ts (already discussed on #16777).
|
Review at Full context for agent readersReview: #16801 (review) (COMMENT, 3 inline threads, all resolved after the fix commit). Verification at Fail-closed question: Fix commit
Local checks on the fix: Why the merge: after Not flagged: unconditional |
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
8d3b2e4 to
3df11ee
Compare
|
pr-shepherd: advanced this PR one lifecycle stage (conflict fix). The branch carried a merge commit ( Three conflicts, and two of them would have been resolved wrongly by taking either side wholesale. In In The rebase is provably content-preserving: the net diff against the base is byte-identical before and after, same six files and the same 75 insertions / 39 deletions, so the rebase inherited Verification at the new head, on Node 25: One scoping note for review: Not merged, and not merge-ready: |
Summary
Removes the remaining insecure-origin UUID fallbacks identified in #16777.
Changes
generateUUID()now falls back fromcrypto.randomUUID()tocrypto.getRandomValues()and fails closed without Web Crypto. PSD GUIDs and subscription checkout attempt IDs now use that shared implementation.getRandomValues()output, unavailable-Web-Crypto failure, PSD GUID fallback, and checkout attempt IDs.Review Focus
Confirm fail-closed behavior is appropriate when both Web Crypto UUID APIs are unavailable.
Evidence
pnpm test:unit packages/shared-frontend-utils/src/formatUtil.test.ts src/renderer/extensions/layerEditor/psdExport.test.ts src/platform/cloud/subscription/utils/subscriptionCheckoutTracker.test.ts— 128 passedpnpm typecheck— passedpnpm --filter @comfyorg/shared-frontend-utils typecheck— existing unrelatedpiiUtil.test.ts$set/$set_onceerrors; full repository typecheck passedSource: #16777 (comment)