Repository navigation
feat(agent): report CRDT mint divergence - #16785
christian-byrne wants to merge 4 commits into
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1912 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.69 MB gzip 🔴 +3.46 kBDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.61 MB (baseline 3.6 MB) • 🔴 +9.01 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 17 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T19:29:49.047Z",
"gitSha": "a89d39c6b5c950c8bf190d9d4bc6c3e5856e4917",
"branch": "christian-byrne/tele-5-crdt-invariants",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2068.0130000000645,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.340999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.746,
"heapDeltaBytes": -3091592,
"heapUsedBytes": 66967748,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.447999999999999,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2047.076000000061,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.194999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.32,
"heapDeltaBytes": 535612,
"heapUsedBytes": 70557208,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.977,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1968.5420000000704,
"styleRecalcs": 82,
"styleRecalcDurationMs": 45.394,
"layouts": 14,
"layoutDurationMs": 5.084,
"taskDurationMs": 960.4899999999999,
"heapDeltaBytes": 4130380,
"heapUsedBytes": 74622052,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 155.59,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1912.9560000000083,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.217,
"layouts": 14,
"layoutDurationMs": 4.801,
"taskDurationMs": 937.925,
"heapDeltaBytes": -8581212,
"heapUsedBytes": 61902496,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 154.307,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.4979999999887,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.557,
"layouts": 6,
"layoutDurationMs": 1.249,
"taskDurationMs": 402.34099999999995,
"heapDeltaBytes": 4770032,
"heapUsedBytes": 75298328,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.746999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.9259999999713,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.645999999999997,
"layouts": 6,
"layoutDurationMs": 1.1669999999999998,
"taskDurationMs": 371.08699999999993,
"heapDeltaBytes": 5131208,
"heapUsedBytes": 75829936,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.005000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 728.6940000000186,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.556000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.5290000000001,
"heapDeltaBytes": -7463492,
"heapUsedBytes": 63001804,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 159.384,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 690.9719999999879,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.8080000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.55400000000003,
"heapDeltaBytes": -7781224,
"heapUsedBytes": 63038260,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 157.41,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.456000000091,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.137999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.9530000000001,
"heapDeltaBytes": -14568808,
"heapUsedBytes": 87179280,
"domNodes": -268,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 36.28099999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.5179999999345,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.808999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.7339999999999,
"heapDeltaBytes": -13947688,
"heapUsedBytes": 87986004,
"domNodes": -272,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 36.924,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2313.2750000000897,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1677.315,
"heapDeltaBytes": 22328032,
"heapUsedBytes": 88207884,
"domNodes": 0,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 772.926,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2178.8790000000517,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.376000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1580.401,
"heapDeltaBytes": 18605604,
"heapUsedBytes": 84439124,
"domNodes": -277,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 755.4730000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3760.3070000000116,
"styleRecalcs": 61,
"styleRecalcDurationMs": 13.036000000000003,
"layouts": 60,
"layoutDurationMs": 14.407,
"taskDurationMs": 1876.439,
"heapDeltaBytes": 10221304,
"heapUsedBytes": 76554604,
"domNodes": -279,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 808.414,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3618.8230000000203,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.557999999999995,
"layouts": 60,
"layoutDurationMs": 13.861,
"taskDurationMs": 1741.1129999999998,
"heapDeltaBytes": 9923180,
"heapUsedBytes": 76288616,
"domNodes": -281,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 775.885,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3149.8710000000756,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.605000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2010.3079999999998,
"heapDeltaBytes": 27478160,
"heapUsedBytes": 94788604,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 992.144,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3106.0309999999163,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.675,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1956.7440000000001,
"heapDeltaBytes": 22017720,
"heapUsedBytes": 89998328,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 952.4480000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.5760000000291,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.777999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.1780000000001,
"heapDeltaBytes": 22336968,
"heapUsedBytes": 87846100,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.004999999999995,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.4519999999247,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.689000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.676,
"heapDeltaBytes": 22251500,
"heapUsedBytes": 88427620,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.407,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 673.7520000000359,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.258999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.80999999999995,
"heapDeltaBytes": 15223120,
"heapUsedBytes": 87730812,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 152.79000000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 660.0770000000011,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.886,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.875,
"heapDeltaBytes": 15247392,
"heapUsedBytes": 88133756,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 150.42899999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2046.6129999999794,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.546999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.6469999999999,
"heapDeltaBytes": -9949432,
"heapUsedBytes": 61954252,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.943,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.051000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.7799999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.356,
"heapDeltaBytes": -8472448,
"heapUsedBytes": 64492188,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.911999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.4210000000357,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.967,
"layouts": 18,
"layoutDurationMs": 5.926,
"taskDurationMs": 845.0430000000001,
"heapDeltaBytes": 10064840,
"heapUsedBytes": 83000516,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 109.62599999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.770999999897,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.448,
"layouts": 18,
"layoutDurationMs": 6.071,
"taskDurationMs": 894.5369999999999,
"heapDeltaBytes": -15066004,
"heapUsedBytes": 57891832,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 114.454,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.0779999999231,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.473000000000003,
"layouts": 13,
"layoutDurationMs": 14.627,
"taskDurationMs": 991.6099999999999,
"heapDeltaBytes": -7409604,
"heapUsedBytes": 87852576,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 32.645,
"eventListeners": 2385,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8812.905999999999,
"styleRecalcs": 248,
"styleRecalcDurationMs": 44.128,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6201.581,
"heapDeltaBytes": -11288944,
"heapUsedBytes": 89243392,
"domNodes": -265,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 2717.1349999999998,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8586.868999999979,
"styleRecalcs": 246,
"styleRecalcDurationMs": 41.02400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5997.103,
"heapDeltaBytes": -13038508,
"heapUsedBytes": 88566952,
"domNodes": -273,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 2639.539,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18582.428999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18240.117000000002,
"heapDeltaBytes": -39201472,
"heapUsedBytes": 174547324,
"domNodes": -6548,
"jsHeapTotalBytes": -9478144,
"scriptDurationMs": 370.058,
"eventListeners": -7475,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18374.453000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17936.382,
"heapDeltaBytes": -39498468,
"heapUsedBytes": 163750836,
"domNodes": -6548,
"jsHeapTotalBytes": 5783552,
"scriptDurationMs": 315.691,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 23590.674000000035,
"styleRecalcs": 176,
"styleRecalcDurationMs": 26.104000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23423.675000000003,
"heapDeltaBytes": -26311688,
"heapUsedBytes": 187485668,
"domNodes": -6552,
"jsHeapTotalBytes": -9023488,
"scriptDurationMs": 942.001,
"eventListeners": -7467,
"totalBlockingTimeMs": 247,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 23605.64999999997,
"styleRecalcs": 177,
"styleRecalcDurationMs": 26.86099999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23410.742,
"heapDeltaBytes": -21928472,
"heapUsedBytes": 191988936,
"domNodes": -6548,
"jsHeapTotalBytes": -7450624,
"scriptDurationMs": 1011.6560000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 131,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6826.076999999941,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.345,
"layouts": 20,
"layoutDurationMs": 28.04599999999999,
"taskDurationMs": 6751.330000000001,
"heapDeltaBytes": -12137724,
"heapUsedBytes": 188283616,
"domNodes": -6548,
"jsHeapTotalBytes": 2318336,
"scriptDurationMs": 130.749,
"eventListeners": -7469,
"totalBlockingTimeMs": 573,
"frameDurationMs": 19.44333333333331,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6785.513000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.957,
"layouts": 20,
"layoutDurationMs": 26.683,
"taskDurationMs": 6753.344999999999,
"heapDeltaBytes": -27704156,
"heapUsedBytes": 181638084,
"domNodes": -6548,
"jsHeapTotalBytes": 2158592,
"scriptDurationMs": 135.254,
"eventListeners": -7471,
"totalBlockingTimeMs": 539,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9309.256000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9155.583,
"heapDeltaBytes": 10544344,
"heapUsedBytes": 178998148,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 156.77299999999994,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9365.573999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9259.719000000001,
"heapDeltaBytes": 2331080,
"heapUsedBytes": 179937320,
"domNodes": 0,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 157.39199999999997,
"eventListeners": -16,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 471.84600000002774,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.453000000000003,
"layouts": 4,
"layoutDurationMs": 1.869,
"taskDurationMs": 129.20100000000002,
"heapDeltaBytes": 5118256,
"heapUsedBytes": 73956808,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.806,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 95.54400000001806,
"styleRecalcs": 5,
"styleRecalcDurationMs": 13.547,
"layouts": 2,
"layoutDurationMs": 1.2260000000000002,
"taskDurationMs": 68.246,
"heapDeltaBytes": 2986828,
"heapUsedBytes": 71779992,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.237000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (11)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughCRDT node, widget, and link minting paths replace console diagnostics with structured ChangesCRDT telemetry migration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to CRDT mint divergence cases now emit structured, sanitized error telemetry while retaining existing minting behavior. The covered error and silent paths show no remaining merge-blocking risk. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the implementation, taxonomy, preserved behavior, affected files, and validation results. However, it does not follow the repository template. The required Summary, Changes, Review Focus, and Screenshots sections are missing. Full details: End-To-End Regression Coverage For FixesExplanation The PR metadata does not include the PR title or commit subjects. The check requires those fields to evaluate the bug-fix condition. The available file list shows changes under Resolution Provide the PR title and all commit subjects. If any contains bug-fix language such as Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The check applies because the changed files are CRDT mint ports for graph entities, including nodes, links, and widgets. The review context does not include the actual diff content required by this check. The summaries and description indicate telemetry-only changes, but they do not prove that the diff contains none of the listed ADR patterns. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
- Dev builds now lose the divergence signal entirely.
- Widget site dropped the ids the other two sites keep.
- Runtime behavior and privacy stance both check out.
Full context for agent readers
Verified against head 4150fff8: the three early returns are unchanged, no widget name or value enters a report, and reportError never throws, so the mint path cannot regress. The tag literals match the ADR 0030 taxonomy in #16784. new Error(...) passed to reportError is the existing convention at the other two layoutMintPort.ts sites, LGraph.ts and App.vue. Ran the three suites locally: 49 passed. mockReset: true in vite.config.mts clears the vi.fn() between tests, so the not.toHaveBeenCalled() assertions are sound.
The one issue is what a developer sees. main.ts sets Sentry enabled: !import.meta.env.DEV && !!sentryDsn and Datadog RUM only comes up through the cloud initTelemetry() path, so in a local dev or desktop build reportError finds no live sink, pushes the report into a 25-entry buffer that is never flushed, and prints nothing. Before this PR the console.error was the only local signal that the bound doc had diverged. crdtLog.ts exists for exactly this case (its warn level reaches the console even when the instrument is off "so that a fail-closed follower is never silent") and it also feeds the dev-panel ring buffer that ends up in the copied CRDT report, which is where a tester reproducing divergence would look. Pairing each reportError with a docLog.warn('mint_divergence', ...) keeps production telemetry as the source of truth while restoring the local signal.
Second, smaller: widgetMintPort.ts reports only hasRootGraph, while the layout site keeps nodeId. Graph and node ids are not user content, so keeping them costs nothing on the privacy side and is the difference between a triageable report and one that says only "some widget, somewhere".
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16785 +/- ##
==========================================
+ Coverage 81.14% 82.70% +1.55%
==========================================
Files 2460 2042 -418
Lines 126611 119141 -7470
Branches 31919 30092 -1827
==========================================
- Hits 102743 98539 -4204
+ Misses 23352 20421 -2931
+ Partials 516 181 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 424 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
CI on 4e10231 failed one pre-existing test; fixed in 8dc7655. Two pins were still spying Full context for agent readersThe original head's
Verified locally: 19/19 across both files, eslint/oxlint/oxfmt clean. |
Full context for agent readersConflict resolved: Semantic choice: kept Evidence at
|
|
Landing conflict confirmed. Preserve both event kinds. Full context for agent readersThis PR and #16797 will conflict on rebase even though both currently read Because the collision is PR-to-PR rather than against |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 3 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| 'widget owner unresolvable; set_widget not sent', | ||
| context | ||
| ) | ||
| reportError(new Error('CRDT widget owner cannot be resolved for mint'), { |
There was a problem hiding this comment.
🟠 High — This sits on the widget value-change feed, which fires per keystroke and per tick of a slider/number drag, so a persistently unresolvable owner (an open subgraph whose interior path won't resolve, or a null root graph) now constructs an Error and synchronously dispatches to Sentry + Datadog on every write. That is input-path stack capture plus a telemetry flood with no dedupe or throttle; reportUnrepresentableInteriorChange in layoutMintPort.ts already keys its reports in reportedInteriorChanges with a microtask reset — apply the same guard here. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial).
| `${what} has no wire op; the bound doc diverges from the local graph`, | ||
| { change: what, linkId: id } | ||
| ) | ||
| reportError( |
There was a problem hiding this comment.
🟡 Medium — surfaceUnrepresentable is invoked once per link — once per unconsumed entry in the sweep, and once per subgraph-interior link in onPlaced — so ordinary bulk editing (multi-link disconnect, convert-selection-to-subgraph, pasting a group inside a subgraph) now emits one remote error per link instead of one cheap console line. The surfaced set only dedupes within a single sweep, giving no cross-sweep bound; coalesce into one aggregated report per sweep or rate-limit. Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
| 'node snapshot unavailable for mint; createNode not sent', | ||
| { nodeId: operation.nodeId } | ||
| ) | ||
| reportError(new Error('CRDT node snapshot is unavailable for mint'), { |
There was a problem hiding this comment.
🟡 Medium — This report has no dedupe even though reportUnrepresentableInteriorChange a few lines above in this same file deliberately keys and expires its own. serializeNode returns null for a whole class of transient conditions — a bulk paste or undo whose createNode ops are delivered before graph insertion, or a rapid create-then-delete where the layout store's own microtask delivery lands after litegraph already removed the node — so one underlying fault becomes one Sentry + Datadog event per node, and self-consistent create/rollback sequences become false divergence alerts. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
| expect(consoleError).toHaveBeenCalledOnce() | ||
| expect(consoleError.mock.calls[0][1]).toBe(41) | ||
| consoleError.mockRestore() | ||
| expect(reportError).toHaveBeenCalledWith(expect.any(Error), { |
There was a problem hiding this comment.
🟡 Medium — The removed toHaveBeenCalledOnce() was the only guard on the surfaced dedupe in scheduleSweep: onDeleted pushes the same SeveranceEntry into both the origin and target buckets, so deleting that set would report every dangling link twice and this toHaveBeenCalledWith would still pass. Report volume is exactly the risk this PR introduces by moving to remote sinks — use toHaveBeenCalledExactlyOnceWith, as layoutStoreMintDelivery.test.ts does in this same diff. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial, gemini-3.1-pro edge-case).
| const context = { | ||
| hasRootGraph: root !== null, | ||
| graphId: set.graphId, | ||
| nodeId: set.nodeId |
There was a problem hiding this comment.
🟢 Low — The new context drops the widget name: the old console.error identified the failed write as ${set.graphId}:${nodeId}:${set.name}, but this carries only hasRootGraph/graphId/nodeId. Multiple unresolvable writes on the same node now produce identical log and telemetry payloads, so a crdt_widget_owner_unresolvable report can't be tied to the widget that diverged — add name: set.name. Raised by 4 of 8 reviewers (gpt-5.6-sol-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max edge-case, kimi-k3-max adversarial).
| expect(minted).toEqual([]) | ||
| expect(consoleError).toHaveBeenCalledOnce() | ||
| consoleError.mockRestore() | ||
| expect(reportError).toHaveBeenCalledWith( |
There was a problem hiding this comment.
🟢 Low — This assertion is strictly weaker than the toHaveBeenCalledOnce() it replaced and weaker than its sibling above: it pins neither the call count nor errorType, so reporting the wrong error type or reporting twice would pass. Assert the same shape as the interior-write case with hasRootGraph: false. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| @@ -146,12 +147,22 @@ export function attachLayoutMintPort(deps: LayoutMintPortDeps): LayoutMintPort { | |||
| if (operation.nodeId === undefined || !operation.layout) return | |||
| const node = deps.source.serializeNode(String(operation.nodeId)) | |||
| if (!node) { | |||
There was a problem hiding this comment.
🟢 Low — serializeNode returns null both when the node is absent from the graph and when serializeForMint swallows a throw from node.serialize(), and this branch replaces either with a fresh generic Error — discarding the original exception and stack. A custom node with a broken serializer becomes indistinguishable from a genuinely missing node; thread the caught cause through so the two are separable in triage. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
| `CRDT ${what} has no wire operation; the bound document diverges from the local graph` | ||
| ), | ||
| { | ||
| errorType: 'crdt_link_change_unrepresentable', |
There was a problem hiding this comment.
⚪ Nit — errorType is the query key on both consoles, and the new slugs (crdt_link_change_unrepresentable here, crdt_node_snapshot_missing in layoutMintPort.ts) don't share the agent_crdt_* prefix that file's existing unrepresentable-change reports already use. That splits one divergence family across two prefixes, so no single dashboard query catches all of it. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: blocking
I confirmed the existing snapshot-timing finding against the production create/delete delivery order. It remains blocking. I found no additional findings.
|
Not closing, but flagging before more of this lands. This PR adds telemetry that measures a disagreement between two implementations of the same behaviour rather than removing the second implementation. The survey found twelve open PRs in this shape. Each metric exists because the agent path and the user path can diverge, and each will read zero by construction once they share a channel: widget writes through What this PR measures: mint divergence at three ports while its body says existing early returns and mint behaviour are preserved. The divergence it reports is the causal bug; the report leaves it in place. The retirement plan is FE-3586: list every drift event, and for each either the PR that deleted it or the reason it still carries information after that work. Genuine failure reporting goes through Recommendation: close, or reduce to a single Context: FE-3387 (Agent/CRDT alignment programme) and the open-PR survey of 2026-10-22 (thread). Posted for DrJKL. |
…y-Org#21752) ## Summary Part of FE-3387, implements FE-3395. The agent CRDT applier used to write remote widget values by assigning `widget.value` and copying the `options.property` mirror by hand. That skipped the widget's own coercion and `min`/`max` clamping, so an agent could leave a number widget holding a value no user could enter. Ordinary `BaseWidget` writes now call `widget.setValue`, the same channel a user edit takes. `setValue` owns coercion, clamping, property mirroring, `callback`, `onWidgetChanged` and the graph version bump. If an extension hook throws, the value and its mirrored property roll back. **Clamping decision (FE-3387 open question): the live widget clamps, and the document keeps what the host sent.** `setValue` clamps or coerces the value on the canvas. The follower mints no correction op, so the document value stays verbatim. Writing a correction back would make the follower author ops from remote writes, which breaks the provenance rule in ADR CRDT-FOLLOWER-0025 and CRDT-AUTHORITY-0035. If the host should store the accepted value, the host or agent has to clamp before sending. To flip to "converge the document on the live value", re-announce the accepted value after `setValue` in `setWidgetValue`. That flip needs an ADR change first. Scope versus the issue: - **`setValue` does not enforce combo membership or `precision`.** The issue assumed it did. Combo values outside `options.values` and numbers finer than `precision` still apply unchanged, and tests pin that. Enforcing either belongs in the widget, not the agent. - **Not routed, on purpose:** - Promoted subgraph-host widgets are store-backed descriptors with no `setValue`. Their callback-receiver and reassert path from Comfy-Org#19332 stays. - Plain-object widgets pushed straight into `node.widgets` keep the direct write. Routing on `instanceof BaseWidget` conflicts with Proposed ADR-ECS-WIDGETS-0023; whether to record an exception or file a follow-up issue is open in the review thread. - DynamicGroup row-count controllers keep the direct write. Their own setter owns the row count, and after a restore that count can legitimately exceed `max`. Existing tests cover this case. - **`BaseWidget.setValue` changes:** - `options` is optional and defaults to `{ node: this.node }`, so one-argument extension wrappers keep working. `e` and `canvas` are optional too. - A number widget refuses a value whose `Number(value)` is NaN: the value stays the same and the callback does not run. - `docs/extensions/widgets-migration.md` documents both changes. - `holdsLocalWrite` already guards every write before it reaches the widget, so plan step 3 needed no change. - Drift telemetry: Comfy-Org#20556 and Comfy-Org#16785 both detect drift on the mint side, not the apply side. On main, `docOpMinter` already reports Comfy-Org#16785's widget-owner case, and its `widgetMintPort` files no longer exist. Comfy-Org#20556's mismatch between the live and stored `serialize` flags happens when a widget registers, so this change does not make it tautological. The regression tests here pin the apply-side contract instead: the live widget holds the value `setValue` accepted, and the follower sends nothing back. ## Verification - A new table in `liveGraphApplier.test.ts` runs the real applier and the real `docOpMinter`. Rows: in range → applied; above max → 10; below min → 0; numeric string → number; non-numeric string → refused, previous value kept; finer than precision → unchanged; combo value not in the list → unchanged. Every row asserts that the minter enqueues no op. - A separate test passes a canvas and asserts that the callback, `onWidgetChanged` and the mirrored property all receive the accepted value. - In `BaseWidget.test.ts`, one test covers a call with no options and one covers NaN refusal. - On the old applier, the clamp, coerce and hook tests fail. On this branch, all of them pass. - `pnpm test:unit src/workbench/extensions/agent/crdt src/lib/litegraph/src/widgets src/core/graph/widgets`: 98 files, 1663 passed. - CI is green at the current head. --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Full context for agent readers
Converts console-only divergence signals in the CRDT human-write mint ports to the existing
reportError()boundary. Each event uses the taxonomy defined by ADR 0030:failure_kind: invariant,feature_area: crdt,operation: sync, andoutcome: failed.Sites:
layoutMintPort.ts— missing node snapshot →crdt_node_snapshot_missinglinkMintPort.ts— unrepresentable placement or disconnect →crdt_link_change_unrepresentablewidgetMintPort.ts— unresolvable widget owner →crdt_widget_owner_unresolvableNo workflow content, widget names, or other user data enters telemetry. Existing early returns and mint behavior are preserved.
Evidence
pnpm test:unit src/workbench/extensions/agent/crdt/layoutMintPort.test.ts src/workbench/extensions/agent/crdt/linkMintPort.test.ts src/workbench/extensions/agent/crdt/widgetMintPort.test.ts— 49 passedpnpm typecheck— passedpnpm lint— passed with existing warnings onlypnpm exec oxfmt --check <six changed files>— passedknip --cache— passedgit show --check HEAD— passed