Skip to content

test: prove comfy multiplayer governance gates fail closed - #16778

Closed
christian-byrne wants to merge 1 commit into
christian-byrne/ecw-106-comfy-multi-player-workspacefrom
christian-byrne/prlc4-governance-negative-tests
Closed

christian-byrne wants to merge 1 commit into
christian-byrne/ecw-106-comfy-multi-player-workspacefrom
christian-byrne/prlc4-governance-negative-tests

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Adds intentional-violation tests proving the purity, citation-pin, and statelessness gates reject prohibited inputs.

This PR is intentionally stacked on open PR #16644 because packages/comfy-multi-player does not yet exist on main.

Changes

  • What: Adds isolated fixture roots and invokes the production gates against planted violations.
  • Dependencies: None.

Review Focus

The tests cover the KA-3/KA-13 stateless rules, the FC-10/KA-12 moving-reference rule, and the yjs-only runtime dependency rule.

Verification: package build/typecheck; all nine package checks; 70 files and 860 tests; focused 41 tests.

@christian-byrne christian-byrne self-assigned this Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: e0792376-4d0e-4cf0-bf33-fc1111ab177c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 01:48:12 PM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎭 Playwright: ✅ 1901 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1880 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 126ms TBT · 90.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.9 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.2 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 172ms TBT · 170.2 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 476ms TBT · 175.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 576ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 55.0 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -151
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 40ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 883ms
canvas-mouse-sweep: script duration 148ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 60.0 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -150
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 365ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 457ms
dom-widget-clipping: script duration 157ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.2 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 642ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.0 MB
large-graph-idle: DOM nodes -266
large-graph-idle: event listeners -149
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1619ms
large-graph-pan: script duration 770ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.6 MB
large-graph-pan: DOM nodes -134
large-graph-pan: event listeners -71
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1749ms
large-graph-zoom: script duration 780ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.2 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1952ms
legacy-node-drag: script duration 960ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.7 MB
legacy-node-drag: DOM nodes -139
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 612ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.9 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -73
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 418ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.5 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 499ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.8 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -194
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 38ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 838ms
subgraph-mouse-sweep: script duration 110ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.9 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -196
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1008ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 126ms
subgraph-transition-enter: heap used 90.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 5922ms
viewport-pan-sweep: script duration 2629ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.9 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -133
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17937ms
vue-large-graph-idle: script duration 312ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.2 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 24ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 177
vue-large-graph-pan: task duration 22862ms
vue-large-graph-pan: script duration 961ms
vue-large-graph-pan: TBT 172ms
vue-large-graph-pan: heap used 170.2 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 30ms
vue-node-resize-workload: style recalc duration 85ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6541ms
vue-node-resize-workload: script duration 117ms
vue-node-resize-workload: TBT 476ms
vue-node-resize-workload: heap used 175.1 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7468
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 4
workflow-execution: style recalc count 16
workflow-execution: task duration 114ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.8 MB
workflow-execution: DOM nodes 132
workflow-execution: event listeners 67
Raw data
{
  "timestamp": "2026-09-03T14:00:04.176Z",
  "gitSha": "4126e09c40128b6f9094744722757c7e5370b503",
  "branch": "christian-byrne/prlc4-governance-negative-tests",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2060.6710000000135,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.230999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 580.1120000000001,
      "heapDeltaBytes": -12629280,
      "heapUsedBytes": 57218624,
      "domNodes": -277,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 11.550999999999998,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.3839999999136,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.921,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 572.244,
      "heapDeltaBytes": -11667444,
      "heapUsedBytes": 58029692,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 11.516000000000002,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1835.8780000000365,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.011,
      "layouts": 14,
      "layoutDurationMs": 4.647,
      "taskDurationMs": 875.4819999999999,
      "heapDeltaBytes": -8578616,
      "heapUsedBytes": 62032440,
      "domNodes": -279,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 148.176,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1853.6649999999781,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 39.010000000000005,
      "layouts": 14,
      "layoutDurationMs": 4.503,
      "taskDurationMs": 891.3140000000001,
      "heapDeltaBytes": -6945420,
      "heapUsedBytes": 63778124,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 147.341,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.1009999999815,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.272000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.103,
      "taskDurationMs": 364.268,
      "heapDeltaBytes": 4768264,
      "heapUsedBytes": 75528312,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.847,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1719.5480000000316,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.277,
      "layouts": 6,
      "layoutDurationMs": 1.124,
      "taskDurationMs": 366.02900000000005,
      "heapDeltaBytes": 5046420,
      "heapUsedBytes": 75337032,
      "domNodes": 78,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 12.445000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 720.6649999999968,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.889000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 457.37800000000004,
      "heapDeltaBytes": -7530424,
      "heapUsedBytes": 62910204,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 156.184,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 709.3759999999065,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.866999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.701,
      "heapDeltaBytes": 18470776,
      "heapUsedBytes": 88447280,
      "domNodes": 18,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 158.63400000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2046.18499999998,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.471999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 656.96,
      "heapDeltaBytes": -14303620,
      "heapUsedBytes": 86856688,
      "domNodes": -263,
      "jsHeapTotalBytes": -1101824,
      "scriptDurationMs": 33.99500000000001,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2057.337999999959,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.610000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 626.9329999999999,
      "heapDeltaBytes": -13734608,
      "heapUsedBytes": 87261112,
      "domNodes": -268,
      "jsHeapTotalBytes": -1101824,
      "scriptDurationMs": 34.408,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2172.0470000000205,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 9.321999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1600.536,
      "heapDeltaBytes": 18196140,
      "heapUsedBytes": 84139104,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 773.462,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2206.32599999999,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.494999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1636.988,
      "heapDeltaBytes": -17100640,
      "heapUsedBytes": 84797848,
      "domNodes": -268,
      "jsHeapTotalBytes": -1138688,
      "scriptDurationMs": 766.933,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3586.884999999995,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.584999999999997,
      "layouts": 60,
      "layoutDurationMs": 13.983000000000002,
      "taskDurationMs": 1748.832,
      "heapDeltaBytes": 8484292,
      "heapUsedBytes": 76093044,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 779.612,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3562.9900000000134,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.459,
      "layouts": 60,
      "layoutDurationMs": 13.819999999999999,
      "taskDurationMs": 1749.178,
      "heapDeltaBytes": 8035460,
      "heapUsedBytes": 75389056,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 779.6299999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3106.7689999999857,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.718000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1957.9279999999999,
      "heapDeltaBytes": 21967012,
      "heapUsedBytes": 89705440,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 966.85,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3120.2030000000605,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.4860000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1945.9360000000001,
      "heapDeltaBytes": 26675288,
      "heapUsedBytes": 94159576,
      "domNodes": -278,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 953.601,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.958000000026,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 3.553999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 629.5049999999999,
      "heapDeltaBytes": 21861824,
      "heapUsedBytes": 88063680,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 38.04500000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.1009999999878,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.346999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 594.9499999999998,
      "heapDeltaBytes": -14795796,
      "heapUsedBytes": 87977688,
      "domNodes": -271,
      "jsHeapTotalBytes": -1626112,
      "scriptDurationMs": 34.419000000000004,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 614.058,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.23,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.82099999999997,
      "heapDeltaBytes": 15180828,
      "heapUsedBytes": 87516784,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 141.005,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 610.1149999999507,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.825000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 419.8069999999999,
      "heapDeltaBytes": 14922100,
      "heapUsedBytes": 87667356,
      "domNodes": 22,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 143.93,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.0139999999606,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.355999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.61199999999997,
      "heapDeltaBytes": -8619720,
      "heapUsedBytes": 63754460,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 9.091000000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.7740000000313,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.372,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.649,
      "heapDeltaBytes": -6966452,
      "heapUsedBytes": 65881932,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.204999999999997,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1741.8710000000033,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 39.864000000000004,
      "layouts": 18,
      "layoutDurationMs": 6.342,
      "taskDurationMs": 842.3739999999999,
      "heapDeltaBytes": -12472576,
      "heapUsedBytes": 60268064,
      "domNodes": -294,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 112.01100000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1741.5849999999864,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.065,
      "layouts": 18,
      "layoutDurationMs": 5.762,
      "taskDurationMs": 833.3259999999999,
      "heapDeltaBytes": -11495236,
      "heapUsedBytes": 61140216,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 108.23400000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.948999999945,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.699000000000005,
      "layouts": 14,
      "layoutDurationMs": 15.453999999999999,
      "taskDurationMs": 1008.1839999999997,
      "heapDeltaBytes": -1813808,
      "heapUsedBytes": 95160384,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 32.647000000000006,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 126,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8597.531000000003,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 42.657,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6047.549999999999,
      "heapDeltaBytes": -7422072,
      "heapUsedBytes": 93550280,
      "domNodes": -272,
      "jsHeapTotalBytes": -1925120,
      "scriptDurationMs": 2651.197,
      "eventListeners": -132,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8426.732000000015,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 40.010000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5795.481000000001,
      "heapDeltaBytes": -11982804,
      "heapUsedBytes": 88650924,
      "domNodes": -266,
      "jsHeapTotalBytes": -2449408,
      "scriptDurationMs": 2606.194,
      "eventListeners": -134,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18251.638999999956,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17722.134000000002,
      "heapDeltaBytes": -29515624,
      "heapUsedBytes": 175241732,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3833856,
      "scriptDurationMs": 316.152,
      "eventListeners": -7477,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18483.799999999974,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18152.113999999998,
      "heapDeltaBytes": -23610776,
      "heapUsedBytes": 179499804,
      "domNodes": -6548,
      "jsHeapTotalBytes": 7852032,
      "scriptDurationMs": 308.102,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23116.24499999999,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 24.069000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22893.96,
      "heapDeltaBytes": -12977824,
      "heapUsedBytes": 190425380,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3063808,
      "scriptDurationMs": 969.197,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 265,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23063.094999999976,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 24.529999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22830.751,
      "heapDeltaBytes": -39569760,
      "heapUsedBytes": 166537436,
      "domNodes": -6548,
      "jsHeapTotalBytes": 466944,
      "scriptDurationMs": 953.6860000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 78,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6637.005999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.00200000000001,
      "layouts": 20,
      "layoutDurationMs": 27.586000000000013,
      "taskDurationMs": 6552.715000000001,
      "heapDeltaBytes": -32615168,
      "heapUsedBytes": 180844668,
      "domNodes": -6548,
      "jsHeapTotalBytes": 7049216,
      "scriptDurationMs": 119.158,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 494,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6553.343000000041,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 94.744,
      "layouts": 20,
      "layoutDurationMs": 32.611000000000004,
      "taskDurationMs": 6528.831999999999,
      "heapDeltaBytes": -23260972,
      "heapUsedBytes": 186373236,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1699840,
      "scriptDurationMs": 115.14,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 458,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 483.8000000000875,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 20.885,
      "layouts": 3,
      "layoutDurationMs": 1.7670000000000001,
      "taskDurationMs": 116.965,
      "heapDeltaBytes": 5035596,
      "heapUsedBytes": 73743340,
      "domNodes": 146,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.605000000000002,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 462.33300000005784,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 22.227000000000004,
      "layouts": 4,
      "layoutDurationMs": 1.782,
      "taskDurationMs": 110.761,
      "heapDeltaBytes": 4790364,
      "heapUsedBytes": 72661048,
      "domNodes": 117,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.954,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48165 70812 68.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.6% 251
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                                   Coverage Diff                                    @@
##           christian-byrne/ecw-106-comfy-multi-player-workspace   #16778      +/-   ##
========================================================================================
- Coverage                                                 80.39%   80.36%   -0.03%     
========================================================================================
  Files                                                      2455     2453       -2     
  Lines                                                    126091   125902     -189     
  Branches                                                  31752    33535    +1783     
========================================================================================
- Hits                                                     101365   101184     -181     
+ Misses                                                    24224    24216       -8     
  Partials                                                    502      502              
Flag Coverage Δ
e2e 68.01% <ø> (-0.02%) ⬇️
unit 76.28% <ø> (-0.04%) ⬇️
website-unit 54.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Standalone replacement: governance recovery. Frontend relocation remains deferred.

Full context for agent readers

The replacement recovers governance tests and invariant registration into comfy-multi-player main. The duplicate frontend-workflow deletion is accounted for by the already-landed standalone restoration, not copied into the replacement. The replacement body attributes all ten captured comments across the three governance sources, retaining authors, dates and direct links.

The earlier instruction to keep this work stacked on the frontend relocation is superseded by Christian's standalone ruling. Historical checks and review-skipped notices are preserved as history, not fresh verification or approvals. The replacement passed its local tests and gates; hosted checks and actual review remain required. This source stays preserved until code, collaboration and late-comment accounting complete. No source branch or review thread is deleted or resolved by this message.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded by merged standalone governance recovery. Closing without merge; branch and review history stay intact.

Full context for agent readers

Christian requested completion of the standalone migration and retirement of accounted originals. This source remains at 341e646 . Its governance negative tests were recovered in Comfy-Org/comfy-multi-player#200 and landed as Comfy-Org/comfy-multi-player@1a689e8 .

The replacement body attributes the original comments. Fresh inspection found four issue comments (including the earlier recovery cross-link), no native reviews and no inline review comments. No new substantive feedback or source commits remain unaccounted. The source's skipped review and historical CI reports are not fresh verification or transferred approval.

No retarget, source-branch deletion, review resolution, package publication or product-acceptance claim accompanies this closure. Future package changes belong in the standalone repository.

Glossary: standalone means Comfy-Org/comfy-multi-player owns the package source; CI means hosted automated checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flag-exempt risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant