Repository navigation
Fix absent CRDT debug storage memoization - #16775
Closed
christian-byrne wants to merge 1 commit into
Closed
christian-byrne wants to merge 1 commit into
christian-byrne wants to merge 1 commit into
Conversation
Contributor
|
Warning Review limit reachedNext included review available in 22 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
Contributor
🎭 Playwright: ❌ 1912 passed, 1 failed · 1 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook |
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16775 +/- ##
==========================================
+ Coverage 81.11% 82.68% +1.56%
==========================================
Files 2458 2040 -418
Lines 126457 118982 -7475
Branches 33692 31865 -1827
==========================================
- Hits 102573 98375 -4198
+ Misses 23369 20427 -2942
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 418 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caches an absent CRDT debug storage value so the hot path reads localStorage only once.
Changes
Review Focus
Confirm explicit enabled/disabled values retain their existing cache behavior.
Evidence
pnpm test:unit src/workbench/extensions/agent/crdt/crdtDebugGate.test.ts— 16 passed.pnpm exec oxfmt --check src/workbench/extensions/agent/crdt/crdtDebugGate.ts src/workbench/extensions/agent/crdt/crdtDebugGate.test.ts— passed.pnpm typecheck— passed.pnpm knip --cache— passed.Follow-up to #16365 (comment)