Repository navigation
test: characterize personal draft identity collision - #16773
christian-byrne wants to merge 1 commit into
Conversation
🎨 Storybook: 🚧 Building...🎭 Playwright: ✅ 1914 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T13:01:58.635Z",
"gitSha": "64acb52cd998e91dcabdd9cc3fab36fb7ab38e4e",
"branch": "test/r50-personal-draft-cross-user",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2030.349000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.39,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.58899999999994,
"heapDeltaBytes": -9736568,
"heapUsedBytes": 60945624,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.438000000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2029.6109999999885,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.966999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.23699999999997,
"heapDeltaBytes": -1650984,
"heapUsedBytes": 68309864,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.4220000000000015,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.7250000000008,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.857999999999997,
"layouts": 14,
"layoutDurationMs": 3.4989999999999997,
"taskDurationMs": 809.0139999999999,
"heapDeltaBytes": 2840196,
"heapUsedBytes": 72214940,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 126.336,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1738.8240000000224,
"styleRecalcs": 74,
"styleRecalcDurationMs": 23.919999999999998,
"layouts": 14,
"layoutDurationMs": 2.928,
"taskDurationMs": 674.5720000000001,
"heapDeltaBytes": 4476440,
"heapUsedBytes": 75289656,
"domNodes": -278,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 102.269,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.5010000000252,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.449,
"layouts": 6,
"layoutDurationMs": 0.923,
"taskDurationMs": 300.7,
"heapDeltaBytes": 5117148,
"heapUsedBytes": 75771792,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.167000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.2279999999755,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.516,
"layouts": 6,
"layoutDurationMs": 0.809,
"taskDurationMs": 298.09400000000005,
"heapDeltaBytes": 5099504,
"heapUsedBytes": 74831796,
"domNodes": 80,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.275999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 544.3679999999631,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.594,
"heapDeltaBytes": 18536648,
"heapUsedBytes": 88497640,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 119.22499999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 543.5769999999707,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.095,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.402,
"heapDeltaBytes": -7757568,
"heapUsedBytes": 62865248,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 120.244,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.2929999999906,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.713000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.8180000000001,
"heapDeltaBytes": -13600600,
"heapUsedBytes": 87835464,
"domNodes": -265,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 29.690999999999995,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2021.0720000000038,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.7209999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.60400000000004,
"heapDeltaBytes": -13962736,
"heapUsedBytes": 87940524,
"domNodes": -267,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 22.359999999999992,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2122.156000000018,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.529000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1294.495,
"heapDeltaBytes": 19957276,
"heapUsedBytes": 86173900,
"domNodes": -271,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 630.669,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2085.3460000000723,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.879,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1178.3260000000002,
"heapDeltaBytes": 18730684,
"heapUsedBytes": 84561216,
"domNodes": -1,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 560.33,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3073.681000000022,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.382000000000001,
"layouts": 60,
"layoutDurationMs": 9.167,
"taskDurationMs": 1289.422,
"heapDeltaBytes": 8188772,
"heapUsedBytes": 75397176,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 549.533,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3112.781000000041,
"styleRecalcs": 61,
"styleRecalcDurationMs": 7.507,
"layouts": 60,
"layoutDurationMs": 8.831999999999999,
"taskDurationMs": 1275.417,
"heapDeltaBytes": 12869484,
"heapUsedBytes": 81073508,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 549.422,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2208.450999999968,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.716999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1454.176,
"heapDeltaBytes": 13615168,
"heapUsedBytes": 81193360,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 680.321,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2268.3550000000423,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.3020000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1336.194,
"heapDeltaBytes": 17305196,
"heapUsedBytes": 84734840,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 638.6390000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.050000000017,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.862999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.12799999999993,
"heapDeltaBytes": -15868400,
"heapUsedBytes": 87958484,
"domNodes": -267,
"jsHeapTotalBytes": -2949120,
"scriptDurationMs": 22.892000000000003,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.654999999958,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.6720000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.7130000000001,
"heapDeltaBytes": 10492496,
"heapUsedBytes": 87526956,
"domNodes": -270,
"jsHeapTotalBytes": -2985984,
"scriptDurationMs": 27.651000000000003,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 540.1300000000333,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.606000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.306,
"heapDeltaBytes": 14993880,
"heapUsedBytes": 87651140,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 98.34700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.939000000023,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.12700000000007,
"heapDeltaBytes": 14910648,
"heapUsedBytes": 87729608,
"domNodes": 24,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 99.825,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.5700000000343,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.511,
"heapDeltaBytes": -10086952,
"heapUsedBytes": 62808724,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.0740000000000025,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.0179999999932,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.203,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.60200000000003,
"heapDeltaBytes": -8687340,
"heapUsedBytes": 64098884,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.212,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.7840000000133,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.811999999999998,
"layouts": 18,
"layoutDurationMs": 3.900000000000001,
"taskDurationMs": 647.91,
"heapDeltaBytes": -9980280,
"heapUsedBytes": 62793612,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 72.912,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.2389999999486,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.355,
"layouts": 18,
"layoutDurationMs": 3.0550000000000006,
"taskDurationMs": 631.51,
"heapDeltaBytes": -13482012,
"heapUsedBytes": 59452932,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 69.928,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.0729999999717,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.509,
"layouts": 16,
"layoutDurationMs": 10.34,
"taskDurationMs": 700.437,
"heapDeltaBytes": 21121644,
"heapUsedBytes": 109504468,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 20.293,
"eventListeners": 2385,
"totalBlockingTimeMs": 111,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8194.84399999999,
"styleRecalcs": 248,
"styleRecalcDurationMs": 22.730000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4469.787,
"heapDeltaBytes": -12474196,
"heapUsedBytes": 89234628,
"domNodes": -267,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 1919.2160000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8154.720999999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 24.447999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4244.65,
"heapDeltaBytes": 12861456,
"heapUsedBytes": 89007060,
"domNodes": -265,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 1825.699,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12533.094000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11516.360999999999,
"heapDeltaBytes": -35661692,
"heapUsedBytes": 174795796,
"domNodes": -6548,
"jsHeapTotalBytes": -5955584,
"scriptDurationMs": 169.51100000000002,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12020.192999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10906.967999999999,
"heapDeltaBytes": -34130204,
"heapUsedBytes": 175347376,
"domNodes": -6548,
"jsHeapTotalBytes": -4149248,
"scriptDurationMs": 151.847,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14790.007000000003,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.333999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14118.801,
"heapDeltaBytes": -14509048,
"heapUsedBytes": 173937512,
"domNodes": -6548,
"jsHeapTotalBytes": 8667136,
"scriptDurationMs": 666.385,
"eventListeners": -7471,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14804.894999999988,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.393999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14156.765,
"heapDeltaBytes": -31581040,
"heapUsedBytes": 173393144,
"domNodes": -6548,
"jsHeapTotalBytes": 11771904,
"scriptDurationMs": 675.298,
"eventListeners": -7473,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4134.048000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.67500000000003,
"layouts": 20,
"layoutDurationMs": 19.516000000000005,
"taskDurationMs": 4001.8710000000005,
"heapDeltaBytes": -26495000,
"heapUsedBytes": 175024632,
"domNodes": -6548,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 87.914,
"eventListeners": -7475,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4207.72199999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.696000000000026,
"layouts": 20,
"layoutDurationMs": 19.083000000000002,
"taskDurationMs": 4062.1679999999988,
"heapDeltaBytes": -7440276,
"heapUsedBytes": 181027340,
"domNodes": -6548,
"jsHeapTotalBytes": 14098432,
"scriptDurationMs": 67.584,
"eventListeners": -7475,
"totalBlockingTimeMs": 13,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5885.4699999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5437.927000000001,
"heapDeltaBytes": 1402856,
"heapUsedBytes": 176625884,
"domNodes": 0,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 71.631,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6217.445999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5769.5740000000005,
"heapDeltaBytes": -2069932,
"heapUsedBytes": 176104720,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 103.38600000000004,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 442.27400000005446,
"styleRecalcs": 21,
"styleRecalcDurationMs": 18.77,
"layouts": 5,
"layoutDurationMs": 1.6829999999999998,
"taskDurationMs": 97.19599999999998,
"heapDeltaBytes": 5094060,
"heapUsedBytes": 73900356,
"domNodes": 151,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.800999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 81.30500000004304,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.995,
"layouts": 2,
"layoutDurationMs": 1.046,
"taskDurationMs": 53.118999999999986,
"heapDeltaBytes": 2962260,
"heapUsedBytes": 71709144,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.683999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds a regression test for authenticated user switches without a selected workspace. The test documents that both users resolve to the same personal draft key and can access the previously stored draft. ChangesDraft storage isolation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change documents existing personal workflow-draft key reuse during direct authenticated account switches without altering production behavior. No merge-blocking risk is introduced by the test-only change. Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
Full details: Description checkExplanation The description clearly states the purpose, scope, change, review focus, issue reference, and validation evidence. The omitted breaking-change, dependency, and screenshots details are not required for this test-only change. Full details: End-To-End Regression Coverage For FixesExplanation PASS. The available commit-subject summary uses “reproduces” and contains no bug-fix signal such as “fix” or “bugfix.” The PR changes a file under Full details: Website End-To-End Regression CoverageExplanation The PR changes only Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The only changed file is ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16773 +/- ##
==========================================
+ Coverage 81.11% 82.67% +1.55%
==========================================
Files 2458 2040 -418
Lines 126457 118978 -7479
Branches 33692 31865 -1827
==========================================
- Hits 102573 98360 -4213
+ Misses 23369 20438 -2931
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
One Major inline: the new characterization test does not exercise the switch it is named after.
| }) | ||
|
|
||
| describe('StorageKeys', () => { | ||
| it('reproduces R-50: an authenticated A → B switch shares the personal draft key', async () => { |
There was a problem hiding this comment.
Severity: Major
What: The case never switches user: getWorkspaceId (storageKeys.ts:14-28) takes no argument and reads only isCloud and the Comfy.Workspace.Current key cleared at :90, userA and userB reach nothing, and the only assertion naming them (:108) compares two literals.
Why this is an issue: It passes with or without a fix for the collision it is named after, so it never goes red when the shared draft key is fixed.
Proposed Fix: Drive the two reads through whatever carries user identity so the second can differ from the first, and drop the userB.uid vs userA.uid literal comparison.
|
Closing as superseded. #17313 ships the fix for the draft-identity problem together with tests covering scope resolution, deferred writes, identity fencing, legacy migration, and logout wipe, which cover what this characterization test was probing. Full context for agent readersThis PR added a characterization test for personal-draft identity collisions in support of #16371. That issue is now closed as a misdiagnosis: the leak came from unscoped drafts, not hash collisions. PR 17313 adds unit tests under |
Summary
Characterize the current R-50 risk: direct authenticated account switches share the subjectless
personalworkflow-draft key.Changes
localStorageentry, which remains unchanged across the modeled identity transition.Review Focus
This records current risky behavior, not the desired storage policy. V3 identity, invalidation, and CRDT lineage decisions remain out of scope.
Relates to #16347.
Evidence
NODE_OPTIONS='--no-experimental-webstorage' pnpm test:unit src/platform/workflow/persistence/base/storageKeys.test.ts— 14 passedpnpm exec oxfmt --check src/platform/workflow/persistence/base/storageKeys.test.ts— passedpnpm exec eslint src/platform/workflow/persistence/base/storageKeys.test.ts— passedpnpm typecheckandknip --cache— passed