Repository navigation
fix(agent): expose run-mode methods on AgentRestClient - #16771
Conversation
…tClient and pin it with a contract test Closes review thread PRRT_kwDOMIrOxs6etRo7 on #16432: the exported alias deliberately subtracts getRunMode/putRunMode so existing useAgentSession test doubles stay structurally valid; run-mode access is store-mediated through the inferred return type of createAgentRestClient(). The rationale now lives above the type and a conditional-type contract test pins the omission so a future widening cannot silently break the doubles. <!-- authored-by:agent phs-6 -->
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe agent REST client type now includes ChangesAgent run-mode client typing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Agent run-mode methods are exposed through the REST client type with aligned tests and fixtures, without changing runtime behavior. The change is ready to merge. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The review context lists the changed files and PR description, but it does not provide the PR title or any commit subjects. The custom check requires those fields to identify bug-fix language. The check therefore cannot determine whether its first condition is met. Full details: Description checkExplanation The description explains the type change, affected test doubles, rationale, and validation results. It does not use the template headings or explicitly state breaking-change and dependency status, but it is otherwise complete and relevant. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1912 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T13:05:48.132Z",
"gitSha": "27bb773e150f69dee25c6eb3d5350190ffea9260",
"branch": "phs6/16432-runmode-residuals",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2085.6129999999666,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.928000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.511,
"heapDeltaBytes": -2357908,
"heapUsedBytes": 68289316,
"domNodes": -284,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.852,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2015.57600000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.133,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.85999999999996,
"heapDeltaBytes": -12554208,
"heapUsedBytes": 57191416,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.442000000000002,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.712999999976,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.053,
"layouts": 14,
"layoutDurationMs": 4.262999999999999,
"taskDurationMs": 888.431,
"heapDeltaBytes": -6715156,
"heapUsedBytes": 64094036,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 160.869,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1838.7500000000045,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.772,
"layouts": 14,
"layoutDurationMs": 4.2490000000000006,
"taskDurationMs": 886.287,
"heapDeltaBytes": 4564940,
"heapUsedBytes": 75020360,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 160.93099999999998,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.5550000000126,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.057000000000002,
"layouts": 6,
"layoutDurationMs": 1.0759999999999998,
"taskDurationMs": 369.448,
"heapDeltaBytes": 4804344,
"heapUsedBytes": 75209484,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.959000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.2369999999828,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.038999999999998,
"layouts": 6,
"layoutDurationMs": 1.2480000000000002,
"taskDurationMs": 403.05100000000004,
"heapDeltaBytes": 5089664,
"heapUsedBytes": 75856680,
"domNodes": 75,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 13.726000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 669.8680000000081,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.556999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.111,
"heapDeltaBytes": -7765740,
"heapUsedBytes": 62898180,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 157.26199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 644.2240000000083,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.923,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.318,
"heapDeltaBytes": -7157588,
"heapUsedBytes": 63271652,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 164.55800000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.4529999999763,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.385000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.65,
"heapDeltaBytes": 10683600,
"heapUsedBytes": 86472760,
"domNodes": -270,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 35.732,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.3709999999646,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.581000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.336,
"heapDeltaBytes": -14193968,
"heapUsedBytes": 87645064,
"domNodes": -270,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 32.055,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2459.419999999966,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.177999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1686.5580000000002,
"heapDeltaBytes": 25740832,
"heapUsedBytes": 91564172,
"domNodes": -272,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 830.7789999999999,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2296.8610000000353,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.716000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1648.9979999999998,
"heapDeltaBytes": 23696112,
"heapUsedBytes": 89523380,
"domNodes": -277,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 843.194,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3534.8940000000084,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.713999999999999,
"layouts": 60,
"layoutDurationMs": 11.853000000000002,
"taskDurationMs": 1681.438,
"heapDeltaBytes": 8209260,
"heapUsedBytes": 76092480,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 761.382,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3637.4329999999873,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.371000000000002,
"layouts": 60,
"layoutDurationMs": 12.291,
"taskDurationMs": 1760.431,
"heapDeltaBytes": 11745728,
"heapUsedBytes": 79912704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 782.4479999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3071.664999999996,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.8839999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1915.389,
"heapDeltaBytes": 25345244,
"heapUsedBytes": 93506620,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 960.3419999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3107.9770000000053,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.667000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1916.3549999999998,
"heapDeltaBytes": 21628476,
"heapUsedBytes": 88921156,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 970.4069999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2025.5559999999946,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7319999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.9899999999999,
"heapDeltaBytes": -15872988,
"heapUsedBytes": 87933728,
"domNodes": -270,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 32.13,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.0829999999241,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.8250000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.524,
"heapDeltaBytes": -15656324,
"heapUsedBytes": 87884572,
"domNodes": -272,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 33.707,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.5359999999537,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.471000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.80800000000005,
"heapDeltaBytes": 14884260,
"heapUsedBytes": 87779160,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.00800000000004,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.2929999999506,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.553,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.04799999999994,
"heapDeltaBytes": 15065616,
"heapUsedBytes": 88116464,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 137.637,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.786000000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.543999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.5099999999999,
"heapDeltaBytes": 3469080,
"heapUsedBytes": 76500256,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.033,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.1120000000305,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.691,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.607,
"heapDeltaBytes": -6788596,
"heapUsedBytes": 66029572,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.391000000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.8519999999799,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.147999999999996,
"layouts": 18,
"layoutDurationMs": 4.720000000000001,
"taskDurationMs": 815.244,
"heapDeltaBytes": -11472992,
"heapUsedBytes": 61228776,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 106.239,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.7299999999946,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.951,
"layouts": 18,
"layoutDurationMs": 5.804,
"taskDurationMs": 837.9240000000001,
"heapDeltaBytes": 4278700,
"heapUsedBytes": 77156152,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 111.796,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.9249999999724,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.098,
"layouts": 16,
"layoutDurationMs": 15.938000000000004,
"taskDurationMs": 955.8140000000002,
"heapDeltaBytes": -11160516,
"heapUsedBytes": 82389192,
"domNodes": 13751,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 32.126999999999995,
"eventListeners": 2385,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8785.894999999982,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5959.715,
"heapDeltaBytes": -16733684,
"heapUsedBytes": 84918472,
"domNodes": -270,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 2711.6990000000005,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8910.101999999937,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.443000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6095.948,
"heapDeltaBytes": 9240388,
"heapUsedBytes": 84918828,
"domNodes": -270,
"jsHeapTotalBytes": -958464,
"scriptDurationMs": 2728.059,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16864.360000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16383.709000000003,
"heapDeltaBytes": -34542392,
"heapUsedBytes": 176239760,
"domNodes": -6548,
"jsHeapTotalBytes": 3907584,
"scriptDurationMs": 266.88,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17072.468999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16615.979,
"heapDeltaBytes": -33950184,
"heapUsedBytes": 175638368,
"domNodes": -6548,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 286.62699999999995,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20333.13700000002,
"styleRecalcs": 165,
"styleRecalcDurationMs": 16.99099999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19962.681,
"heapDeltaBytes": -38139868,
"heapUsedBytes": 166855280,
"domNodes": -6548,
"jsHeapTotalBytes": 1810432,
"scriptDurationMs": 862.0889999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 45,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20332.51000000007,
"styleRecalcs": 164,
"styleRecalcDurationMs": 17.417000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20035.533,
"heapDeltaBytes": -25989252,
"heapUsedBytes": 176654900,
"domNodes": -6548,
"jsHeapTotalBytes": 237568,
"scriptDurationMs": 858.487,
"eventListeners": -7469,
"totalBlockingTimeMs": 115,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6117.893999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.32500000000003,
"layouts": 20,
"layoutDurationMs": 21.538000000000014,
"taskDurationMs": 5998.513,
"heapDeltaBytes": -22483972,
"heapUsedBytes": 180854648,
"domNodes": -6548,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 109.46099999999998,
"eventListeners": -7473,
"totalBlockingTimeMs": 390,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6156.9749999999885,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.51200000000003,
"layouts": 20,
"layoutDurationMs": 23.568999999999992,
"taskDurationMs": 6040.0419999999995,
"heapDeltaBytes": -31146284,
"heapUsedBytes": 178356444,
"domNodes": -6548,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 108.416,
"eventListeners": -7471,
"totalBlockingTimeMs": 465,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8639.355000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8365.65,
"heapDeltaBytes": 19668992,
"heapUsedBytes": 175684848,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 162.265,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8751.954999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8455.25,
"heapDeltaBytes": 6287824,
"heapUsedBytes": 179965640,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 130.065,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 94.6440000000166,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.783999999999999,
"layouts": 2,
"layoutDurationMs": 1.2200000000000002,
"taskDurationMs": 71.465,
"heapDeltaBytes": 3068348,
"heapUsedBytes": 71553340,
"domNodes": 127,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.220999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 447.73799999995845,
"styleRecalcs": 17,
"styleRecalcDurationMs": 18.659000000000002,
"layouts": 3,
"layoutDurationMs": 1.3680000000000003,
"taskDurationMs": 98.952,
"heapDeltaBytes": 4940776,
"heapUsedBytes": 73829692,
"domNodes": 142,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.886,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16771 +/- ##
==========================================
+ Coverage 81.11% 82.67% +1.56%
==========================================
Files 2458 2040 -418
Lines 126457 118978 -7479
Branches 33692 31868 -1824
==========================================
- Hits 102573 98370 -4203
+ Misses 23369 20428 -2941
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 422 files with indirect coverage changes 🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Type widening checked against every construction site; none left unupdated. Nothing to add.
The exported
AgentRestClienttype now matches the client returned by its factory.getRunModeandputRunMode.Full context for agent readers
This resolves the live API-contract concern from #16432. The prior
Omitexisted only to avoid updating test doubles, leaving the exported client type narrower than the real client. The alias now derives the full factory return type, the route test exercises both methods through that alias, and the affected session double implements the complete contract.Evidence
NODE_OPTIONS="--no-experimental-webstorage" pnpm exec vitest run src/workbench/extensions/agent/services/agent/agentRestClient.test.ts src/workbench/extensions/agent/stores/agent/agentRunModeStore.test.ts src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts→ 3 files, 85 tests passed.pnpm typecheck→ passed.pnpm exec eslint src/workbench/extensions/agent/services/agent/agentRestClient.ts src/workbench/extensions/agent/services/agent/agentRestClient.test.ts src/workbench/extensions/agent/stores/agent/agentRunModeStore.ts src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts→ passed.oxfmt, type-awareoxlint, ESLint, and typecheck → passed at6e045a21e1.