Repository navigation
[backport cloud/1.53] fix(litegraph): avoid delete on pos/widget in SubgraphNode - #16761
Conversation
## Summary Replaces `delete input.pos` and `delete input.widget` with `input.pos = undefined` / `input.widget = undefined` at the two remaining call sites in `SubgraphNode.ts` (unlink cleanup, failed-registration guard). ## Why Follow-up from a review thread on [#16717](#16717 (comment)): > Want to do all 3? — @DrJKL #16717 replaced `delete input.widgetId` with `input.widgetId = undefined` at three call sites, since `delete` has been a source of issues with the compatibility proxies. DrJKL's comment, on the third call site (which also deletes `pos` and `widget` right next to `widgetId`), asked to apply the same treatment to all 3 fields, not just `widgetId`. This PR completes that at both remaining sites that still had `delete input.pos` / `delete input.widget`. Both fields are optional on `INodeInputSlot` (`pos?: Point`, `widget?: IWidgetLocator`, `src/lib/litegraph/src/interfaces.ts`), so assignment is a semantically equivalent, proxy-safe replacement for `delete`. ## Evidence - `NODE_OPTIONS="--no-experimental-webstorage" npx vitest run src/lib/litegraph/src/subgraph/`: 18 files, 323/323 passed. - `npx vue-tsc --noEmit` (full project): clean. - `npx eslint src/lib/litegraph/src/subgraph/SubgraphNode.ts`: 0 errors, 2 pre-existing unrelated warnings (restricted-path imports, present before this change). <!-- authored-by:agent lane-act-fe-16717-followup-2e392d0d -->
🎭 Playwright: ✅ 1887 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-03T12:11:19.150Z",
"gitSha": "cf294c8395aeefbd3c2c1cbfadcac77b96cff728",
"branch": "backport-16742-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.4470000000056,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.366000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.0600000000001,
"heapDeltaBytes": -7762180,
"heapUsedBytes": 62274140,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.427999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2034.985000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.6919999999999,
"heapDeltaBytes": -9480784,
"heapUsedBytes": 60358188,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.071000000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1833.8249999999903,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.324999999999996,
"layouts": 14,
"layoutDurationMs": 4.309,
"taskDurationMs": 861.2040000000001,
"heapDeltaBytes": -6349132,
"heapUsedBytes": 64162548,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 157.39999999999998,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1802.3959999999306,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.291,
"layouts": 14,
"layoutDurationMs": 4.146,
"taskDurationMs": 867.5570000000001,
"heapDeltaBytes": -9179644,
"heapUsedBytes": 61417652,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 157.525,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1715.024000000028,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.627,
"layouts": 6,
"layoutDurationMs": 0.993,
"taskDurationMs": 344.26099999999997,
"heapDeltaBytes": 4402256,
"heapUsedBytes": 74557784,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.48,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.9810000000198,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.316,
"layouts": 6,
"layoutDurationMs": 1.2010000000000003,
"taskDurationMs": 363.437,
"heapDeltaBytes": 4365760,
"heapUsedBytes": 75019648,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.242000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 643.6009999999897,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.295000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.60100000000006,
"heapDeltaBytes": 18154756,
"heapUsedBytes": 87824304,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 166.14900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 647.8869999999688,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.164000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.57699999999994,
"heapDeltaBytes": 18120736,
"heapUsedBytes": 87920644,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 159.999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2027.990999999986,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.255999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.132,
"heapDeltaBytes": -13523076,
"heapUsedBytes": 87166908,
"domNodes": -267,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 31.616000000000007,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.5180000000482,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.459000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.1560000000001,
"heapDeltaBytes": -13587232,
"heapUsedBytes": 86757280,
"domNodes": -271,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 33.569,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2130.0149999999576,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.348,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1549.996,
"heapDeltaBytes": 22123144,
"heapUsedBytes": 88067752,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 777.02,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2253.3240000000205,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.146999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1596.432,
"heapDeltaBytes": 21089948,
"heapUsedBytes": 86577308,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 795.399,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3455.3130000000465,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.424000000000001,
"layouts": 60,
"layoutDurationMs": 11.511000000000003,
"taskDurationMs": 1663.417,
"heapDeltaBytes": 8192124,
"heapUsedBytes": 75272148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 746.37,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3448.207000000025,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.529999999999998,
"layouts": 60,
"layoutDurationMs": 11.578999999999999,
"taskDurationMs": 1643.6419999999998,
"heapDeltaBytes": 8318264,
"heapUsedBytes": 75317184,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 746.5999999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3015.0039999999763,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.597,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1884.786,
"heapDeltaBytes": 16633236,
"heapUsedBytes": 83602724,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 948.225,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3066.1509999999907,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.4399999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1913.777,
"heapDeltaBytes": 19999220,
"heapUsedBytes": 87319768,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 926.3169999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.551000000013,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.54,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.734,
"heapDeltaBytes": 10553564,
"heapUsedBytes": 86765932,
"domNodes": -271,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 33.422999999999995,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1995.394000000033,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.8030000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.814,
"heapDeltaBytes": 21365004,
"heapUsedBytes": 86686392,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.054,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.0839999999903,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.089999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.081,
"heapDeltaBytes": 14907124,
"heapUsedBytes": 87437128,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.926,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.6189999999506,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.36,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.736,
"heapDeltaBytes": 14769984,
"heapUsedBytes": 87571852,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 137.311,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.853000000031,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.283000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.303,
"heapDeltaBytes": -6210384,
"heapUsedBytes": 66315240,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.616999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2017.979999999966,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.975000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.658,
"heapDeltaBytes": 3704020,
"heapUsedBytes": 76388264,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.274000000000001,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.265999999995,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.622,
"layouts": 18,
"layoutDurationMs": 5.948,
"taskDurationMs": 841.044,
"heapDeltaBytes": -12699184,
"heapUsedBytes": 59886064,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 112.99600000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.445000000056,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.423,
"layouts": 18,
"layoutDurationMs": 4.881999999999999,
"taskDurationMs": 833.9630000000001,
"heapDeltaBytes": -12474308,
"heapUsedBytes": 60104060,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 106.64800000000001,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.1460000000552,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.91799999999999,
"layouts": 15,
"layoutDurationMs": 16.384,
"taskDurationMs": 967.8629999999999,
"heapDeltaBytes": 21844228,
"heapUsedBytes": 105751096,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.655,
"eventListeners": 2381,
"totalBlockingTimeMs": 153,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8388.719000000037,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.144999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5724.584,
"heapDeltaBytes": 9523060,
"heapUsedBytes": 84462944,
"domNodes": -265,
"jsHeapTotalBytes": 143360,
"scriptDurationMs": 2589.515,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8631.871000000046,
"styleRecalcs": 247,
"styleRecalcDurationMs": 32.77400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5779.125,
"heapDeltaBytes": 13460240,
"heapUsedBytes": 88949008,
"domNodes": -272,
"jsHeapTotalBytes": 143360,
"scriptDurationMs": 2625.509,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16885.88699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16477.157,
"heapDeltaBytes": -33166588,
"heapUsedBytes": 175393188,
"domNodes": -6577,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 277.884,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16754.132000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16290.171999999999,
"heapDeltaBytes": -34043000,
"heapUsedBytes": 175396428,
"domNodes": -6548,
"jsHeapTotalBytes": 2375680,
"scriptDurationMs": 262.65700000000004,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20765.964999999993,
"styleRecalcs": 167,
"styleRecalcDurationMs": 18.033999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20401.164,
"heapDeltaBytes": -37287636,
"heapUsedBytes": 176081028,
"domNodes": -6548,
"jsHeapTotalBytes": -8409088,
"scriptDurationMs": 886.764,
"eventListeners": -7467,
"totalBlockingTimeMs": 52,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20523.468999999975,
"styleRecalcs": 173,
"styleRecalcDurationMs": 16.74700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20029.442,
"heapDeltaBytes": -43716408,
"heapUsedBytes": 166175180,
"domNodes": -6548,
"jsHeapTotalBytes": -8032256,
"scriptDurationMs": 914.307,
"eventListeners": -7469,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6089.301999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.30900000000001,
"layouts": 20,
"layoutDurationMs": 22.766999999999996,
"taskDurationMs": 5989.971,
"heapDeltaBytes": -24452576,
"heapUsedBytes": 179911152,
"domNodes": -6548,
"jsHeapTotalBytes": 15945728,
"scriptDurationMs": 109.764,
"eventListeners": -7473,
"totalBlockingTimeMs": 432,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6126.574000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.472,
"layouts": 20,
"layoutDurationMs": 23.189,
"taskDurationMs": 5997.518,
"heapDeltaBytes": -37197132,
"heapUsedBytes": 172377904,
"domNodes": -6548,
"jsHeapTotalBytes": 2232320,
"scriptDurationMs": 131.89299999999997,
"eventListeners": -7471,
"totalBlockingTimeMs": 365,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 108.87500000001182,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.649999999999997,
"layouts": 3,
"layoutDurationMs": 1.658,
"taskDurationMs": 81.55099999999999,
"heapDeltaBytes": 3193040,
"heapUsedBytes": 71629260,
"domNodes": 132,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.283000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 110.22000000002663,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.768999999999998,
"layouts": 2,
"layoutDurationMs": 0.5690000000000001,
"taskDurationMs": 73.38100000000001,
"heapDeltaBytes": 3221632,
"heapUsedBytes": 71136580,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.231000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #16761 +/- ##
=============================================
Coverage ? 83.29%
=============================================
Files ? 2023
Lines ? 117015
Branches ? 33036
=============================================
Hits ? 97467
Misses ? 19193
Partials ? 355
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #16742 to
cloud/1.53Automatically created by backport workflow.