Skip to content

[backport cloud/1.53] fix(litegraph): avoid delete on pos/widget in SubgraphNode - #16761

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16742-to-cloud-1.53
Sep 3, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16742-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16742 to cloud/1.53

Automatically created by backport workflow.

## Summary

Replaces `delete input.pos` and `delete input.widget` with `input.pos =
undefined` / `input.widget = undefined` at the two remaining call sites
in `SubgraphNode.ts` (unlink cleanup, failed-registration guard).

## Why

Follow-up from a review thread on
[#16717](#16717 (comment)):

> Want to do all 3? — @DrJKL

#16717 replaced `delete input.widgetId` with `input.widgetId =
undefined` at three call sites, since `delete` has been a source of
issues with the compatibility proxies. DrJKL's comment, on the third
call site (which also deletes `pos` and `widget` right next to
`widgetId`), asked to apply the same treatment to all 3 fields, not just
`widgetId`. This PR completes that at both remaining sites that still
had `delete input.pos` / `delete input.widget`.

Both fields are optional on `INodeInputSlot` (`pos?: Point`, `widget?:
IWidgetLocator`, `src/lib/litegraph/src/interfaces.ts`), so assignment
is a semantically equivalent, proxy-safe replacement for `delete`.

## Evidence

- `NODE_OPTIONS="--no-experimental-webstorage" npx vitest run
src/lib/litegraph/src/subgraph/`: 18 files, 323/323 passed.
- `npx vue-tsc --noEmit` (full project): clean.
- `npx eslint src/lib/litegraph/src/subgraph/SubgraphNode.ts`: 0 errors,
2 pre-existing unrelated warnings (restricted-path imports, present
before this change).

<!-- authored-by:agent lane-act-fe-16717-followup-2e392d0d -->
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 3, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 3, 2026 11:57
@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1887 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1866 / ❌ 0 / ⚠️ 3 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 11:59:56 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 153ms TBT · 100.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
vue-large-graph-idle: · 57.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.3 MB heap
vue-large-graph-pan: · 54.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 64ms TBT · 163.2 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 399ms TBT · 168.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 543ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 58.5 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 36ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 864ms
canvas-mouse-sweep: script duration 157ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.9 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -156
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 354ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 453ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.8 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 593ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.9 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1573ms
large-graph-pan: script duration 786ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.3 MB
large-graph-pan: DOM nodes 3
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 9ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1654ms
large-graph-zoom: script duration 746ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.8 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1899ms
legacy-node-drag: script duration 937ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.5 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 566ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.7 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -91
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 402ms
subgraph-dom-widget-clipping: script duration 139ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.5 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 492ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.0 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -215
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 838ms
subgraph-mouse-sweep: script duration 110ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.2 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -200
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 968ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 153ms
subgraph-transition-enter: heap used 100.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5752ms
viewport-pan-sweep: script duration 2608ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.7 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -168
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16384ms
vue-large-graph-idle: script duration 270ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.3 MB
vue-large-graph-idle: DOM nodes -6563
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 170
vue-large-graph-pan: task duration 20215ms
vue-large-graph-pan: script duration 901ms
vue-large-graph-pan: TBT 64ms
vue-large-graph-pan: heap used 163.2 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5994ms
vue-node-resize-workload: script duration 121ms
vue-node-resize-workload: TBT 399ms
vue-node-resize-workload: heap used 168.0 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7472
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 8
workflow-execution: task duration 77ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.1 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 37
Raw data
{
  "timestamp": "2026-09-03T12:11:19.150Z",
  "gitSha": "cf294c8395aeefbd3c2c1cbfadcac77b96cff728",
  "branch": "backport-16742-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2053.4470000000056,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.366000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 577.0600000000001,
      "heapDeltaBytes": -7762180,
      "heapUsedBytes": 62274140,
      "domNodes": -278,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 9.427999999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2034.985000000006,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.6919999999999,
      "heapDeltaBytes": -9480784,
      "heapUsedBytes": 60358188,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.071000000000003,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1833.8249999999903,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 36.324999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.309,
      "taskDurationMs": 861.2040000000001,
      "heapDeltaBytes": -6349132,
      "heapUsedBytes": 64162548,
      "domNodes": -279,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 157.39999999999998,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1802.3959999999306,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 36.291,
      "layouts": 14,
      "layoutDurationMs": 4.146,
      "taskDurationMs": 867.5570000000001,
      "heapDeltaBytes": -9179644,
      "heapUsedBytes": 61417652,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 157.525,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1715.024000000028,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.627,
      "layouts": 6,
      "layoutDurationMs": 0.993,
      "taskDurationMs": 344.26099999999997,
      "heapDeltaBytes": 4402256,
      "heapUsedBytes": 74557784,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.48,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.9810000000198,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.316,
      "layouts": 6,
      "layoutDurationMs": 1.2010000000000003,
      "taskDurationMs": 363.437,
      "heapDeltaBytes": 4365760,
      "heapUsedBytes": 75019648,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.242000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 643.6009999999897,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.295000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.60100000000006,
      "heapDeltaBytes": 18154756,
      "heapUsedBytes": 87824304,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 166.14900000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 647.8869999999688,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.164000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.57699999999994,
      "heapDeltaBytes": 18120736,
      "heapUsedBytes": 87920644,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 159.999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.990999999986,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.255999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 594.132,
      "heapDeltaBytes": -13523076,
      "heapUsedBytes": 87166908,
      "domNodes": -267,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 31.616000000000007,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2034.5180000000482,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.459000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 591.1560000000001,
      "heapDeltaBytes": -13587232,
      "heapUsedBytes": 86757280,
      "domNodes": -271,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 33.569,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2130.0149999999576,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.348,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1549.996,
      "heapDeltaBytes": 22123144,
      "heapUsedBytes": 88067752,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 777.02,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2253.3240000000205,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.146999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1596.432,
      "heapDeltaBytes": 21089948,
      "heapUsedBytes": 86577308,
      "domNodes": 4,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 795.399,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3455.3130000000465,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.424000000000001,
      "layouts": 60,
      "layoutDurationMs": 11.511000000000003,
      "taskDurationMs": 1663.417,
      "heapDeltaBytes": 8192124,
      "heapUsedBytes": 75272148,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 746.37,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3448.207000000025,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.529999999999998,
      "layouts": 60,
      "layoutDurationMs": 11.578999999999999,
      "taskDurationMs": 1643.6419999999998,
      "heapDeltaBytes": 8318264,
      "heapUsedBytes": 75317184,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 746.5999999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3015.0039999999763,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.597,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1884.786,
      "heapDeltaBytes": 16633236,
      "heapUsedBytes": 83602724,
      "domNodes": 0,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 948.225,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3066.1509999999907,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.4399999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1913.777,
      "heapDeltaBytes": 19999220,
      "heapUsedBytes": 87319768,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 926.3169999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2056.551000000013,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.54,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.734,
      "heapDeltaBytes": 10553564,
      "heapUsedBytes": 86765932,
      "domNodes": -271,
      "jsHeapTotalBytes": -1916928,
      "scriptDurationMs": 33.422999999999995,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 1995.394000000033,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.8030000000000026,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 532.814,
      "heapDeltaBytes": 21365004,
      "heapUsedBytes": 86686392,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.054,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.0839999999903,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.089999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.081,
      "heapDeltaBytes": 14907124,
      "heapUsedBytes": 87437128,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 139.926,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 561.6189999999506,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.36,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.736,
      "heapDeltaBytes": 14769984,
      "heapUsedBytes": 87571852,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 137.311,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.853000000031,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.283000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.303,
      "heapDeltaBytes": -6210384,
      "heapUsedBytes": 66315240,
      "domNodes": -297,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.616999999999999,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.979999999966,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.975000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.658,
      "heapDeltaBytes": 3704020,
      "heapUsedBytes": 76388264,
      "domNodes": -297,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.274000000000001,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1717.265999999995,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.622,
      "layouts": 18,
      "layoutDurationMs": 5.948,
      "taskDurationMs": 841.044,
      "heapDeltaBytes": -12699184,
      "heapUsedBytes": 59886064,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 112.99600000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1753.445000000056,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 36.423,
      "layouts": 18,
      "layoutDurationMs": 4.881999999999999,
      "taskDurationMs": 833.9630000000001,
      "heapDeltaBytes": -12474308,
      "heapUsedBytes": 60104060,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 106.64800000000001,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1434.1460000000552,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.91799999999999,
      "layouts": 15,
      "layoutDurationMs": 16.384,
      "taskDurationMs": 967.8629999999999,
      "heapDeltaBytes": 21844228,
      "heapUsedBytes": 105751096,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 31.655,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 153,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8388.719000000037,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 36.144999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5724.584,
      "heapDeltaBytes": 9523060,
      "heapUsedBytes": 84462944,
      "domNodes": -265,
      "jsHeapTotalBytes": 143360,
      "scriptDurationMs": 2589.515,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8631.871000000046,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 32.77400000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5779.125,
      "heapDeltaBytes": 13460240,
      "heapUsedBytes": 88949008,
      "domNodes": -272,
      "jsHeapTotalBytes": 143360,
      "scriptDurationMs": 2625.509,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16885.88699999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16477.157,
      "heapDeltaBytes": -33166588,
      "heapUsedBytes": 175393188,
      "domNodes": -6577,
      "jsHeapTotalBytes": -4067328,
      "scriptDurationMs": 277.884,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16754.132000000027,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16290.171999999999,
      "heapDeltaBytes": -34043000,
      "heapUsedBytes": 175396428,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2375680,
      "scriptDurationMs": 262.65700000000004,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20765.964999999993,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 18.033999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20401.164,
      "heapDeltaBytes": -37287636,
      "heapUsedBytes": 176081028,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8409088,
      "scriptDurationMs": 886.764,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 52,
      "frameDurationMs": 18.886666666666617,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20523.468999999975,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 16.74700000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20029.442,
      "heapDeltaBytes": -43716408,
      "heapUsedBytes": 166175180,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8032256,
      "scriptDurationMs": 914.307,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 76,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6089.301999999975,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.30900000000001,
      "layouts": 20,
      "layoutDurationMs": 22.766999999999996,
      "taskDurationMs": 5989.971,
      "heapDeltaBytes": -24452576,
      "heapUsedBytes": 179911152,
      "domNodes": -6548,
      "jsHeapTotalBytes": 15945728,
      "scriptDurationMs": 109.764,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 432,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6126.574000000005,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.472,
      "layouts": 20,
      "layoutDurationMs": 23.189,
      "taskDurationMs": 5997.518,
      "heapDeltaBytes": -37197132,
      "heapUsedBytes": 172377904,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2232320,
      "scriptDurationMs": 131.89299999999997,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 365,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 108.87500000001182,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.649999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.658,
      "taskDurationMs": 81.55099999999999,
      "heapDeltaBytes": 3193040,
      "heapUsedBytes": 71629260,
      "domNodes": 132,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.283000000000001,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 110.22000000002663,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 14.768999999999998,
      "layouts": 2,
      "layoutDurationMs": 0.5690000000000001,
      "taskDurationMs": 73.38100000000001,
      "heapDeltaBytes": 3221632,
      "heapUsedBytes": 71136580,
      "domNodes": 111,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.231000000000001,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48003 70518 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions
github-actions Bot requested a review from DrJKL September 3, 2026 11:58
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #16761   +/-   ##
=============================================
  Coverage              ?   83.29%           
=============================================
  Files                 ?     2023           
  Lines                 ?   117015           
  Branches              ?    33036           
=============================================
  Hits                  ?    97467           
  Misses                ?    19193           
  Partials              ?      355           
Flag Coverage Δ
e2e 66.58% <50.00%> (?)
unit 76.55% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/subgraph/SubgraphNode.ts 89.85% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit bdecfa1 into cloud/1.53 Sep 3, 2026
108 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16742-to-cloud-1.53 branch September 3, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants