Repository navigation
[backport core/1.53] fix(litegraph): avoid delete on pos/widget in SubgraphNode - #16760
Conversation
## Summary Replaces `delete input.pos` and `delete input.widget` with `input.pos = undefined` / `input.widget = undefined` at the two remaining call sites in `SubgraphNode.ts` (unlink cleanup, failed-registration guard). ## Why Follow-up from a review thread on [#16717](#16717 (comment)): > Want to do all 3? — @DrJKL #16717 replaced `delete input.widgetId` with `input.widgetId = undefined` at three call sites, since `delete` has been a source of issues with the compatibility proxies. DrJKL's comment, on the third call site (which also deletes `pos` and `widget` right next to `widgetId`), asked to apply the same treatment to all 3 fields, not just `widgetId`. This PR completes that at both remaining sites that still had `delete input.pos` / `delete input.widget`. Both fields are optional on `INodeInputSlot` (`pos?: Point`, `widget?: IWidgetLocator`, `src/lib/litegraph/src/interfaces.ts`), so assignment is a semantically equivalent, proxy-safe replacement for `delete`. ## Evidence - `NODE_OPTIONS="--no-experimental-webstorage" npx vitest run src/lib/litegraph/src/subgraph/`: 18 files, 323/323 passed. - `npx vue-tsc --noEmit` (full project): clean. - `npx eslint src/lib/litegraph/src/subgraph/SubgraphNode.ts`: 0 errors, 2 pre-existing unrelated warnings (restricted-path imports, present before this change). <!-- authored-by:agent lane-act-fe-16717-followup-2e392d0d -->
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T12:12:35.458Z",
"gitSha": "b9cdf8c493161abf1dcb58f7caf1b87f92e5de2d",
"branch": "backport-16742-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2132.2999999999865,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.630999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.4920000000001,
"heapDeltaBytes": -13153336,
"heapUsedBytes": 56503876,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 12.298999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2028.2250000000204,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.998999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.7109999999999,
"heapDeltaBytes": -8647156,
"heapUsedBytes": 61552344,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.294,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1991.533000000004,
"styleRecalcs": 82,
"styleRecalcDurationMs": 48.88999999999999,
"layouts": 14,
"layoutDurationMs": 6.016,
"taskDurationMs": 983.814,
"heapDeltaBytes": -8957292,
"heapUsedBytes": 61341548,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 155.60000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1900.7419999999229,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.326,
"layouts": 14,
"layoutDurationMs": 5.301,
"taskDurationMs": 918.885,
"heapDeltaBytes": -7102548,
"heapUsedBytes": 63230164,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 144.74900000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.0219999999772,
"styleRecalcs": 32,
"styleRecalcDurationMs": 21.651000000000003,
"layouts": 6,
"layoutDurationMs": 1.6470000000000002,
"taskDurationMs": 429.558,
"heapDeltaBytes": 4367072,
"heapUsedBytes": 74075372,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.190000000000001,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1673.0870000000095,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.739999999999995,
"layouts": 6,
"layoutDurationMs": 1.3510000000000002,
"taskDurationMs": 400.539,
"heapDeltaBytes": 4402904,
"heapUsedBytes": 74934564,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.925999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 768.8989999999762,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.195,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.55799999999994,
"heapDeltaBytes": -7753504,
"heapUsedBytes": 62749716,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 164.667,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 695.8309999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.839999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.771,
"heapDeltaBytes": -7803440,
"heapUsedBytes": 62762616,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.875,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2077.0409999999515,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.627,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.8679999999999,
"heapDeltaBytes": -14061896,
"heapUsedBytes": 86806200,
"domNodes": -270,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 49.767999999999994,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.2439999999442,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.4880000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.4770000000001,
"heapDeltaBytes": -13924532,
"heapUsedBytes": 86852864,
"domNodes": -276,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 39.919999999999995,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3136.9280000000117,
"styleRecalcs": 65,
"styleRecalcDurationMs": 19.835,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1901.5230000000001,
"heapDeltaBytes": 26741916,
"heapUsedBytes": 92382384,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 892.528,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3073.309999999992,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.113999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1789.8529999999998,
"heapDeltaBytes": 27885244,
"heapUsedBytes": 93226076,
"domNodes": -277,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 842.028,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4056.8080000000464,
"styleRecalcs": 60,
"styleRecalcDurationMs": 16.432000000000002,
"layouts": 60,
"layoutDurationMs": 19.073,
"taskDurationMs": 1944.693,
"heapDeltaBytes": 10208528,
"heapUsedBytes": 76551792,
"domNodes": -280,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 846.478,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4001.205000000027,
"styleRecalcs": 60,
"styleRecalcDurationMs": 15.387999999999998,
"layouts": 60,
"layoutDurationMs": 18.406,
"taskDurationMs": 1845.417,
"heapDeltaBytes": 7713988,
"heapUsedBytes": 75350480,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 798.986,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3602.7709999999615,
"styleRecalcs": 40,
"styleRecalcDurationMs": 8.498000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2333.4349999999995,
"heapDeltaBytes": 1162972,
"heapUsedBytes": 68717984,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 1125.736,
"eventListeners": 190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3269.2429999999604,
"styleRecalcs": 40,
"styleRecalcDurationMs": 8.26,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2121.217,
"heapDeltaBytes": 25131776,
"heapUsedBytes": 92461756,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1019.2759999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1998.659000000032,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6589999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.313,
"heapDeltaBytes": 21771604,
"heapUsedBytes": 87527848,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 41.836,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.6550000000661,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.2140000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.6620000000001,
"heapDeltaBytes": 21817624,
"heapUsedBytes": 87016160,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 44.602000000000004,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 705.8959999999956,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.717999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.2180000000001,
"heapDeltaBytes": 14803700,
"heapUsedBytes": 87385100,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.599,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 690.0020000000495,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.661999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.288,
"heapDeltaBytes": 14871388,
"heapUsedBytes": 87505968,
"domNodes": 12,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 148.019,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.1920000000182,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.372,
"heapDeltaBytes": 1654380,
"heapUsedBytes": 74318844,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.555,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.3860000000732,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.228000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.988,
"heapDeltaBytes": 2885680,
"heapUsedBytes": 75597904,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.089999999999998,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1856.585999999993,
"styleRecalcs": 77,
"styleRecalcDurationMs": 47.114000000000004,
"layouts": 18,
"layoutDurationMs": 7.590000000000001,
"taskDurationMs": 987.589,
"heapDeltaBytes": -12919652,
"heapUsedBytes": 59833384,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 119.91,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.2899999999872,
"styleRecalcs": 77,
"styleRecalcDurationMs": 43.25,
"layouts": 18,
"layoutDurationMs": 7.151,
"taskDurationMs": 924.977,
"heapDeltaBytes": -13179956,
"heapUsedBytes": 59543976,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 115.542,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.1110000000008,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.337,
"layouts": 14,
"layoutDurationMs": 14.072000000000001,
"taskDurationMs": 940.183,
"heapDeltaBytes": 21030196,
"heapUsedBytes": 109489736,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 36.647,
"eventListeners": 2381,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10640.998000000025,
"styleRecalcs": 245,
"styleRecalcDurationMs": 55.38999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6371.435,
"heapDeltaBytes": 5047468,
"heapUsedBytes": 80083864,
"domNodes": -277,
"jsHeapTotalBytes": -413696,
"scriptDurationMs": 2826.39,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 10295.306000000095,
"styleRecalcs": 247,
"styleRecalcDurationMs": 54.57299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6212.125999999999,
"heapDeltaBytes": -7938436,
"heapUsedBytes": 92480448,
"domNodes": -271,
"jsHeapTotalBytes": -901120,
"scriptDurationMs": 2790.306,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17242.578999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16953.635,
"heapDeltaBytes": -55039316,
"heapUsedBytes": 160417856,
"domNodes": -6548,
"jsHeapTotalBytes": 729088,
"scriptDurationMs": 364.217,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17186.316000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16866.921,
"heapDeltaBytes": -47994336,
"heapUsedBytes": 161536496,
"domNodes": -6548,
"jsHeapTotalBytes": -7241728,
"scriptDurationMs": 360.267,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22133.973999999966,
"styleRecalcs": 164,
"styleRecalcDurationMs": 32.43499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22016.412000000004,
"heapDeltaBytes": -27106800,
"heapUsedBytes": 175951388,
"domNodes": -6548,
"jsHeapTotalBytes": 1830912,
"scriptDurationMs": 1162.511,
"eventListeners": -7467,
"totalBlockingTimeMs": 139,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22427.515999999967,
"styleRecalcs": 167,
"styleRecalcDurationMs": 33.447,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22251.456000000002,
"heapDeltaBytes": -12640000,
"heapUsedBytes": 190107132,
"domNodes": -6548,
"jsHeapTotalBytes": -3715072,
"scriptDurationMs": 1166.5810000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 65,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6447.001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.901,
"layouts": 20,
"layoutDurationMs": 34.452999999999996,
"taskDurationMs": 6386.567,
"heapDeltaBytes": -25315380,
"heapUsedBytes": 175689184,
"domNodes": -6578,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 145.82,
"eventListeners": -7491,
"totalBlockingTimeMs": 402,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6428.576999999905,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.15300000000003,
"layouts": 20,
"layoutDurationMs": 35.82099999999999,
"taskDurationMs": 6335.154,
"heapDeltaBytes": -25026700,
"heapUsedBytes": 178516868,
"domNodes": -6548,
"jsHeapTotalBytes": 3805184,
"scriptDurationMs": 192.06099999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 546,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 986.9029999999839,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.551999999999996,
"layouts": 3,
"layoutDurationMs": 1.272,
"taskDurationMs": 131.698,
"heapDeltaBytes": 5796796,
"heapUsedBytes": 74502288,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.725000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 518.6979999999721,
"styleRecalcs": 12,
"styleRecalcDurationMs": 25.351,
"layouts": 3,
"layoutDurationMs": 1.2329999999999999,
"taskDurationMs": 126.54400000000001,
"heapDeltaBytes": 5050724,
"heapUsedBytes": 73735780,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.485999999999997,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.53 #16760 +/- ##
===========================================
Coverage 83.29% 83.30%
===========================================
Files 2023 2023
Lines 117016 117034 +18
Branches 32452 33044 +592
===========================================
+ Hits 97467 97491 +24
- Misses 19193 19195 +2
+ Partials 356 348 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #16742 to
core/1.53Automatically created by backport workflow.