Repository navigation
[backport cloud/1.53] test: land review follow-ups and current main for #16381 - #16752
Conversation
*PR Created by the Glary-Bot Agent* --- ## Summary Brings #16381 up to date with `main` (14 commits behind), lands the two test simplifications still outstanding from @DrJKL's review, and fixes a save-path regression the branch was carrying. Supersedes #16441 — its two changes are included here verbatim. ## Changes - **What**: - Merge current `main` into the branch. No textual conflicts; the merge was verified against `main`'s widget refactors (#16214, #16428, #16454). - `LLink.spreadCopy.test.ts` / `widgetValueStore.test.ts`: apply #16441 exactly — fold the redundant store-mutation spread test into the single topology test, and drop the registration case that codified an empty-name `WidgetId` (`isWidgetId` rejects it; re-registration is already covered at four other sites in the same file). - `LGraph.ts`: the live-node mismatch guard added by this branch compared stored state against `_nodes.length`. A node held twice in `_nodes` took the fallback and wrote **its id twice into the saved workflow** — `main` serialises it once. Compare against the count of distinct live ids and serialise identity-deduplicated live nodes. - `LGraph.serialise.test.ts`: two regressions — one pinning the store path for a benign duplicate (no fallback, no diagnostic), one forcing the fallback with an unregistered orphan so the dedup itself is exercised. Both fail without the fix. - `litegraphUtil.test.ts`: the widget-identity regressions asserted identity with `toEqual`, so a clone would have passed; `expect(node.widgets).toEqual([first, frozen])` compared the array to its own contents and could not fail. Now `toBe` per entry, with names asserted explicitly. - `LGraph.serialise.test.ts`: give the adapter-only fixture a real node id instead of pinning the diagnostic on `-1`, which `add()` can never produce. - **Breaking**: none. ## Review Focus `LGraph.ts` is the only behaviour change here. Verified against `main`: | `_nodes` | stored | `main` | #16381 head | this branch | | --- | --- | --- | --- | --- | | `[n, n]` | `{n}` | `[n]` | `[n, n]` — corrupt | `[n]`, no diagnostic | | `[n]` after double-add + remove | `{}` | `[]` — silent data loss | `[n]` | `[n]` | The branch's new guard genuinely fixes the second row, so it should stay — only the fallback needed deduplicating. Two reviewer notes left as-is, deliberately: - The third arm of the diagnostic string (`N stored nodes do not match M live nodes`) is now unreachable, since the guard and the arms use the same key sets. It is error-message text on an error path, so removing it would mean either a non-null assertion or `undefined` in a log line. - `mapLiveWidgetsById`'s synthetic `name#N` ids are not registered in `widgetValueStore`, so no consumer can observe them. That non-registration is intentional (a read helper must not mutate the store), but the JSDoc still describes the pre-#16381 contract. Separately: #16381 is titled `test:` but ships runtime changes to `LGraph.ts` and `litegraphUtil.ts`. Both sit on error paths with no healthy-path difference, but the title is worth updating so reviewers know the serialisation path is in play. ## Verification - `pnpm typecheck`, `pnpm lint` (0 errors), `pnpm format:check`, `pnpm knip`, `pnpm build` — all clean. - Full `pnpm test:unit`: 1440/1443 files pass. The failures (`AgentPanelRoot`, `GettingStartedScreen`, `agentPanel`, `presetService`, `useWorkspaceAuth`, `useFirstRunTourController`) reproduce identically on `origin/main` in this sandbox and are unrelated to these files. - The 7 test files this PR touches: 196 tests, all pass. - Manual: ComfyUI backend + dev server, default workflow loaded in Chromium. 10 nodes serialise with unique ids and no `Cannot serialize graph …` diagnostic; save → reload → re-serialise is byte-identical; a prompt edit made in the UI reaches both the workflow JSON and `graphToPrompt`; all 20 live widgets map 1:1 through `mapLiveWidgetsById` and resolve back to themselves via `getWidgetIdForNode`. ## Screenshots Default workflow loaded against a live backend, and the same graph after editing the positive prompt through the UI. ## Screenshots   --------- Co-authored-by: Pipeline Agent <agent@pipeline.local> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-03T16:38:28.971Z",
"gitSha": "cec6a85849fccd69076a404b8ef9e3a74bd1bb32",
"branch": "backport-16475-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2051.3649999999757,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.726999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.634,
"heapDeltaBytes": -3207436,
"heapUsedBytes": 65395768,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 13.471000000000004,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2064.5090000000437,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.270999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.7049999999999,
"heapDeltaBytes": -10381820,
"heapUsedBytes": 60044652,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.06,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.6290000000095,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.112,
"layouts": 14,
"layoutDurationMs": 4.907,
"taskDurationMs": 969.715,
"heapDeltaBytes": 5244624,
"heapUsedBytes": 75581680,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 150.725,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1873.7330000000156,
"styleRecalcs": 72,
"styleRecalcDurationMs": 36.267999999999994,
"layouts": 14,
"layoutDurationMs": 4.331,
"taskDurationMs": 930.2470000000001,
"heapDeltaBytes": -7048364,
"heapUsedBytes": 63405916,
"domNodes": -285,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 143.333,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0060000000076,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.857,
"layouts": 6,
"layoutDurationMs": 1.247,
"taskDurationMs": 415.786,
"heapDeltaBytes": 4454196,
"heapUsedBytes": 74259548,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.316999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.6019999999762,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.071,
"layouts": 6,
"layoutDurationMs": 1.3670000000000002,
"taskDurationMs": 411.299,
"heapDeltaBytes": 4361304,
"heapUsedBytes": 74920912,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.663000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 854.4650000000047,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.7920000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.1999999999999,
"heapDeltaBytes": 17828240,
"heapUsedBytes": 88091608,
"domNodes": 8,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 187.21400000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 683.1879999999728,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.595000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.46900000000005,
"heapDeltaBytes": 18425048,
"heapUsedBytes": 88083144,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 159.64600000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.6279999999792,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.772000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 692.0999999999999,
"heapDeltaBytes": -13386092,
"heapUsedBytes": 87252692,
"domNodes": -270,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 38.25799999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2006.907999999953,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.860000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.7369999999999,
"heapDeltaBytes": 21870748,
"heapUsedBytes": 86840788,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.843,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2817.3300000000268,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.055000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1784.1809999999998,
"heapDeltaBytes": 26815672,
"heapUsedBytes": 92092396,
"domNodes": -274,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 831.427,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2489.4689999999855,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1722.8600000000004,
"heapDeltaBytes": 21995496,
"heapUsedBytes": 87333388,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 802.087,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3812.142999999992,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.358000000000002,
"layouts": 60,
"layoutDurationMs": 13.236999999999998,
"taskDurationMs": 1794.894,
"heapDeltaBytes": 9865336,
"heapUsedBytes": 75869804,
"domNodes": -280,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 769.8280000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3869.507999999996,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.583000000000002,
"layouts": 60,
"layoutDurationMs": 13.121,
"taskDurationMs": 1818.057,
"heapDeltaBytes": 8471308,
"heapUsedBytes": 76064968,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.775,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3104.282000000012,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.027999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1984.9769999999999,
"heapDeltaBytes": 25289368,
"heapUsedBytes": 92606052,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 942.626,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3126.651000000038,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.166999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1993.62,
"heapDeltaBytes": 21937628,
"heapUsedBytes": 89661612,
"domNodes": -11,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 941.8340000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.8620000000083,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.218,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.425,
"heapDeltaBytes": 11127904,
"heapUsedBytes": 86898640,
"domNodes": -268,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 37.382,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.368000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.748,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.6240000000001,
"heapDeltaBytes": 21852548,
"heapUsedBytes": 87029872,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 41.044,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 635.9090000000265,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.612,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.08199999999994,
"heapDeltaBytes": 14775748,
"heapUsedBytes": 87404076,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.90399999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.0350000000308,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.424000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.441,
"heapDeltaBytes": 14854108,
"heapUsedBytes": 87399628,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 140.564,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.3159999999853,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.692999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.132,
"heapDeltaBytes": 2135600,
"heapUsedBytes": 73694772,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.617999999999999,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.6239999999934,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.905999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.106,
"heapDeltaBytes": -7589736,
"heapUsedBytes": 65068504,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.810000000000002,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.271999999994,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.925,
"layouts": 18,
"layoutDurationMs": 5.118,
"taskDurationMs": 908.076,
"heapDeltaBytes": -12685840,
"heapUsedBytes": 59837488,
"domNodes": -298,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 106.06500000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.844000000001,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.726,
"layouts": 18,
"layoutDurationMs": 6.236000000000001,
"taskDurationMs": 958.34,
"heapDeltaBytes": 2308916,
"heapUsedBytes": 75089924,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 111.15400000000001,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1450.5869999999277,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.88199999999999,
"layouts": 14,
"layoutDurationMs": 14.135000000000002,
"taskDurationMs": 986.3520000000001,
"heapDeltaBytes": 21865228,
"heapUsedBytes": 104775180,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.148,
"eventListeners": 2383,
"totalBlockingTimeMs": 131,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8731.965000000002,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6245.046,
"heapDeltaBytes": -8799872,
"heapUsedBytes": 91977220,
"domNodes": -270,
"jsHeapTotalBytes": -81920,
"scriptDurationMs": 2789.9159999999997,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9406.555000000026,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6322.616,
"heapDeltaBytes": -11812604,
"heapUsedBytes": 88944160,
"domNodes": -270,
"jsHeapTotalBytes": -1163264,
"scriptDurationMs": 2696.001,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15776.265000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15176.029,
"heapDeltaBytes": -30188740,
"heapUsedBytes": 176948616,
"domNodes": -6548,
"jsHeapTotalBytes": -6311936,
"scriptDurationMs": 261.1,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15625.238999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15093.654999999999,
"heapDeltaBytes": -19410488,
"heapUsedBytes": 168797812,
"domNodes": -6548,
"jsHeapTotalBytes": 3133440,
"scriptDurationMs": 251.25200000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 18681.132999999987,
"styleRecalcs": 135,
"styleRecalcDurationMs": 17.607999999999958,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18485.941,
"heapDeltaBytes": -40110828,
"heapUsedBytes": 162616496,
"domNodes": -6548,
"jsHeapTotalBytes": 2646016,
"scriptDurationMs": 874.158,
"eventListeners": -7471,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18810.951000000045,
"styleRecalcs": 135,
"styleRecalcDurationMs": 17.714999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18496.074999999997,
"heapDeltaBytes": -33485796,
"heapUsedBytes": 176155516,
"domNodes": -6548,
"jsHeapTotalBytes": -4845568,
"scriptDurationMs": 862.24,
"eventListeners": -7469,
"totalBlockingTimeMs": 32,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5644.329000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.83600000000001,
"layouts": 20,
"layoutDurationMs": 25.610999999999994,
"taskDurationMs": 5583.827,
"heapDeltaBytes": -22014896,
"heapUsedBytes": 180261504,
"domNodes": -6548,
"jsHeapTotalBytes": 17035264,
"scriptDurationMs": 102.96100000000001,
"eventListeners": -7472,
"totalBlockingTimeMs": 275,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5536.298999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.12799999999997,
"layouts": 20,
"layoutDurationMs": 23.790000000000006,
"taskDurationMs": 5474.488,
"heapDeltaBytes": -25046148,
"heapUsedBytes": 181264504,
"domNodes": -6548,
"jsHeapTotalBytes": 17395712,
"scriptDurationMs": 99.20799999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 294,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 117.99400000006699,
"styleRecalcs": 6,
"styleRecalcDurationMs": 15.421,
"layouts": 2,
"layoutDurationMs": 1.4390000000000003,
"taskDurationMs": 88.86800000000001,
"heapDeltaBytes": 3146820,
"heapUsedBytes": 70735768,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.168000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 109.16799999995419,
"styleRecalcs": 6,
"styleRecalcDurationMs": 18.495,
"layouts": 2,
"layoutDurationMs": 1.1940000000000002,
"taskDurationMs": 84.77299999999998,
"heapDeltaBytes": 3122688,
"heapUsedBytes": 70794516,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.613999999999998,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.53 #16752 +/- ##
=============================================
Coverage ? 83.29%
=============================================
Files ? 2023
Lines ? 117035
Branches ? 32458
=============================================
Hits ? 97490
Misses ? 19188
Partials ? 357
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve after CI is green
I compared this backport of #16475 with merged source commit 26eba65. The normalized nine-file deltas are identical; ordinary patch differences are release-branch context only. pnpm typecheck, scoped ESLint with 0 errors, scoped oxfmt, and 213 targeted tests passed. One hosted Playwright shard fails in the unchanged viewport-tab test at browser_tests/tests/interaction.spec.ts:1072; the core twin with the identical patch passed that shard. I found no backport defect, but I am leaving a comment rather than approving while hosted CI is red.
Backport of #16475 to
cloud/1.53Automatically created by backport workflow.