Skip to content

[backport cloud/1.53] test: land review follow-ups and current main for #16381 - #16752

Merged
comfy-pr-bot merged 2 commits into
cloud/1.53from
backport-16475-to-cloud-1.53
Sep 3, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.53from
backport-16475-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16475 to cloud/1.53

Automatically created by backport workflow.

*PR Created by the Glary-Bot Agent*

---

## Summary

Brings #16381 up to date with `main` (14 commits behind), lands the two
test simplifications still outstanding from @DrJKL's review, and fixes a
save-path regression the branch was carrying.

Supersedes #16441 — its two changes are included here verbatim.

## Changes

- **What**:
- Merge current `main` into the branch. No textual conflicts; the merge
was verified against `main`'s widget refactors (#16214, #16428, #16454).
- `LLink.spreadCopy.test.ts` / `widgetValueStore.test.ts`: apply #16441
exactly — fold the redundant store-mutation spread test into the single
topology test, and drop the registration case that codified an
empty-name `WidgetId` (`isWidgetId` rejects it; re-registration is
already covered at four other sites in the same file).
- `LGraph.ts`: the live-node mismatch guard added by this branch
compared stored state against `_nodes.length`. A node held twice in
`_nodes` took the fallback and wrote **its id twice into the saved
workflow** — `main` serialises it once. Compare against the count of
distinct live ids and serialise identity-deduplicated live nodes.
- `LGraph.serialise.test.ts`: two regressions — one pinning the store
path for a benign duplicate (no fallback, no diagnostic), one forcing
the fallback with an unregistered orphan so the dedup itself is
exercised. Both fail without the fix.
- `litegraphUtil.test.ts`: the widget-identity regressions asserted
identity with `toEqual`, so a clone would have passed;
`expect(node.widgets).toEqual([first, frozen])` compared the array to
its own contents and could not fail. Now `toBe` per entry, with names
asserted explicitly.
- `LGraph.serialise.test.ts`: give the adapter-only fixture a real node
id instead of pinning the diagnostic on `-1`, which `add()` can never
produce.
- **Breaking**: none.

## Review Focus

`LGraph.ts` is the only behaviour change here. Verified against `main`:

| `_nodes` | stored | `main` | #16381 head | this branch |
| --- | --- | --- | --- | --- |
| `[n, n]` | `{n}` | `[n]` | `[n, n]` — corrupt | `[n]`, no diagnostic |
| `[n]` after double-add + remove | `{}` | `[]` — silent data loss |
`[n]` | `[n]` |

The branch's new guard genuinely fixes the second row, so it should stay
— only the fallback needed deduplicating.

Two reviewer notes left as-is, deliberately:

- The third arm of the diagnostic string (`N stored nodes do not match M
live nodes`) is now unreachable, since the guard and the arms use the
same key sets. It is error-message text on an error path, so removing it
would mean either a non-null assertion or `undefined` in a log line.
- `mapLiveWidgetsById`'s synthetic `name#N` ids are not registered in
`widgetValueStore`, so no consumer can observe them. That
non-registration is intentional (a read helper must not mutate the
store), but the JSDoc still describes the pre-#16381 contract.

Separately: #16381 is titled `test:` but ships runtime changes to
`LGraph.ts` and `litegraphUtil.ts`. Both sit on error paths with no
healthy-path difference, but the title is worth updating so reviewers
know the serialisation path is in play.

## Verification

- `pnpm typecheck`, `pnpm lint` (0 errors), `pnpm format:check`, `pnpm
knip`, `pnpm build` — all clean.
- Full `pnpm test:unit`: 1440/1443 files pass. The failures
(`AgentPanelRoot`, `GettingStartedScreen`, `agentPanel`,
`presetService`, `useWorkspaceAuth`, `useFirstRunTourController`)
reproduce identically on `origin/main` in this sandbox and are unrelated
to these files.
- The 7 test files this PR touches: 196 tests, all pass.
- Manual: ComfyUI backend + dev server, default workflow loaded in
Chromium. 10 nodes serialise with unique ids and no `Cannot serialize
graph …` diagnostic; save → reload → re-serialise is byte-identical; a
prompt edit made in the UI reaches both the workflow JSON and
`graphToPrompt`; all 20 live widgets map 1:1 through
`mapLiveWidgetsById` and resolve back to themselves via
`getWidgetIdForNode`.

## Screenshots

Default workflow loaded against a live backend, and the same graph after
editing the positive prompt through the UI.


## Screenshots

![Default workflow loaded and rendered against a live ComfyUI
backend](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/c36aefc0e01f7b182e53c890bbae76401bf11c595a11544bf5e0b597077c04c2/pr-images/1788248923807-1890ca36-8f67-4db8-8bb9-790b76ee58c3.png)

![Same graph after editing the positive prompt through the UI; the edit
reaches the serialised workflow and the API
prompt](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/c36aefc0e01f7b182e53c890bbae76401bf11c595a11544bf5e0b597077c04c2/pr-images/1788248924205-dbf3d4c4-9530-402d-bb7d-5044fff97448.png)

---------

Co-authored-by: Pipeline Agent <agent@pipeline.local>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 3, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 3, 2026 08:26
@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1870 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 04:27:19 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 131ms TBT · 99.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.3 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.9 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 45ms TBT · 161.5 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 285ms TBT · 172.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 583ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.8 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 39ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 950ms
canvas-mouse-sweep: script duration 147ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.3 MB
canvas-mouse-sweep: DOM nodes -283
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 414ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.1 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 9
dom-widget-clipping: task duration 516ms
dom-widget-clipping: script duration 173ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.0 MB
dom-widget-clipping: DOM nodes 13
dom-widget-clipping: event listeners 3
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 3
large-graph-idle: task duration 667ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.0 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1754ms
large-graph-pan: script duration 817ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 85.6 MB
large-graph-pan: DOM nodes -272
large-graph-pan: event listeners -74
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1806ms
large-graph-zoom: script duration 774ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.4 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1989ms
legacy-node-drag: script duration 942ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.9 MB
legacy-node-drag: DOM nodes -6
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 655ms
minimap-idle: script duration 39ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.9 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -185
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 428ms
subgraph-dom-widget-clipping: script duration 141ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 558ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.2 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 39ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 933ms
subgraph-mouse-sweep: script duration 109ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.3 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 986ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 131ms
subgraph-transition-enter: heap used 99.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6284ms
viewport-pan-sweep: script duration 2743ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.3 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -136
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15135ms
vue-large-graph-idle: script duration 256ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 164.9 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 135
vue-large-graph-pan: task duration 18491ms
vue-large-graph-pan: script duration 868ms
vue-large-graph-pan: TBT 45ms
vue-large-graph-pan: heap used 161.5 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 75ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5529ms
vue-node-resize-workload: script duration 101ms
vue-node-resize-workload: TBT 285ms
vue-node-resize-workload: heap used 172.4 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7472
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 2
workflow-execution: style recalc count 6
workflow-execution: task duration 87ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.5 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-09-03T16:38:28.971Z",
  "gitSha": "cec6a85849fccd69076a404b8ef9e3a74bd1bb32",
  "branch": "backport-16475-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2051.3649999999757,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.726999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 572.634,
      "heapDeltaBytes": -3207436,
      "heapUsedBytes": 65395768,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 13.471000000000004,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2064.5090000000437,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.270999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 593.7049999999999,
      "heapDeltaBytes": -10381820,
      "heapUsedBytes": 60044652,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 12.06,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1906.6290000000095,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 41.112,
      "layouts": 14,
      "layoutDurationMs": 4.907,
      "taskDurationMs": 969.715,
      "heapDeltaBytes": 5244624,
      "heapUsedBytes": 75581680,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 150.725,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1873.7330000000156,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 36.267999999999994,
      "layouts": 14,
      "layoutDurationMs": 4.331,
      "taskDurationMs": 930.2470000000001,
      "heapDeltaBytes": -7048364,
      "heapUsedBytes": 63405916,
      "domNodes": -285,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 143.333,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.0060000000076,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.857,
      "layouts": 6,
      "layoutDurationMs": 1.247,
      "taskDurationMs": 415.786,
      "heapDeltaBytes": 4454196,
      "heapUsedBytes": 74259548,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 13.316999999999998,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1730.6019999999762,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.071,
      "layouts": 6,
      "layoutDurationMs": 1.3670000000000002,
      "taskDurationMs": 411.299,
      "heapDeltaBytes": 4361304,
      "heapUsedBytes": 74920912,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 13.663000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 854.4650000000047,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.7920000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.1999999999999,
      "heapDeltaBytes": 17828240,
      "heapUsedBytes": 88091608,
      "domNodes": 8,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 187.21400000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 683.1879999999728,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.595000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.46900000000005,
      "heapDeltaBytes": 18425048,
      "heapUsedBytes": 88083144,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 159.64600000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.6279999999792,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.772000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 692.0999999999999,
      "heapDeltaBytes": -13386092,
      "heapUsedBytes": 87252692,
      "domNodes": -270,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 38.25799999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2006.907999999953,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.860000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 641.7369999999999,
      "heapDeltaBytes": 21870748,
      "heapUsedBytes": 86840788,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 37.843,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2817.3300000000268,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.055000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1784.1809999999998,
      "heapDeltaBytes": 26815672,
      "heapUsedBytes": 92092396,
      "domNodes": -274,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 831.427,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2489.4689999999855,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1722.8600000000004,
      "heapDeltaBytes": 21995496,
      "heapUsedBytes": 87333388,
      "domNodes": -270,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 802.087,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3812.142999999992,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.358000000000002,
      "layouts": 60,
      "layoutDurationMs": 13.236999999999998,
      "taskDurationMs": 1794.894,
      "heapDeltaBytes": 9865336,
      "heapUsedBytes": 75869804,
      "domNodes": -280,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 769.8280000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3869.507999999996,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.583000000000002,
      "layouts": 60,
      "layoutDurationMs": 13.121,
      "taskDurationMs": 1818.057,
      "heapDeltaBytes": 8471308,
      "heapUsedBytes": 76064968,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 777.775,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3104.282000000012,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.027999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1984.9769999999999,
      "heapDeltaBytes": 25289368,
      "heapUsedBytes": 92606052,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 942.626,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3126.651000000038,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.166999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1993.62,
      "heapDeltaBytes": 21937628,
      "heapUsedBytes": 89661612,
      "domNodes": -11,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 941.8340000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2023.8620000000083,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.218,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 649.425,
      "heapDeltaBytes": 11127904,
      "heapUsedBytes": 86898640,
      "domNodes": -268,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 37.382,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2013.368000000014,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.748,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 659.6240000000001,
      "heapDeltaBytes": 21852548,
      "heapUsedBytes": 87029872,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 41.044,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 635.9090000000265,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.612,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.08199999999994,
      "heapDeltaBytes": 14775748,
      "heapUsedBytes": 87404076,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 141.90399999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 644.0350000000308,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.424000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 430.441,
      "heapDeltaBytes": 14854108,
      "heapUsedBytes": 87399628,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 140.564,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2039.3159999999853,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.692999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 563.132,
      "heapDeltaBytes": 2135600,
      "heapUsedBytes": 73694772,
      "domNodes": -297,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 9.617999999999999,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.6239999999934,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.905999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 552.106,
      "heapDeltaBytes": -7589736,
      "heapUsedBytes": 65068504,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 9.810000000000002,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1714.271999999994,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 35.925,
      "layouts": 18,
      "layoutDurationMs": 5.118,
      "taskDurationMs": 908.076,
      "heapDeltaBytes": -12685840,
      "heapUsedBytes": 59837488,
      "domNodes": -298,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 106.06500000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1756.844000000001,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 41.726,
      "layouts": 18,
      "layoutDurationMs": 6.236000000000001,
      "taskDurationMs": 958.34,
      "heapDeltaBytes": 2308916,
      "heapUsedBytes": 75089924,
      "domNodes": -294,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 111.15400000000001,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1450.5869999999277,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 28.88199999999999,
      "layouts": 14,
      "layoutDurationMs": 14.135000000000002,
      "taskDurationMs": 986.3520000000001,
      "heapDeltaBytes": 21865228,
      "heapUsedBytes": 104775180,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 30.148,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 131,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8731.965000000002,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 37.019,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6245.046,
      "heapDeltaBytes": -8799872,
      "heapUsedBytes": 91977220,
      "domNodes": -270,
      "jsHeapTotalBytes": -81920,
      "scriptDurationMs": 2789.9159999999997,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9406.555000000026,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.594,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6322.616,
      "heapDeltaBytes": -11812604,
      "heapUsedBytes": 88944160,
      "domNodes": -270,
      "jsHeapTotalBytes": -1163264,
      "scriptDurationMs": 2696.001,
      "eventListeners": -135,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15776.265000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15176.029,
      "heapDeltaBytes": -30188740,
      "heapUsedBytes": 176948616,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6311936,
      "scriptDurationMs": 261.1,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15625.238999999965,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15093.654999999999,
      "heapDeltaBytes": -19410488,
      "heapUsedBytes": 168797812,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3133440,
      "scriptDurationMs": 251.25200000000004,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18681.132999999987,
      "styleRecalcs": 135,
      "styleRecalcDurationMs": 17.607999999999958,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18485.941,
      "heapDeltaBytes": -40110828,
      "heapUsedBytes": 162616496,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2646016,
      "scriptDurationMs": 874.158,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 57,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18810.951000000045,
      "styleRecalcs": 135,
      "styleRecalcDurationMs": 17.714999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18496.074999999997,
      "heapDeltaBytes": -33485796,
      "heapUsedBytes": 176155516,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4845568,
      "scriptDurationMs": 862.24,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 32,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5644.329000000027,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.83600000000001,
      "layouts": 20,
      "layoutDurationMs": 25.610999999999994,
      "taskDurationMs": 5583.827,
      "heapDeltaBytes": -22014896,
      "heapUsedBytes": 180261504,
      "domNodes": -6548,
      "jsHeapTotalBytes": 17035264,
      "scriptDurationMs": 102.96100000000001,
      "eventListeners": -7472,
      "totalBlockingTimeMs": 275,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5536.298999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.12799999999997,
      "layouts": 20,
      "layoutDurationMs": 23.790000000000006,
      "taskDurationMs": 5474.488,
      "heapDeltaBytes": -25046148,
      "heapUsedBytes": 181264504,
      "domNodes": -6548,
      "jsHeapTotalBytes": 17395712,
      "scriptDurationMs": 99.20799999999998,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 294,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 117.99400000006699,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 15.421,
      "layouts": 2,
      "layoutDurationMs": 1.4390000000000003,
      "taskDurationMs": 88.86800000000001,
      "heapDeltaBytes": 3146820,
      "heapUsedBytes": 70735768,
      "domNodes": 128,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.168000000000001,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 109.16799999995419,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 18.495,
      "layouts": 2,
      "layoutDurationMs": 1.1940000000000002,
      "taskDurationMs": 84.77299999999998,
      "heapDeltaBytes": 3122688,
      "heapUsedBytes": 70794516,
      "domNodes": 125,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.613999999999998,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48042 70534 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.8% 255
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions
github-actions Bot requested a review from DrJKL September 3, 2026 08:27
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/litegraph/src/LGraph.ts 90.90% 0 Missing and 1 partial ⚠️
src/utils/litegraphUtil.ts 93.33% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.53   #16752   +/-   ##
=============================================
  Coverage              ?   83.29%           
=============================================
  Files                 ?     2023           
  Lines                 ?   117035           
  Branches              ?    32458           
=============================================
  Hits                  ?    97490           
  Misses                ?    19188           
  Partials              ?      357           
Flag Coverage Δ
e2e 66.61% <75.00%> (?)
unit 76.55% <93.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraph.ts 78.22% <90.90%> (ø)
src/utils/litegraphUtil.ts 87.91% <93.33%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ready to approve after CI is green

I compared this backport of #16475 with merged source commit 26eba65. The normalized nine-file deltas are identical; ordinary patch differences are release-branch context only. pnpm typecheck, scoped ESLint with 0 errors, scoped oxfmt, and 213 targeted tests passed. One hosted Playwright shard fails in the unchanged viewport-tab test at browser_tests/tests/interaction.spec.ts:1072; the core twin with the identical patch passed that shard. I found no backport defect, but I am leaving a comment rather than approving while hosted CI is red.

@comfy-pr-bot
comfy-pr-bot merged commit 61fb1ee into cloud/1.53 Sep 3, 2026
95 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16475-to-cloud-1.53 branch September 3, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants