Skip to content

[backport cloud/1.53] fix(litegraph): avoid delete on widgetId in SubgraphNode - #16751

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16717-to-cloud-1.53
Sep 3, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16717-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16717 to cloud/1.53

Automatically created by backport workflow.

## Summary

Replaces `delete input.widgetId` with `input.widgetId = undefined` at
the three call sites in `SubgraphNode.ts` (unlink cleanup,
unassigned-node guard, failed-registration guard).

`widgetId` is an optional field (`widgetId?: WidgetId`,
`src/lib/litegraph/src/interfaces.ts:375`), so assignment is a
semantically equivalent, proxy-safe replacement for `delete`.

## Why

Follow-up from a review thread on the cloud/1.53 backport
[#16679](#16679 (comment)):

> `delete` has been a source of issues with the compatibility proxies
we're using. — @DrJKL

That backport kept the pattern byte-identical to `main` (it predates the
change under review, also present at the merged core twin
[#16678](#16678)).
This PR is the forward fix on `main`; both `cloud/1.53` and `core/1.53`
can backport it once merged.

## Verification

- No caller checks key presence (`in` / `hasOwnProperty`) or serializes
`input` directly — pure behavior-preserving substitution.
- `SubgraphNode.test.ts` + `SubgraphNode.titleButton.test.ts`: 61/61
passed.
- Full `src/lib/litegraph/src/subgraph/` suite: 323/323 passed.
- `eslint` on the changed file: 0 errors (2 pre-existing, unrelated
warnings).
- Full-project `vue-tsc --noEmit`: clean.

Co-authored-by: cheap-drain <christian@ampcode.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 3, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 3, 2026 08:26
@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 08:28:20 AM UTC

Links

🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1870 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 126ms TBT · 81.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.9 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.5 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 95ms TBT · 170.2 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 459ms TBT · 179.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 519ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.1 MB
canvas-idle: DOM nodes -283
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 39ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 877ms
canvas-mouse-sweep: script duration 149ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.0 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -172
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 353ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 447ms
dom-widget-clipping: script duration 155ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 59.8 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 587ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.1 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1509ms
large-graph-pan: script duration 740ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.4 MB
large-graph-pan: DOM nodes -275
large-graph-pan: event listeners 4
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1619ms
large-graph-zoom: script duration 747ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.0 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1841ms
legacy-node-drag: script duration 932ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 80.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 563ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.1 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 414ms
subgraph-dom-widget-clipping: script duration 152ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.7 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 478ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.4 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 35ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 773ms
subgraph-mouse-sweep: script duration 100ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.3 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 12
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 924ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 126ms
subgraph-transition-enter: heap used 81.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5483ms
viewport-pan-sweep: script duration 2506ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 78.9 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -139
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17065ms
vue-large-graph-idle: script duration 297ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.5 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 171
vue-large-graph-pan: task duration 21444ms
vue-large-graph-pan: script duration 923ms
vue-large-graph-pan: TBT 95ms
vue-large-graph-pan: heap used 170.2 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 72ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6197ms
vue-node-resize-workload: script duration 114ms
vue-node-resize-workload: TBT 459ms
vue-node-resize-workload: heap used 179.7 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 27ms
workflow-execution: layout count 3
workflow-execution: style recalc count 17
workflow-execution: task duration 122ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.8 MB
workflow-execution: DOM nodes 138
workflow-execution: event listeners 99
Raw data
{
  "timestamp": "2026-09-03T08:39:58.932Z",
  "gitSha": "48a8fe7ebe3d2a6a7cdba480118e4541740f32da",
  "branch": "backport-16717-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2084.9959999999896,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.631000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 537.952,
      "heapDeltaBytes": -12607940,
      "heapUsedBytes": 56999440,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.091999999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000007,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2067.605999999955,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.366,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.942,
      "heapDeltaBytes": -587596,
      "heapUsedBytes": 69126592,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.924000000000001,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1865.5529999999771,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 41.572,
      "layouts": 14,
      "layoutDurationMs": 4.7749999999999995,
      "taskDurationMs": 898.104,
      "heapDeltaBytes": -9692588,
      "heapUsedBytes": 59987384,
      "domNodes": -281,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 150.79899999999998,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1875.8450000000266,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 36.21099999999999,
      "layouts": 14,
      "layoutDurationMs": 4.661999999999999,
      "taskDurationMs": 856.546,
      "heapDeltaBytes": 3076072,
      "heapUsedBytes": 72192024,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 147.73600000000002,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.3339999999616,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.396,
      "layouts": 6,
      "layoutDurationMs": 1.22,
      "taskDurationMs": 349.00600000000003,
      "heapDeltaBytes": 4404204,
      "heapUsedBytes": 74969640,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.809,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.0610000000825,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.899,
      "layouts": 6,
      "layoutDurationMs": 1.11,
      "taskDurationMs": 357.73900000000003,
      "heapDeltaBytes": 4713204,
      "heapUsedBytes": 74819576,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.82,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 634.2489999999543,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.183999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.55699999999996,
      "heapDeltaBytes": -7859728,
      "heapUsedBytes": 62705124,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 153.847,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 649.4999999999891,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.65,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.68399999999997,
      "heapDeltaBytes": -7740220,
      "heapUsedBytes": 62802488,
      "domNodes": 22,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 156.638,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.8240000000096,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.599999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 585.072,
      "heapDeltaBytes": -12962980,
      "heapUsedBytes": 87189976,
      "domNodes": -269,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 33.15299999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2058.7909999999283,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.012999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.8609999999999,
      "heapDeltaBytes": -13611480,
      "heapUsedBytes": 87132312,
      "domNodes": -270,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 32.735,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2126.1690000000044,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.484999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1500.6050000000002,
      "heapDeltaBytes": 22697108,
      "heapUsedBytes": 88446028,
      "domNodes": -271,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 733.375,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2139.9300000000494,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 9.396999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1516.592,
      "heapDeltaBytes": 22765888,
      "heapUsedBytes": 88642420,
      "domNodes": -278,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 745.6610000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3478.5930000000462,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.329,
      "layouts": 60,
      "layoutDurationMs": 12.580999999999998,
      "taskDurationMs": 1611.157,
      "heapDeltaBytes": 8478132,
      "heapUsedBytes": 75533508,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 744.916,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3463.5350000000926,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.443000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.480000000000002,
      "taskDurationMs": 1627.4159999999997,
      "heapDeltaBytes": 8053016,
      "heapUsedBytes": 75371524,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 748.722,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3007.233000000042,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.250999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1852.474,
      "heapDeltaBytes": 17524384,
      "heapUsedBytes": 85052412,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 929.1479999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2993.8270000000102,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.184999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1830.1309999999999,
      "heapDeltaBytes": 17004812,
      "heapUsedBytes": 84653260,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 934.015,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2014.7739999999885,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.2589999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.6019999999999,
      "heapDeltaBytes": 21735252,
      "heapUsedBytes": 87500120,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.599999999999994,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.2190000000264,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.0520000000000027,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.52,
      "heapDeltaBytes": -16036092,
      "heapUsedBytes": 86781964,
      "domNodes": -271,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 36.602000000000004,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 597.5979999999481,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.697000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 411.76899999999995,
      "heapDeltaBytes": 14866412,
      "heapUsedBytes": 87271336,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 151.12399999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 630.0149999999576,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.783,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.82000000000005,
      "heapDeltaBytes": 14284556,
      "heapUsedBytes": 86216240,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 153.662,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.0880000000343,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.114999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.11099999999993,
      "heapDeltaBytes": -9601472,
      "heapUsedBytes": 63029040,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.452,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.055999999935,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.614,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.01000000000005,
      "heapDeltaBytes": -8966576,
      "heapUsedBytes": 63635104,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.648999999999999,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1705.082999999945,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 35.598,
      "layouts": 18,
      "layoutDurationMs": 5.141000000000001,
      "taskDurationMs": 770.9130000000001,
      "heapDeltaBytes": -12995092,
      "heapUsedBytes": 59535544,
      "domNodes": -295,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 99.3,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1719.0800000000763,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 34.185,
      "layouts": 18,
      "layoutDurationMs": 5.377,
      "taskDurationMs": 774.957,
      "heapDeltaBytes": -11612988,
      "heapUsedBytes": 60645488,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 100.631,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1416.8409999999767,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 29.980999999999995,
      "layouts": 12,
      "layoutDurationMs": 13.680000000000001,
      "taskDurationMs": 924.3489999999998,
      "heapDeltaBytes": -7334632,
      "heapUsedBytes": 85910672,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 30.622000000000003,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 126,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8347.702000000027,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.388000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5477.3189999999995,
      "heapDeltaBytes": -23803712,
      "heapUsedBytes": 76434192,
      "domNodes": -270,
      "jsHeapTotalBytes": -868352,
      "scriptDurationMs": 2508.725,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8330.126999999948,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 37.816,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5489,
      "heapDeltaBytes": -11343468,
      "heapUsedBytes": 89044752,
      "domNodes": -269,
      "jsHeapTotalBytes": -344064,
      "scriptDurationMs": 2503.9669999999996,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17854.44300000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17133.081000000002,
      "heapDeltaBytes": -28578200,
      "heapUsedBytes": 175326296,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4059136,
      "scriptDurationMs": 274.91099999999994,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17858.457999999926,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16996.776,
      "heapDeltaBytes": -42656256,
      "heapUsedBytes": 173853832,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1597440,
      "scriptDurationMs": 319.161,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21506.35,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 18.27200000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21174.172,
      "heapDeltaBytes": -23142884,
      "heapUsedBytes": 189959060,
      "domNodes": -6548,
      "jsHeapTotalBytes": -10051584,
      "scriptDurationMs": 927.5319999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21994.326,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 19.459999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21713.876999999997,
      "heapDeltaBytes": -43413912,
      "heapUsedBytes": 166888236,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5632000,
      "scriptDurationMs": 918.1479999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 57,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6334.198000000015,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 71.51299999999999,
      "layouts": 20,
      "layoutDurationMs": 23.40600000000001,
      "taskDurationMs": 6189.778,
      "heapDeltaBytes": -6893396,
      "heapUsedBytes": 196207548,
      "domNodes": -6548,
      "jsHeapTotalBytes": 16773120,
      "scriptDurationMs": 116.982,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 457,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6344.6689999999535,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.042,
      "layouts": 20,
      "layoutDurationMs": 23.371000000000002,
      "taskDurationMs": 6203.285999999999,
      "heapDeltaBytes": -29636568,
      "heapUsedBytes": 180743044,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9048064,
      "scriptDurationMs": 110.92399999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 461,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 480.4430000000366,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 25.303,
      "layouts": 3,
      "layoutDurationMs": 1.645,
      "taskDurationMs": 119.35399999999998,
      "heapDeltaBytes": 5307736,
      "heapUsedBytes": 73651452,
      "domNodes": 153,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 11.107,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 491.1709999998948,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 27.823,
      "layouts": 3,
      "layoutDurationMs": 0.9650000000000002,
      "taskDurationMs": 125,
      "heapDeltaBytes": 5051108,
      "heapUsedBytes": 72810536,
      "domNodes": 123,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.336,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48012 70502 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions
github-actions Bot requested a review from DrJKL September 3, 2026 08:27
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #16751   +/-   ##
=============================================
  Coverage              ?   83.30%           
=============================================
  Files                 ?     2023           
  Lines                 ?   116997           
  Branches              ?    33032           
=============================================
  Hits                  ?    97465           
  Misses                ?    19177           
  Partials              ?      355           
Flag Coverage Δ
e2e 66.60% <66.66%> (?)
unit 76.55% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/subgraph/SubgraphNode.ts 89.85% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared this backport of #16717 with merged source commit cef1bfc. The stable patch IDs match, with all three widgetId assignments preserved and no extra changes. pnpm typecheck, scoped ESLint with 0 errors, scoped oxfmt, and 106 targeted subgraph tests passed. Hosted checks are green. I found no blocking issues.

@comfy-pr-bot
comfy-pr-bot merged commit e44f148 into cloud/1.53 Sep 3, 2026
106 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16717-to-cloud-1.53 branch September 3, 2026 09:12
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 23, 2026
…58) (Comfy-Org#17486)

*PR Created by the Glary-Bot Agent*

---

Fixes the `scale_multiplier` widget on the
`utility_seedvr2_3b_int8_upscale_image` template rendering as a
disconnected input slot, with a duplicate `resize_type.multiplier_1`
appended below it. Reproduces on current `main`; neither Comfy-Org#16717 nor its
backport Comfy-Org#16751 touched the failing path.

- Fixes FE-258

## Root cause

A node is constructed with its dynamic combo's **default** option laid
out (`resize_type.width/height/crop`), and `ComfyNode.configure`
rewrites `data.inputs` into that definition order, appending the
serialized inputs the definition lacks. Serialized `target_slot` values
count the **saved** layout, so link `50` — saved on
`resize_type.multiplier` at slot 1 — lands on slot 1 of the rebuilt
layout, which is a different input.

Applying the combo's serialized value then tears the group down and
hands each surviving link to the new input of the same name. The link is
sitting on `resize_type.width`, which the selected option does not
define, so it is dropped. Across a subgraph boundary the promoted input
is demoted to a bare slot and a duplicate `_1` promotion is
auto-created.

## Fix

Realign the node's input links by name in `LGraphNode.configure`, after
slots are wired and before widget values are applied — the window in
which the correct slot exists. Scoped to nodes that have a group widget
child input; `LGraph.configure`'s existing pass still runs for
everything else once all nodes are configured.

The node's ordinary inputs join the batch so a link still occupying a
child's destination slot moves in the same atomic update instead of
blocking it. Inputs owned by a group that is not a widget (autogrow)
stay out because their slots grow and renumber during configure.

## Verification

- `pnpm test:unit
src/lib/litegraph/src/LGraph.inputSlotRealign.test.ts`: 21 passed.
- `pnpm test:browser:local
browser_tests/tests/subgraph/subgraphPromotedDynamicComboChild.spec.ts`:
2 passed after the development server warmed up. The first cold-start
run timed out before the app became ready; its second test passed.
- `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint`, `pnpm
format:check`, and `pnpm knip` passed.

## Unverified residuals

- An excluded autogrow link can block the early batch and produce a
`Failed to realign input link slots` log. This PR does not include a
complete-config base/head test for the final topology in that case.
- A nested dynamic combo under a non-default outer option is excluded
because its widget does not exist at this point in configure. Base/head
parity for that case was not reverified in this review round.

## Screenshots

![Before, on main: scale_multiplier is a bare disconnected input slot
and a duplicate resize_type.multiplier_1 widget is appended at the
bottom of the
node](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/a48037af157a30f246f73578b4cedea7fcb7acb6473a9fc84046508377963380/pr-images/1789169961897-4970176d-8c5d-45dc-8ac6-c46125b400c4.png)

![After the fix: scale_multiplier renders as a widget with value 4.00 in
its correct position, with no duplicate
input](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/a48037af157a30f246f73578b4cedea7fcb7acb6473a9fc84046508377963380/pr-images/1789169962235-4c9befc5-08de-46f2-a42a-7927a3e8224d.png)

---------

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Co-authored-by: Amp <amp@ampcode.com>
christian-byrne pushed a commit that referenced this pull request Oct 1, 2026
…58) (#17486)

*PR Created by the Glary-Bot Agent*

---

Fixes the `scale_multiplier` widget on the
`utility_seedvr2_3b_int8_upscale_image` template rendering as a
disconnected input slot, with a duplicate `resize_type.multiplier_1`
appended below it. Reproduces on current `main`; neither #16717 nor its
backport #16751 touched the failing path.

- Fixes FE-258

## Root cause

A node is constructed with its dynamic combo's **default** option laid
out (`resize_type.width/height/crop`), and `ComfyNode.configure`
rewrites `data.inputs` into that definition order, appending the
serialized inputs the definition lacks. Serialized `target_slot` values
count the **saved** layout, so link `50` — saved on
`resize_type.multiplier` at slot 1 — lands on slot 1 of the rebuilt
layout, which is a different input.

Applying the combo's serialized value then tears the group down and
hands each surviving link to the new input of the same name. The link is
sitting on `resize_type.width`, which the selected option does not
define, so it is dropped. Across a subgraph boundary the promoted input
is demoted to a bare slot and a duplicate `_1` promotion is
auto-created.

## Fix

Realign the node's input links by name in `LGraphNode.configure`, after
slots are wired and before widget values are applied — the window in
which the correct slot exists. Scoped to nodes that have a group widget
child input; `LGraph.configure`'s existing pass still runs for
everything else once all nodes are configured.

The node's ordinary inputs join the batch so a link still occupying a
child's destination slot moves in the same atomic update instead of
blocking it. Inputs owned by a group that is not a widget (autogrow)
stay out because their slots grow and renumber during configure.

## Verification

- `pnpm test:unit
src/lib/litegraph/src/LGraph.inputSlotRealign.test.ts`: 21 passed.
- `pnpm test:browser:local
browser_tests/tests/subgraph/subgraphPromotedDynamicComboChild.spec.ts`:
2 passed after the development server warmed up. The first cold-start
run timed out before the app became ready; its second test passed.
- `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint`, `pnpm
format:check`, and `pnpm knip` passed.

## Unverified residuals

- An excluded autogrow link can block the early batch and produce a
`Failed to realign input link slots` log. This PR does not include a
complete-config base/head test for the final topology in that case.
- A nested dynamic combo under a non-default outer option is excluded
because its widget does not exist at this point in configure. Base/head
parity for that case was not reverified in this review round.

## Screenshots

![Before, on main: scale_multiplier is a bare disconnected input slot
and a duplicate resize_type.multiplier_1 widget is appended at the
bottom of the
node](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/a48037af157a30f246f73578b4cedea7fcb7acb6473a9fc84046508377963380/pr-images/1789169961897-4970176d-8c5d-45dc-8ac6-c46125b400c4.png)

![After the fix: scale_multiplier renders as a widget with value 4.00 in
its correct position, with no duplicate
input](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/a48037af157a30f246f73578b4cedea7fcb7acb6473a9fc84046508377963380/pr-images/1789169962235-4c9befc5-08de-46f2-a42a-7927a3e8224d.png)

---------

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
(cherry picked from commit 3f29ced)
(cherry picked from commit 3ebfb0c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants