Repository navigation
[backport cloud/1.53] fix(litegraph): avoid delete on widgetId in SubgraphNode - #16751
Conversation
## Summary Replaces `delete input.widgetId` with `input.widgetId = undefined` at the three call sites in `SubgraphNode.ts` (unlink cleanup, unassigned-node guard, failed-registration guard). `widgetId` is an optional field (`widgetId?: WidgetId`, `src/lib/litegraph/src/interfaces.ts:375`), so assignment is a semantically equivalent, proxy-safe replacement for `delete`. ## Why Follow-up from a review thread on the cloud/1.53 backport [#16679](#16679 (comment)): > `delete` has been a source of issues with the compatibility proxies we're using. — @DrJKL That backport kept the pattern byte-identical to `main` (it predates the change under review, also present at the merged core twin [#16678](#16678)). This PR is the forward fix on `main`; both `cloud/1.53` and `core/1.53` can backport it once merged. ## Verification - No caller checks key presence (`in` / `hasOwnProperty`) or serializes `input` directly — pure behavior-preserving substitution. - `SubgraphNode.test.ts` + `SubgraphNode.titleButton.test.ts`: 61/61 passed. - Full `src/lib/litegraph/src/subgraph/` suite: 323/323 passed. - `eslint` on the changed file: 0 errors (2 pre-existing, unrelated warnings). - Full-project `vue-tsc --noEmit`: clean. Co-authored-by: cheap-drain <christian@ampcode.com>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-03T08:39:58.932Z",
"gitSha": "48a8fe7ebe3d2a6a7cdba480118e4541740f32da",
"branch": "backport-16717-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2084.9959999999896,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.631000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.952,
"heapDeltaBytes": -12607940,
"heapUsedBytes": 56999440,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.091999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2067.605999999955,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.366,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.942,
"heapDeltaBytes": -587596,
"heapUsedBytes": 69126592,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.924000000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1865.5529999999771,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.572,
"layouts": 14,
"layoutDurationMs": 4.7749999999999995,
"taskDurationMs": 898.104,
"heapDeltaBytes": -9692588,
"heapUsedBytes": 59987384,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 150.79899999999998,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.8450000000266,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.21099999999999,
"layouts": 14,
"layoutDurationMs": 4.661999999999999,
"taskDurationMs": 856.546,
"heapDeltaBytes": 3076072,
"heapUsedBytes": 72192024,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 147.73600000000002,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.3339999999616,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.396,
"layouts": 6,
"layoutDurationMs": 1.22,
"taskDurationMs": 349.00600000000003,
"heapDeltaBytes": 4404204,
"heapUsedBytes": 74969640,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.809,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.0610000000825,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.899,
"layouts": 6,
"layoutDurationMs": 1.11,
"taskDurationMs": 357.73900000000003,
"heapDeltaBytes": 4713204,
"heapUsedBytes": 74819576,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.82,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 634.2489999999543,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.183999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.55699999999996,
"heapDeltaBytes": -7859728,
"heapUsedBytes": 62705124,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 153.847,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 649.4999999999891,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.65,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.68399999999997,
"heapDeltaBytes": -7740220,
"heapUsedBytes": 62802488,
"domNodes": 22,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 156.638,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.8240000000096,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.599999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.072,
"heapDeltaBytes": -12962980,
"heapUsedBytes": 87189976,
"domNodes": -269,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 33.15299999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2058.7909999999283,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.012999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.8609999999999,
"heapDeltaBytes": -13611480,
"heapUsedBytes": 87132312,
"domNodes": -270,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 32.735,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2126.1690000000044,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.484999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1500.6050000000002,
"heapDeltaBytes": 22697108,
"heapUsedBytes": 88446028,
"domNodes": -271,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 733.375,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2139.9300000000494,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.396999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1516.592,
"heapDeltaBytes": 22765888,
"heapUsedBytes": 88642420,
"domNodes": -278,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 745.6610000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3478.5930000000462,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.329,
"layouts": 60,
"layoutDurationMs": 12.580999999999998,
"taskDurationMs": 1611.157,
"heapDeltaBytes": 8478132,
"heapUsedBytes": 75533508,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 744.916,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3463.5350000000926,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.443000000000001,
"layouts": 60,
"layoutDurationMs": 12.480000000000002,
"taskDurationMs": 1627.4159999999997,
"heapDeltaBytes": 8053016,
"heapUsedBytes": 75371524,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 748.722,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3007.233000000042,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.250999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1852.474,
"heapDeltaBytes": 17524384,
"heapUsedBytes": 85052412,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 929.1479999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2993.8270000000102,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.184999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1830.1309999999999,
"heapDeltaBytes": 17004812,
"heapUsedBytes": 84653260,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 934.015,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2014.7739999999885,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.2589999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.6019999999999,
"heapDeltaBytes": 21735252,
"heapUsedBytes": 87500120,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.599999999999994,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2038.2190000000264,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.0520000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.52,
"heapDeltaBytes": -16036092,
"heapUsedBytes": 86781964,
"domNodes": -271,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 36.602000000000004,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.5979999999481,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.697000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.76899999999995,
"heapDeltaBytes": 14866412,
"heapUsedBytes": 87271336,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.12399999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.0149999999576,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.783,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.82000000000005,
"heapDeltaBytes": 14284556,
"heapUsedBytes": 86216240,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 153.662,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.0880000000343,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.114999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.11099999999993,
"heapDeltaBytes": -9601472,
"heapUsedBytes": 63029040,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.452,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.055999999935,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.614,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.01000000000005,
"heapDeltaBytes": -8966576,
"heapUsedBytes": 63635104,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.648999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.082999999945,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.598,
"layouts": 18,
"layoutDurationMs": 5.141000000000001,
"taskDurationMs": 770.9130000000001,
"heapDeltaBytes": -12995092,
"heapUsedBytes": 59535544,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 99.3,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.0800000000763,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.185,
"layouts": 18,
"layoutDurationMs": 5.377,
"taskDurationMs": 774.957,
"heapDeltaBytes": -11612988,
"heapUsedBytes": 60645488,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 100.631,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.8409999999767,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.980999999999995,
"layouts": 12,
"layoutDurationMs": 13.680000000000001,
"taskDurationMs": 924.3489999999998,
"heapDeltaBytes": -7334632,
"heapUsedBytes": 85910672,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.622000000000003,
"eventListeners": 2381,
"totalBlockingTimeMs": 126,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8347.702000000027,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.388000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5477.3189999999995,
"heapDeltaBytes": -23803712,
"heapUsedBytes": 76434192,
"domNodes": -270,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 2508.725,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8330.126999999948,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.816,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5489,
"heapDeltaBytes": -11343468,
"heapUsedBytes": 89044752,
"domNodes": -269,
"jsHeapTotalBytes": -344064,
"scriptDurationMs": 2503.9669999999996,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17854.44300000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17133.081000000002,
"heapDeltaBytes": -28578200,
"heapUsedBytes": 175326296,
"domNodes": -6548,
"jsHeapTotalBytes": -4059136,
"scriptDurationMs": 274.91099999999994,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17858.457999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16996.776,
"heapDeltaBytes": -42656256,
"heapUsedBytes": 173853832,
"domNodes": -6548,
"jsHeapTotalBytes": 1597440,
"scriptDurationMs": 319.161,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21506.35,
"styleRecalcs": 168,
"styleRecalcDurationMs": 18.27200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21174.172,
"heapDeltaBytes": -23142884,
"heapUsedBytes": 189959060,
"domNodes": -6548,
"jsHeapTotalBytes": -10051584,
"scriptDurationMs": 927.5319999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21994.326,
"styleRecalcs": 174,
"styleRecalcDurationMs": 19.459999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21713.876999999997,
"heapDeltaBytes": -43413912,
"heapUsedBytes": 166888236,
"domNodes": -6548,
"jsHeapTotalBytes": -5632000,
"scriptDurationMs": 918.1479999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6334.198000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.51299999999999,
"layouts": 20,
"layoutDurationMs": 23.40600000000001,
"taskDurationMs": 6189.778,
"heapDeltaBytes": -6893396,
"heapUsedBytes": 196207548,
"domNodes": -6548,
"jsHeapTotalBytes": 16773120,
"scriptDurationMs": 116.982,
"eventListeners": -7471,
"totalBlockingTimeMs": 457,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6344.6689999999535,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.042,
"layouts": 20,
"layoutDurationMs": 23.371000000000002,
"taskDurationMs": 6203.285999999999,
"heapDeltaBytes": -29636568,
"heapUsedBytes": 180743044,
"domNodes": -6548,
"jsHeapTotalBytes": 9048064,
"scriptDurationMs": 110.92399999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 461,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 480.4430000000366,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.303,
"layouts": 3,
"layoutDurationMs": 1.645,
"taskDurationMs": 119.35399999999998,
"heapDeltaBytes": 5307736,
"heapUsedBytes": 73651452,
"domNodes": 153,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.107,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 491.1709999998948,
"styleRecalcs": 14,
"styleRecalcDurationMs": 27.823,
"layouts": 3,
"layoutDurationMs": 0.9650000000000002,
"taskDurationMs": 125,
"heapDeltaBytes": 5051108,
"heapUsedBytes": 72810536,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.336,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #16751 +/- ##
=============================================
Coverage ? 83.30%
=============================================
Files ? 2023
Lines ? 116997
Branches ? 33032
=============================================
Hits ? 97465
Misses ? 19177
Partials ? 355
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
I compared this backport of #16717 with merged source commit cef1bfc. The stable patch IDs match, with all three widgetId assignments preserved and no extra changes. pnpm typecheck, scoped ESLint with 0 errors, scoped oxfmt, and 106 targeted subgraph tests passed. Hosted checks are green. I found no blocking issues.
…58) (Comfy-Org#17486) *PR Created by the Glary-Bot Agent* --- Fixes the `scale_multiplier` widget on the `utility_seedvr2_3b_int8_upscale_image` template rendering as a disconnected input slot, with a duplicate `resize_type.multiplier_1` appended below it. Reproduces on current `main`; neither Comfy-Org#16717 nor its backport Comfy-Org#16751 touched the failing path. - Fixes FE-258 ## Root cause A node is constructed with its dynamic combo's **default** option laid out (`resize_type.width/height/crop`), and `ComfyNode.configure` rewrites `data.inputs` into that definition order, appending the serialized inputs the definition lacks. Serialized `target_slot` values count the **saved** layout, so link `50` — saved on `resize_type.multiplier` at slot 1 — lands on slot 1 of the rebuilt layout, which is a different input. Applying the combo's serialized value then tears the group down and hands each surviving link to the new input of the same name. The link is sitting on `resize_type.width`, which the selected option does not define, so it is dropped. Across a subgraph boundary the promoted input is demoted to a bare slot and a duplicate `_1` promotion is auto-created. ## Fix Realign the node's input links by name in `LGraphNode.configure`, after slots are wired and before widget values are applied — the window in which the correct slot exists. Scoped to nodes that have a group widget child input; `LGraph.configure`'s existing pass still runs for everything else once all nodes are configured. The node's ordinary inputs join the batch so a link still occupying a child's destination slot moves in the same atomic update instead of blocking it. Inputs owned by a group that is not a widget (autogrow) stay out because their slots grow and renumber during configure. ## Verification - `pnpm test:unit src/lib/litegraph/src/LGraph.inputSlotRealign.test.ts`: 21 passed. - `pnpm test:browser:local browser_tests/tests/subgraph/subgraphPromotedDynamicComboChild.spec.ts`: 2 passed after the development server warmed up. The first cold-start run timed out before the app became ready; its second test passed. - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint`, `pnpm format:check`, and `pnpm knip` passed. ## Unverified residuals - An excluded autogrow link can block the early batch and produce a `Failed to realign input link slots` log. This PR does not include a complete-config base/head test for the final topology in that case. - A nested dynamic combo under a non-default outer option is excluded because its widget does not exist at this point in configure. Base/head parity for that case was not reverified in this review round. ## Screenshots   --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
…58) (#17486) *PR Created by the Glary-Bot Agent* --- Fixes the `scale_multiplier` widget on the `utility_seedvr2_3b_int8_upscale_image` template rendering as a disconnected input slot, with a duplicate `resize_type.multiplier_1` appended below it. Reproduces on current `main`; neither #16717 nor its backport #16751 touched the failing path. - Fixes FE-258 ## Root cause A node is constructed with its dynamic combo's **default** option laid out (`resize_type.width/height/crop`), and `ComfyNode.configure` rewrites `data.inputs` into that definition order, appending the serialized inputs the definition lacks. Serialized `target_slot` values count the **saved** layout, so link `50` — saved on `resize_type.multiplier` at slot 1 — lands on slot 1 of the rebuilt layout, which is a different input. Applying the combo's serialized value then tears the group down and hands each surviving link to the new input of the same name. The link is sitting on `resize_type.width`, which the selected option does not define, so it is dropped. Across a subgraph boundary the promoted input is demoted to a bare slot and a duplicate `_1` promotion is auto-created. ## Fix Realign the node's input links by name in `LGraphNode.configure`, after slots are wired and before widget values are applied — the window in which the correct slot exists. Scoped to nodes that have a group widget child input; `LGraph.configure`'s existing pass still runs for everything else once all nodes are configured. The node's ordinary inputs join the batch so a link still occupying a child's destination slot moves in the same atomic update instead of blocking it. Inputs owned by a group that is not a widget (autogrow) stay out because their slots grow and renumber during configure. ## Verification - `pnpm test:unit src/lib/litegraph/src/LGraph.inputSlotRealign.test.ts`: 21 passed. - `pnpm test:browser:local browser_tests/tests/subgraph/subgraphPromotedDynamicComboChild.spec.ts`: 2 passed after the development server warmed up. The first cold-start run timed out before the app became ready; its second test passed. - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint`, `pnpm format:check`, and `pnpm knip` passed. ## Unverified residuals - An excluded autogrow link can block the early batch and produce a `Failed to realign input link slots` log. This PR does not include a complete-config base/head test for the final topology in that case. - A nested dynamic combo under a non-default outer option is excluded because its widget does not exist at this point in configure. Base/head parity for that case was not reverified in this review round. ## Screenshots   --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> (cherry picked from commit 3f29ced) (cherry picked from commit 3ebfb0c)
Backport of #16717 to
cloud/1.53Automatically created by backport workflow.