Repository navigation
[backport core/1.53] test: land review follow-ups and current main for #16381 - #16749
Conversation
*PR Created by the Glary-Bot Agent* --- ## Summary Brings #16381 up to date with `main` (14 commits behind), lands the two test simplifications still outstanding from @DrJKL's review, and fixes a save-path regression the branch was carrying. Supersedes #16441 — its two changes are included here verbatim. ## Changes - **What**: - Merge current `main` into the branch. No textual conflicts; the merge was verified against `main`'s widget refactors (#16214, #16428, #16454). - `LLink.spreadCopy.test.ts` / `widgetValueStore.test.ts`: apply #16441 exactly — fold the redundant store-mutation spread test into the single topology test, and drop the registration case that codified an empty-name `WidgetId` (`isWidgetId` rejects it; re-registration is already covered at four other sites in the same file). - `LGraph.ts`: the live-node mismatch guard added by this branch compared stored state against `_nodes.length`. A node held twice in `_nodes` took the fallback and wrote **its id twice into the saved workflow** — `main` serialises it once. Compare against the count of distinct live ids and serialise identity-deduplicated live nodes. - `LGraph.serialise.test.ts`: two regressions — one pinning the store path for a benign duplicate (no fallback, no diagnostic), one forcing the fallback with an unregistered orphan so the dedup itself is exercised. Both fail without the fix. - `litegraphUtil.test.ts`: the widget-identity regressions asserted identity with `toEqual`, so a clone would have passed; `expect(node.widgets).toEqual([first, frozen])` compared the array to its own contents and could not fail. Now `toBe` per entry, with names asserted explicitly. - `LGraph.serialise.test.ts`: give the adapter-only fixture a real node id instead of pinning the diagnostic on `-1`, which `add()` can never produce. - **Breaking**: none. ## Review Focus `LGraph.ts` is the only behaviour change here. Verified against `main`: | `_nodes` | stored | `main` | #16381 head | this branch | | --- | --- | --- | --- | --- | | `[n, n]` | `{n}` | `[n]` | `[n, n]` — corrupt | `[n]`, no diagnostic | | `[n]` after double-add + remove | `{}` | `[]` — silent data loss | `[n]` | `[n]` | The branch's new guard genuinely fixes the second row, so it should stay — only the fallback needed deduplicating. Two reviewer notes left as-is, deliberately: - The third arm of the diagnostic string (`N stored nodes do not match M live nodes`) is now unreachable, since the guard and the arms use the same key sets. It is error-message text on an error path, so removing it would mean either a non-null assertion or `undefined` in a log line. - `mapLiveWidgetsById`'s synthetic `name#N` ids are not registered in `widgetValueStore`, so no consumer can observe them. That non-registration is intentional (a read helper must not mutate the store), but the JSDoc still describes the pre-#16381 contract. Separately: #16381 is titled `test:` but ships runtime changes to `LGraph.ts` and `litegraphUtil.ts`. Both sit on error paths with no healthy-path difference, but the title is worth updating so reviewers know the serialisation path is in play. ## Verification - `pnpm typecheck`, `pnpm lint` (0 errors), `pnpm format:check`, `pnpm knip`, `pnpm build` — all clean. - Full `pnpm test:unit`: 1440/1443 files pass. The failures (`AgentPanelRoot`, `GettingStartedScreen`, `agentPanel`, `presetService`, `useWorkspaceAuth`, `useFirstRunTourController`) reproduce identically on `origin/main` in this sandbox and are unrelated to these files. - The 7 test files this PR touches: 196 tests, all pass. - Manual: ComfyUI backend + dev server, default workflow loaded in Chromium. 10 nodes serialise with unique ids and no `Cannot serialize graph …` diagnostic; save → reload → re-serialise is byte-identical; a prompt edit made in the UI reaches both the workflow JSON and `graphToPrompt`; all 20 live widgets map 1:1 through `mapLiveWidgetsById` and resolve back to themselves via `getWidgetIdForNode`. ## Screenshots Default workflow loaded against a live backend, and the same graph after editing the positive prompt through the UI. ## Screenshots   --------- Co-authored-by: Pipeline Agent <agent@pipeline.local> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T08:39:08.746Z",
"gitSha": "e40da66a1b5cbe17ddc851925544f39e70a6e4ae",
"branch": "backport-16475-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.7920000000045,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.397,
"heapDeltaBytes": -747260,
"heapUsedBytes": 69710696,
"domNodes": -280,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 6.374,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.8760000000493,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.595,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.97700000000003,
"heapDeltaBytes": 10541240,
"heapUsedBytes": 81142220,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.427000000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2156.9200000000137,
"styleRecalcs": 85,
"styleRecalcDurationMs": 26.308999999999997,
"layouts": 14,
"layoutDurationMs": 2.882,
"taskDurationMs": 932.129,
"heapDeltaBytes": -8556424,
"heapUsedBytes": 61704636,
"domNodes": -281,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 89.957,
"eventListeners": -155,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1688.2460000000492,
"styleRecalcs": 75,
"styleRecalcDurationMs": 20.272,
"layouts": 14,
"layoutDurationMs": 2.382,
"taskDurationMs": 567.8599999999999,
"heapDeltaBytes": -11325732,
"heapUsedBytes": 59251448,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 80.99100000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1656.183999999996,
"styleRecalcs": 29,
"styleRecalcDurationMs": 11.009,
"layouts": 6,
"layoutDurationMs": 1.0579999999999998,
"taskDurationMs": 246.87400000000002,
"heapDeltaBytes": 4444032,
"heapUsedBytes": 73888516,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.6679999999999975,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.0730000000785,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.658999999999999,
"layouts": 6,
"layoutDurationMs": 1.219,
"taskDurationMs": 264.169,
"heapDeltaBytes": 4459920,
"heapUsedBytes": 74221888,
"domNodes": 79,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.821000000000002,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 517.0390000000111,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.543,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.512,
"heapDeltaBytes": -8149728,
"heapUsedBytes": 62542448,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 102.879,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 532.6190000000679,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.242,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.987,
"heapDeltaBytes": -8069152,
"heapUsedBytes": 62532088,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 102.658,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2023.533000000043,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.452,
"heapDeltaBytes": 22230264,
"heapUsedBytes": 87006792,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.536,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2002.2440000000188,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.4849999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.6460000000001,
"heapDeltaBytes": 22165924,
"heapUsedBytes": 86624924,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.65900000000001,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2082.370000000026,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.5600000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1073.67,
"heapDeltaBytes": 23347432,
"heapUsedBytes": 88678676,
"domNodes": -271,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 511.93100000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2068.136999999979,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1051.088,
"heapDeltaBytes": 21983328,
"heapUsedBytes": 87674424,
"domNodes": -270,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 486.255,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3073.5160000000405,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.001,
"layouts": 60,
"layoutDurationMs": 9.467,
"taskDurationMs": 1126.2589999999998,
"heapDeltaBytes": 8485068,
"heapUsedBytes": 75384676,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 477.779,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3044.7209999999814,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.333999999999998,
"layouts": 60,
"layoutDurationMs": 10.308,
"taskDurationMs": 1137.465,
"heapDeltaBytes": 11737292,
"heapUsedBytes": 79437576,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 474.491,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2101.835000000051,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.765999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1191.122,
"heapDeltaBytes": 18120984,
"heapUsedBytes": 85046656,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 540.698,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2133.493000000044,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.893999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1226.6879999999999,
"heapDeltaBytes": 18933460,
"heapUsedBytes": 88497496,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 575.658,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.6020000000203,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.19,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.093,
"heapDeltaBytes": 10248668,
"heapUsedBytes": 86982788,
"domNodes": -271,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 30.356,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2016.9659999999112,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.630999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.607,
"heapDeltaBytes": -15483152,
"heapUsedBytes": 87097060,
"domNodes": -270,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 29.234999999999996,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 414.211000000023,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.657,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 258.22900000000004,
"heapDeltaBytes": 14223820,
"heapUsedBytes": 86066516,
"domNodes": 20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 81.884,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 426.31699999992634,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.1990000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.973,
"heapDeltaBytes": 15045864,
"heapUsedBytes": 87502804,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 83.73899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2005.0400000000081,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.917,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.204,
"heapDeltaBytes": 892168,
"heapUsedBytes": 73754408,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.519000000000001,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.9759999999715,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.463999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.19500000000005,
"heapDeltaBytes": -6790280,
"heapUsedBytes": 65717064,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.840000000000001,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.8779999999742,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.915000000000003,
"layouts": 18,
"layoutDurationMs": 3.201,
"taskDurationMs": 567.142,
"heapDeltaBytes": 1979264,
"heapUsedBytes": 74762128,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 61.632999999999996,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.0450000000128,
"styleRecalcs": 78,
"styleRecalcDurationMs": 23.732999999999997,
"layouts": 18,
"layoutDurationMs": 3.581,
"taskDurationMs": 595.0310000000001,
"heapDeltaBytes": 1970532,
"heapUsedBytes": 74577432,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 68.051,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 865.9159999999702,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.200000000000003,
"layouts": 16,
"layoutDurationMs": 9.408999999999999,
"taskDurationMs": 620.4370000000001,
"heapDeltaBytes": -7252652,
"heapUsedBytes": 86620556,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 20.897,
"eventListeners": 2381,
"totalBlockingTimeMs": 94,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8158.137000000011,
"styleRecalcs": 249,
"styleRecalcDurationMs": 22.619000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3750.3439999999996,
"heapDeltaBytes": 13471988,
"heapUsedBytes": 88887224,
"domNodes": -268,
"jsHeapTotalBytes": -118784,
"scriptDurationMs": 1627.6709999999998,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8113.507000000027,
"styleRecalcs": 249,
"styleRecalcDurationMs": 25.649000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3886.679,
"heapDeltaBytes": 13748308,
"heapUsedBytes": 89868748,
"domNodes": -267,
"jsHeapTotalBytes": -1691648,
"scriptDurationMs": 1703.209,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10463.080999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9503.328,
"heapDeltaBytes": -12515392,
"heapUsedBytes": 176201732,
"domNodes": -6548,
"jsHeapTotalBytes": 258048,
"scriptDurationMs": 136.815,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11090.630000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10253.642000000002,
"heapDeltaBytes": -31280668,
"heapUsedBytes": 182054224,
"domNodes": -6548,
"jsHeapTotalBytes": -2547712,
"scriptDurationMs": 145.49300000000002,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13241.943000000048,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.187000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12512.434000000001,
"heapDeltaBytes": 563316,
"heapUsedBytes": 188147552,
"domNodes": -6548,
"jsHeapTotalBytes": 8593408,
"scriptDurationMs": 611.499,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13136.032,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.746000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12511.291,
"heapDeltaBytes": -42622584,
"heapUsedBytes": 170666584,
"domNodes": -6548,
"jsHeapTotalBytes": -2285568,
"scriptDurationMs": 670.1270000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 46,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3740.865000000099,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.49799999999999,
"layouts": 20,
"layoutDurationMs": 20.21500000000001,
"taskDurationMs": 3609.91,
"heapDeltaBytes": -11005588,
"heapUsedBytes": 176861496,
"domNodes": -6548,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 56.45199999999999,
"eventListeners": -7475,
"totalBlockingTimeMs": 6,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3798.4159999999747,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.131999999999984,
"layouts": 20,
"layoutDurationMs": 21.042999999999992,
"taskDurationMs": 3669.3049999999994,
"heapDeltaBytes": -36460084,
"heapUsedBytes": 179264420,
"domNodes": -6548,
"jsHeapTotalBytes": 12578816,
"scriptDurationMs": 60.205000000000005,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 446.82000000000244,
"styleRecalcs": 15,
"styleRecalcDurationMs": 15.556000000000003,
"layouts": 2,
"layoutDurationMs": 0.686,
"taskDurationMs": 84.77699999999999,
"heapDeltaBytes": 5068976,
"heapUsedBytes": 72909376,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.611000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 70.86200000003373,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.159,
"layouts": 2,
"layoutDurationMs": 0.8469999999999999,
"taskDurationMs": 47.07299999999999,
"heapDeltaBytes": 3105344,
"heapUsedBytes": 71677788,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.247999999999998,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.53 #16749 +/- ##
=============================================
- Coverage 83.29% 83.29% -0.01%
=============================================
Files 2023 2023
Lines 116989 117016 +27
Branches 32447 33040 +593
=============================================
+ Hits 97443 97463 +20
- Misses 19190 19196 +6
- Partials 356 357 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
I compared this backport of #16475 with merged source commit 26eba65. The normalized nine-file deltas are identical; ordinary patch differences are release-branch context only. pnpm typecheck, scoped ESLint with 0 errors, scoped oxfmt, and 213 targeted tests passed. Hosted checks are green. I found no blocking issues.
Backport of #16475 to
core/1.53Automatically created by backport workflow.