Skip to content

[backport cloud/1.53] fix: retain missing-node warnings after partial replacement - #16737

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16464-to-cloud-1.53
Sep 3, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16464-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16464 to cloud/1.53

Automatically created by backport workflow.

Partial replacements now keep unresolved missing-node warnings.
Regression covered; focused checks green.

<details><summary>Full context for agent readers</summary>

## Summary

When several missing nodes share a type, one successful replacement
previously marked the entire type complete. If a later replacement
failed, the missing-node warning disappeared even though an unresolved
placeholder remained.

## Changes

- Track replacement failures by node type.
- Return a type as replaced only when no node of that type failed.
- Add a regression with two same-type placeholders where the first
replacement succeeds and the second fails.

## Verification

- Regression failed against unmodified `main`, with missing-node state
cleared instead of retained.
- `pnpm test:unit
src/platform/nodeReplacement/useNodeReplacement.test.ts` — 43 passed.
- `pnpm typecheck` — passed.
- Focused format, lint, commit hooks, and pre-push `knip` — passed.

## Review Focus

Confirm that a per-type failure prevents both pending-warning and
rendered-state cleanup while fully successful types retain the existing
cleanup behavior.

Tracked checklist item: [missing-node replacement partial failures
suppress per-node
warnings](#15973)
Original review:
#15924 (comment)

</details>

<!-- authored-by:agent -->
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 3, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 3, 2026 03:22
@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 03:24:30 AM UTC

Links

🎭 Playwright: ✅ 1887 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1866 / ❌ 0 / ⚠️ 3 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 116ms TBT · 82.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.6 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.1 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 53ms TBT · 155.0 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 129ms TBT · 167.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 431ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.6 MB
canvas-idle: DOM nodes -278
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 25ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 690ms
canvas-mouse-sweep: script duration 105ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.9 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 303ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.5 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 361ms
dom-widget-clipping: script duration 125ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 59.7 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 489ms
large-graph-idle: script duration 28ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.6 MB
large-graph-idle: DOM nodes -266
large-graph-idle: event listeners -166
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1212ms
large-graph-pan: script duration 572ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.3 MB
large-graph-pan: DOM nodes -133
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1327ms
large-graph-zoom: script duration 580ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.8 MB
large-graph-zoom: DOM nodes 3
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1398ms
legacy-node-drag: script duration 660ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.0 MB
legacy-node-drag: DOM nodes 5
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 477ms
minimap-idle: script duration 28ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.2 MB
minimap-idle: DOM nodes -267
minimap-idle: event listeners -151
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 300ms
subgraph-dom-widget-clipping: script duration 97ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.3 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 410ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.9 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -233
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 615ms
subgraph-mouse-sweep: script duration 75ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.8 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 729ms
subgraph-transition-enter: script duration 23ms
subgraph-transition-enter: TBT 116ms
subgraph-transition-enter: heap used 82.5 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 28ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4328ms
viewport-pan-sweep: script duration 1881ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 78.6 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -167
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11970ms
vue-large-graph-idle: script duration 219ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.1 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 78
vue-large-graph-pan: task duration 14948ms
vue-large-graph-pan: script duration 768ms
vue-large-graph-pan: TBT 53ms
vue-large-graph-pan: heap used 155.0 MB
vue-large-graph-pan: DOM nodes -6552
vue-large-graph-pan: event listeners -7472
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 64ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4280ms
vue-node-resize-workload: script duration 87ms
vue-node-resize-workload: TBT 129ms
vue-node-resize-workload: heap used 167.5 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7473
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 4
workflow-execution: style recalc count 19
workflow-execution: task duration 97ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.1 MB
workflow-execution: DOM nodes 150
workflow-execution: event listeners 97
Raw data
{
  "timestamp": "2026-09-03T03:35:46.054Z",
  "gitSha": "ea3a51d7c41a1fc535a693e2687b196236f7663a",
  "branch": "backport-16464-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2089.2659999999523,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.199000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.752,
      "heapDeltaBytes": 1125108,
      "heapUsedBytes": 70301924,
      "domNodes": -277,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.146,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2019.2219999998997,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.854000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.371,
      "heapDeltaBytes": -11382832,
      "heapUsedBytes": 58842120,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.231999999999998,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1735.029000000054,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 24.566000000000006,
      "layouts": 14,
      "layoutDurationMs": 3.549,
      "taskDurationMs": 730.449,
      "heapDeltaBytes": -8943868,
      "heapUsedBytes": 60779764,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 109.694,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1683.3570000001146,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 24.492000000000004,
      "layouts": 14,
      "layoutDurationMs": 3.3479999999999994,
      "taskDurationMs": 650.3030000000001,
      "heapDeltaBytes": -7423152,
      "heapUsedBytes": 62744068,
      "domNodes": -278,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 100.868,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1683.952999999974,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 11.751,
      "layouts": 6,
      "layoutDurationMs": 0.8590000000000002,
      "taskDurationMs": 293.246,
      "heapDeltaBytes": 4461252,
      "heapUsedBytes": 74831732,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.597,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1741.7669999999816,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.015,
      "layouts": 6,
      "layoutDurationMs": 1.2270000000000003,
      "taskDurationMs": 313.37199999999996,
      "heapDeltaBytes": 4441740,
      "heapUsedBytes": 75065740,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.335,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 555.4199999999128,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.354000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 364.92999999999995,
      "heapDeltaBytes": -7772736,
      "heapUsedBytes": 62767456,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 124.40299999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 544.0439999999853,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 6.897,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 357.66400000000004,
      "heapDeltaBytes": -8065008,
      "heapUsedBytes": 62441532,
      "domNodes": 24,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 124.67000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2011.2829999999349,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.742000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 464.48,
      "heapDeltaBytes": 22132920,
      "heapUsedBytes": 86932416,
      "domNodes": -268,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.72600000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.667999999925,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.8519999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.451,
      "heapDeltaBytes": 11174804,
      "heapUsedBytes": 86230448,
      "domNodes": -264,
      "jsHeapTotalBytes": -1654784,
      "scriptDurationMs": 27.498,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2096.2240000000065,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.338000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1214.392,
      "heapDeltaBytes": 20808200,
      "heapUsedBytes": 86876300,
      "domNodes": -272,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 573.21,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2075.808000000052,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 7.984000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1208.969,
      "heapDeltaBytes": 17348768,
      "heapUsedBytes": 83545456,
      "domNodes": 6,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 571.7520000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3207.377000000065,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.334999999999999,
      "layouts": 60,
      "layoutDurationMs": 11.443,
      "taskDurationMs": 1367.7830000000001,
      "heapDeltaBytes": 13037472,
      "heapUsedBytes": 80859424,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 605.5240000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3127.287000000024,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 10.161,
      "layouts": 60,
      "layoutDurationMs": 10.879,
      "taskDurationMs": 1285.742,
      "heapDeltaBytes": 9458260,
      "heapUsedBytes": 75976076,
      "domNodes": 6,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 555.421,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2162.7429999999777,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 5.392999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1400.619,
      "heapDeltaBytes": 13336952,
      "heapUsedBytes": 80529688,
      "domNodes": 4,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 657.483,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2254.462999999987,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.048,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1395.945,
      "heapDeltaBytes": 13951508,
      "heapUsedBytes": 80873656,
      "domNodes": 6,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 663.4730000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.516999999998,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.257000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.84100000000007,
      "heapDeltaBytes": 21834864,
      "heapUsedBytes": 87558592,
      "domNodes": -266,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 27.733,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.7790000001423,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.764,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.14199999999994,
      "heapDeltaBytes": -15495632,
      "heapUsedBytes": 86977444,
      "domNodes": -268,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 28.153,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 510.70000000004256,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.228999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 306.154,
      "heapDeltaBytes": 14812504,
      "heapUsedBytes": 87173272,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 97.505,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 480.70499999994354,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.848,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 292.996,
      "heapDeltaBytes": 14790848,
      "heapUsedBytes": 87528308,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 96.105,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.791000000031,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.9899999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 411.58400000000006,
      "heapDeltaBytes": 1268636,
      "heapUsedBytes": 72887764,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 6.988999999999999,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.8590000000295,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.739999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.652,
      "heapDeltaBytes": 53776,
      "heapUsedBytes": 71612580,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.534000000000001,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1675.6979999998975,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 24.909999999999993,
      "layouts": 18,
      "layoutDurationMs": 3.536,
      "taskDurationMs": 630.952,
      "heapDeltaBytes": -10828268,
      "heapUsedBytes": 61756944,
      "domNodes": -296,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 72.865,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.8950000000605,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 29.953,
      "layouts": 18,
      "layoutDurationMs": 4.149,
      "taskDurationMs": 598.6830000000001,
      "heapDeltaBytes": -13100652,
      "heapUsedBytes": 59537000,
      "domNodes": -293,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 78.092,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 916.2189999999555,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 24.332000000000008,
      "layouts": 16,
      "layoutDurationMs": 10.741,
      "taskDurationMs": 729.1829999999999,
      "heapDeltaBytes": -7355204,
      "heapUsedBytes": 86514692,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 22.853000000000005,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 116,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8155.979000000002,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 28.321,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4328.233,
      "heapDeltaBytes": 5410616,
      "heapUsedBytes": 80826344,
      "domNodes": -270,
      "jsHeapTotalBytes": 667648,
      "scriptDurationMs": 1884.234,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8133.671999999933,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 28.093000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4328.17,
      "heapDeltaBytes": 8391004,
      "heapUsedBytes": 84056988,
      "domNodes": -267,
      "jsHeapTotalBytes": -1167360,
      "scriptDurationMs": 1878.3159999999998,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12689.959000000044,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11944.73,
      "heapDeltaBytes": -41127904,
      "heapUsedBytes": 174094344,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1585152,
      "scriptDurationMs": 221.858,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12626.035000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11995.078,
      "heapDeltaBytes": -13755136,
      "heapUsedBytes": 174257336,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1327104,
      "scriptDurationMs": 216.329,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15369.076999999947,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 13.056999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14848.641999999998,
      "heapDeltaBytes": -37965676,
      "heapUsedBytes": 166112480,
      "domNodes": -6548,
      "jsHeapTotalBytes": -266240,
      "scriptDurationMs": 745.6279999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15562.15300000008,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 14.039999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15047.951000000001,
      "heapDeltaBytes": -44295848,
      "heapUsedBytes": 158954176,
      "domNodes": -6556,
      "jsHeapTotalBytes": -5562368,
      "scriptDurationMs": 789.808,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 101,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4367.681999999945,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 62.755,
      "layouts": 20,
      "layoutDurationMs": 22.289999999999992,
      "taskDurationMs": 4243.992,
      "heapDeltaBytes": -27869368,
      "heapUsedBytes": 176722084,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12369920,
      "scriptDurationMs": 77.35499999999999,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 117,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4484.66899999994,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 65.89899999999999,
      "layouts": 20,
      "layoutDurationMs": 27.22999999999999,
      "taskDurationMs": 4315.133000000001,
      "heapDeltaBytes": -28956208,
      "heapUsedBytes": 174620816,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10829824,
      "scriptDurationMs": 96.84300000000002,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 453.324000000066,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 18.428,
      "layouts": 4,
      "layoutDurationMs": 1.8509999999999998,
      "taskDurationMs": 103.987,
      "heapDeltaBytes": 5320344,
      "heapUsedBytes": 74001388,
      "domNodes": 151,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.786000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 439.40299999985655,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 16.54,
      "layouts": 3,
      "layoutDurationMs": 1.314,
      "taskDurationMs": 90.834,
      "heapDeltaBytes": 5263940,
      "heapUsedBytes": 73039440,
      "domNodes": 148,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.265999999999998,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 47990 70518 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions
github-actions Bot requested a review from DrJKL September 3, 2026 03:23
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/nodeReplacement/useNodeReplacement.ts 80.00% 5 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.53   #16737   +/-   ##
=============================================
  Coverage              ?   83.28%           
=============================================
  Files                 ?     2023           
  Lines                 ?   117015           
  Branches              ?    32452           
=============================================
  Hits                  ?    97458           
  Misses                ?    19202           
  Partials              ?      355           
Flag Coverage Δ
e2e 66.56% <45.83%> (?)
unit 76.55% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/nodeReplacement/useNodeReplacement.ts 91.20% <80.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared this backport of #16464 with merged source commit 32577b5. The stable patch IDs and both changed files match exactly, including all regression tests. pnpm typecheck, scoped ESLint, scoped oxfmt, and 45 targeted tests passed. The release branch has the same pre-fix production blob used to verify the regression tests fail before the fix. Hosted checks are green. I found no blocking issues.

@comfy-pr-bot
comfy-pr-bot merged commit 7a538f4 into cloud/1.53 Sep 3, 2026
108 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16464-to-cloud-1.53 branch September 3, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants