Repository navigation
[backport cloud/1.53] fix: retain missing-node warnings after partial replacement - #16737
Conversation
Partial replacements now keep unresolved missing-node warnings. Regression covered; focused checks green. <details><summary>Full context for agent readers</summary> ## Summary When several missing nodes share a type, one successful replacement previously marked the entire type complete. If a later replacement failed, the missing-node warning disappeared even though an unresolved placeholder remained. ## Changes - Track replacement failures by node type. - Return a type as replaced only when no node of that type failed. - Add a regression with two same-type placeholders where the first replacement succeeds and the second fails. ## Verification - Regression failed against unmodified `main`, with missing-node state cleared instead of retained. - `pnpm test:unit src/platform/nodeReplacement/useNodeReplacement.test.ts` — 43 passed. - `pnpm typecheck` — passed. - Focused format, lint, commit hooks, and pre-push `knip` — passed. ## Review Focus Confirm that a per-type failure prevents both pending-warning and rendered-state cleanup while fully successful types retain the existing cleanup behavior. Tracked checklist item: [missing-node replacement partial failures suppress per-node warnings](#15973) Original review: #15924 (comment) </details> <!-- authored-by:agent -->
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1887 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-03T03:35:46.054Z",
"gitSha": "ea3a51d7c41a1fc535a693e2687b196236f7663a",
"branch": "backport-16464-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2089.2659999999523,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.199000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.752,
"heapDeltaBytes": 1125108,
"heapUsedBytes": 70301924,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.146,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2019.2219999998997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.854000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.371,
"heapDeltaBytes": -11382832,
"heapUsedBytes": 58842120,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.231999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1735.029000000054,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.566000000000006,
"layouts": 14,
"layoutDurationMs": 3.549,
"taskDurationMs": 730.449,
"heapDeltaBytes": -8943868,
"heapUsedBytes": 60779764,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 109.694,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1683.3570000001146,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.492000000000004,
"layouts": 14,
"layoutDurationMs": 3.3479999999999994,
"taskDurationMs": 650.3030000000001,
"heapDeltaBytes": -7423152,
"heapUsedBytes": 62744068,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 100.868,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.952999999974,
"styleRecalcs": 29,
"styleRecalcDurationMs": 11.751,
"layouts": 6,
"layoutDurationMs": 0.8590000000000002,
"taskDurationMs": 293.246,
"heapDeltaBytes": 4461252,
"heapUsedBytes": 74831732,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.597,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.7669999999816,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.015,
"layouts": 6,
"layoutDurationMs": 1.2270000000000003,
"taskDurationMs": 313.37199999999996,
"heapDeltaBytes": 4441740,
"heapUsedBytes": 75065740,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.335,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 555.4199999999128,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.354000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.92999999999995,
"heapDeltaBytes": -7772736,
"heapUsedBytes": 62767456,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 124.40299999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 544.0439999999853,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.897,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.66400000000004,
"heapDeltaBytes": -8065008,
"heapUsedBytes": 62441532,
"domNodes": 24,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 124.67000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2011.2829999999349,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.742000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.48,
"heapDeltaBytes": 22132920,
"heapUsedBytes": 86932416,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.72600000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.667999999925,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.8519999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.451,
"heapDeltaBytes": 11174804,
"heapUsedBytes": 86230448,
"domNodes": -264,
"jsHeapTotalBytes": -1654784,
"scriptDurationMs": 27.498,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2096.2240000000065,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.338000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1214.392,
"heapDeltaBytes": 20808200,
"heapUsedBytes": 86876300,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 573.21,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2075.808000000052,
"styleRecalcs": 65,
"styleRecalcDurationMs": 7.984000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1208.969,
"heapDeltaBytes": 17348768,
"heapUsedBytes": 83545456,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 571.7520000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3207.377000000065,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.334999999999999,
"layouts": 60,
"layoutDurationMs": 11.443,
"taskDurationMs": 1367.7830000000001,
"heapDeltaBytes": 13037472,
"heapUsedBytes": 80859424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 605.5240000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3127.287000000024,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.161,
"layouts": 60,
"layoutDurationMs": 10.879,
"taskDurationMs": 1285.742,
"heapDeltaBytes": 9458260,
"heapUsedBytes": 75976076,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 555.421,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2162.7429999999777,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.392999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1400.619,
"heapDeltaBytes": 13336952,
"heapUsedBytes": 80529688,
"domNodes": 4,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 657.483,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2254.462999999987,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1395.945,
"heapDeltaBytes": 13951508,
"heapUsedBytes": 80873656,
"domNodes": 6,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 663.4730000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.516999999998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.257000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.84100000000007,
"heapDeltaBytes": 21834864,
"heapUsedBytes": 87558592,
"domNodes": -266,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.733,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.7790000001423,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.14199999999994,
"heapDeltaBytes": -15495632,
"heapUsedBytes": 86977444,
"domNodes": -268,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 28.153,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.70000000004256,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.228999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.154,
"heapDeltaBytes": 14812504,
"heapUsedBytes": 87173272,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 97.505,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 480.70499999994354,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.848,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.996,
"heapDeltaBytes": 14790848,
"heapUsedBytes": 87528308,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 96.105,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.791000000031,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.9899999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.58400000000006,
"heapDeltaBytes": 1268636,
"heapUsedBytes": 72887764,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.988999999999999,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.8590000000295,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.739999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.652,
"heapDeltaBytes": 53776,
"heapUsedBytes": 71612580,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.534000000000001,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.6979999998975,
"styleRecalcs": 78,
"styleRecalcDurationMs": 24.909999999999993,
"layouts": 18,
"layoutDurationMs": 3.536,
"taskDurationMs": 630.952,
"heapDeltaBytes": -10828268,
"heapUsedBytes": 61756944,
"domNodes": -296,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 72.865,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.8950000000605,
"styleRecalcs": 79,
"styleRecalcDurationMs": 29.953,
"layouts": 18,
"layoutDurationMs": 4.149,
"taskDurationMs": 598.6830000000001,
"heapDeltaBytes": -13100652,
"heapUsedBytes": 59537000,
"domNodes": -293,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 78.092,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.2189999999555,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.332000000000008,
"layouts": 16,
"layoutDurationMs": 10.741,
"taskDurationMs": 729.1829999999999,
"heapDeltaBytes": -7355204,
"heapUsedBytes": 86514692,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 22.853000000000005,
"eventListeners": 2381,
"totalBlockingTimeMs": 116,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8155.979000000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 28.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4328.233,
"heapDeltaBytes": 5410616,
"heapUsedBytes": 80826344,
"domNodes": -270,
"jsHeapTotalBytes": 667648,
"scriptDurationMs": 1884.234,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8133.671999999933,
"styleRecalcs": 249,
"styleRecalcDurationMs": 28.093000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4328.17,
"heapDeltaBytes": 8391004,
"heapUsedBytes": 84056988,
"domNodes": -267,
"jsHeapTotalBytes": -1167360,
"scriptDurationMs": 1878.3159999999998,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12689.959000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11944.73,
"heapDeltaBytes": -41127904,
"heapUsedBytes": 174094344,
"domNodes": -6548,
"jsHeapTotalBytes": 1585152,
"scriptDurationMs": 221.858,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12626.035000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11995.078,
"heapDeltaBytes": -13755136,
"heapUsedBytes": 174257336,
"domNodes": -6548,
"jsHeapTotalBytes": 1327104,
"scriptDurationMs": 216.329,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15369.076999999947,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.056999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14848.641999999998,
"heapDeltaBytes": -37965676,
"heapUsedBytes": 166112480,
"domNodes": -6548,
"jsHeapTotalBytes": -266240,
"scriptDurationMs": 745.6279999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15562.15300000008,
"styleRecalcs": 82,
"styleRecalcDurationMs": 14.039999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15047.951000000001,
"heapDeltaBytes": -44295848,
"heapUsedBytes": 158954176,
"domNodes": -6556,
"jsHeapTotalBytes": -5562368,
"scriptDurationMs": 789.808,
"eventListeners": -7475,
"totalBlockingTimeMs": 101,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4367.681999999945,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.755,
"layouts": 20,
"layoutDurationMs": 22.289999999999992,
"taskDurationMs": 4243.992,
"heapDeltaBytes": -27869368,
"heapUsedBytes": 176722084,
"domNodes": -6548,
"jsHeapTotalBytes": 12369920,
"scriptDurationMs": 77.35499999999999,
"eventListeners": -7473,
"totalBlockingTimeMs": 117,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4484.66899999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.89899999999999,
"layouts": 20,
"layoutDurationMs": 27.22999999999999,
"taskDurationMs": 4315.133000000001,
"heapDeltaBytes": -28956208,
"heapUsedBytes": 174620816,
"domNodes": -6548,
"jsHeapTotalBytes": 10829824,
"scriptDurationMs": 96.84300000000002,
"eventListeners": -7473,
"totalBlockingTimeMs": 140,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 453.324000000066,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.428,
"layouts": 4,
"layoutDurationMs": 1.8509999999999998,
"taskDurationMs": 103.987,
"heapDeltaBytes": 5320344,
"heapUsedBytes": 74001388,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.786000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 439.40299999985655,
"styleRecalcs": 18,
"styleRecalcDurationMs": 16.54,
"layouts": 3,
"layoutDurationMs": 1.314,
"taskDurationMs": 90.834,
"heapDeltaBytes": 5263940,
"heapUsedBytes": 73039440,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.265999999999998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.53 #16737 +/- ##
=============================================
Coverage ? 83.28%
=============================================
Files ? 2023
Lines ? 117015
Branches ? 32452
=============================================
Hits ? 97458
Misses ? 19202
Partials ? 355
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
I compared this backport of #16464 with merged source commit 32577b5. The stable patch IDs and both changed files match exactly, including all regression tests. pnpm typecheck, scoped ESLint, scoped oxfmt, and 45 targeted tests passed. The release branch has the same pre-fix production blob used to verify the regression tests fail before the fix. Hosted checks are green. I found no blocking issues.
Backport of #16464 to
cloud/1.53Automatically created by backport workflow.