Repository navigation
test: add lint prohibition on comfyPage.setup() re-calls in tests - #16733
Conversation
comfyPageFixture already calls comfyPage.setup() once per test before the test body runs. A test that calls it again re-navigates and re-clears storage on top of that, which AustinMroz identified as the source of video-recording timeouts on #16711. DrJKL asked for a lint prohibition in the same thread; this adds it as an oxlint rule scoped to browser_tests/tests/**/*.spec.ts, with the 72 pre-existing call sites grandfathered via oxlint-disable-next-line comments (not fixed in this pass, since removing them changes test startup semantics case by case). Closes evfail-23. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Comment |
🎭 Playwright: ✅ 1916 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T05:16:49.718Z",
"gitSha": "5096cb9becd45479a152a9cc6e571670ad1d93c9",
"branch": "evfail-23-comfypage-setup-lint",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.4260000000154,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.437,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.3200000000001,
"heapDeltaBytes": -11946940,
"heapUsedBytes": 57803940,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.352999999999996,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2079.121999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.082999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.48,
"heapDeltaBytes": 1347924,
"heapUsedBytes": 71788836,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 11.123000000000001,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2092.252999999971,
"styleRecalcs": 82,
"styleRecalcDurationMs": 46.006,
"layouts": 14,
"layoutDurationMs": 4.824,
"taskDurationMs": 1035.5140000000001,
"heapDeltaBytes": -6905452,
"heapUsedBytes": 63876528,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 181.25000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.5429999999797,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.11000000000001,
"layouts": 14,
"layoutDurationMs": 4.308,
"taskDurationMs": 904.6039999999999,
"heapDeltaBytes": 4002224,
"heapUsedBytes": 73867764,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 163.892,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.7599999999775,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.556,
"layouts": 6,
"layoutDurationMs": 0.9679999999999999,
"taskDurationMs": 355.273,
"heapDeltaBytes": 5088044,
"heapUsedBytes": 75727428,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.901000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.7970000000905,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.054000000000002,
"layouts": 6,
"layoutDurationMs": 1.1010000000000002,
"taskDurationMs": 390.49699999999996,
"heapDeltaBytes": 5092852,
"heapUsedBytes": 75733848,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.477000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 645.5490000000168,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.573,
"heapDeltaBytes": -8145684,
"heapUsedBytes": 62503360,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 159.954,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 729.0520000000242,
"styleRecalcs": 11,
"styleRecalcDurationMs": 13.728999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.04900000000004,
"heapDeltaBytes": 18250468,
"heapUsedBytes": 88022016,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 162.87099999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2044.271999999978,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.822000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.746,
"heapDeltaBytes": 11458504,
"heapUsedBytes": 87321352,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 33.04899999999999,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2060.084999999958,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.143000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.567,
"heapDeltaBytes": 11057092,
"heapUsedBytes": 86668816,
"domNodes": -273,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 37.80800000000001,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2239.1999999999825,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.672999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.781,
"heapDeltaBytes": 23193988,
"heapUsedBytes": 88670008,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 781.117,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2386.588999999958,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.097999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1647.4550000000002,
"heapDeltaBytes": 21828212,
"heapUsedBytes": 87675392,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 798.3679999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3658.6869999999863,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.024999999999999,
"layouts": 60,
"layoutDurationMs": 12.140999999999998,
"taskDurationMs": 1707.263,
"heapDeltaBytes": 8505860,
"heapUsedBytes": 75313544,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 760.3270000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3662.93399999995,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.005,
"layouts": 60,
"layoutDurationMs": 11.922,
"taskDurationMs": 1734.325,
"heapDeltaBytes": 11756888,
"heapUsedBytes": 79358776,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 767.2489999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3049.4089999999687,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.858000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1930.2140000000004,
"heapDeltaBytes": 21947772,
"heapUsedBytes": 89323416,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 946.886,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3103.8299999999026,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.722000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1932.863,
"heapDeltaBytes": 24242200,
"heapUsedBytes": 91017796,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 938.8149999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.9899999999784,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.379,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.1669999999999,
"heapDeltaBytes": 22331232,
"heapUsedBytes": 87708564,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.784000000000006,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.6849999999058,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.313000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.2400000000001,
"heapDeltaBytes": 21899724,
"heapUsedBytes": 87686300,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.235,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.3899999999853,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.3329999999999,
"heapDeltaBytes": 14901372,
"heapUsedBytes": 87777516,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 137.877,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.5149999999448,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.83,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.3910000000001,
"heapDeltaBytes": 15157928,
"heapUsedBytes": 87649876,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.27700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2005.8650000000284,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.988000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.06800000000004,
"heapDeltaBytes": -9233148,
"heapUsedBytes": 63174532,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.855999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.4670000000297,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.048000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.6260000000001,
"heapDeltaBytes": -7901836,
"heapUsedBytes": 64881888,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.168,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.2030000000123,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.452,
"layouts": 18,
"layoutDurationMs": 5.761,
"taskDurationMs": 827.1930000000001,
"heapDeltaBytes": 2509228,
"heapUsedBytes": 75427892,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 111.21,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.1859999999178,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.05200000000001,
"layouts": 18,
"layoutDurationMs": 6.1259999999999994,
"taskDurationMs": 841.501,
"heapDeltaBytes": -12116724,
"heapUsedBytes": 60292592,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 113.137,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.3889999999656,
"styleRecalcs": 18,
"styleRecalcDurationMs": 33.047,
"layouts": 14,
"layoutDurationMs": 15.263999999999996,
"taskDurationMs": 906.5600000000001,
"heapDeltaBytes": -1571688,
"heapUsedBytes": 96283236,
"domNodes": 13751,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 29.784,
"eventListeners": 2381,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8734.487000000001,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.206,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5873.329,
"heapDeltaBytes": -11306560,
"heapUsedBytes": 89110900,
"domNodes": -270,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 2646.2270000000003,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8940.991000000053,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.185,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6072.280999999999,
"heapDeltaBytes": 17989144,
"heapUsedBytes": 92956164,
"domNodes": -270,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 2699.081,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16854.00900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16404.383,
"heapDeltaBytes": -34493676,
"heapUsedBytes": 174321000,
"domNodes": -6548,
"jsHeapTotalBytes": -5378048,
"scriptDurationMs": 291.65599999999995,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17612.51600000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16896.809999999998,
"heapDeltaBytes": -34467676,
"heapUsedBytes": 176270556,
"domNodes": -6548,
"jsHeapTotalBytes": 3903488,
"scriptDurationMs": 280.81100000000004,
"eventListeners": -7469,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20769.470000000012,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.645999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20356.230999999996,
"heapDeltaBytes": -28237364,
"heapUsedBytes": 176272476,
"domNodes": -6548,
"jsHeapTotalBytes": 729088,
"scriptDurationMs": 923.578,
"eventListeners": -7471,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21019.08400000002,
"styleRecalcs": 165,
"styleRecalcDurationMs": 18.630000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20782.934,
"heapDeltaBytes": -24942412,
"heapUsedBytes": 177613432,
"domNodes": -6548,
"jsHeapTotalBytes": 3657728,
"scriptDurationMs": 887.518,
"eventListeners": -7471,
"totalBlockingTimeMs": 32,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6140.631000000041,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.11400000000002,
"layouts": 20,
"layoutDurationMs": 22.348999999999993,
"taskDurationMs": 6004.015999999999,
"heapDeltaBytes": -40203008,
"heapUsedBytes": 173582424,
"domNodes": -6548,
"jsHeapTotalBytes": -471040,
"scriptDurationMs": 134.07200000000003,
"eventListeners": -7471,
"totalBlockingTimeMs": 387,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6383.059000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.21500000000003,
"layouts": 20,
"layoutDurationMs": 23.361000000000008,
"taskDurationMs": 6238.249000000001,
"heapDeltaBytes": -36040952,
"heapUsedBytes": 172867288,
"domNodes": -6553,
"jsHeapTotalBytes": 4161536,
"scriptDurationMs": 139.656,
"eventListeners": -7469,
"totalBlockingTimeMs": 357,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8502.166999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8228.518999999998,
"heapDeltaBytes": 22801972,
"heapUsedBytes": 179792848,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 134.146,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9000.329999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8603.383000000002,
"heapDeltaBytes": 3132168,
"heapUsedBytes": 180283360,
"domNodes": 0,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 143.085,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 480.55599999997867,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.529999999999998,
"layouts": 4,
"layoutDurationMs": 1.9269999999999998,
"taskDurationMs": 127.109,
"heapDeltaBytes": 5152508,
"heapUsedBytes": 73225608,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.426,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 102.65099999992344,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.128000000000002,
"layouts": 2,
"layoutDurationMs": 0.798,
"taskDurationMs": 72.668,
"heapDeltaBytes": 3018028,
"heapUsedBytes": 71541208,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.083,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16733 +/- ##
==========================================
+ Coverage 80.95% 82.56% +1.60%
==========================================
Files 2451 2033 -418
Lines 125491 118132 -7359
Branches 31575 31766 +191
==========================================
- Hits 101597 97531 -4066
+ Misses 23382 20424 -2958
+ Partials 512 177 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified locally on fe31c24: the plugin test passes (2/2), oxlint is clean across browser_tests/tests and tools/oxlint-plugins (349 files), and probe files confirm the override fires on browser_tests/tests//.spec.ts and apps//e2e//*.spec.ts while staying silent on a fixture file with the same call. The rule itself is sound; the two notes are about what the test covers and how the suppressions read upstream.
suggestion: the test lints a tmpdir against a bespoke config that enables the rule directly, so it proves the AST match but nothing about the .oxlintrc.json override, which is where this rule's correctness actually lives. Fixtures own the one legitimate comfyPage.setup() call, so a widened or dropped override would either flag ComfyPage.ts and the auth fixtures or silently stop gating specs, and the test would stay green either way. comfyIngestTypes.test.ts already establishes the alternative: write probes into the trees pnpm lint sees and run oxlint with the repo config. Deleting the override with that harness in place fails 2 of 3 cases.
question: the 72 grandfather comments cite "tracked by evfail-23", which is an identifier from an internal tracker rather than anything an upstream contributor can resolve. Would it be worth pointing them at the #16711 review thread the rule header already links, or at a GitHub issue for the migration, so the follow-up is discoverable from the repo itself?
Full context for agent readers
Round 54 of the HPS PR-review loop. Evidence: browser_tests/fixtures/ComfyPage.ts line 686 calls comfyPage.setup() inside comfyPageFixture after seeding initialFeatureFlags, and the initialSettings / initialFeatureFlags fixture options at lines 559-571 exist, so the remedy the rule message suggests is real. rg counts 72 suppression comments across 30 spec files, all in the exact same form and each on the line immediately above the call; the remaining comfyPage.setup occurrences under browser_tests are in fixtures (ComfyPage.ts, workspaceRailAuthFixture.ts, localAuthFixture.ts, apiKeyAuthFixture.ts, utils/flashDetector.ts, helpers/FeatureFlagHelper.ts), which the override intentionally excludes. linearMode.spec.ts matches rg for comfyPage.setup only via setupUser. No comfyPage.setup calls exist under apps/ today, so the apps/*/e2e glob is forward-looking; a probe there fires as expected.
Pushed d22fee2 on this branch: comfyPageSetup.test.ts now writes probes into browser_tests/tests/comfy_page_setup_probes (reported.spec.ts, accepted.spec.ts) and browser_tests/fixtures/comfy_page_setup_probes/fixture.ts, lints them through the repo .oxlintrc.json, and asserts error severity on the spec, zero findings on the accepted spec and the fixture, and exactly one finding total. With the override removed from .oxlintrc.json the suite fails 2 of 3; with it present 3/3 pass. eslint, oxlint, oxfmt clean on the file; probe dirs are removed in afterAll and the tree is clean afterwards.
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Walked the ratchet against the current head: severity is error and every spec sits inside the two globs. The open thread is your own question about the tracker id, not an objection. Nothing to add.
|
queue notice from the approve-with-comments follow-up audit: this merged with one review thread still unresolved, so it is tracked as the open item is the |
|
Done — #16859 is the migration tracking issue, and #16861 re-points all 72 Full context for agent readersThe suggestion half of this review was already addressed by d22fee2 before merge (probes through the repo .oxlintrc.json; deleting the override fails 2 of 3 cases). This reply resolves the remaining question: the internal |
comfyPageFixturealready callscomfyPage.setup()once per test before the test body runs (browser_tests/fixtures/ComfyPage.ts). A test that calls it again re-navigates and re-clears storage on top of that automatic setup.#16711 review: AustinMroz traced video-recording test timeouts to exactly this pattern ("naughty tests that call
comfyPage.setup()"). Follow-up: DrJKL asked for a lint prohibition, but the merged commit (44c4785f) didn't add one and no PR back-referenced #16711 for it.This adds
comfy/no-comfy-page-setup-call, an oxlint rule scoped tobrowser_tests/tests/**/*.spec.tsandapps/*/e2e/**/*.spec.ts, flagging anycomfyPage.setup(...)call. The 72 pre-existing call sites across 30 spec files are grandfathered withoxlint-disable-next-linecomments (matching the repo's existing suppression convention) rather than fixed in this pass — removing each one changes that test's startup semantics case by case and needs per-test review, which is out of scope for landing the lint gate itself.Evidence
Pre-commit gates (lint, typecheck, typecheck:browser) all passed on this branch.