Repository navigation
test(billing): assert real i18n interpolation in the add-payment preview - #16722
Conversation
The add-payment preview test mocked vue-i18n wholesale, so the renewal assertion matched a synthetic 'key|name=value' string that the mock itself produced. Real Vue I18n interpolation was never exercised: a broken placeholder in the production message would not have failed anything. Supply the renewal messages through a real createI18n plugin, matching SubscriptionTransitionPreviewWorkspace.test.ts in the same directory. Every other key still renders as itself, so the remaining key-based assertions are unchanged.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1913 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T00:21:10.761Z",
"gitSha": "1344ca8e19da2b238142ca7484fab1b51e1a6344",
"branch": "dante01yoon/addpay-preview-real-i18n",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2150.388000000021,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.310000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.2070000000001,
"heapDeltaBytes": -9744072,
"heapUsedBytes": 60652844,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.742999999999997,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2027.4480000000494,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.672999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.452,
"heapDeltaBytes": 9257200,
"heapUsedBytes": 79106568,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.562999999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1987.3589999999695,
"styleRecalcs": 80,
"styleRecalcDurationMs": 46.563,
"layouts": 14,
"layoutDurationMs": 5.079000000000001,
"taskDurationMs": 1040.124,
"heapDeltaBytes": -7550432,
"heapUsedBytes": 62898344,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 163.761,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1941.5380000000368,
"styleRecalcs": 78,
"styleRecalcDurationMs": 46.07,
"layouts": 14,
"layoutDurationMs": 5.09,
"taskDurationMs": 929.9069999999999,
"heapDeltaBytes": 9389056,
"heapUsedBytes": 78969728,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 156.088,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.952000000007,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.215,
"layouts": 6,
"layoutDurationMs": 1.354,
"taskDurationMs": 411.034,
"heapDeltaBytes": 5071924,
"heapUsedBytes": 75881876,
"domNodes": 74,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.98,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.0669999999536,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.694,
"layouts": 6,
"layoutDurationMs": 1.2609999999999997,
"taskDurationMs": 390.406,
"heapDeltaBytes": 5138668,
"heapUsedBytes": 75400492,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.146000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 721.1269999999672,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.594000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.886,
"heapDeltaBytes": -7849444,
"heapUsedBytes": 62923924,
"domNodes": 14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 156.524,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 694.7250000000622,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.694,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.01000000000005,
"heapDeltaBytes": -7883752,
"heapUsedBytes": 62867508,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 162.138,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.074999999968,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.013000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.9839999999999,
"heapDeltaBytes": -13540668,
"heapUsedBytes": 87413300,
"domNodes": -267,
"jsHeapTotalBytes": -1634304,
"scriptDurationMs": 36.767999999999994,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2066.816000000017,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7920000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 645.4599999999999,
"heapDeltaBytes": -13750496,
"heapUsedBytes": 87361504,
"domNodes": -270,
"jsHeapTotalBytes": -61440,
"scriptDurationMs": 36.644999999999996,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2435.6940000000122,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.923999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1698.694,
"heapDeltaBytes": 23478224,
"heapUsedBytes": 88879704,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 797.781,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2148.449000000028,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.563000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1595.788,
"heapDeltaBytes": 17875632,
"heapUsedBytes": 83901952,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 763.293,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3721.57100000004,
"styleRecalcs": 60,
"styleRecalcDurationMs": 12.266999999999996,
"layouts": 60,
"layoutDurationMs": 14.693000000000001,
"taskDurationMs": 1809.9979999999998,
"heapDeltaBytes": 7710136,
"heapUsedBytes": 75536072,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 802.7160000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3625.448000000006,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.553999999999998,
"layouts": 60,
"layoutDurationMs": 13.819999999999999,
"taskDurationMs": 1755.48,
"heapDeltaBytes": 11756884,
"heapUsedBytes": 79377284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.0509999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3141.914999999983,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.371999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2040.7340000000002,
"heapDeltaBytes": 22715196,
"heapUsedBytes": 89681976,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 995.8710000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3122.4489999999605,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.784000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1978.2559999999999,
"heapDeltaBytes": 21987980,
"heapUsedBytes": 89127972,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 958.182,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.1290000000454,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.798,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 735.425,
"heapDeltaBytes": 10784608,
"heapUsedBytes": 86817760,
"domNodes": -272,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 44.21,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2003.2720000000381,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.732,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.0399999999998,
"heapDeltaBytes": 22200928,
"heapUsedBytes": 88255656,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.62,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 666.5780000000154,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.385000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.75299999999993,
"heapDeltaBytes": 15250656,
"heapUsedBytes": 87717196,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 150.337,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.8129999999264,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.302000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.52500000000003,
"heapDeltaBytes": 15111080,
"heapUsedBytes": 87958568,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.465,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2052.0799999999895,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.519000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.962,
"heapDeltaBytes": -6692128,
"heapUsedBytes": 65992516,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.141000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.4059999999372,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.813999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.7560000000001,
"heapDeltaBytes": -8770408,
"heapUsedBytes": 64079204,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 8.234000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1792.1440000000075,
"styleRecalcs": 79,
"styleRecalcDurationMs": 42.373999999999995,
"layouts": 18,
"layoutDurationMs": 6.558,
"taskDurationMs": 923.3679999999999,
"heapDeltaBytes": 5162608,
"heapUsedBytes": 78245624,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 117.152,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.9289999999237,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.90200000000001,
"layouts": 18,
"layoutDurationMs": 5.853000000000001,
"taskDurationMs": 849.1560000000001,
"heapDeltaBytes": -12164760,
"heapUsedBytes": 60756052,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 109.90899999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.9379999999728,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.363000000000003,
"layouts": 14,
"layoutDurationMs": 14.585999999999999,
"taskDurationMs": 936.5999999999999,
"heapDeltaBytes": -5410384,
"heapUsedBytes": 86775256,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.566000000000003,
"eventListeners": 2381,
"totalBlockingTimeMs": 130,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9352.491999999984,
"styleRecalcs": 246,
"styleRecalcDurationMs": 43.865,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6438.961,
"heapDeltaBytes": -15898708,
"heapUsedBytes": 84779268,
"domNodes": -268,
"jsHeapTotalBytes": -655360,
"scriptDurationMs": 2783.9449999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8464.976999999977,
"styleRecalcs": 247,
"styleRecalcDurationMs": 46.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6080.6140000000005,
"heapDeltaBytes": -10107128,
"heapUsedBytes": 91103796,
"domNodes": -268,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 2690.734,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18653.197999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18374.915999999997,
"heapDeltaBytes": -27851092,
"heapUsedBytes": 176030124,
"domNodes": -6548,
"jsHeapTotalBytes": -4861952,
"scriptDurationMs": 320.353,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18727.201000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17981.945,
"heapDeltaBytes": -41686496,
"heapUsedBytes": 162828076,
"domNodes": -6550,
"jsHeapTotalBytes": -5648384,
"scriptDurationMs": 363.069,
"eventListeners": -7471,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23668.11000000001,
"styleRecalcs": 176,
"styleRecalcDurationMs": 26.04999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23495.644,
"heapDeltaBytes": -37569496,
"heapUsedBytes": 166739568,
"domNodes": -6548,
"jsHeapTotalBytes": -4145152,
"scriptDurationMs": 960.2219999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 174,
"frameDurationMs": 17.779999999999806,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 23325.864000000023,
"styleRecalcs": 179,
"styleRecalcDurationMs": 24.170000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23141.58,
"heapDeltaBytes": -24802396,
"heapUsedBytes": 185167096,
"domNodes": -6548,
"jsHeapTotalBytes": -5193728,
"scriptDurationMs": 967.855,
"eventListeners": -7467,
"totalBlockingTimeMs": 188,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6657.304999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.94299999999998,
"layouts": 20,
"layoutDurationMs": 26.580999999999992,
"taskDurationMs": 6588.636,
"heapDeltaBytes": -28229740,
"heapUsedBytes": 181880956,
"domNodes": -6548,
"jsHeapTotalBytes": 13225984,
"scriptDurationMs": 137.665,
"eventListeners": -7469,
"totalBlockingTimeMs": 526,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6594.856999999934,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.92499999999997,
"layouts": 20,
"layoutDurationMs": 24.996999999999993,
"taskDurationMs": 6547.205,
"heapDeltaBytes": -23991144,
"heapUsedBytes": 181806748,
"domNodes": -6548,
"jsHeapTotalBytes": 19341312,
"scriptDurationMs": 123.61999999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 444,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9331.867000000102,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8943.452000000001,
"heapDeltaBytes": 1356292,
"heapUsedBytes": 174471636,
"domNodes": 0,
"jsHeapTotalBytes": -6553600,
"scriptDurationMs": 187.74599999999998,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9202.642999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8932.650000000003,
"heapDeltaBytes": 5511020,
"heapUsedBytes": 176979332,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 149.516,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 504.69300000008843,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.817999999999998,
"layouts": 4,
"layoutDurationMs": 2.269,
"taskDurationMs": 128.656,
"heapDeltaBytes": 5144832,
"heapUsedBytes": 73773888,
"domNodes": 152,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.893,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 461.5999999999758,
"styleRecalcs": 16,
"styleRecalcDurationMs": 23.849000000000004,
"layouts": 2,
"layoutDurationMs": 1.3330000000000002,
"taskDurationMs": 109.85000000000001,
"heapDeltaBytes": 4992132,
"heapUsedBytes": 73477456,
"domNodes": 142,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.971,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe test replaces mocked translation behavior with a real English ChangesPayment preview i18n test
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This test-only change improves coverage of real i18n interpolation without changing production behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed file and PR description are available, but the PR title and actual commit subjects are not provided. The custom check requires commit subjects when available and explicitly requires INCONCLUSIVE if commit subjects are unavailable. Therefore, the bug-fix signal cannot be verified. Full details: Website End-To-End Regression CoverageExplanation The PR changes only Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed-file list contains only Full details: Description checkExplanation The description explains the problem, implementation, review focus, testing evidence, regression coverage, and why screenshots are not applicable. It does not use the template's exact Changes headings, but it provides the required information and is mostly complete.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16722 +/- ##
==========================================
+ Coverage 80.89% 82.47% +1.57%
==========================================
Files 2450 2032 -418
Lines 125009 117547 -7462
Branches 31552 31544 -8
==========================================
- Hits 101131 96942 -4189
+ Misses 23365 20427 -2938
+ Partials 513 178 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
The add-payment preview test mocked
vue-i18nwholesale, so its renewal assertion matched a string the mock itself had fabricated — real Vue I18n interpolation was never exercised. This supplies the renewal messages through a realcreateI18nplugin instead.Root cause
SubscriptionAddPaymentPreviewWorkspace.test.tsreplaced the whole module:and asserted on the shape that mock produced:
Both sides of that assertion come from the mock. The production message
subscription.preview.renewsAt("Renews at {amount} on {date}. Cancel anytime.") was never rendered, so the test could not fail on a broken placeholder, a renamed interpolation variable, or a malformed message — the exact defects it looks like it covers.The component reaches i18n three ways (
$tacross the template,t()with named interpolation forrenewsAt/renewsAtAmount, andn()for amounts), and mocking the module stubbed all three.What changed
Drop the module mock; register a real plugin, mirroring
SubscriptionTransitionPreviewWorkspace.test.tsin the same directory:Only the renewal messages are supplied. Vue I18n renders a missing key as the key itself, so the other 17 tests keep their key-based assertions untouched; one assertion becomes the rendered sentence.
Message text is copied verbatim from
src/locales/en/main.json.Review focus
Mutation-checked rather than assumed. Changing the message to
"... on {wrongVar} ..."fails exactly one test:Under the old mock that mutation was invisible. Reverted, 18/18 pass.
n()needs nonumberFormats: with none configured Vue I18n falls back toIntl.NumberFormat("en"), matching thetoLocaleString("en-US")the mock used.Test-only; no production code and no UI change, so there is no AS-IS/TO-BE to screenshot.
pnpm typecheck,pnpm lint,pnpm formatclean.Raised in review on #16515, which was closed in favour of #16517; the code shipped and the comment was never addressed. Original thread: #16515 (comment)
Regression coverage
Recording this explicitly, since the
End-To-End Regression Coverage For Fixespre-merge check came back inconclusive for want of the title and commit subjects:test(billing): assert real i18n interpolation in the add-payment previewtest(billing): assert real i18n interpolation in the add-payment previewNeither carries bug-fix language, and that is accurate: this is a
test:change with no production code in the diff. The only file touched issrc/platform/workspace/components/SubscriptionAddPaymentPreviewWorkspace.test.ts.No
browser_tests/change accompanies it, and none is warranted. Nothing about the app's runtime behaviour changes, so there is no regression for an E2E test to pin — the defect being closed is that an existing unit assertion could not fail, and the fix is that same unit test now exercising real Vue I18n interpolation. That is verified by the mutation check above (broken placeholder → 1 failed, 17 passed), which is a stronger guard than an E2E test would give here and lives at the right level.Playwright is unaffected and green: 1913 passed, 0 failed.