Skip to content

[backport cloud/1.52] fix(billing): obtain a server quote before the team confirmation step - #16713

Merged
comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16647-to-cloud-1.52
Sep 3, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16647-to-cloud-1.52

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16647 to cloud/1.52

Automatically created by backport workflow.

…#16647)

## Summary

With embedded checkout off, the Team confirmation step opened before any
quote was requested — so "Total due today" rendered with no amount, and
a plan change that could not be priced emptied the dialog entirely.

Found on staging during 1.52 QA (Denys), after #16517 fixed the same
symptom for Personal.

## Root cause

`handleSubscribeTeamClick`'s legacy branch set the step *before*
fetching, and then usually never fetched:

```ts
checkoutStep.value = 'preview'                              // step first
const needsPreview = payload.isChange || isSubscriptionCancelled()
if (!needsPreview || !payload.stop.id) return               // fresh subscribe: no request at all
```

`previewData` is reset to `null` immediately above this, so a fresh team
subscribe reached the confirmation with no quote.
`SubscriptionAddPaymentPreviewWorkspace` renders the total from
`previewData`, so the amount and the whole renewal line came out empty.
Everything else on that screen ($665, billing cycle, refill credits) is
derived from the `teamPlan` prop, which is why the screen looked
otherwise healthy.

Personal was never affected: `handleSubscribeClick` calls
`previewSubscribe` on both sides of the flag and only then advances the
step. So #16517 (legacy quote formatting) could not have fixed Team —
there was no preview to format.

The same early step change produced the empty modal on Team → Change
plan. `previewVariant` returns `'team-change'` from `checkoutType`
alone, and the two exits at `if (!payload.stop.id) return` and `if
(!isSubscriptionCancelled()) return` leave `previewData` null.
`SubscriptionTransitionPreviewWorkspace` declares `previewData:
PreviewSubscribeResponse` (required) and dereferences it during setup
(`previewData.promotion_code`), so setup throws and only the dialog
chrome renders. The `:preview-data="previewData!"` assertion at the call
site is what kept this off the type checker.

## Changes

- **What**: the legacy team path fetches and installs the preview first,
and advances to the confirmation only when `isUsableTeamPreview` accepts
it — otherwise it reports the failure and stays on pricing, matching the
personal and embedded paths. Removed the `previewData!` assertions so a
null preview can no longer reach a required prop. The total row is
omitted rather than rendered blank when nothing can price it (the
id-less OSS stop, the one case with no server quote available).
- **Breaking**: a preview failure now blocks a fresh team subscribe
instead of showing an unpriced confirmation. This matches what the
flag-on path already does.

## Review Focus

`isUsableTeamPreview` keeps the three acceptance rules that were
previously inline and adds the new-subscription case, which had no rule
because it never fetched: cancelled needs a reactivation-capable
preview, a change needs an existing-plan transition, a new subscribe
needs any allowed preview.

Worth knowing for the release call: `embeddedCheckoutEnabled` appears
exactly once in `useSubscriptionCheckout.test.ts` — as the `setup()`
default of `true`. Every one of the 131 existing tests ran the flag-on
branch, so the entire legacy branch shipped uncovered. That is the
actual reason this reached staging, and the four new tests are scoped to
it.

Amounts stay server-resolved throughout; nothing here derives a price
from `teamPlan`.

- Fixes FE-1974

## Screenshots (if applicable)

Captured against a cloud-distribution dev server with embedded checkout
off, driving the real flow: Settings → Plan & Credits → Change plan →
pick a different Team credit stop → Change plan.

### AS IS — `main`

![AS IS: the change-plan confirmation is an empty "Choose a Plan"
box](https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-16647-screenshots/docs-assets/pr-16647/asis-change-plan-empty.png)

The step is entered with `previewData` still null.
`SubscriptionTransitionPreviewWorkspace` declares that prop required and
dereferences it during setup, so setup throws and the body renders
nothing — only the shell's own header is left. This is the same failure
QA hit on staging.

### TO BE — this PR

> This shot still shows a duplicated "Choose a Plan" header and a second
back arrow. That is a separate defect, fixed in #16648 — it is left
visible here so this PR's own contribution is legible on its own.

![TO BE: the confirmation renders with Total due today priced from the
server](https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-16647-screenshots/docs-assets/pr-16647/tobe-change-plan-priced.png)

The preview is fetched and installed before the step is entered, so the
confirmation renders and `Total due today` is priced from the server's
legacy `cost_*` fields — $361.00 here, with the renewal line resolved
too.

### TO BE — with #16648 applied as well

![TO BE: a single header and one back action, with the amount
priced](https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-16647-screenshots/docs-assets/pr-16647/tobe-both-prs.png)

How the step looks once both PRs are in. They are two halves of the same
report and ship together for 1.52.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 11:39:19 PM UTC

Links

🎭 Playwright: ✅ 1983 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1962 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 142ms TBT · 98.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.8 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 54ms TBT · 184.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 493ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 72.9 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -151
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 35ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 72
canvas-mouse-sweep: task duration 853ms
canvas-mouse-sweep: script duration 110ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.6 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 356ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 62.8 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 397ms
dom-widget-clipping: script duration 57ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.2 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 594ms
large-graph-idle: script duration 13ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 64.3 MB
large-graph-idle: DOM nodes -280
large-graph-idle: event listeners -165
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1169ms
large-graph-pan: script duration 341ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.3 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1374ms
large-graph-zoom: script duration 386ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.3 MB
large-graph-zoom: DOM nodes -289
large-graph-zoom: event listeners -184
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1410ms
legacy-node-drag: script duration 459ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.1 MB
legacy-node-drag: DOM nodes 12
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 616ms
minimap-idle: script duration 16ms
minimap-idle: TBT 0ms
minimap-idle: heap used 65.3 MB
minimap-idle: DOM nodes -284
minimap-idle: event listeners -164
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 384ms
subgraph-dom-widget-clipping: script duration 115ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.3 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 479ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.7 MB
subgraph-idle: DOM nodes -283
subgraph-idle: event listeners -152
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 33ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 762ms
subgraph-mouse-sweep: script duration 83ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 76.8 MB
subgraph-mouse-sweep: DOM nodes -281
subgraph-mouse-sweep: event listeners -151
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 953ms
subgraph-transition-enter: script duration 16ms
subgraph-transition-enter: TBT 142ms
subgraph-transition-enter: heap used 98.5 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4109ms
viewport-pan-sweep: script duration 1043ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 72.0 MB
viewport-pan-sweep: DOM nodes -278
viewport-pan-sweep: event listeners -148
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16662ms
vue-large-graph-idle: script duration 116ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.8 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16389
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 20041ms
vue-large-graph-pan: script duration 406ms
vue-large-graph-pan: TBT 54ms
vue-large-graph-pan: heap used 184.2 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16386
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 93ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.7 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-02T23:50:31.647Z",
  "gitSha": "744176be36cd2ba22dff890573a433f593f1b83f",
  "branch": "backport-16647-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2031.351000000086,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.7920000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.73400000000004,
      "heapDeltaBytes": 14566348,
      "heapUsedBytes": 77358332,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 6.810999999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2060.8240000001388,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.397000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.323,
      "heapDeltaBytes": 13128536,
      "heapUsedBytes": 75493076,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 6.43,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1857.966000000033,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 37.036,
      "layouts": 12,
      "layoutDurationMs": 3.8329999999999997,
      "taskDurationMs": 851.341,
      "heapDeltaBytes": 18604056,
      "heapUsedBytes": 81216420,
      "domNodes": -278,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 110.246,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1859.1449999998986,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 33.339,
      "layouts": 12,
      "layoutDurationMs": 3.374,
      "taskDurationMs": 855.159,
      "heapDeltaBytes": -5070140,
      "heapUsedBytes": 58399152,
      "domNodes": -283,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 110.68,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1665.4969999999594,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 14.423,
      "layouts": 6,
      "layoutDurationMs": 0.5520000000000002,
      "taskDurationMs": 339.69899999999996,
      "heapDeltaBytes": 3668244,
      "heapUsedBytes": 66464324,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 8.357000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.941000000119,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.515000000000004,
      "layouts": 6,
      "layoutDurationMs": 0.6379999999999999,
      "taskDurationMs": 372.69700000000006,
      "heapDeltaBytes": 3443276,
      "heapUsedBytes": 65330012,
      "domNodes": 75,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 10.691,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 701.3710000001083,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.283999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.45200000000006,
      "heapDeltaBytes": 10973840,
      "heapUsedBytes": 73440212,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 59.12100000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 578.4410000001117,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.971000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.92500000000007,
      "heapDeltaBytes": 10811692,
      "heapUsedBytes": 73831360,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 55.672,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.3109999999979,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.289999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.6519999999999,
      "heapDeltaBytes": -12914616,
      "heapUsedBytes": 63391004,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 12.474000000000002,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.2310000000198,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.495,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 599.572,
      "heapDeltaBytes": -5889756,
      "heapUsedBytes": 71479328,
      "domNodes": -278,
      "jsHeapTotalBytes": -532480,
      "scriptDurationMs": 13.584999999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2183.3809999998266,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.856,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1168.858,
      "heapDeltaBytes": -14315300,
      "heapUsedBytes": 63969636,
      "domNodes": -283,
      "jsHeapTotalBytes": 2088960,
      "scriptDurationMs": 342.72799999999995,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2182.6840000001084,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.748,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1169.602,
      "heapDeltaBytes": 12632488,
      "heapUsedBytes": 89802196,
      "domNodes": -283,
      "jsHeapTotalBytes": 4935680,
      "scriptDurationMs": 338.494,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3195.1340000000528,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.858,
      "layouts": 60,
      "layoutDurationMs": 7.2,
      "taskDurationMs": 1395.484,
      "heapDeltaBytes": -11407224,
      "heapUsedBytes": 68170144,
      "domNodes": -289,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 389.274,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3184.966999999915,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.874999999999998,
      "layouts": 60,
      "layoutDurationMs": 6.7269999999999985,
      "taskDurationMs": 1352.97,
      "heapDeltaBytes": -11964068,
      "heapUsedBytes": 66653136,
      "domNodes": -288,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 382.509,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2272.0150000000103,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.348000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1417.4389999999999,
      "heapDeltaBytes": -17265316,
      "heapUsedBytes": 69955860,
      "domNodes": 14,
      "jsHeapTotalBytes": 9998336,
      "scriptDurationMs": 466.77799999999996,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2169.938000000002,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.511999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1401.6770000000001,
      "heapDeltaBytes": 11723024,
      "heapUsedBytes": 91772224,
      "domNodes": 10,
      "jsHeapTotalBytes": 7008256,
      "scriptDurationMs": 450.816,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2061.429000000089,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.529999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 590.7800000000001,
      "heapDeltaBytes": -11873732,
      "heapUsedBytes": 71558400,
      "domNodes": -283,
      "jsHeapTotalBytes": 3137536,
      "scriptDurationMs": 14.724,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2040.7089999998789,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.157,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 641.038,
      "heapDeltaBytes": -12721756,
      "heapUsedBytes": 65459964,
      "domNodes": -285,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 16.736999999999995,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 545.8959999998569,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.573,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.88700000000006,
      "heapDeltaBytes": 11416256,
      "heapUsedBytes": 74530660,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 111.014,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 607.4699999999211,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.384,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.636,
      "heapDeltaBytes": 11967988,
      "heapUsedBytes": 75056044,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 118.347,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2003.2600000001821,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.690999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.138,
      "heapDeltaBytes": 17889016,
      "heapUsedBytes": 79889236,
      "domNodes": -284,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 5.861999999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2056.810999999925,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.567000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.58,
      "heapDeltaBytes": -7303124,
      "heapUsedBytes": 55796488,
      "domNodes": -281,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 6.185999999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.6669999999776,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 33.00899999999999,
      "layouts": 16,
      "layoutDurationMs": 3.665,
      "taskDurationMs": 751.112,
      "heapDeltaBytes": 17542688,
      "heapUsedBytes": 80428988,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 83.287,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1713.8100000001941,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 33.085,
      "layouts": 16,
      "layoutDurationMs": 3.659,
      "taskDurationMs": 773.071,
      "heapDeltaBytes": 17470964,
      "heapUsedBytes": 80676948,
      "domNodes": -279,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 82.756,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.3590000000095,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 30.571999999999996,
      "layouts": 14,
      "layoutDurationMs": 14.116,
      "taskDurationMs": 952.7509999999999,
      "heapDeltaBytes": 20271980,
      "heapUsedBytes": 103310336,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 16.243999999999996,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 142,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8296.880000000101,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 38.093,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4135.886,
      "heapDeltaBytes": 1313980,
      "heapUsedBytes": 78501968,
      "domNodes": -275,
      "jsHeapTotalBytes": 1527808,
      "scriptDurationMs": 1053.581,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8230.023999999958,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 35.955,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4082.4940000000006,
      "heapDeltaBytes": -3765424,
      "heapUsedBytes": 72579856,
      "domNodes": -281,
      "jsHeapTotalBytes": 4673536,
      "scriptDurationMs": 1031.711,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16874.627000000146,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16232.635999999999,
      "heapDeltaBytes": -31183320,
      "heapUsedBytes": 180975584,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9740288,
      "scriptDurationMs": 100.59600000000002,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17993.974999999864,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17091.684999999998,
      "heapDeltaBytes": -43775572,
      "heapUsedBytes": 181480496,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9478144,
      "scriptDurationMs": 130.498,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20777.86500000002,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 17.141000000000016,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20081.59,
      "heapDeltaBytes": -33748608,
      "heapUsedBytes": 193185708,
      "domNodes": -8312,
      "jsHeapTotalBytes": -17813504,
      "scriptDurationMs": 403.39899999999994,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 54,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20519.95500000021,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 17.351000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20001.371,
      "heapDeltaBytes": -32159736,
      "heapUsedBytes": 193112804,
      "domNodes": -8312,
      "jsHeapTotalBytes": -19509248,
      "scriptDurationMs": 408.49500000000006,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 53,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 111.59799999995812,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 14.679,
      "layouts": 2,
      "layoutDurationMs": 0.9350000000000003,
      "taskDurationMs": 84.04499999999999,
      "heapDeltaBytes": 3174856,
      "heapUsedBytes": 65906368,
      "domNodes": 131,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.123999999999999,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 452.8989999998885,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 18.622,
      "layouts": 3,
      "layoutDurationMs": 1.2340000000000002,
      "taskDurationMs": 102.854,
      "heapDeltaBytes": 5006916,
      "heapUsedBytes": 67721988,
      "domNodes": 121,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.314000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 46469 68801 67.5% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1212
src/LGraphNode.ts 64.3% 464
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/LGraph.ts 73.0% 312
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 38.0% 258
src/scripts/app.ts 71.2% 241
src/scripts/pnginfo.ts 21.5% 219
src/stores/assetsStore.ts 45.0% 203

@github-actions
github-actions Bot requested a review from DrJKL September 2, 2026 23:38
@dante01yoon dante01yoon self-assigned this Sep 2, 2026
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff               @@
##           cloud/1.52   #16713      +/-   ##
==============================================
+ Coverage       79.65%   82.07%   +2.41%     
==============================================
  Files            2243     1913     -330     
  Lines          115294   110304    -4990     
  Branches        32983    31793    -1190     
==============================================
- Hits            91843    90535    -1308     
+ Misses          22956    19426    -3530     
+ Partials          495      343     -152     
Flag Coverage Δ
e2e 66.04% <ø> (-0.08%) ⬇️
unit 74.12% <100.00%> (+0.02%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 90.47% <100.00%> (+0.11%) ⬆️
...nents/SubscriptionRequiredDialogContentUnified.vue 59.63% <100.00%> (+5.50%) ⬆️
...m/workspace/composables/useSubscriptionCheckout.ts 92.37% <100.00%> (+3.22%) ⬆️

... and 350 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot added this pull request to the merge queue Sep 2, 2026
Merged via the queue into cloud/1.52 with commit 01c5e95 Sep 3, 2026
91 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16647-to-cloud-1.52 branch September 3, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants