Skip to content

[backport cloud/1.53] fix(billing): give the confirm step a single header and back action - #16698

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16648-to-cloud-1.53
Sep 2, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16648-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16648 to cloud/1.53

Automatically created by backport workflow.

…16648)

## Summary

With embedded checkout off, the subscription dialog drew "Choose a Plan"
and a back arrow on top of a confirm step that already renders both —
two stacked headers on every legacy confirmation, and two back arrows on
plan changes.

Found on staging during 1.52 QA (Denys).

## Root cause

The shell suppressed its own chrome only for the embedded steps:

```ts
const isEmbeddedPaymentStep = computed(() => … && stripePaymentElementEnabled && …)
const isEmbeddedConfirmStep = computed(() => … && stripePaymentElementEnabled && …)
```

Both require `stripePaymentElementEnabled`, so with the flag off they
are false and the header and back arrow render on every step. The
comment above the header already described this exact failure ("stacking
'Choose a Plan' above it doubled the header") — the guard written for it
just never covered the flag-off path.

The arrow count differed by step for a second reason:
`SubscriptionAddPaymentPreviewWorkspace` hid its back button behind
`v-if="usePaymentElement"`, so a new subscription showed one arrow (the
shell's), while `SubscriptionTransitionPreviewWorkspace` renders its own
unconditionally and showed two. Both arrows call `handleBackToPricing`,
which is why they behaved identically.

## Changes

- **What**: the shell header is now bound to the pricing step — the
confirm and success steps title themselves, so no flag is involved. The
back action moves to the step that owns the header: the confirmation
renders it in both modes, and neither dialog shell renders one.

`isEmbedded*` are still used for the container sizing and transitions;
only the chrome stopped consulting them.

`SubscriptionRequiredDialogContentWorkspace` (the legacy per-member team
dialog) is touched because it shares the confirm component. It had the
same duplication on plan changes and is fixed by the same ownership
rule. Its two back-button tests now assert the child owns the action
rather than the shell.

## Review Focus

The back arrow moves from the shell's absolute top-left to inline beside
the confirm title in the flag-off path. That is the position it already
occupies with embedded checkout on, so the two modes now match rather
than diverge — worth a designer's eye if the old placement was
deliberate.

Behaviour deliberately unchanged: `isPolling`/loading still disable the
action, since the confirm components already gate their button on the
`isLoading` prop the shell passes.

## Screenshots (if applicable)

Captured against a cloud-distribution dev server with embedded checkout
off, driving the real flow: Settings → Plan & Credits → Change plan →
pick a different Team credit stop → Change plan.

Both shots are taken on top of #16647 so the confirm body renders — on
current `main` this step is empty, which hides the chrome problem rather
than fixing it.

### AS IS

![AS IS: "Choose a Plan" stacked over "Confirm your upgrade", with two
back
arrows](https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-16648-screenshots/docs-assets/pr-16648/asis-doubled-chrome.png)

Two titles and two back arrows. The shell draws its own header and arrow
because every `isEmbedded*` guard requires
`stripePaymentElementEnabled`, which is false with the flag off, and the
confirm step renders its own on top.

### TO BE — this PR

![TO BE: a single "Confirm your upgrade" header and one back
action](https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-16648-screenshots/docs-assets/pr-16648/tobe-single-chrome.png)

One header, one back action. The shell header now belongs to the pricing
step, and the back action to the step that owns the header.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 2, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 2, 2026 21:49
@github-actions
github-actions Bot requested a review from DrJKL September 2, 2026 21:49
@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 09:53:02 PM UTC

Links

🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1870 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 121ms TBT · 104.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.9 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.0 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 151ms TBT · 170.0 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 410ms TBT · 171.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 492ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 55.5 MB
canvas-idle: DOM nodes -283
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 41ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 929ms
canvas-mouse-sweep: script duration 154ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.8 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -172
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 350ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 442ms
dom-widget-clipping: script duration 152ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.7 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 602ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.5 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1526ms
large-graph-pan: script duration 755ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.5 MB
large-graph-pan: DOM nodes -138
large-graph-pan: event listeners 5
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1638ms
large-graph-zoom: script duration 747ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.3 MB
large-graph-zoom: DOM nodes -6
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1840ms
legacy-node-drag: script duration 916ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.2 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 558ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.5 MB
minimap-idle: DOM nodes -134
minimap-idle: event listeners -76
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 403ms
subgraph-dom-widget-clipping: script duration 141ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.5 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 480ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 58.6 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 34ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 779ms
subgraph-mouse-sweep: script duration 99ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.5 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 889ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 121ms
subgraph-transition-enter: heap used 104.5 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5539ms
viewport-pan-sweep: script duration 2546ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.9 MB
viewport-pan-sweep: DOM nodes -267
viewport-pan-sweep: event listeners -139
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16909ms
vue-large-graph-idle: script duration 283ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.0 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 175
vue-large-graph-pan: task duration 21086ms
vue-large-graph-pan: script duration 885ms
vue-large-graph-pan: TBT 151ms
vue-large-graph-pan: heap used 170.0 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6180ms
vue-node-resize-workload: script duration 111ms
vue-node-resize-workload: TBT 410ms
vue-node-resize-workload: heap used 171.9 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 2
workflow-execution: style recalc count 9
workflow-execution: task duration 88ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 124
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-02T22:05:03.231Z",
  "gitSha": "7c50a7ed739200a356f1f1cc20fb9047c3c5b440",
  "branch": "backport-16648-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2018.28900000001,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.952999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.46000000000004,
      "heapDeltaBytes": -12020976,
      "heapUsedBytes": 57550184,
      "domNodes": -283,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.94,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2051.2039999999843,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.167999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.97499999999997,
      "heapDeltaBytes": -10743416,
      "heapUsedBytes": 58852484,
      "domNodes": -283,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.882000000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2040.2250000000208,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 47.729,
      "layouts": 14,
      "layoutDurationMs": 4.965,
      "taskDurationMs": 994.1229999999998,
      "heapDeltaBytes": -8439636,
      "heapUsedBytes": 61154896,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 162.704,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1811.8850000000748,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 33.886,
      "layouts": 14,
      "layoutDurationMs": 4.129,
      "taskDurationMs": 864.23,
      "heapDeltaBytes": 2860204,
      "heapUsedBytes": 72618284,
      "domNodes": -280,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 146.13199999999998,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1731.3990000000103,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 17.008,
      "layouts": 6,
      "layoutDurationMs": 1.132,
      "taskDurationMs": 353.323,
      "heapDeltaBytes": 4455632,
      "heapUsedBytes": 74869520,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.872,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1734.572000000071,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.906999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.052,
      "taskDurationMs": 346.49600000000004,
      "heapDeltaBytes": 4413276,
      "heapUsedBytes": 74835588,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.924,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 625.2719999999954,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.653000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.565,
      "heapDeltaBytes": -8084004,
      "heapUsedBytes": 62374268,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 149.976,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 644.4490000000087,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.968000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.017,
      "heapDeltaBytes": 17832460,
      "heapUsedBytes": 88004280,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 154.743,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2034.5189999999889,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.009999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 590.268,
      "heapDeltaBytes": -13615076,
      "heapUsedBytes": 86668928,
      "domNodes": -271,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 35.88099999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.3779999999424,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.237000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 614.298,
      "heapDeltaBytes": -14107140,
      "heapUsedBytes": 86301312,
      "domNodes": -268,
      "jsHeapTotalBytes": -307200,
      "scriptDurationMs": 38.059000000000005,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2224.7539999999617,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.870000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1526.555,
      "heapDeltaBytes": 23001832,
      "heapUsedBytes": 88446036,
      "domNodes": -277,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 742.811,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2170.2790000000505,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 9.181999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1525.5990000000002,
      "heapDeltaBytes": 22987452,
      "heapUsedBytes": 88821668,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 767.33,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3474.0400000000022,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.315000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.736999999999998,
      "taskDurationMs": 1673.419,
      "heapDeltaBytes": 8552448,
      "heapUsedBytes": 75813912,
      "domNodes": -11,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 763.793,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3474.6659999999565,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.314000000000004,
      "layouts": 60,
      "layoutDurationMs": 12.516,
      "taskDurationMs": 1602.97,
      "heapDeltaBytes": 10771164,
      "heapUsedBytes": 79953112,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 730.589,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3090.156000000036,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.2379999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1866.021,
      "heapDeltaBytes": 17734864,
      "heapUsedBytes": 85150792,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 935.125,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2984.213000000068,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.184000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1813.2859999999998,
      "heapDeltaBytes": 13404588,
      "heapUsedBytes": 81012680,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 896.2570000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2063.10400000001,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.001999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 586.546,
      "heapDeltaBytes": -14931464,
      "heapUsedBytes": 87416300,
      "domNodes": -269,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 32.717000000000006,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2003.78099999989,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.8580000000000011,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 528.882,
      "heapDeltaBytes": 21757900,
      "heapUsedBytes": 87768800,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.26,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 565.4109999999832,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.74,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.07499999999993,
      "heapDeltaBytes": 15172120,
      "heapUsedBytes": 87651880,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 139.53400000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 594.2199999999502,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.967000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.886,
      "heapDeltaBytes": 14774860,
      "heapUsedBytes": 87427204,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 141.711,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.5090000000373,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.283999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 482.04999999999995,
      "heapDeltaBytes": -9703972,
      "heapUsedBytes": 61749792,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.845999999999999,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2014.5560000000842,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.281,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.999,
      "heapDeltaBytes": -10626232,
      "heapUsedBytes": 61115816,
      "domNodes": -299,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.911999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1738.7229999999931,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 32.509,
      "layouts": 18,
      "layoutDurationMs": 5.137,
      "taskDurationMs": 779.982,
      "heapDeltaBytes": 5448476,
      "heapUsedBytes": 77860996,
      "domNodes": -298,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 100.009,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.8069999999652,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 36.097,
      "layouts": 18,
      "layoutDurationMs": 5.121,
      "taskDurationMs": 778.313,
      "heapDeltaBytes": -12631912,
      "heapUsedBytes": 59595384,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 98.30699999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1383.154999999988,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 30.057000000000006,
      "layouts": 15,
      "layoutDurationMs": 14.248000000000001,
      "taskDurationMs": 888.533,
      "heapDeltaBytes": 21069160,
      "heapUsedBytes": 109539820,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 28.833,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 121,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8383.30499999995,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 37.849999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5638.6,
      "heapDeltaBytes": -5811940,
      "heapUsedBytes": 95085960,
      "domNodes": -267,
      "jsHeapTotalBytes": -1654784,
      "scriptDurationMs": 2627.196,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8216.83900000005,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.596000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5438.601000000001,
      "heapDeltaBytes": -15877652,
      "heapUsedBytes": 84975580,
      "domNodes": -267,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 2464.312,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17903.92300000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17024.781,
      "heapDeltaBytes": -29473352,
      "heapUsedBytes": 179994872,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2260992,
      "scriptDurationMs": 287.50699999999995,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17297.49700000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16793.188000000002,
      "heapDeltaBytes": -30237524,
      "heapUsedBytes": 174361304,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6979584,
      "scriptDurationMs": 278.17499999999995,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21303.854,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 19.12999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20980.623,
      "heapDeltaBytes": -13022892,
      "heapUsedBytes": 189885376,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2023424,
      "scriptDurationMs": 876.6429999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 179,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21517.687000000024,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 18.909999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21192.069,
      "heapDeltaBytes": -36359200,
      "heapUsedBytes": 166558888,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1830912,
      "scriptDurationMs": 893.37,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 122,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6237.276000000009,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.03599999999999,
      "layouts": 20,
      "layoutDurationMs": 23.470000000000006,
      "taskDurationMs": 6138.801,
      "heapDeltaBytes": -23911100,
      "heapUsedBytes": 180877220,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12316672,
      "scriptDurationMs": 111.144,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 442,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6325.263999999947,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.065,
      "layouts": 20,
      "layoutDurationMs": 24.250999999999994,
      "taskDurationMs": 6222.023000000001,
      "heapDeltaBytes": -30190588,
      "heapUsedBytes": 179629852,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10620928,
      "scriptDurationMs": 110.119,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 378,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 466.9380000000274,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 19.578,
      "layouts": 2,
      "layoutDurationMs": 0.5549999999999999,
      "taskDurationMs": 104.30300000000001,
      "heapDeltaBytes": 5067272,
      "heapUsedBytes": 73269572,
      "domNodes": 122,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.538999999999999,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 95.51399999998011,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 12.227,
      "layouts": 1,
      "layoutDurationMs": 1.004,
      "taskDurationMs": 71.101,
      "heapDeltaBytes": 3118232,
      "heapUsedBytes": 70794740,
      "domNodes": 125,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 6.3450000000000015,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #16698   +/-   ##
=============================================
  Coverage              ?   83.27%           
=============================================
  Files                 ?     2023           
  Lines                 ?   116969           
  Branches              ?    32444           
=============================================
  Hits                  ?    97410           
  Misses                ?    19204           
  Partials              ?      355           
Flag Coverage Δ
e2e 66.62% <ø> (?)
unit 76.51% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 90.36% <ø> (ø)
...nents/SubscriptionRequiredDialogContentUnified.vue 54.12% <100.00%> (ø)
...nts/SubscriptionRequiredDialogContentWorkspace.vue 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit d7f6193 into cloud/1.53 Sep 2, 2026
107 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16648-to-cloud-1.53 branch September 2, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants