Skip to content

[backport cloud/1.52] fix(billing): give the confirm step a single header and back action - #16696

Merged
comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16648-to-cloud-1.52
Sep 2, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16648-to-cloud-1.52

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16648 to cloud/1.52

Automatically created by backport workflow.

…16648)

## Summary

With embedded checkout off, the subscription dialog drew "Choose a Plan"
and a back arrow on top of a confirm step that already renders both —
two stacked headers on every legacy confirmation, and two back arrows on
plan changes.

Found on staging during 1.52 QA (Denys).

## Root cause

The shell suppressed its own chrome only for the embedded steps:

```ts
const isEmbeddedPaymentStep = computed(() => … && stripePaymentElementEnabled && …)
const isEmbeddedConfirmStep = computed(() => … && stripePaymentElementEnabled && …)
```

Both require `stripePaymentElementEnabled`, so with the flag off they
are false and the header and back arrow render on every step. The
comment above the header already described this exact failure ("stacking
'Choose a Plan' above it doubled the header") — the guard written for it
just never covered the flag-off path.

The arrow count differed by step for a second reason:
`SubscriptionAddPaymentPreviewWorkspace` hid its back button behind
`v-if="usePaymentElement"`, so a new subscription showed one arrow (the
shell's), while `SubscriptionTransitionPreviewWorkspace` renders its own
unconditionally and showed two. Both arrows call `handleBackToPricing`,
which is why they behaved identically.

## Changes

- **What**: the shell header is now bound to the pricing step — the
confirm and success steps title themselves, so no flag is involved. The
back action moves to the step that owns the header: the confirmation
renders it in both modes, and neither dialog shell renders one.

`isEmbedded*` are still used for the container sizing and transitions;
only the chrome stopped consulting them.

`SubscriptionRequiredDialogContentWorkspace` (the legacy per-member team
dialog) is touched because it shares the confirm component. It had the
same duplication on plan changes and is fixed by the same ownership
rule. Its two back-button tests now assert the child owns the action
rather than the shell.

## Review Focus

The back arrow moves from the shell's absolute top-left to inline beside
the confirm title in the flag-off path. That is the position it already
occupies with embedded checkout on, so the two modes now match rather
than diverge — worth a designer's eye if the old placement was
deliberate.

Behaviour deliberately unchanged: `isPolling`/loading still disable the
action, since the confirm components already gate their button on the
`isLoading` prop the shell passes.

## Screenshots (if applicable)

Captured against a cloud-distribution dev server with embedded checkout
off, driving the real flow: Settings → Plan & Credits → Change plan →
pick a different Team credit stop → Change plan.

Both shots are taken on top of #16647 so the confirm body renders — on
current `main` this step is empty, which hides the chrome problem rather
than fixing it.

### AS IS

![AS IS: "Choose a Plan" stacked over "Confirm your upgrade", with two
back
arrows](https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-16648-screenshots/docs-assets/pr-16648/asis-doubled-chrome.png)

Two titles and two back arrows. The shell draws its own header and arrow
because every `isEmbedded*` guard requires
`stripePaymentElementEnabled`, which is false with the flag off, and the
confirm step renders its own on top.

### TO BE — this PR

![TO BE: a single "Confirm your upgrade" header and one back
action](https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-16648-screenshots/docs-assets/pr-16648/tobe-single-chrome.png)

One header, one back action. The shell header now belongs to the pricing
step, and the back action to the step that owns the header.
@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1981 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1960 / ❌ 0 / ⚠️ 4 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 09:51:57 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 112ms TBT · 81.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.3 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 2ms TBT · 184.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 443ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 76.2 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -152
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 27ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 71
canvas-mouse-sweep: task duration 766ms
canvas-mouse-sweep: script duration 86ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.5 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -167
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 33
canvas-zoom-sweep: task duration 313ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 62.8 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 296ms
dom-widget-clipping: script duration 42ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.0 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 545ms
large-graph-idle: script duration 13ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 69.4 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -148
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1031ms
large-graph-pan: script duration 275ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 67.4 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -147
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1199ms
large-graph-zoom: script duration 322ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.1 MB
large-graph-zoom: DOM nodes -138
large-graph-zoom: event listeners -73
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1184ms
legacy-node-drag: script duration 369ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 66.8 MB
legacy-node-drag: DOM nodes 13
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 537ms
minimap-idle: script duration 13ms
minimap-idle: TBT 0ms
minimap-idle: heap used 66.0 MB
minimap-idle: DOM nodes -278
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 326ms
subgraph-dom-widget-clipping: script duration 95ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.0 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 435ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.7 MB
subgraph-idle: DOM nodes -280
subgraph-idle: event listeners -167
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 30ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 692ms
subgraph-mouse-sweep: script duration 66ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.7 MB
subgraph-mouse-sweep: DOM nodes -280
subgraph-mouse-sweep: event listeners -166
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 9ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 773ms
subgraph-transition-enter: script duration 13ms
subgraph-transition-enter: TBT 112ms
subgraph-transition-enter: heap used 81.3 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 3571ms
viewport-pan-sweep: script duration 875ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.6 MB
viewport-pan-sweep: DOM nodes -278
viewport-pan-sweep: event listeners -148
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13276ms
vue-large-graph-idle: script duration 106ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.3 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16394
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 131
vue-large-graph-pan: task duration 16247ms
vue-large-graph-pan: script duration 404ms
vue-large-graph-pan: TBT 2ms
vue-large-graph-pan: heap used 184.8 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16389
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 93ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 64.4 MB
workflow-execution: DOM nodes 134
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-09-02T22:02:21.437Z",
  "gitSha": "9f2324fef7f065c9522e0b9a11154c0e8542dea6",
  "branch": "backport-16648-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2041.4350000000354,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.320000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.44599999999997,
      "heapDeltaBytes": 16384972,
      "heapUsedBytes": 78638108,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 6.720000000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2016.6320000000155,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.281999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.096,
      "heapDeltaBytes": 18229340,
      "heapUsedBytes": 81215684,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 6.618,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1841.8770000000109,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 27.218,
      "layouts": 12,
      "layoutDurationMs": 2.797,
      "taskDurationMs": 832.1510000000001,
      "heapDeltaBytes": 7250768,
      "heapUsedBytes": 69541996,
      "domNodes": -278,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 90.38399999999999,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1703.1309999999849,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 27.059,
      "layouts": 12,
      "layoutDurationMs": 3.014,
      "taskDurationMs": 700.3580000000001,
      "heapDeltaBytes": 17734904,
      "heapUsedBytes": 80328028,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 81.041,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1714.7099999999682,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 12.55,
      "layouts": 6,
      "layoutDurationMs": 0.5659999999999998,
      "taskDurationMs": 316.59900000000005,
      "heapDeltaBytes": 3299196,
      "heapUsedBytes": 65886220,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 8.702000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.0509999999886,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 13.391,
      "layouts": 6,
      "layoutDurationMs": 0.6380000000000001,
      "taskDurationMs": 309.88000000000005,
      "heapDeltaBytes": 3323964,
      "heapUsedBytes": 65881416,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.119,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 531.7440000000033,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.217,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 302.498,
      "heapDeltaBytes": 10994564,
      "heapUsedBytes": 73616432,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 43.971,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 502.15099999991253,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.843999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 290.275,
      "heapDeltaBytes": 10910280,
      "heapUsedBytes": 73142748,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 39.614000000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.298999999991,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 546.8629999999999,
      "heapDeltaBytes": -3427884,
      "heapUsedBytes": 74011416,
      "domNodes": -273,
      "jsHeapTotalBytes": -1056768,
      "scriptDurationMs": 13.206,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.3270000000712,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.023999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.894,
      "heapDeltaBytes": -5764544,
      "heapUsedBytes": 71525352,
      "domNodes": -279,
      "jsHeapTotalBytes": -1056768,
      "scriptDurationMs": 12.989,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2111.985000000004,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.606999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1022.2189999999999,
      "heapDeltaBytes": -8856100,
      "heapUsedBytes": 69582104,
      "domNodes": -275,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 274.60400000000004,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2110.7509999999365,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.536,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1039.58,
      "heapDeltaBytes": -6391704,
      "heapUsedBytes": 71683796,
      "domNodes": -273,
      "jsHeapTotalBytes": -307200,
      "scriptDurationMs": 274.91900000000004,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3084.142999999983,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.747,
      "layouts": 60,
      "layoutDurationMs": 8.175999999999998,
      "taskDurationMs": 1185.725,
      "heapDeltaBytes": -8731100,
      "heapUsedBytes": 69846328,
      "domNodes": 12,
      "jsHeapTotalBytes": 5804032,
      "scriptDurationMs": 326.47099999999995,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3135.081000000014,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.440000000000001,
      "layouts": 60,
      "layoutDurationMs": 8.24,
      "taskDurationMs": 1212.325,
      "heapDeltaBytes": -14991432,
      "heapUsedBytes": 64557964,
      "domNodes": -288,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 318.484,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2102.6430000000005,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 7.726999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1154.21,
      "heapDeltaBytes": -17490628,
      "heapUsedBytes": 69883980,
      "domNodes": 12,
      "jsHeapTotalBytes": 8687616,
      "scriptDurationMs": 352.01099999999997,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2174.8270000000502,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.780999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1213.728,
      "heapDeltaBytes": -17336912,
      "heapUsedBytes": 70232448,
      "domNodes": 14,
      "jsHeapTotalBytes": 9211904,
      "scriptDurationMs": 386.09800000000007,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.158000000005,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.831999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 552.51,
      "heapDeltaBytes": -12727408,
      "heapUsedBytes": 72478184,
      "domNodes": -275,
      "jsHeapTotalBytes": 3399680,
      "scriptDurationMs": 12.201000000000004,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2007.319999999936,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.308999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 522.274,
      "heapDeltaBytes": -12426140,
      "heapUsedBytes": 65954716,
      "domNodes": -281,
      "jsHeapTotalBytes": 3399680,
      "scriptDurationMs": 12.909,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 555.8369999999968,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.72,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 335.94599999999997,
      "heapDeltaBytes": 11575908,
      "heapUsedBytes": 74501132,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 97.331,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 509.689000000094,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 6.403999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 315.973,
      "heapDeltaBytes": 11539904,
      "heapUsedBytes": 74467228,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 92.765,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2026.096999999993,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.086999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.0729999999999,
      "heapDeltaBytes": 2630524,
      "heapUsedBytes": 65336532,
      "domNodes": -280,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 6.641000000000001,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.7489999999998,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.069,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.074,
      "heapDeltaBytes": -7168140,
      "heapUsedBytes": 55750984,
      "domNodes": -279,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 6.432,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.390000000018,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 27.523000000000007,
      "layouts": 16,
      "layoutDurationMs": 3.379,
      "taskDurationMs": 671.613,
      "heapDeltaBytes": 2660984,
      "heapUsedBytes": 65766504,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 64.846,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.2660000000706,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 31.654,
      "layouts": 16,
      "layoutDurationMs": 4.542,
      "taskDurationMs": 711.703,
      "heapDeltaBytes": 15819440,
      "heapUsedBytes": 78401404,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 67.68,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 965.6009999999924,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.501999999999995,
      "layouts": 15,
      "layoutDurationMs": 9.168,
      "taskDurationMs": 773.0780000000002,
      "heapDeltaBytes": -9869336,
      "heapUsedBytes": 85215836,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15990784,
      "scriptDurationMs": 13.006000000000004,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8116.232000000025,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.678,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3582.56,
      "heapDeltaBytes": 18299976,
      "heapUsedBytes": 95780728,
      "domNodes": -282,
      "jsHeapTotalBytes": 4935680,
      "scriptDurationMs": 894.049,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8121.337999999923,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.434999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3559.19,
      "heapDeltaBytes": -2035340,
      "heapUsedBytes": 75377184,
      "domNodes": -274,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 855.713,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14379.741000000024,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13260.717,
      "heapDeltaBytes": -43112420,
      "heapUsedBytes": 183064284,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8957952,
      "scriptDurationMs": 105.66499999999999,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14328.60500000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13291.157,
      "heapDeltaBytes": -49329304,
      "heapUsedBytes": 176146564,
      "domNodes": -8312,
      "jsHeapTotalBytes": -16556032,
      "scriptDurationMs": 106.517,
      "eventListeners": -16395,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16918.29799999999,
      "styleRecalcs": 133,
      "styleRecalcDurationMs": 17.846,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16336.606,
      "heapDeltaBytes": -19722032,
      "heapUsedBytes": 192986056,
      "domNodes": -8312,
      "jsHeapTotalBytes": -18726912,
      "scriptDurationMs": 410.952,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16798.10199999997,
      "styleRecalcs": 128,
      "styleRecalcDurationMs": 17.121,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16158.076000000001,
      "heapDeltaBytes": -31619960,
      "heapUsedBytes": 194481068,
      "domNodes": -8312,
      "jsHeapTotalBytes": -17678336,
      "scriptDurationMs": 397.32300000000004,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.9469999999951,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 17.893,
      "layouts": 2,
      "layoutDurationMs": 0.892,
      "taskDurationMs": 94.76599999999999,
      "heapDeltaBytes": 5130568,
      "heapUsedBytes": 67498992,
      "domNodes": 148,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.514000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 441.39399999994566,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 13.885000000000002,
      "layouts": 3,
      "layoutDurationMs": 0.722,
      "taskDurationMs": 92.16999999999997,
      "heapDeltaBytes": 4990652,
      "heapUsedBytes": 67585708,
      "domNodes": 119,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.374000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 46445 68776 67.5% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1212
src/LGraphNode.ts 64.3% 464
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/LGraph.ts 73.0% 312
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 38.0% 258
src/scripts/app.ts 71.2% 241
src/scripts/pnginfo.ts 21.5% 219
src/stores/assetsStore.ts 45.0% 203

@github-actions
github-actions Bot requested a review from DrJKL September 2, 2026 21:49
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff               @@
##           cloud/1.52   #16696      +/-   ##
==============================================
+ Coverage       79.66%   82.04%   +2.38%     
==============================================
  Files            2243     1913     -330     
  Lines          115303   110296    -5007     
  Branches        32990    32280     -710     
==============================================
- Hits            91851    90491    -1360     
+ Misses          22957    19464    -3493     
+ Partials          495      341     -154     
Flag Coverage Δ
e2e 66.02% <ø> (-0.10%) ⬇️
unit 74.09% <100.00%> (-0.01%) ⬇️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 90.36% <ø> (-0.18%) ⬇️
...nents/SubscriptionRequiredDialogContentUnified.vue 54.12% <100.00%> (-0.34%) ⬇️
...nts/SubscriptionRequiredDialogContentWorkspace.vue 100.00% <ø> (ø)

... and 347 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot added this pull request to the merge queue Sep 2, 2026
Merged via the queue into cloud/1.52 with commit 15457dd Sep 2, 2026
91 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16648-to-cloud-1.52 branch September 2, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants