Repository navigation
ci: scan only first-parent commits for AI co-author trailers - #16693
christian-byrne wants to merge 1 commit into
Conversation
git log base..head walks the full merge ancestry, so a long-lived PR branch that merges main in picks up every already-merged main commit as a false positive (14 inherited flags on #15457 from #15974, #15857, #14158). --first-parent restricts the trailer scan to commits actually introduced on the PR branch.
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 1903 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.68 MB gzip 🟢 -1 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 294 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T21:42:18.252Z",
"gitSha": "dcb49e8a8c16725608d52ac2570bb715a53cfcfd",
"branch": "christian-byrne/qa15-trailer-check-first-parent",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2052.436,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.526,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.097,
"heapDeltaBytes": -3377448,
"heapUsedBytes": 65727532,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.967999999999996,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.0049999999746,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.604,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.5450000000001,
"heapDeltaBytes": -13270748,
"heapUsedBytes": 57334940,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.599,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1959.5170000000053,
"styleRecalcs": 80,
"styleRecalcDurationMs": 46.148,
"layouts": 14,
"layoutDurationMs": 4.733,
"taskDurationMs": 957.1840000000001,
"heapDeltaBytes": -7354192,
"heapUsedBytes": 63317844,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 152.895,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1886.9609999999852,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.12299999999999,
"layouts": 14,
"layoutDurationMs": 4.890000000000001,
"taskDurationMs": 924.657,
"heapDeltaBytes": -11983108,
"heapUsedBytes": 58764432,
"domNodes": -284,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 148.811,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.299999999981,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.576,
"layouts": 6,
"layoutDurationMs": 1.1449999999999998,
"taskDurationMs": 418.48500000000007,
"heapDeltaBytes": 4382460,
"heapUsedBytes": 73914324,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 15.039,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.0899999999665,
"styleRecalcs": 33,
"styleRecalcDurationMs": 19.348999999999997,
"layouts": 6,
"layoutDurationMs": 1.3629999999999998,
"taskDurationMs": 380.75299999999993,
"heapDeltaBytes": 5146180,
"heapUsedBytes": 75900524,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.236,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 696.3930000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.1859999999999,
"heapDeltaBytes": -7431840,
"heapUsedBytes": 62793172,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 159.724,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 741.4019999999937,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.45,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.491,
"heapDeltaBytes": 18065560,
"heapUsedBytes": 88342060,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 155.57399999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.449999999993,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.954999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 686.9610000000001,
"heapDeltaBytes": -13832748,
"heapUsedBytes": 87414016,
"domNodes": -267,
"jsHeapTotalBytes": -1634304,
"scriptDurationMs": 40.366,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2049.146999999948,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.274000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.168,
"heapDeltaBytes": -14456092,
"heapUsedBytes": 86489408,
"domNodes": -267,
"jsHeapTotalBytes": -847872,
"scriptDurationMs": 36.75599999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2402.6419999999575,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.471000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1729.3339999999996,
"heapDeltaBytes": -13978768,
"heapUsedBytes": 87384172,
"domNodes": -268,
"jsHeapTotalBytes": -1409024,
"scriptDurationMs": 782.1270000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2525.254000000018,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.199,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1744.1309999999999,
"heapDeltaBytes": 27184940,
"heapUsedBytes": 92705188,
"domNodes": -277,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 803.609,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3746.2409999999977,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.593999999999996,
"layouts": 60,
"layoutDurationMs": 14.029000000000002,
"taskDurationMs": 1817.067,
"heapDeltaBytes": 8780240,
"heapUsedBytes": 75843808,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 787.528,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3702.171000000021,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.765,
"layouts": 60,
"layoutDurationMs": 14.150999999999998,
"taskDurationMs": 1806.4630000000002,
"heapDeltaBytes": 11781956,
"heapUsedBytes": 79736412,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 782.146,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3279.389999999978,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.633999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2103.86,
"heapDeltaBytes": 20879344,
"heapUsedBytes": 88188504,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1025.108,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3130.064999999945,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.004999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2070.627,
"heapDeltaBytes": 23236540,
"heapUsedBytes": 89846940,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1002.4650000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2001.8549999999777,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.9140000000001,
"heapDeltaBytes": 22639904,
"heapUsedBytes": 88684944,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.022999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.268000000021,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.558999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.77,
"heapDeltaBytes": -16042728,
"heapUsedBytes": 86936060,
"domNodes": -271,
"jsHeapTotalBytes": -1634304,
"scriptDurationMs": 38.061,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.6809999999805,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.268,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.715,
"heapDeltaBytes": 15169160,
"heapUsedBytes": 87909712,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 147.529,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.1519999999609,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.875,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.8810000000001,
"heapDeltaBytes": 15226488,
"heapUsedBytes": 88012628,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 141.85899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.2840000000228,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.230000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.6170000000001,
"heapDeltaBytes": -14558476,
"heapUsedBytes": 58026508,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.488000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.7959999999616,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.7800000000001,
"heapDeltaBytes": -8725380,
"heapUsedBytes": 64047240,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.505999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.951000000011,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.553,
"layouts": 18,
"layoutDurationMs": 6.194999999999999,
"taskDurationMs": 883.526,
"heapDeltaBytes": -12405652,
"heapUsedBytes": 60265352,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 112.66000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1766.742000000022,
"styleRecalcs": 75,
"styleRecalcDurationMs": 45.165,
"layouts": 18,
"layoutDurationMs": 5.909,
"taskDurationMs": 897.419,
"heapDeltaBytes": 2859684,
"heapUsedBytes": 75410788,
"domNodes": -299,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 112.58699999999999,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.0970000000302,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.097,
"layouts": 15,
"layoutDurationMs": 14.597,
"taskDurationMs": 972.253,
"heapDeltaBytes": -5579520,
"heapUsedBytes": 86369180,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.424000000000007,
"eventListeners": 2381,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8823.670999999991,
"styleRecalcs": 247,
"styleRecalcDurationMs": 41.76299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6178.957,
"heapDeltaBytes": -11939128,
"heapUsedBytes": 88767384,
"domNodes": -268,
"jsHeapTotalBytes": -1409024,
"scriptDurationMs": 2681.9860000000003,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8715.371000000005,
"styleRecalcs": 246,
"styleRecalcDurationMs": 40.751999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6053.3009999999995,
"heapDeltaBytes": 13570972,
"heapUsedBytes": 89104928,
"domNodes": -274,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 2624.7760000000003,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18621.871999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18381.591999999997,
"heapDeltaBytes": -18059912,
"heapUsedBytes": 191738828,
"domNodes": -6548,
"jsHeapTotalBytes": -700416,
"scriptDurationMs": 320.95,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17859.33299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17399.238999999998,
"heapDeltaBytes": -20610208,
"heapUsedBytes": 183773060,
"domNodes": -6548,
"jsHeapTotalBytes": -3620864,
"scriptDurationMs": 296.653,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23597.16900000001,
"styleRecalcs": 177,
"styleRecalcDurationMs": 26.50199999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23414.02,
"heapDeltaBytes": -37122824,
"heapUsedBytes": 176441576,
"domNodes": -6548,
"jsHeapTotalBytes": -10260480,
"scriptDurationMs": 960.5509999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 221,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 22901.63199999995,
"styleRecalcs": 173,
"styleRecalcDurationMs": 23.363999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22663.153000000002,
"heapDeltaBytes": -12584144,
"heapUsedBytes": 190309840,
"domNodes": -6548,
"jsHeapTotalBytes": 2560000,
"scriptDurationMs": 962.2890000000001,
"eventListeners": -7465,
"totalBlockingTimeMs": 167,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6602.865999999949,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.46700000000001,
"layouts": 20,
"layoutDurationMs": 25.442000000000007,
"taskDurationMs": 6558.618,
"heapDeltaBytes": -33028196,
"heapUsedBytes": 180588188,
"domNodes": -6548,
"jsHeapTotalBytes": 8183808,
"scriptDurationMs": 119.67599999999999,
"eventListeners": -7467,
"totalBlockingTimeMs": 649,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6533.2599999999275,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.93800000000002,
"layouts": 20,
"layoutDurationMs": 30.817999999999998,
"taskDurationMs": 6438.374999999999,
"heapDeltaBytes": -34975376,
"heapUsedBytes": 174835872,
"domNodes": -6548,
"jsHeapTotalBytes": 5885952,
"scriptDurationMs": 161.672,
"eventListeners": -7469,
"totalBlockingTimeMs": 573,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9098.131000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8982.738,
"heapDeltaBytes": -15985884,
"heapUsedBytes": 162831472,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 148.75800000000007,
"eventListeners": 22,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9076.829000000089,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8875.541,
"heapDeltaBytes": 6788004,
"heapUsedBytes": 184597068,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 144.25900000000001,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 112.60700000002544,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.698,
"layouts": 3,
"layoutDurationMs": 1.9580000000000002,
"taskDurationMs": 78.26899999999999,
"heapDeltaBytes": 3122372,
"heapUsedBytes": 71548128,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.524000000000001,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 490.38099999995666,
"styleRecalcs": 18,
"styleRecalcDurationMs": 34.366,
"layouts": 3,
"layoutDurationMs": 1.7260000000000002,
"taskDurationMs": 140.57899999999998,
"heapDeltaBytes": 4906664,
"heapUsedBytes": 73856696,
"domNodes": 144,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.926000000000002,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16693 +/- ##
==========================================
+ Coverage 80.82% 82.43% +1.60%
==========================================
Files 2444 2032 -412
Lines 124795 117502 -7293
Branches 33024 31307 -1717
==========================================
- Hits 100869 96857 -4012
+ Misses 23423 20467 -2956
+ Partials 503 178 -325
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
One Minor inline: first-parent fixes the false positive but skips every commit a side-branch merge brings in; the merge-base is the cleaner left end.
|
|
||
| commit_trailers="$( | ||
| git log --format=' %h: %(trailers:key=Co-authored-by,separator=%x09)' \ | ||
| git log --first-parent --format=' %h: %(trailers:key=Co-authored-by,separator=%x09)' \ |
There was a problem hiding this comment.
Severity: Minor (correctness)
What: .github/scripts/check-ai-co-authors.sh:70 adds --first-parent to the git log "${base_sha}..${head_sha}" trailer scan.
Why this is an issue: --first-parent does remove the false positive from a merged-in mainline, but it also skips every second-parent commit, so a PR that merges a side branch delivers commits whose Co-authored-by trailers this gate never reads, the gate shrinks below what the PR ships.
Proposed Fix: drop --first-parent and move the range's left end instead, git log "$(git merge-base "$base_sha" "$head_sha")..$head_sha", which excludes the merged-in mainline history without losing the side-branch commits the PR delivers.
|
@christian-byrne could you refresh this against current main and resolve the conflicts? Please also address the review finding about first-parent skipping side-branch commits, rerun the trailer-scan checks and relevant CI, and request my re-review when ready. |
Fixes the "Check for AI agent co-author trailers" workflow flagging commits it shouldn't own.
git log base..head(no--first-parent) walks the full merge ancestry, so once a long-lived PR branch mergesmainin, every already-mergedmaincommit that happens to carry an AI co-author trailer gets re-flagged as if it belonged to the PR. This hit #15457 14 times, inherited from already-merged main PRs #15974, #15857, and #14158.--first-parentrestricts the scan to commits actually introduced on the PR branch (the first-parent line fromheadback tobase), which excludes commits reachable only via a second-parent (i.e. commits merged in frommain, not authored on the branch).Evidence
Synthetic repro (base repo, one already-merged trailer-carrying commit on
main, one clean commit on a feature branch, thenmerge maininto feature):Commands run:
bash -n .github/scripts/check-ai-co-authors.sh— syntax OKLinear
n/a — CI-only one-line fix, no ticket required per repo convention for trivial CI scripts.