Repository navigation
fix(agent): exit node selection on workflow switch - #16665
Conversation
|
Important Approval pendingCodeRabbit has no unresolved comments, but it could not review the latest commit because the review limit was reached. Follow the review guidance in this comment to continue. Comment |
🎭 Playwright: ✅ 1903 passed, 0 failed📊 Browser Reports
🎨 Storybook: ❌ FailedDetails⏰ Completed at: 09/02/2026, 09:48:13 PM UTC Links
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T21:57:44.260Z",
"gitSha": "1d8c66dbaeb607afb30a5bc290ff738be1788b34",
"branch": "fix/qa-58-selection-workflow-swap",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2050.1669999999876,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.745000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.4820000000001,
"heapDeltaBytes": -8878460,
"heapUsedBytes": 61366372,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.697,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.8009999999822,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.503000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.465,
"heapDeltaBytes": -8942564,
"heapUsedBytes": 61378500,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.246999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1892.9049999999847,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.362,
"layouts": 14,
"layoutDurationMs": 4.535,
"taskDurationMs": 913.8069999999999,
"heapDeltaBytes": -11829320,
"heapUsedBytes": 58984780,
"domNodes": -278,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 162.284,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1924.9570000000062,
"styleRecalcs": 79,
"styleRecalcDurationMs": 44.147,
"layouts": 14,
"layoutDurationMs": 4.493,
"taskDurationMs": 920.4150000000001,
"heapDeltaBytes": -6902656,
"heapUsedBytes": 63547668,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 162.773,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.320999999985,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.496000000000002,
"layouts": 6,
"layoutDurationMs": 1.148,
"taskDurationMs": 377.46,
"heapDeltaBytes": 5078272,
"heapUsedBytes": 75262228,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.902,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.2939999999335,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.135999999999996,
"layouts": 6,
"layoutDurationMs": 1.073,
"taskDurationMs": 374.90899999999993,
"heapDeltaBytes": 5018976,
"heapUsedBytes": 75724804,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.3,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 656.7609999999604,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.185,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.055,
"heapDeltaBytes": 18049832,
"heapUsedBytes": 88006956,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 165.934,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 674.8540000000389,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.841999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.488,
"heapDeltaBytes": -8211772,
"heapUsedBytes": 62567792,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 159.52500000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.1089999999826,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.9110000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.3060000000002,
"heapDeltaBytes": -13613632,
"heapUsedBytes": 86981112,
"domNodes": -264,
"jsHeapTotalBytes": -847872,
"scriptDurationMs": 38.579,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2031.596000000036,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.761999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.1750000000001,
"heapDeltaBytes": -13303584,
"heapUsedBytes": 87039384,
"domNodes": -270,
"jsHeapTotalBytes": -1110016,
"scriptDurationMs": 35.036,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2434.500000000014,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.070999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1669.932,
"heapDeltaBytes": 26722224,
"heapUsedBytes": 92382124,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 833.828,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2307.7600000000302,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.703999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1635.182,
"heapDeltaBytes": 17727840,
"heapUsedBytes": 84215224,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 821.198,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3653.6879999999883,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.991,
"layouts": 60,
"layoutDurationMs": 12.109000000000002,
"taskDurationMs": 1739.493,
"heapDeltaBytes": 11766916,
"heapUsedBytes": 79704480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.7389999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3636.799999999994,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.167000000000002,
"layouts": 60,
"layoutDurationMs": 12.086999999999998,
"taskDurationMs": 1715.2359999999999,
"heapDeltaBytes": 7734408,
"heapUsedBytes": 75205780,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 771.295,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3146.905000000004,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.932000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1982.4290000000003,
"heapDeltaBytes": 22421712,
"heapUsedBytes": 90100996,
"domNodes": -278,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 982.0239999999999,
"eventListeners": 34,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3067.637999999988,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.855999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1943.769,
"heapDeltaBytes": 20440940,
"heapUsedBytes": 88377356,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 951.2629999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.5290000000014,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.804,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.6289999999999,
"heapDeltaBytes": 9940936,
"heapUsedBytes": 86783616,
"domNodes": -275,
"jsHeapTotalBytes": -2457600,
"scriptDurationMs": 35.974000000000004,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2032.3210000000245,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.9270000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.7080000000001,
"heapDeltaBytes": 22525484,
"heapUsedBytes": 88602092,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.59499999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.8079999999718,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.777,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.122,
"heapDeltaBytes": 14874424,
"heapUsedBytes": 87709772,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.355,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.9969999999785,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.153,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.02099999999996,
"heapDeltaBytes": 15250712,
"heapUsedBytes": 87613808,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 147.99400000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.8649999999907,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.619000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.98699999999997,
"heapDeltaBytes": -38996,
"heapUsedBytes": 72011556,
"domNodes": -298,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.575,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.0389999999788,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.544999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.6039999999999,
"heapDeltaBytes": -15355804,
"heapUsedBytes": 57442236,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.649000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.7030000000045,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.066,
"layouts": 18,
"layoutDurationMs": 4.925000000000001,
"taskDurationMs": 850.3240000000001,
"heapDeltaBytes": 885720,
"heapUsedBytes": 72948456,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 115.044,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1772.9910000000473,
"styleRecalcs": 80,
"styleRecalcDurationMs": 41.251000000000005,
"layouts": 18,
"layoutDurationMs": 5.796000000000001,
"taskDurationMs": 869.843,
"heapDeltaBytes": 10870852,
"heapUsedBytes": 83742764,
"domNodes": -293,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 119.42999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.520999999961,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.96399999999999,
"layouts": 14,
"layoutDurationMs": 15.831999999999999,
"taskDurationMs": 962.4000000000001,
"heapDeltaBytes": 21913228,
"heapUsedBytes": 105446404,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.858000000000004,
"eventListeners": 2381,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8854.615000000023,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.513,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6046.342,
"heapDeltaBytes": 16783052,
"heapUsedBytes": 91845100,
"domNodes": -268,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 2810.982,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8511.68800000005,
"styleRecalcs": 246,
"styleRecalcDurationMs": 33.982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5879.401,
"heapDeltaBytes": -7638828,
"heapUsedBytes": 93533132,
"domNodes": -270,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 2700.408,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17694.20200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16934.823,
"heapDeltaBytes": -21964984,
"heapUsedBytes": 180007032,
"domNodes": -6548,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 308.906,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17439.364999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16881.136000000002,
"heapDeltaBytes": -28151576,
"heapUsedBytes": 176276116,
"domNodes": -6548,
"jsHeapTotalBytes": -6070272,
"scriptDurationMs": 310.66,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21260.355000000003,
"styleRecalcs": 166,
"styleRecalcDurationMs": 18.619000000000053,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20901.988,
"heapDeltaBytes": -26231656,
"heapUsedBytes": 176208192,
"domNodes": -6548,
"jsHeapTotalBytes": -20480,
"scriptDurationMs": 920.1610000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20998.740999999995,
"styleRecalcs": 167,
"styleRecalcDurationMs": 18.31499999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20647.514000000003,
"heapDeltaBytes": -27094140,
"heapUsedBytes": 176287332,
"domNodes": -6548,
"jsHeapTotalBytes": 991232,
"scriptDurationMs": 955.8380000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 71,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6353.580000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.53399999999999,
"layouts": 20,
"layoutDurationMs": 24.817999999999994,
"taskDurationMs": 6257.042,
"heapDeltaBytes": -21312944,
"heapUsedBytes": 186345756,
"domNodes": -6548,
"jsHeapTotalBytes": 9940992,
"scriptDurationMs": 116.00999999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 476,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6263.661999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 96.47100000000003,
"layouts": 20,
"layoutDurationMs": 28.419999999999987,
"taskDurationMs": 6160.141,
"heapDeltaBytes": -33191708,
"heapUsedBytes": 175580336,
"domNodes": -6548,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 111.57700000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 417,
"frameDurationMs": 18.33333333333327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8807.652999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8501.988,
"heapDeltaBytes": -8376372,
"heapUsedBytes": 176196080,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 137.15500000000003,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8672.769000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8434.829999999998,
"heapDeltaBytes": 17483600,
"heapUsedBytes": 180237624,
"domNodes": 0,
"jsHeapTotalBytes": -1835008,
"scriptDurationMs": 133.82799999999995,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 132.57400000003372,
"styleRecalcs": 10,
"styleRecalcDurationMs": 22.019000000000002,
"layouts": 4,
"layoutDurationMs": 2.51,
"taskDurationMs": 104.43799999999999,
"heapDeltaBytes": 3495572,
"heapUsedBytes": 72363036,
"domNodes": 221,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.224999999999999,
"eventListeners": 55,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 98.7120000000914,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.73,
"layouts": 2,
"layoutDurationMs": 1.35,
"taskDurationMs": 74.555,
"heapDeltaBytes": 3109328,
"heapUsedBytes": 71987952,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.619,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16665 +/- ##
==========================================
+ Coverage 80.76% 82.43% +1.66%
==========================================
Files 2440 2032 -408
Lines 124596 117503 -7093
Branches 31154 31355 +201
==========================================
- Hits 100629 96859 -3770
+ Misses 23465 20466 -2999
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 443 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
The diagnosis holds up: openWorkflow assigns activeWorkflow inside loadGraphData, between beforeLoadGraph and afterLoadGraph, so the old combined watcher saw the path change only while isLoadingWorkflow was true and never exited. Splitting the two triggers and dropping the guard from the path watcher is the right shape, and the exit path is idempotent so the extra call from the isActive watcher is harmless.
One suggestion inline about what the path watcher keys on. The tag restore in afterLoadGraph does not depend on selection mode, and the selectionTags save watcher is still guarded by isLoadingWorkflow, so exiting on switch does not clobber the per-workflow saved node IDs.
|
Pushed 1409e01: the path watcher now keys on the workflow object. Full context for agent readers
Added a component test that renames the active workflow through the reactive store proxy mid-selection and asserts the mode stays active (isActive, multi_select, allow_dragnodes, selectOnly). Verified it fails on c692302 and passes on 1409e01. Left as-is: |
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Re-walked at 1409e01. Keying the watcher on the workflow object holds: rename mutates the same instance in place and openWorkflow is the only assignment, so a switch still exits. Nothing blocking.
|
Follow-up queued for renamed-workflow selection state. Full context for agent readersProgram row |
Summary
Exit node-selection mode whenever the active workflow changes, including while the replacement graph is loading.
Changes
Review Focus
The active workflow watcher is intentionally unconditional; the graph watcher retains the load guard needed for restoring a selection within one workflow.
Evidence
isActive(expected true to be false).pnpm test:unit src/workbench/extensions/agent/AgentPanelRoot.test.ts— 114 passed.PLAYWRIGHT_TEST_URL=http://localhost:6258 PLAYWRIGHT_SETUP_API_URL=http://localhost:8188 PLAYWRIGHT_LOCAL=1 DISTRIBUTION=cloud DEV_SERVER_COMFYUI_URL=http://localhost:8188 pnpm exec start-server-and-test "pnpm exec vite --port 6258 --strictPort" http-get://localhost:6258 "pnpm exec playwright test browser_tests/tests/agent/agentPanel.spec.ts --project=cloud --timeout=60000 -g 'exits node selection when the active workflow changes'"— 1 passed.pnpm exec oxfmt --checkand targeted ESLint for all three changed files — passed.pnpm typecheckandpnpm typecheck:browser— passed.pnpm knip --cache— passed.