Repository navigation
docs: clarify stable-store registration idempotency - #16636
Conversation
|
Warning Review limit reachedNext included review available in 32 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Comment |
🎭 Playwright: ✅ 1901 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.68 MB gzip 🔴 +125 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • 🔴 +429 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • 🟢 -49 BBundles that do not match a named category
Status: 72 added / 72 removed / 223 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T10:56:40.179Z",
"gitSha": "ef36ccc76ef1ee47f81b94a176aba97453f6a413",
"branch": "christian/followup-15761-idempotency",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2085.0529999999594,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.373,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 678.295,
"heapDeltaBytes": -10470280,
"heapUsedBytes": 60234868,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 16.169999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2071.8329999999696,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.284,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.048,
"heapDeltaBytes": 9133408,
"heapUsedBytes": 79445120,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.108999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1853.7729999999897,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.602,
"layouts": 14,
"layoutDurationMs": 4.242,
"taskDurationMs": 924.0129999999999,
"heapDeltaBytes": -7286792,
"heapUsedBytes": 63152508,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 161.268,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1898.0700000000752,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.754,
"layouts": 14,
"layoutDurationMs": 4.256,
"taskDurationMs": 999.495,
"heapDeltaBytes": 5110040,
"heapUsedBytes": 75815000,
"domNodes": -280,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 169.861,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.7309999999538,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.325000000000003,
"layouts": 6,
"layoutDurationMs": 1.3059999999999998,
"taskDurationMs": 427.316,
"heapDeltaBytes": 4669592,
"heapUsedBytes": 75238608,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 15.305000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1752.7350000000297,
"styleRecalcs": 33,
"styleRecalcDurationMs": 22.060000000000002,
"layouts": 6,
"layoutDurationMs": 1.0850000000000002,
"taskDurationMs": 446.016,
"heapDeltaBytes": 4812204,
"heapUsedBytes": 75107256,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 17.082000000000004,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 705.4069999999797,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.9929999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.116,
"heapDeltaBytes": 18205592,
"heapUsedBytes": 88053892,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 167.706,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 706.792000000064,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.084999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.56699999999995,
"heapDeltaBytes": -7493860,
"heapUsedBytes": 62943964,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 164.55,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.6700000000205,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.821000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.71,
"heapDeltaBytes": -13345320,
"heapUsedBytes": 87359992,
"domNodes": -269,
"jsHeapTotalBytes": -1101824,
"scriptDurationMs": 39.864999999999995,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2045.0730000000021,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.157000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 743.9,
"heapDeltaBytes": 11400756,
"heapUsedBytes": 86841252,
"domNodes": -270,
"jsHeapTotalBytes": -1138688,
"scriptDurationMs": 37.43000000000001,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2463.3909999999446,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.274000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1689.5699999999997,
"heapDeltaBytes": 25565896,
"heapUsedBytes": 91508504,
"domNodes": -275,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 822.211,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2606.492000000003,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.413999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1767.891,
"heapDeltaBytes": 19063236,
"heapUsedBytes": 84486624,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 851.984,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3839.0739999999823,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.890999999999998,
"layouts": 60,
"layoutDurationMs": 13.123,
"taskDurationMs": 1819.3830000000003,
"heapDeltaBytes": 9597164,
"heapUsedBytes": 76399580,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 807.843,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3717.9539999999633,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.925,
"layouts": 60,
"layoutDurationMs": 12.834,
"taskDurationMs": 1823.0010000000002,
"heapDeltaBytes": 8168976,
"heapUsedBytes": 75535140,
"domNodes": -11,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 800.6170000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3130.665000000022,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.993000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1996.9929999999997,
"heapDeltaBytes": 25757308,
"heapUsedBytes": 93511312,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 974.4449999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3151.190999999926,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.688000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2060.825,
"heapDeltaBytes": 25783996,
"heapUsedBytes": 92783008,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1006.9449999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2029.9249999999915,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.372,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.2700000000002,
"heapDeltaBytes": -15841452,
"heapUsedBytes": 87216644,
"domNodes": -267,
"jsHeapTotalBytes": -1626112,
"scriptDurationMs": 36.357,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.341999999995,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9419999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.959,
"heapDeltaBytes": 9870436,
"heapUsedBytes": 86605256,
"domNodes": -273,
"jsHeapTotalBytes": -1662976,
"scriptDurationMs": 37.32000000000001,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.6720000000269,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.799,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.387,
"heapDeltaBytes": 15116028,
"heapUsedBytes": 88023356,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 140.02800000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 675.0839999999698,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.803999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.56699999999995,
"heapDeltaBytes": 15192156,
"heapUsedBytes": 87684460,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 150.846,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.979999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.328999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.357,
"heapDeltaBytes": -8900860,
"heapUsedBytes": 64054460,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.506999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.868999999957,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.636,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.068,
"heapDeltaBytes": -13822260,
"heapUsedBytes": 58951760,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.949000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.5979999999854,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.597,
"layouts": 18,
"layoutDurationMs": 5.047999999999999,
"taskDurationMs": 889.8330000000001,
"heapDeltaBytes": -12526968,
"heapUsedBytes": 60237836,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 116.183,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1801.311999999939,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.171,
"layouts": 18,
"layoutDurationMs": 5.555,
"taskDurationMs": 944.6430000000001,
"heapDeltaBytes": 2485100,
"heapUsedBytes": 75399056,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 120.78600000000002,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.3229999999494,
"styleRecalcs": 19,
"styleRecalcDurationMs": 35.288,
"layouts": 15,
"layoutDurationMs": 16.881999999999998,
"taskDurationMs": 1086.7630000000001,
"heapDeltaBytes": 19941784,
"heapUsedBytes": 103558788,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 36.992,
"eventListeners": 2383,
"totalBlockingTimeMs": 165,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9379.469999999968,
"styleRecalcs": 246,
"styleRecalcDurationMs": 36.702,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6195.455,
"heapDeltaBytes": -11347556,
"heapUsedBytes": 89354084,
"domNodes": -269,
"jsHeapTotalBytes": -1433600,
"scriptDurationMs": 2750.285,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9993.790999999987,
"styleRecalcs": 246,
"styleRecalcDurationMs": 39.179,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6578.852,
"heapDeltaBytes": -11573840,
"heapUsedBytes": 89096368,
"domNodes": -270,
"jsHeapTotalBytes": -909312,
"scriptDurationMs": 2925.89,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18076.434000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17398.277000000002,
"heapDeltaBytes": -32938192,
"heapUsedBytes": 176536544,
"domNodes": -6548,
"jsHeapTotalBytes": -3088384,
"scriptDurationMs": 291.13899999999995,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18416.684999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17870.038,
"heapDeltaBytes": -36877064,
"heapUsedBytes": 176273700,
"domNodes": -6548,
"jsHeapTotalBytes": -7368704,
"scriptDurationMs": 311.947,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21495.908999999985,
"styleRecalcs": 173,
"styleRecalcDurationMs": 21.22099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21307.915999999997,
"heapDeltaBytes": -38542516,
"heapUsedBytes": 166878460,
"domNodes": -6576,
"jsHeapTotalBytes": 774144,
"scriptDurationMs": 931.708,
"eventListeners": -7469,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21785.489999999983,
"styleRecalcs": 166,
"styleRecalcDurationMs": 22.363999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21550.189000000002,
"heapDeltaBytes": -12084044,
"heapUsedBytes": 190256908,
"domNodes": -6548,
"jsHeapTotalBytes": 1228800,
"scriptDurationMs": 972.3570000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 126,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6383.424999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.905,
"layouts": 20,
"layoutDurationMs": 22.723999999999993,
"taskDurationMs": 6264.542,
"heapDeltaBytes": -6923592,
"heapUsedBytes": 182120896,
"domNodes": -6547,
"jsHeapTotalBytes": 19865600,
"scriptDurationMs": 114.696,
"eventListeners": -7471,
"totalBlockingTimeMs": 364,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6319.6570000000065,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.87799999999996,
"layouts": 20,
"layoutDurationMs": 24.620000000000005,
"taskDurationMs": 6196.032999999999,
"heapDeltaBytes": -35655180,
"heapUsedBytes": 179679600,
"domNodes": -6548,
"jsHeapTotalBytes": 16982016,
"scriptDurationMs": 111.428,
"eventListeners": -7473,
"totalBlockingTimeMs": 413,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 113.34799999997358,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.939,
"layouts": 2,
"layoutDurationMs": 1.428,
"taskDurationMs": 83.18100000000001,
"heapDeltaBytes": 3017176,
"heapUsedBytes": 71557756,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.401,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 117.45599999994738,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.678999999999998,
"layouts": 2,
"layoutDurationMs": 1.0900000000000003,
"taskDurationMs": 82.09100000000001,
"heapDeltaBytes": 3093028,
"heapUsedBytes": 71552764,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.761999999999999,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16636 +/- ##
==========================================
+ Coverage 80.73% 82.34% +1.60%
==========================================
Files 2438 2029 -409
Lines 124324 117111 -7213
Branches 32894 31218 -1676
==========================================
- Hits 100378 96437 -3941
+ Misses 23444 20496 -2948
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 424 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
The three JSDoc contracts match their implementations, Vue raw/proxy identity semantics, ADR 0016, and the targeted store tests. Typecheck, scoped lint/format, and all 62 targeted tests pass. No findings.
Summary
Clarifies that stable-identity store registration is idempotent for the same raw object and owner, while distinct occupants are rejected.
Changes
@returnsdocumentation for link, node-data, and reroute registration.Review Focus
Confirm each description matches the existing identity checks and preserves public contracts.
Follow-up to source PR #15761.
Addresses:
Evidence
pnpm exec oxfmt --check src/stores/linkStore.ts src/stores/nodeDataStore.ts src/stores/rerouteStore.ts— passedpnpm test:unit src/stores/linkStore.test.ts src/stores/nodeDataStore.test.ts src/stores/rerouteStore.test.ts— 62 passedpnpm typecheck— passed