Skip to content

[backport cloud/1.52] fix(billing): price legacy subscription previews from the server costs - #16617

Merged
comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16517-to-cloud-1.52
Sep 2, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16517-to-cloud-1.52

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16517 to cloud/1.52

Automatically created by backport workflow.

#16517)

## Summary

The subscription confirm screens rendered no amount at all whenever
embedded checkout was off — a blank "Total due today" on new
subscriptions and "Unavailable" on plan changes. Resolve the amount from
the legacy cost fields the server always sends.

## Changes

- **What**: `formatAmountDueToday` / `formatRenewalAmount` /
`resolveRenewalDate` in `subscriptionQuoteFormatting.ts` resolve each
figure from the exact quote when the server sent one and from the
always-present legacy costs otherwise.
`SubscriptionAddPaymentPreviewWorkspace` and
`SubscriptionTransitionPreviewWorkspace` consume them. New
`subscription.preview.renewsAtAmount` message for the case where the
server supplies an amount but no renewal date.

### Root cause

#14483 ("consolidate embedded checkout frontend") rewrote both quote
computeds to read only the embedded-checkout field family:

```ts
const totalDueToday = computed(() =>
  previewData?.amount_due_cents === undefined ? '' : formatQuoteMoney(...)
)
```

`POST /api/billing/preview-subscribe` returns two different shapes.
`packages/ingest-types` documents the split on the sibling field:
`payment_method_configuration_id` is *"Present on every successful
preview while embedded checkout is enabled and absent from legacy
previews."* The same holds for the whole family:

| field | contract | legacy preview |
| --- | --- | --- |
| `amount_due_cents`, `currency` | optional | absent |
| `renewal_amount_cents`, `renewal_at` | optional | absent |
| `cost_today_cents`, `cost_next_period_cents` | **required** |
**present** |

So with the flag off, `amount_due_cents` is `undefined` and
`totalDueToday` short-circuits to `''`.
`SubscriptionTransitionPreviewWorkspace` falls through to
`subscription.preview.quoteUnavailable` and prints "Unavailable" twice.

Two things widen the blast radius beyond "someone turned the flag off":

- `embeddedCheckoutEnabled` resolves **fail-closed**
(`resolveFailClosedBooleanFlag`), so a flag that cannot be read is
treated as off and takes this same path.
- `formatQuoteMoney` returns `''` when `currency` is missing, so even
reading `cost_today_cents` while passing the absent `currency` through
would still render blank.

Note the branch here is on the **response shape**, not on the
`embeddedCheckoutEnabled` prop. The shape is what the contract actually
guarantees, it needs no prop threaded into
`SubscriptionTransitionPreviewWorkspace`, and it stays correct if the
flag is on while the backend still serves a legacy preview.
`chargeCents` in the same component already branched this way
(`amount_due_cents ?? cost_today_cents`) — the consolidation just missed
the display computeds.

The renewal **date** is deliberately not synthesized.
`PreviewPlanInfo.period_end` is documented "only for current_plan" and
is absent on a new-subscription preview, so the legacy path shows the
server-provided renewal amount without inventing a date.

## Review Focus

- `LEGACY_QUOTE_CURRENCY = 'usd'` is the one assumption added. The
legacy rail carries no `currency` field because it prices in USD; this
keeps that assumption in a single named constant instead of at each call
site.
- `SubscriptionTransitionPreviewWorkspaceReactivation.test.ts` had a
test asserting "Unavailable" appeared twice for a preview with no exact
quote. That test codified this bug, so it now asserts the legacy amount
renders.
- `cloudSubscribeDeepLink.spec.ts` already drove a legacy-shaped preview
through the real checkout but only asserted the heading, which is how
this reached QA. It now asserts the total.

## Tests

- 8 unit tests on the pure resolvers (exact quote, legacy fallback,
non-USD, missing date)
- 3 component regression tests; verified they fail without the fix and
pass with it
- 1 E2E assertion on the existing flag-off deep-link spec

## Screenshots

Captured in the running app (cloud distribution,
`embedded_checked_enabled` off) — posting them in a follow-up comment.

<!-- Supersedes #16515, which fixes the same bug by branching on the
flag prop and drops the renewal line when the server sends no date. -->
@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 07:01:08 AM UTC

Links

🎭 Playwright: ✅ 1985 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1964 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 145ms TBT · 84.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.6 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 40ms TBT · 181.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 503ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.4 MB
canvas-idle: DOM nodes -283
canvas-idle: event listeners -166
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 43ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 979ms
canvas-mouse-sweep: script duration 123ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.7 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -153
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 383ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 63.1 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 372ms
dom-widget-clipping: script duration 57ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.4 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 630ms
large-graph-idle: script duration 17ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 64.8 MB
large-graph-idle: DOM nodes -284
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1264ms
large-graph-pan: script duration 350ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 63.9 MB
large-graph-pan: DOM nodes -284
large-graph-pan: event listeners -150
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1421ms
large-graph-zoom: script duration 398ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.5 MB
large-graph-zoom: DOM nodes -289
large-graph-zoom: event listeners -169
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1457ms
legacy-node-drag: script duration 460ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 66.7 MB
legacy-node-drag: DOM nodes 8
legacy-node-drag: event listeners 185
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 666ms
minimap-idle: script duration 18ms
minimap-idle: TBT 0ms
minimap-idle: heap used 67.4 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -164
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 398ms
subgraph-dom-widget-clipping: script duration 120ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.1 MB
subgraph-dom-widget-clipping: DOM nodes 16
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 487ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.9 MB
subgraph-idle: DOM nodes -281
subgraph-idle: event listeners -166
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 38ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 814ms
subgraph-mouse-sweep: script duration 89ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 70.3 MB
subgraph-mouse-sweep: DOM nodes -283
subgraph-mouse-sweep: event listeners -167
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 990ms
subgraph-transition-enter: script duration 19ms
subgraph-transition-enter: TBT 145ms
subgraph-transition-enter: heap used 84.5 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4436ms
viewport-pan-sweep: script duration 1082ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.7 MB
viewport-pan-sweep: DOM nodes -278
viewport-pan-sweep: event listeners -133
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17030ms
vue-large-graph-idle: script duration 127ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.6 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16392
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 170
vue-large-graph-pan: task duration 20491ms
vue-large-graph-pan: script duration 408ms
vue-large-graph-pan: TBT 40ms
vue-large-graph-pan: heap used 181.9 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16385
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 95ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.9 MB
workflow-execution: DOM nodes 138
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-02T07:12:30.316Z",
  "gitSha": "1091f5625d2a2cb012b2e745db527f0ba2f3833e",
  "branch": "backport-16517-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2041.199000000006,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.375999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.14899999999994,
      "heapDeltaBytes": 16839280,
      "heapUsedBytes": 78551344,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.521,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2049.893999999995,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.703,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.7250000000001,
      "heapDeltaBytes": 1169964,
      "heapUsedBytes": 62785212,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.886999999999997,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2121.6450000000577,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 51.32500000000001,
      "layouts": 12,
      "layoutDurationMs": 3.79,
      "taskDurationMs": 1089.4740000000002,
      "heapDeltaBytes": 18746752,
      "heapUsedBytes": 81096408,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 133.809,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1814.1600000000153,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 34.753,
      "layouts": 12,
      "layoutDurationMs": 3.4220000000000006,
      "taskDurationMs": 868.796,
      "heapDeltaBytes": -6330072,
      "heapUsedBytes": 56650636,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 111.264,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.2339999999967,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.024,
      "layouts": 6,
      "layoutDurationMs": 0.6479999999999999,
      "taskDurationMs": 372.12,
      "heapDeltaBytes": 3342380,
      "heapUsedBytes": 66193000,
      "domNodes": 77,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 10.547,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.8770000000022,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.207999999999995,
      "layouts": 6,
      "layoutDurationMs": 0.784,
      "taskDurationMs": 394.03700000000003,
      "heapDeltaBytes": 2926744,
      "heapUsedBytes": 66121020,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.936999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 574.5660000000044,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.133,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.23799999999994,
      "heapDeltaBytes": 10918836,
      "heapUsedBytes": 73830836,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 56.31199999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 592.805999999996,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.42,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 376.31100000000004,
      "heapDeltaBytes": 10918716,
      "heapUsedBytes": 73857356,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 57.52900000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.363000000004,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.079999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 630.655,
      "heapDeltaBytes": -12857232,
      "heapUsedBytes": 63467876,
      "domNodes": -283,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 17.634,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.032999999985,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.653000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 629.36,
      "heapDeltaBytes": -5123136,
      "heapUsedBytes": 72376216,
      "domNodes": -285,
      "jsHeapTotalBytes": -1843200,
      "scriptDurationMs": 17.116,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2184.1369999999642,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.567000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1232.9479999999999,
      "heapDeltaBytes": -7946736,
      "heapUsedBytes": 70299880,
      "domNodes": -283,
      "jsHeapTotalBytes": 479232,
      "scriptDurationMs": 353.104,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2203.27199999997,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.331999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1295.578,
      "heapDeltaBytes": -14452476,
      "heapUsedBytes": 63716800,
      "domNodes": -284,
      "jsHeapTotalBytes": 1302528,
      "scriptDurationMs": 346.897,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3200.5139999999983,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.012999999999998,
      "layouts": 60,
      "layoutDurationMs": 8.145,
      "taskDurationMs": 1415.585,
      "heapDeltaBytes": -11069156,
      "heapUsedBytes": 68162964,
      "domNodes": -287,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 394.704,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3281.5029999999297,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.144000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.696,
      "taskDurationMs": 1426.1650000000002,
      "heapDeltaBytes": -8030612,
      "heapUsedBytes": 71332408,
      "domNodes": -290,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 400.47600000000006,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2296.305000000075,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.267,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1447.873,
      "heapDeltaBytes": -17355384,
      "heapUsedBytes": 69930512,
      "domNodes": 8,
      "jsHeapTotalBytes": 8687616,
      "scriptDurationMs": 462.785,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2276.181000000065,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.188999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1466.92,
      "heapDeltaBytes": -17357668,
      "heapUsedBytes": 70047216,
      "domNodes": 8,
      "jsHeapTotalBytes": 8425472,
      "scriptDurationMs": 457.194,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.5779999999777,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.052999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 639.8870000000001,
      "heapDeltaBytes": -3296856,
      "heapUsedBytes": 75637108,
      "domNodes": -270,
      "jsHeapTotalBytes": -1318912,
      "scriptDurationMs": 16.063000000000002,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.4909999999509,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.562,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 692.219,
      "heapDeltaBytes": -12367468,
      "heapUsedBytes": 65771300,
      "domNodes": -282,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 20.389000000000003,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 574.1559999999026,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.43,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 383.245,
      "heapDeltaBytes": 11460588,
      "heapUsedBytes": 74637744,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 118.32,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 618.863000000033,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.75,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.97100000000006,
      "heapDeltaBytes": 11750692,
      "heapUsedBytes": 74409796,
      "domNodes": 14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 121.095,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.7979999999798,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.113,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.05299999999994,
      "heapDeltaBytes": 2150844,
      "heapUsedBytes": 65227564,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 5.729000000000002,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2012.903999999935,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.29,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.28499999999997,
      "heapDeltaBytes": 18414096,
      "heapUsedBytes": 81423296,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 6.5120000000000005,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.3690000000006,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 37.544,
      "layouts": 16,
      "layoutDurationMs": 4.4639999999999995,
      "taskDurationMs": 796.061,
      "heapDeltaBytes": 19132748,
      "heapUsedBytes": 81978028,
      "domNodes": -284,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 86.422,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1727.1329999999807,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 38.513000000000005,
      "layouts": 16,
      "layoutDurationMs": 4.595999999999999,
      "taskDurationMs": 831.525,
      "heapDeltaBytes": 2642340,
      "heapUsedBytes": 65409640,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 90.63600000000001,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1402.4870000000647,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.739000000000004,
      "layouts": 14,
      "layoutDurationMs": 14.664,
      "taskDurationMs": 989.6709999999997,
      "heapDeltaBytes": -6155968,
      "heapUsedBytes": 88600364,
      "domNodes": 13673,
      "jsHeapTotalBytes": 12320768,
      "scriptDurationMs": 18.703999999999997,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 145,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8331.203000000074,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 38.339,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4254.785,
      "heapDeltaBytes": 772444,
      "heapUsedBytes": 78085356,
      "domNodes": -274,
      "jsHeapTotalBytes": 479232,
      "scriptDurationMs": 1036.6250000000002,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8746.14900000006,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.354,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4617.572,
      "heapDeltaBytes": -774748,
      "heapUsedBytes": 76387180,
      "domNodes": -281,
      "jsHeapTotalBytes": -307200,
      "scriptDurationMs": 1127.0240000000001,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17646.147999999925,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16850.625,
      "heapDeltaBytes": -38030072,
      "heapUsedBytes": 177514020,
      "domNodes": -8312,
      "jsHeapTotalBytes": -22044672,
      "scriptDurationMs": 126.39200000000001,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18070.10200000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17210.011,
      "heapDeltaBytes": -52242684,
      "heapUsedBytes": 178086708,
      "domNodes": -8312,
      "jsHeapTotalBytes": -22618112,
      "scriptDurationMs": 127.52199999999996,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20928.82899999995,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 17.440000000000012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20266.137,
      "heapDeltaBytes": -17548824,
      "heapUsedBytes": 194470968,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14528512,
      "scriptDurationMs": 396.946,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21364.57299999995,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 19.769999999999953,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20714.925,
      "heapDeltaBytes": -31589484,
      "heapUsedBytes": 187038908,
      "domNodes": -8312,
      "jsHeapTotalBytes": -16363520,
      "scriptDurationMs": 418.35100000000006,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 62,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 467.2579999999016,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 20.098,
      "layouts": 3,
      "layoutDurationMs": 1.3660000000000003,
      "taskDurationMs": 111.11599999999999,
      "heapDeltaBytes": 5264476,
      "heapUsedBytes": 68107632,
      "domNodes": 150,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.864999999999998,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 109.94999999979882,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 19.925,
      "layouts": 3,
      "layoutDurationMs": 1.521,
      "taskDurationMs": 79.52400000000002,
      "heapDeltaBytes": 2993500,
      "heapUsedBytes": 65830152,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.567999999999999,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 46432 68770 67.5% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1212
src/LGraphNode.ts 64.3% 464
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/LGraph.ts 73.0% 312
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.4% 283
src/platform/workspace/stores/teamWorkspaceStore.ts 38.0% 258
src/scripts/app.ts 71.2% 241
src/scripts/pnginfo.ts 21.5% 219
src/stores/assetsStore.ts 45.0% 203

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff               @@
##           cloud/1.52   #16617      +/-   ##
==============================================
+ Coverage       79.66%   82.04%   +2.37%     
==============================================
  Files            2243     1913     -330     
  Lines          115250   110263    -4987     
  Branches        33462    32276    -1186     
==============================================
- Hits            91816    90463    -1353     
+ Misses          22942    19452    -3490     
+ Partials          492      348     -144     
Flag Coverage Δ
e2e 66.02% <ø> (-0.10%) ⬇️
unit 74.10% <100.00%> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../subscription/utils/subscriptionQuoteFormatting.ts 100.00% <100.00%> (ø)
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 90.53% <100.00%> (-0.06%) ⬇️
...ponents/SubscriptionTransitionPreviewWorkspace.vue 91.20% <100.00%> (-0.04%) ⬇️

... and 337 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot added this pull request to the merge queue Sep 2, 2026
Merged via the queue into cloud/1.52 with commit b729188 Sep 2, 2026
90 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16517-to-cloud-1.52 branch September 2, 2026 07:35
@huang47 huang47 added risk:xhigh PR risk grade (advisory shadow check; grader-owned) and removed risk:R3 PR risk grade (advisory shadow check; grader-owned) labels Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants