Repository navigation
fix(preview): follow-up to #14073 — nullish output recovery - #16605
Conversation
|
Warning Review limit reachedNext included review available in 29 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Comment |
🎭 Playwright: ✅ 1901 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T07:51:07.440Z",
"gitSha": "b57955dbff20e70c45671ca467373cbc8418e074",
"branch": "followup-14073-nullish-preview-output",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.3899999999553,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.966000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.6129999999999,
"heapDeltaBytes": 10728,
"heapUsedBytes": 69851132,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 8.680999999999997,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2037.0659999999816,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.403,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.749,
"heapDeltaBytes": 7850588,
"heapUsedBytes": 77784852,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.187999999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1991.9770000000199,
"styleRecalcs": 83,
"styleRecalcDurationMs": 44.553,
"layouts": 14,
"layoutDurationMs": 4.557,
"taskDurationMs": 1014.899,
"heapDeltaBytes": -6158344,
"heapUsedBytes": 63306264,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 162.268,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1941.1269999999377,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.69499999999999,
"layouts": 14,
"layoutDurationMs": 4.656000000000001,
"taskDurationMs": 894.0239999999999,
"heapDeltaBytes": 6429572,
"heapUsedBytes": 76879076,
"domNodes": -278,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 152.777,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.0700000000024,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.595,
"layouts": 6,
"layoutDurationMs": 1.239,
"taskDurationMs": 356.87199999999996,
"heapDeltaBytes": 4799932,
"heapUsedBytes": 75379256,
"domNodes": 75,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.350999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.542000000014,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.668000000000003,
"layouts": 6,
"layoutDurationMs": 1.142,
"taskDurationMs": 360.70900000000006,
"heapDeltaBytes": 4682004,
"heapUsedBytes": 75246380,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.576000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 645.9070000000224,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.612000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.56700000000006,
"heapDeltaBytes": -7429416,
"heapUsedBytes": 62759572,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 157.12699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 659.6889999999576,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.713000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.36800000000005,
"heapDeltaBytes": -7784500,
"heapUsedBytes": 62878788,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 157.596,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2002.2690000000125,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.1719999999999,
"heapDeltaBytes": 22289264,
"heapUsedBytes": 87430104,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.961,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2063.3229999999685,
"styleRecalcs": 5,
"styleRecalcDurationMs": 9.240000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.763,
"heapDeltaBytes": -13451292,
"heapUsedBytes": 87284840,
"domNodes": -268,
"jsHeapTotalBytes": -1626112,
"scriptDurationMs": 34.81700000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2177.0419999999717,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.174999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1554.6759999999997,
"heapDeltaBytes": 19071916,
"heapUsedBytes": 84479452,
"domNodes": -274,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 752.5500000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2152.153999999996,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.799,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1604.105,
"heapDeltaBytes": 18660264,
"heapUsedBytes": 84277884,
"domNodes": -9,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 773.506,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3555.912000000035,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.770999999999999,
"layouts": 60,
"layoutDurationMs": 13.07,
"taskDurationMs": 1682.954,
"heapDeltaBytes": 8043344,
"heapUsedBytes": 75784164,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 753.3330000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3543.578000000025,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.716999999999997,
"layouts": 60,
"layoutDurationMs": 12.884,
"taskDurationMs": 1698.76,
"heapDeltaBytes": 8435436,
"heapUsedBytes": 76159632,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 772.094,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3113.2920000000013,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.526,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1931.721,
"heapDeltaBytes": 19674392,
"heapUsedBytes": 86971128,
"domNodes": 0,
"jsHeapTotalBytes": 2514944,
"scriptDurationMs": 946.3950000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3080.3099999999404,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.954999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1920.9279999999999,
"heapDeltaBytes": 22296236,
"heapUsedBytes": 89305984,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 955.874,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.186999999979,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4610000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.6650000000001,
"heapDeltaBytes": 22141072,
"heapUsedBytes": 87984516,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.411,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2001.0110000000623,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4569999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.307,
"heapDeltaBytes": 22169588,
"heapUsedBytes": 88654916,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.296000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.0810000000079,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.510000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.30799999999994,
"heapDeltaBytes": 14875052,
"heapUsedBytes": 87572580,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 137.581,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.9250000000075,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.536999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.22400000000005,
"heapDeltaBytes": 15183516,
"heapUsedBytes": 87875448,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 137.657,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2031.0390000000211,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.487000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.52000000000004,
"heapDeltaBytes": -7987428,
"heapUsedBytes": 64386368,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.111999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2037.337999999977,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.290000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.24,
"heapDeltaBytes": -9880608,
"heapUsedBytes": 62923672,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.167,
"eventListeners": -224,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.163999999997,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.197,
"layouts": 18,
"layoutDurationMs": 5.341,
"taskDurationMs": 800.486,
"heapDeltaBytes": -12430976,
"heapUsedBytes": 60274604,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 105.31,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.2329999999365,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.76,
"layouts": 18,
"layoutDurationMs": 5.258000000000001,
"taskDurationMs": 804.279,
"heapDeltaBytes": -10701560,
"heapUsedBytes": 61660136,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 104.88,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.5229999999838,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.933000000000003,
"layouts": 14,
"layoutDurationMs": 14.753000000000002,
"taskDurationMs": 979.4180000000001,
"heapDeltaBytes": -13038548,
"heapUsedBytes": 82492328,
"domNodes": 13751,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 32.18399999999999,
"eventListeners": 2381,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8303.846000000021,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.004000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5631.137,
"heapDeltaBytes": -12040308,
"heapUsedBytes": 88984416,
"domNodes": -268,
"jsHeapTotalBytes": -876544,
"scriptDurationMs": 2528.7409999999995,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8295.342000000004,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.225,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5602.549,
"heapDeltaBytes": 13502016,
"heapUsedBytes": 88724616,
"domNodes": -268,
"jsHeapTotalBytes": -126976,
"scriptDurationMs": 2498.3500000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18290.00100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17535.635999999995,
"heapDeltaBytes": -24126264,
"heapUsedBytes": 178149556,
"domNodes": -6548,
"jsHeapTotalBytes": -2117632,
"scriptDurationMs": 306.52000000000004,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18156.23400000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17512.431,
"heapDeltaBytes": -30972560,
"heapUsedBytes": 178873784,
"domNodes": -6548,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 300.837,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22388.936999999998,
"styleRecalcs": 165,
"styleRecalcDurationMs": 21.550999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22118.918999999998,
"heapDeltaBytes": -47293232,
"heapUsedBytes": 166313364,
"domNodes": -6548,
"jsHeapTotalBytes": -8679424,
"scriptDurationMs": 957.373,
"eventListeners": -7469,
"totalBlockingTimeMs": 265,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22322.015999999963,
"styleRecalcs": 163,
"styleRecalcDurationMs": 21.537000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22029.803,
"heapDeltaBytes": -36057224,
"heapUsedBytes": 176529704,
"domNodes": -6548,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 917.1399999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 159,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6441.040999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.868,
"layouts": 20,
"layoutDurationMs": 30.71,
"taskDurationMs": 6378.97,
"heapDeltaBytes": -35014748,
"heapUsedBytes": 174725564,
"domNodes": -6548,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 117.00500000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 681,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6510.6269999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.959,
"layouts": 20,
"layoutDurationMs": 23.82200000000001,
"taskDurationMs": 6394.252,
"heapDeltaBytes": -26856688,
"heapUsedBytes": 175986648,
"domNodes": -6548,
"jsHeapTotalBytes": 12599296,
"scriptDurationMs": 120.43400000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 351,
"frameDurationMs": 18.33333333333327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 104.09899999990557,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.381,
"layouts": 2,
"layoutDurationMs": 0.6130000000000001,
"taskDurationMs": 81.165,
"heapDeltaBytes": 3115184,
"heapUsedBytes": 71952448,
"domNodes": 111,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.1690000000000005,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 453.8989999999785,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.866,
"layouts": 3,
"layoutDurationMs": 0.8640000000000002,
"taskDurationMs": 102.323,
"heapDeltaBytes": 4841628,
"heapUsedBytes": 72706692,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.753999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook |
Addresses #14073 (comment) Addresses #14073 (comment)
| await expect(preview).toHaveValue('recovered again') | ||
| }) | ||
|
|
||
| await test.step('nullish output does not wedge the widget', async () => { |
There was a problem hiding this comment.
did you mean the step label wording itself, or is there a specific behavior here you want changed? happy to adjust if you can point at what should differ.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16605 +/- ##
==========================================
+ Coverage 80.68% 82.34% +1.65%
==========================================
Files 2432 2029 -403
Lines 124058 117078 -6980
Branches 30999 31256 +257
==========================================
- Hits 100097 96403 -3694
+ Misses 23460 20497 -2963
+ Partials 501 178 -323
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Addresses review feedback: #16605 (comment)
|
@coderabbitai review |
|
|
Unresolved review request queued. Full context for agent readersThe unresolved human thread says, “Slight inclination to have this parameterized.” The author requested clarification, but no resolution landed before merge and no open or merged follow-up PR back-references #16605. Queued as |
|
Correction: the named review request was already fixed and resolved before merge; the queued follow-up is closed as unnecessary. |
Summary
Full context for agent readers
Changes
nulland omittedoutputpayloads, then adds browser coverage proving Preview as Text clears without wedging and accepts a later valid update.JSON.parse(event.data) as ApiMessageUnioningress cast is not bundled here because changing the full WebSocket contract is independent of the preview regression test and needs dedicated schema/compatibility analysis.Verification
pnpm typecheckpnpm typecheck:browserpnpm test:unit src/extensions/core/textPreviewWidgets.test.ts(12 passed)Review Focus
Please confirm the fixture models both wire shapes correctly: explicit
output: nulland omittedoutput(produced byundefined).