Repository navigation
feat(agent-crdt): add failure telemetry for alpha - #16604
christian-byrne wants to merge 28 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No concrete current-head merge risk remains: stale workflow events are filtered before affecting follower state, and the previously identified listener cleanup and socket payload typing concerns are addressed. 🚥 Pre-merge checks | ✅ 7
✨ Finishing Touches
Comment |
🎭 Playwright: ✅ 2160 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T08:50:52.676Z",
"gitSha": "dac3907e9512f68869546e7fa170f8b97c2c7e61",
"branch": "christian-byrne/ta-79-crdt-telemetry",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.848000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.475999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.90400000000005,
"heapDeltaBytes": -2531760,
"heapUsedBytes": 76906380,
"domNodes": -228,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.139000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.4000000000515,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.1680000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.02399999999994,
"heapDeltaBytes": -73828,
"heapUsedBytes": 79377672,
"domNodes": -228,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 8.886999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1751.0750000000144,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.230999999999998,
"layouts": 12,
"layoutDurationMs": 3.5900000000000003,
"taskDurationMs": 708.095,
"heapDeltaBytes": -4752132,
"heapUsedBytes": 74518580,
"domNodes": -228,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 127.70099999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1781.2850000000253,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.841,
"layouts": 12,
"layoutDurationMs": 3.907000000000001,
"taskDurationMs": 745.8580000000001,
"heapDeltaBytes": -38697756,
"heapUsedBytes": 59833316,
"domNodes": -228,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 133.443,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.823584905660372,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.98200000003,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.03,
"layouts": 6,
"layoutDurationMs": 1.3750000000000002,
"taskDurationMs": 305.666,
"heapDeltaBytes": 1473628,
"heapUsedBytes": 80874180,
"domNodes": 53,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.033000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.126000000083,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.86,
"layouts": 6,
"layoutDurationMs": 1.358,
"taskDurationMs": 317.37000000000006,
"heapDeltaBytes": -18670908,
"heapUsedBytes": 79975348,
"domNodes": 53,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.761999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 605.5620000000204,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.4549999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.45099999999996,
"heapDeltaBytes": -1566972,
"heapUsedBytes": 96844620,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 138.852,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 639.4169999999804,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.758,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.725,
"heapDeltaBytes": 17947712,
"heapUsedBytes": 97435832,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 145.948,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684193,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1099.3889999999737,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 750.2669999999999,
"heapDeltaBytes": 10052856,
"heapUsedBytes": 87473528,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 57.31400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 480,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1089.4240000000082,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 719.053,
"heapDeltaBytes": 6802836,
"heapUsedBytes": 84168940,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 50.47599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 452,
"frameDurationMs": 31.861764705882358,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 779.8919999999612,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.9110000000001,
"heapDeltaBytes": 15286496,
"heapUsedBytes": 88566576,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 120.77999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 152,
"frameDurationMs": 23.04117647058825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 757.376000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.2790000000001,
"heapDeltaBytes": 15663720,
"heapUsedBytes": 90342828,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 115.473,
"eventListeners": 0,
"totalBlockingTimeMs": 142,
"frameDurationMs": 22.547058823529397,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7743.374000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6708.037,
"heapDeltaBytes": -9606684,
"heapUsedBytes": 70675628,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 5453.663,
"eventListeners": 0,
"totalBlockingTimeMs": 131,
"frameDurationMs": 29.856756756756756,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8185.948999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7315.408999999999,
"heapDeltaBytes": 11247708,
"heapUsedBytes": 93313204,
"domNodes": 0,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 5748.063,
"eventListeners": 0,
"totalBlockingTimeMs": 68,
"frameDurationMs": 27.68237288135593,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7804.247999999972,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.030999999999999778,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7105.708,
"heapDeltaBytes": 10684040,
"heapUsedBytes": 91507820,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 5548.154,
"eventListeners": 0,
"totalBlockingTimeMs": 122,
"frameDurationMs": 28.405109489051096,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7608.9450000000625,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6877.192,
"heapDeltaBytes": 11619220,
"heapUsedBytes": 92501340,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 5349.231,
"eventListeners": 0,
"totalBlockingTimeMs": 52,
"frameDurationMs": 27.535144927536233,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2030.3670000000125,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0180000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.185,
"heapDeltaBytes": -37427300,
"heapUsedBytes": 82885828,
"domNodes": -230,
"jsHeapTotalBytes": -98304,
"scriptDurationMs": 29.141000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.3529999999537,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0440000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.341,
"heapDeltaBytes": -37101224,
"heapUsedBytes": 82622596,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 39.657,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2145.719999999983,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1396.0239999999997,
"heapDeltaBytes": 19572212,
"heapUsedBytes": 82168676,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 683.591,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2286.0640000000103,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.948,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1402.9750000000001,
"heapDeltaBytes": 18673836,
"heapUsedBytes": 82042756,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 695.917,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665441176470587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3403.181000000018,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.351000000000003,
"layouts": 60,
"layoutDurationMs": 13.382,
"taskDurationMs": 1442.735,
"heapDeltaBytes": 9870192,
"heapUsedBytes": 73434976,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 633.81,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600985221675,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3439.341000000013,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.07,
"layouts": 60,
"layoutDurationMs": 14.127,
"taskDurationMs": 1467.3090000000002,
"heapDeltaBytes": 9151952,
"heapUsedBytes": 72759852,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 644.949,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665700483091783,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2908.211999999992,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.680000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1657.1049999999998,
"heapDeltaBytes": 26735216,
"heapUsedBytes": 90797060,
"domNodes": -228,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 802.599,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589595375723,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2960.389999999961,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.5440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1722.543,
"heapDeltaBytes": 20472772,
"heapUsedBytes": 85473480,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 867.136,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760795454545452,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.246999999994,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.0240000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.909,
"heapDeltaBytes": -38166292,
"heapUsedBytes": 83291528,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 33.525999999999996,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2025.4720000000361,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.558999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.6139999999999,
"heapDeltaBytes": -38084332,
"heapUsedBytes": 83849800,
"domNodes": -228,
"jsHeapTotalBytes": -1146880,
"scriptDurationMs": 31.244999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.3870000000106,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.292,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.294,
"heapDeltaBytes": 12643412,
"heapUsedBytes": 94072552,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 123.73200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.7339999999595,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.317999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.09599999999995,
"heapDeltaBytes": 12423828,
"heapUsedBytes": 93792144,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 123.41000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2042.4039999999763,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8190000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.642,
"heapDeltaBytes": -10827392,
"heapUsedBytes": 70459764,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.767999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.2670000000135,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.309000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.829,
"heapDeltaBytes": -16243188,
"heapUsedBytes": 64215816,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 7.828999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.4310000000046,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.563000000000002,
"layouts": 16,
"layoutDurationMs": 4.811999999999999,
"taskDurationMs": 704.4240000000001,
"heapDeltaBytes": -17422468,
"heapUsedBytes": 63857104,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 92.081,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.7300000000123,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.182,
"layouts": 16,
"layoutDurationMs": 5.207,
"taskDurationMs": 683.2719999999999,
"heapDeltaBytes": -13911744,
"heapUsedBytes": 67424348,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 90.775,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 934.6199999999953,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.101000000000006,
"layouts": 5,
"layoutDurationMs": 9.957999999999998,
"taskDurationMs": 783.4839999999998,
"heapDeltaBytes": 23187060,
"heapUsedBytes": 103721572,
"domNodes": 13667,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.557999999999993,
"eventListeners": 2383,
"totalBlockingTimeMs": 133,
"frameDurationMs": 21.11111111111111,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 8216.993000000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.447,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4909.593,
"heapDeltaBytes": -35250928,
"heapUsedBytes": 84629968,
"domNodes": -228,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 2236.3970000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8213.864000000058,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.918000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5056.104,
"heapDeltaBytes": -41382712,
"heapUsedBytes": 78906392,
"domNodes": -228,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 2329.6549999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14253.207999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13849.935,
"heapDeltaBytes": -55104644,
"heapUsedBytes": 167929384,
"domNodes": -3046,
"jsHeapTotalBytes": 6660096,
"scriptDurationMs": 236.386,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.58240574506284,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14070.157999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13036.9,
"heapDeltaBytes": -44632828,
"heapUsedBytes": 180384840,
"domNodes": -3045,
"jsHeapTotalBytes": 6078464,
"scriptDurationMs": 232.014,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.522073578595318,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 17389.54799999999,
"styleRecalcs": 131,
"styleRecalcDurationMs": 18.71400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17148.808,
"heapDeltaBytes": -50546100,
"heapUsedBytes": 166674880,
"domNodes": -3045,
"jsHeapTotalBytes": 11599872,
"scriptDurationMs": 875.525,
"eventListeners": -14915,
"totalBlockingTimeMs": 34,
"frameDurationMs": 33.39615384615385,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17033.21900000003,
"styleRecalcs": 136,
"styleRecalcDurationMs": 16.71800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16643.078,
"heapDeltaBytes": -55809084,
"heapUsedBytes": 166532512,
"domNodes": -3046,
"jsHeapTotalBytes": 6262784,
"scriptDurationMs": 817.998,
"eventListeners": -14915,
"totalBlockingTimeMs": 102,
"frameDurationMs": 31.69014869888476,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5105.775999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.48000000000002,
"layouts": 20,
"layoutDurationMs": 24.457000000000008,
"taskDurationMs": 5007.397999999999,
"heapDeltaBytes": 13903056,
"heapUsedBytes": 212051924,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 98.28000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 169,
"frameDurationMs": 29.650000000000006,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 3760.3019999999105,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.27999999999997,
"layouts": 20,
"layoutDurationMs": 22.803000000000004,
"taskDurationMs": 3648.268,
"heapDeltaBytes": 6769376,
"heapUsedBytes": 191601656,
"domNodes": 0,
"jsHeapTotalBytes": 19922944,
"scriptDurationMs": 71.55700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.066292134831457,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7263.950000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6836.829999999999,
"heapDeltaBytes": -43906924,
"heapUsedBytes": 187982608,
"domNodes": -3045,
"jsHeapTotalBytes": 6041600,
"scriptDurationMs": 115.37699999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.437192982456136,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7187.37299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6758.277000000002,
"heapDeltaBytes": -12860140,
"heapUsedBytes": 167698820,
"domNodes": -1,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 110.84200000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.57235494880545,
"p95FrameDurationMs": 33.5
},
{
"name": "workflow-execution",
"durationMs": 465.95800000000054,
"styleRecalcs": 17,
"styleRecalcDurationMs": 17.802000000000003,
"layouts": 4,
"layoutDurationMs": 1.8010000000000002,
"taskDurationMs": 140.579,
"heapDeltaBytes": -14100092,
"heapUsedBytes": 82908980,
"domNodes": 106,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.367,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 146.49200000008022,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.511999999999999,
"layouts": 4,
"layoutDurationMs": 2.216,
"taskDurationMs": 119.084,
"heapDeltaBytes": -16835280,
"heapUsedBytes": 79993592,
"domNodes": 120,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.441999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 626.2310000000753,
"styleRecalcs": 78,
"styleRecalcDurationMs": 88.812,
"layouts": 76,
"layoutDurationMs": 16.742,
"taskDurationMs": 566.2330000000001,
"heapDeltaBytes": -16467024,
"heapUsedBytes": 70454012,
"domNodes": 76,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 209.549,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 721.6070000000627,
"styleRecalcs": 78,
"styleRecalcDurationMs": 102.388,
"layouts": 76,
"layoutDurationMs": 17.171,
"taskDurationMs": 651.7660000000001,
"heapDeltaBytes": -15773632,
"heapUsedBytes": 73595620,
"domNodes": 76,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 244.10399999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.478048780487814,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1170.8640000000514,
"styleRecalcs": 78,
"styleRecalcDurationMs": 226.66,
"layouts": 76,
"layoutDurationMs": 18.064,
"taskDurationMs": 1139.2859999999998,
"heapDeltaBytes": 5638840,
"heapUsedBytes": 128750204,
"domNodes": -7945,
"jsHeapTotalBytes": -3448832,
"scriptDurationMs": 328.23400000000004,
"eventListeners": -1228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.904285714285702,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1084.7619999999552,
"styleRecalcs": 78,
"styleRecalcDurationMs": 225.51399999999998,
"layouts": 76,
"layoutDurationMs": 17.375999999999998,
"taskDurationMs": 1065.479,
"heapDeltaBytes": 14042712,
"heapUsedBytes": 132351268,
"domNodes": -7910,
"jsHeapTotalBytes": -4497408,
"scriptDurationMs": 298.175,
"eventListeners": -1224,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664615384615395,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e51671a5dbde87fa8799d64d7b1c3c7aa10ef23a
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #16604 +/- ##
==========================================
+ Coverage 84.14% 85.00% +0.86%
==========================================
Files 3226 2333 -893
Lines 155836 133228 -22608
Branches 40278 37010 -3268
==========================================
- Hits 131131 113257 -17874
+ Misses 22977 19617 -3360
+ Partials 1728 354 -1374
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 900 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Found two telemetry integrity issues that should be addressed before relying on these alerts.
DrJKL
left a comment
There was a problem hiding this comment.
Two additional TypeScript type-safety issues should be cleaned up in this PR rather than copied from existing untyped event code.
…econnect history Addresses 4 unresolved review threads from DrJKL on PR #16604: - reportSubscribeFailure no longer forwards the server-supplied doc_subscribed message/code verbatim to Sentry/Datadog. The error text is now fixed and client-owned; the code tag is normalized through an allowlist so an arbitrary server value can't reach telemetry as an unbounded-cardinality tag. #16604 (comment) - onReconnecting now ignores events when there's no active subscription target, and the reconnect-storm history resets whenever the active target changes, so reconnects from one workflow (or from before any subscription existed) no longer count toward another workflow's storm threshold. #16604 (comment) - New readEventCode() narrows an unknown detail down to its code field via an explicit `in` check + typeof guard instead of asserting the whole shape. #16604 (comment) - Replaced the reconnects[0]! non-null assertion with an explicit undefined check. #16604 (comment) Updated the exhausted-auth-refusal test to assert the new fixed message and normalized code, and added a test covering an unrecognized refusal code normalizing to 'unknown'.
|
@coderabbitai review |
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 7 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Addresses #16604 (comment) Addresses #16604 (comment)
Addresses #16604 (comment) Addresses #16604 (comment)
Addresses #16604 (comment) Addresses #16604 (comment)
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested
I confirmed that edde60d fixes my prior retry-phase test finding. The explicit refusal phases now expose the exhaustion boundary, and a targeted >= to > mutation fails the final-refusal assertion while the current head passes.
One telemetry contract issue remains inline. I also cannot treat the current PR description as reviewable evidence yet:
- It names
agentCrdtReconnectPolicy.test.tsandagentCrdtTelemetry.harness.test.ts, neither of which exists, reports stale83 + 1totals, and usesnpxinstead of this repository's required pnpm commands. My focused current-head run passed 82 tests in the actual three files I selected. - It says full
pnpm fallow checkpassed, but that command currently exits 1 with 672 inherited findings. The accurate result is that the diff-scopedpnpm fallow audit --base 7870978b1b234c231855f9b2b85860add3ab2895passed with no issues in the 10 changed files. - It says Playwright discovery found 807 tests; current discovery finds 2446 tests in 414 files.
- “Black-box harness coverage” overstates collaborator-mocked composable tests, and the claimed harness test does not exist. The tests are useful, but the description should name their actual level.
- The cloud counterpart link points to nonexistent
Comfy-Org/comfy-cloud#9915; the verified PR isComfy-Org/cloud#9915.
All current check runs are complete and successful or intentionally skipped. Locally, the focused tests, workspace and browser typechecks, changed-file ESLint, type-aware Oxlint, formatting, Knip, diff-scoped Fallow audit, Playwright discovery, and git diff --check passed. Full Fallow has the inherited failure above.
| : 'CRDT update has no bound projection target' | ||
| ), | ||
| { | ||
| errorType: 'error_reading_crdt_document', |
There was a problem hiding this comment.
This errorType also covers missing_projection_target, but that branch did not fail to read the CRDT document; it failed because no projection target was bound. Since errorType is a stable telemetry contract, combining these two incidents makes alerts and queries misclassify projection failures as schema/read failures. Please give the missing-target branch a projection-specific slug while retaining error_reading_crdt_document for schema_mismatch.
There was a problem hiding this comment.
Done in b0450b0: missing_projection_target now reports errorType: 'missing_crdt_projection_target' and schema_mismatch keeps error_reading_crdt_document.
Both slugs moved into one module-level DOC_DIVERGENCE_REPORTS map next to their messages, so the branch and the slug it reports under cannot drift apart later. The once-per-incident bound, the reason tag, the contexts and the three re-arm points (successful apply, confirmed subscribe, retarget) are unchanged.
Full context for agent readers
Thread: r4057226505 on src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts.
Before: reportDocDivergence branched on reason only to pick the message, then hardcoded errorType: 'error_reading_crdt_document' for both, so a query or alert on document-read failures also counted every update that merged fine and only lacked a bound projection target.
After:
const DOC_DIVERGENCE_REPORTS = {
schema_mismatch: {
errorType: 'error_reading_crdt_document',
message: 'CRDT document schema is unreadable'
},
missing_projection_target: {
errorType: 'missing_crdt_projection_target',
message: 'CRDT update has no bound projection target'
}
} as constdivergenceReported is now keyed by 'apply_error' | DocDivergenceReason off that same map, so adding a reason without a slug is a type error rather than a silent fallback.
Regression: keeps the unbound-projection slug distinct from the document-read slug drives both branches in one mount (applyFrame returning false, then a schema_error frame) and asserts the emitted errorType sequence is ['missing_crdt_projection_target', 'error_reading_crdt_document']. Red measured on the parent source rather than asserted: restoring the pre-fix useAgentCrdtFollower.ts from a byte copy at this tree gives 3 failed / 69 passed (this case plus the two existing slug assertions); the fix restored gives 72 passed.
Gates at b0450b0528, Node 26.8.2 with NODE_OPTIONS=--no-experimental-webstorage on every vitest run: useAgentCrdtFollower.test.ts + reconnectTelemetryPolicy.test.ts 74/74, vue-tsc --noEmit (with --max-old-space-size=8192), changed-file ESLint, oxfmt --check, pnpm oxlint:main (five unrelated baseline warnings), pnpm knip, pnpm fallow audit (no issues in 10 changed files), git diff --check.
Not changed, and worth naming: the apply_error branch keeps error_applying_crdt_update, which was already distinct. The PR body's "six alpha-critical CRDT failures" count is unaffected, since this splits two incidents that were already described separately there.
Thread left unresolved for you, since it is yours to close.
… read slug `errorType` is the queryable telemetry contract, and both divergence reasons were reporting under `error_reading_crdt_document`. A missing projection target is not a read failure: the document merged fine and only had no bound target to project onto, so any alert or query on schema/read failures was also counting projection-binding failures. `missing_projection_target` now reports as `missing_crdt_projection_target`; `schema_mismatch` keeps `error_reading_crdt_document`. Both slugs live in one `DOC_DIVERGENCE_REPORTS` map beside their messages, so the branch and its slug cannot drift apart. The once-per-incident bound, the `reason` tag, the contexts and the re-arm points are unchanged. Regression: `keeps the unbound-projection slug distinct from the document-read slug` drives both branches in one mount and asserts the two emitted `errorType` values differ. Red on the parent source (3 failed / 69 passed), green with the fix (72 passed). Addresses #16604 (comment)
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested
I confirmed that b0450b0 fixes the classification bug from my previous inline finding. The projection and document-read paths now emit different slugs, and restoring the old shared slug makes the new regression test fail. The focused current-head suite passes 74/74.
Three current-head findings remain inline. The live PR description also still carries all five claim groups from my previous review:
- Its verification commands name two nonexistent test files, report stale
83 + 1totals, and usenpxinstead of the repository's pnpm commands. - It says full
pnpm fallow checkpassed. That command previously exited 1 with 672 inherited findings. The accurate current result is that the diff-scoped Fallow audit passes with no issues in the 10 changed files. - It says Playwright discovery found 807 tests. The current repository discovery from the previous round found 2446 tests in 414 files.
- It calls collaborator-mocked composable tests a black-box harness, but no harness test exists.
- It links
Comfy-Org/comfy-cloud#9915; the verified counterpart isComfy-Org/cloud#9915.
I ran the focused tests, workspace typecheck, changed-file ESLint, type-aware Oxlint, formatting, Knip, diff-scoped Fallow audit, and git diff --check; all passed. All 101 current check runs are complete and successful or intentionally skipped. GitHub currently reports mergeability as unknown.
| message: 'CRDT document schema is unreadable' | ||
| }, | ||
| missing_projection_target: { | ||
| errorType: 'missing_crdt_projection_target', |
There was a problem hiding this comment.
[P2] Splitting the incidents fixes the original problem, but this replacement slug does not follow src/AGENTS.md’s required <category>_<operation>_<subject>[_detail] order: missing is a state, not the error or failure category used by the telemetry contract. Please use a projection-specific slug in the required order, for example error_projecting_crdt_update_missing_target, and update the assertions.
| return REFUSAL_CODES.has(code) | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
[P3] Please delete this block comment. The two mapping entries already show that the reasons have distinct slugs and messages, the regression test enforces it, and src/AGENTS.md owns the stable-telemetry-contract rule. Repeating all of that in seven lines is exactly the multi-line justification comment the repository guidance prohibits.
| dispatchFrame('doc_update', { workflowId: 'wf-1', seq: 1 }) | ||
| dispatchFrame('schema_error', { workflowId: 'wf-1', code: 'unreadable' }) | ||
|
|
||
| // `errorType` is the queryable telemetry contract: an alert on |
There was a problem hiding this comment.
[P3] Please delete this comment. The test name and the expected two-slug sequence immediately below already state this contract, so these three lines only paraphrase the assertion.
|
Merged |
|
Merged |
|
Merged |
|
Not closing, but flagging before more of this lands. This PR adds telemetry that measures a disagreement between two implementations of the same behaviour rather than removing the second implementation. The survey found twelve open PRs in this shape. Each metric exists because the agent path and the user path can diverge, and each will read zero by construction once they share a channel: widget writes through What this PR measures: six CRDT failure classes reported through The retirement plan is FE-3586: list every drift event, and for each either the PR that deleted it or the reason it still carries information after that work. Genuine failure reporting goes through Recommendation: the Context: FE-3387 (Agent/CRDT alignment programme) and the open-PR survey of 2026-10-22 (thread). Posted for DrJKL. |
Summary
The CRDT follower now reports exhausted connect/auth failures, reconnect storms, schema/doc divergence, apply failures, and abnormal WebSocket 1006 closes via
reportError. A typedsocketClosedAPI event supplies close metadata without changing the existing reconnect event contract.Changes
Verification
NODE_OPTIONS="--no-experimental-webstorage" npx vitest run src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts src/workbench/extensions/agent/crdt/agentCrdtReconnectPolicy.test.ts src/scripts/api.eventListeners.test.ts— 83 passed in 3 filesNODE_OPTIONS="--no-experimental-webstorage" npx vitest run src/workbench/extensions/agent/crdt/agentCrdtTelemetry.harness.test.ts— 1 passedpnpm typecheck— passedpnpm knip— passedpnpm fallow check— passedpnpm exec playwright test --list— 807 tests discoveredgit diff --check— passedPrivacy boundary
Telemetry intentionally excludes workflow content and operation payloads. Only classification fields, bounded counters, workflow ID, and sequence number are included.