Repository navigation
fix(onboarding): follow-up to #14673 — tour hold precondition and viewport coverage - #16598
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe onboarding tour store now requires an active entry-path hold before starting a tour. Unit tests initialize app context consistently, and browser tests cover viewport narrowing during the app-mode welcome flow. ChangesOnboarding tour entry
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR prevents invalid tour registration before state mutation and adds coverage for viewport-triggered tour teardown; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed files are available and include Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed-file list contains only onboarding store/test files and a browser tour test. It contains no files under
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: 🚧 Building...🎭 Playwright: ✅ 1901 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.68 MB gzip 🔴 +3 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • 🔴 +25 BStores, services, APIs, and repositories
Status: 2 added / 2 removed / 14 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 294 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T14:53:59.740Z",
"gitSha": "e8bfb4ceed2ee6aafe36cf9a94d20d817031acd8",
"branch": "fix/14673-tour-holds-precondition-followup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2030.6860000000029,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.789,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.46399999999994,
"heapDeltaBytes": -11580572,
"heapUsedBytes": 58655468,
"domNodes": -284,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.276,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2044.401999999991,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.066000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.016,
"heapDeltaBytes": 8709948,
"heapUsedBytes": 78503628,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.896999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2064.737999999977,
"styleRecalcs": 79,
"styleRecalcDurationMs": 45.292,
"layouts": 14,
"layoutDurationMs": 4.9319999999999995,
"taskDurationMs": 1041.112,
"heapDeltaBytes": -7696896,
"heapUsedBytes": 62853488,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 190.23000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1856.1750000000075,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.827,
"layouts": 14,
"layoutDurationMs": 4.337,
"taskDurationMs": 884.3999999999999,
"heapDeltaBytes": -13002744,
"heapUsedBytes": 57423556,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 157.879,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.210999999992,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.487000000000002,
"layouts": 6,
"layoutDurationMs": 1.153,
"taskDurationMs": 361.402,
"heapDeltaBytes": 4771312,
"heapUsedBytes": 75500512,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.622999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.2669999999644,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.842999999999996,
"layouts": 6,
"layoutDurationMs": 1.035,
"taskDurationMs": 362.101,
"heapDeltaBytes": 4828960,
"heapUsedBytes": 75207688,
"domNodes": 76,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 11.454000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 672.585999999967,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.528999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.884,
"heapDeltaBytes": 18194336,
"heapUsedBytes": 88166968,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 164.95399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 677.7379999999766,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.810000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.24,
"heapDeltaBytes": -7772592,
"heapUsedBytes": 62618476,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 166.619,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.171000000034,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.162000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.265,
"heapDeltaBytes": -14611316,
"heapUsedBytes": 86373804,
"domNodes": -264,
"jsHeapTotalBytes": -1363968,
"scriptDurationMs": 33.22800000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.5419999999212,
"styleRecalcs": 3,
"styleRecalcDurationMs": 4.9209999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.5070000000002,
"heapDeltaBytes": 11891204,
"heapUsedBytes": 86918860,
"domNodes": -272,
"jsHeapTotalBytes": -1400832,
"scriptDurationMs": 37.23799999999999,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2295.353999999975,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.298000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1657.8319999999999,
"heapDeltaBytes": 27208276,
"heapUsedBytes": 92765292,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 823.466,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2198.8910000000033,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.753999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1594.6609999999998,
"heapDeltaBytes": 26432156,
"heapUsedBytes": 92702584,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 791.279,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3724.6390000000247,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.980000000000002,
"layouts": 60,
"layoutDurationMs": 12.046999999999999,
"taskDurationMs": 1782.0869999999998,
"heapDeltaBytes": 12703624,
"heapUsedBytes": 80284604,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 829.276,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3525.6279999999833,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.578000000000003,
"layouts": 60,
"layoutDurationMs": 11.623,
"taskDurationMs": 1677.1600000000003,
"heapDeltaBytes": 7747052,
"heapUsedBytes": 75135052,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 759.1719999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3012.734000000023,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.529999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1911.936,
"heapDeltaBytes": 21950324,
"heapUsedBytes": 89703340,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 933.808,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2963.090999999963,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.788,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1858.9819999999997,
"heapDeltaBytes": 18211240,
"heapUsedBytes": 87798048,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 919.151,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2016.0419999999704,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8529999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.788,
"heapDeltaBytes": 21884272,
"heapUsedBytes": 87729792,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.495000000000008,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2022.4319999999807,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.049,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.071,
"heapDeltaBytes": 10293888,
"heapUsedBytes": 87137036,
"domNodes": -272,
"jsHeapTotalBytes": -2187264,
"scriptDurationMs": 31.122999999999998,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.6520000000392,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.831,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.46199999999993,
"heapDeltaBytes": 14901732,
"heapUsedBytes": 87754180,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.874,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.9319999999898,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.108,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.2250000000001,
"heapDeltaBytes": 14784800,
"heapUsedBytes": 87534568,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 137.42300000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.4849999999842,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.822000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.97499999999997,
"heapDeltaBytes": -73048,
"heapUsedBytes": 71993752,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.334999999999999,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.705999999971,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.899000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.62300000000005,
"heapDeltaBytes": 3429432,
"heapUsedBytes": 75468408,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.625,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.437000000015,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.881,
"layouts": 18,
"layoutDurationMs": 5.549999999999999,
"taskDurationMs": 868.986,
"heapDeltaBytes": -13811188,
"heapUsedBytes": 58796740,
"domNodes": -292,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 116.176,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.9059999999808,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.537,
"layouts": 18,
"layoutDurationMs": 5.505,
"taskDurationMs": 835.839,
"heapDeltaBytes": -10430808,
"heapUsedBytes": 62269704,
"domNodes": -298,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 111.28699999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.1179999999968,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.495999999999995,
"layouts": 15,
"layoutDurationMs": 16.335999999999995,
"taskDurationMs": 953.8049999999998,
"heapDeltaBytes": -11267928,
"heapUsedBytes": 84673040,
"domNodes": 13751,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 29.968000000000007,
"eventListeners": 2381,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8622.36999999999,
"styleRecalcs": 246,
"styleRecalcDurationMs": 33.239000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5891.927,
"heapDeltaBytes": 17311468,
"heapUsedBytes": 92729048,
"domNodes": -273,
"jsHeapTotalBytes": -913408,
"scriptDurationMs": 2664.4480000000003,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8470.44100000005,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.68000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5823.5,
"heapDeltaBytes": -10980592,
"heapUsedBytes": 89327912,
"domNodes": -266,
"jsHeapTotalBytes": -352256,
"scriptDurationMs": 2643.441,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16959.749999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16449.501,
"heapDeltaBytes": -31485920,
"heapUsedBytes": 177230304,
"domNodes": -6548,
"jsHeapTotalBytes": -1970176,
"scriptDurationMs": 274.581,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17796.91200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16948.836,
"heapDeltaBytes": -27065792,
"heapUsedBytes": 174997404,
"domNodes": -6548,
"jsHeapTotalBytes": 2080768,
"scriptDurationMs": 295.738,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20895.83799999997,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.07599999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20475.803000000004,
"heapDeltaBytes": -33664708,
"heapUsedBytes": 176360364,
"domNodes": -6548,
"jsHeapTotalBytes": -5971968,
"scriptDurationMs": 925.3889999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21087.784000000058,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.527000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20746.327999999998,
"heapDeltaBytes": -29259076,
"heapUsedBytes": 179889440,
"domNodes": -6548,
"jsHeapTotalBytes": -4923392,
"scriptDurationMs": 879.95,
"eventListeners": -7469,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6207.198000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.88800000000002,
"layouts": 20,
"layoutDurationMs": 23.231,
"taskDurationMs": 6079.188,
"heapDeltaBytes": -30257696,
"heapUsedBytes": 179539356,
"domNodes": -6548,
"jsHeapTotalBytes": 10846208,
"scriptDurationMs": 115.432,
"eventListeners": -7473,
"totalBlockingTimeMs": 410,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6213.69100000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.50999999999998,
"layouts": 20,
"layoutDurationMs": 21.638000000000005,
"taskDurationMs": 6115.764999999999,
"heapDeltaBytes": -15458044,
"heapUsedBytes": 188799868,
"domNodes": -6548,
"jsHeapTotalBytes": 17395712,
"scriptDurationMs": 114.70899999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 412,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 466.7180000000144,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.166,
"layouts": 3,
"layoutDurationMs": 1.422,
"taskDurationMs": 108.35200000000002,
"heapDeltaBytes": 4908764,
"heapUsedBytes": 72730972,
"domNodes": 147,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.639,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 442.08800000001247,
"styleRecalcs": 15,
"styleRecalcDurationMs": 23.974000000000004,
"layouts": 4,
"layoutDurationMs": 1.7519999999999998,
"taskDurationMs": 108.607,
"heapDeltaBytes": 4783868,
"heapUsedBytes": 73451748,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.735000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
|
|
Adopted as the existing carrier for #14673; no duplicate PR opened. Full context for agent readersDedupe and current-head read-back confirm this PR covers the deferred review work: store-level hold enforcement plus real-browser mid-tour viewport narrowing. Source dispositions are recorded at #14673 (comment). The default FE assignees and roster reviewer request are present. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16598 +/- ##
==========================================
+ Coverage 80.76% 82.38% +1.61%
==========================================
Files 2440 2031 -409
Lines 124596 117354 -7242
Branches 31154 31235 +81
==========================================
- Hits 100629 96678 -3951
+ Misses 23465 20498 -2967
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 409 files with indirect coverage changes 🚀 New features to boost your workflow:
|
c0b1cb5 to
3a772c2
Compare
|
Rebased onto current Full context for agent readers
CI is running on the rebased head. The prior approval predates this exact head, so CodeJuggernaut has been re-requested. |
Follow-up to #14673
Summary
Follow-up to #14673.
Addressed review records:
Verification
pnpm typecheckpnpm typecheck:browserpnpm test:unit src/platform/onboarding(188 passed)pnpm test:unit src/renderer/extensions/firstRunTour src/platform/onboarding(435 passed; one unrelated timing test failed under parallel load and passed alone)