Repository navigation
fix(widgets): follow-up to #15759 — preserve compacted dynamic values - #16592
Conversation
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
🎨 Storybook: 🚧 Building...🎭 Playwright: ✅ 1896 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.67 MB gzip 🔴 +22 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • 🔴 +218 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 17 added / 17 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 70 added / 70 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T05:50:36.927Z",
"gitSha": "80da6eeb1fc5fe1f6678b57a9a94758e08146bdd",
"branch": "dm67-b-fe15759-followup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2034.1109999999958,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.92,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.29,
"heapDeltaBytes": -12092428,
"heapUsedBytes": 57545404,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.195999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.361999999969,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.873999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.712,
"heapDeltaBytes": 5399984,
"heapUsedBytes": 75246880,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.554,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2165.37900000003,
"styleRecalcs": 81,
"styleRecalcDurationMs": 58.666999999999994,
"layouts": 14,
"layoutDurationMs": 5.13,
"taskDurationMs": 1191.9370000000001,
"heapDeltaBytes": 5561532,
"heapUsedBytes": 75321428,
"domNodes": -279,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 183.45899999999997,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1915.1190000000042,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.821,
"layouts": 14,
"layoutDurationMs": 4.787,
"taskDurationMs": 981.334,
"heapDeltaBytes": -6912668,
"heapUsedBytes": 63609812,
"domNodes": -280,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 153.89700000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.7819999999,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.108999999999998,
"layouts": 6,
"layoutDurationMs": 1.024,
"taskDurationMs": 399.04499999999996,
"heapDeltaBytes": 4397728,
"heapUsedBytes": 75100464,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.831000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.27700000002,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.566999999999997,
"layouts": 6,
"layoutDurationMs": 1.265,
"taskDurationMs": 410.375,
"heapDeltaBytes": 4453012,
"heapUsedBytes": 75081228,
"domNodes": 75,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 13.314,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 708.8130000000206,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.832999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.06000000000006,
"heapDeltaBytes": -7769604,
"heapUsedBytes": 62818148,
"domNodes": 16,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 154.87699999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 726.7980000000307,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.376,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.15,
"heapDeltaBytes": 18111176,
"heapUsedBytes": 87797296,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 158.846,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2060.777999999914,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.311,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 702.6709999999999,
"heapDeltaBytes": -14256204,
"heapUsedBytes": 86610524,
"domNodes": -266,
"jsHeapTotalBytes": -835584,
"scriptDurationMs": 34.937,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.7869999999803,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.815999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.993,
"heapDeltaBytes": -13811588,
"heapUsedBytes": 87208068,
"domNodes": -271,
"jsHeapTotalBytes": -1622016,
"scriptDurationMs": 31.743000000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2575.15699999999,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.577999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1720.1600000000003,
"heapDeltaBytes": 23434712,
"heapUsedBytes": 89095088,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 809.655,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2464.6779999999353,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.537999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1701.1850000000002,
"heapDeltaBytes": 3929776,
"heapUsedBytes": 80223672,
"domNodes": -272,
"jsHeapTotalBytes": -122880,
"scriptDurationMs": 803.921,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3735.302000000047,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.186999999999998,
"layouts": 60,
"layoutDurationMs": 12.639999999999999,
"taskDurationMs": 1769.2240000000004,
"heapDeltaBytes": 10182940,
"heapUsedBytes": 75932052,
"domNodes": -281,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 746.9780000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3798.8249999999653,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.363999999999999,
"layouts": 60,
"layoutDurationMs": 12.86,
"taskDurationMs": 1776.524,
"heapDeltaBytes": 12107912,
"heapUsedBytes": 79909928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.2650000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3096.217999999908,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.844999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1958.242,
"heapDeltaBytes": 21715528,
"heapUsedBytes": 88994396,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 918.676,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3192.957999999976,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.215000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2041.8529999999996,
"heapDeltaBytes": 24153792,
"heapUsedBytes": 91844876,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 989.758,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.9810000000634,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.6670000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.6850000000001,
"heapDeltaBytes": 10355304,
"heapUsedBytes": 86601288,
"domNodes": -274,
"jsHeapTotalBytes": -2445312,
"scriptDurationMs": 41.787000000000006,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2053.417999999965,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.448999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.47,
"heapDeltaBytes": 22114848,
"heapUsedBytes": 87027900,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.919999999999995,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.6079999999993,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.42,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.18199999999996,
"heapDeltaBytes": 14830640,
"heapUsedBytes": 87534996,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 137.65800000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.6809999999759,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.290000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.519,
"heapDeltaBytes": 14322912,
"heapUsedBytes": 86290144,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 143.186,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2025.4979999999705,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.722000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.306,
"heapDeltaBytes": 3086240,
"heapUsedBytes": 75531244,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.893000000000002,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2030.9040000000778,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.791999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.8929999999999,
"heapDeltaBytes": -10674700,
"heapUsedBytes": 61966624,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.149999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1793.7039999999342,
"styleRecalcs": 80,
"styleRecalcDurationMs": 43.753,
"layouts": 18,
"layoutDurationMs": 6.4159999999999995,
"taskDurationMs": 955.4630000000001,
"heapDeltaBytes": 1690828,
"heapUsedBytes": 74531684,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 109.023,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.7180000000571,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.330000000000005,
"layouts": 18,
"layoutDurationMs": 5.868999999999999,
"taskDurationMs": 904.1120000000001,
"heapDeltaBytes": -12896832,
"heapUsedBytes": 59862644,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 105.822,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.9320000000116,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.37,
"layouts": 14,
"layoutDurationMs": 13.954999999999998,
"taskDurationMs": 947.668,
"heapDeltaBytes": 22257964,
"heapUsedBytes": 105703544,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 36.777,
"eventListeners": 2383,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8983.161999999993,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.27,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6133.755000000001,
"heapDeltaBytes": -11851940,
"heapUsedBytes": 88862200,
"domNodes": -272,
"jsHeapTotalBytes": -872448,
"scriptDurationMs": 2684.742,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8867.682000000059,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.42099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6138.981999999999,
"heapDeltaBytes": 13841832,
"heapUsedBytes": 88918660,
"domNodes": -271,
"jsHeapTotalBytes": -385024,
"scriptDurationMs": 2666.133,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15605.077000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15141.86,
"heapDeltaBytes": -34980584,
"heapUsedBytes": 175169072,
"domNodes": -6548,
"jsHeapTotalBytes": -4395008,
"scriptDurationMs": 320.553,
"eventListeners": -7473,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15764.418000000092,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15225.658,
"heapDeltaBytes": -34933112,
"heapUsedBytes": 175392004,
"domNodes": -6548,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 250.19399999999996,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19150.513000000046,
"styleRecalcs": 135,
"styleRecalcDurationMs": 18.143000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18946.319,
"heapDeltaBytes": -24960224,
"heapUsedBytes": 179780484,
"domNodes": -6548,
"jsHeapTotalBytes": 3166208,
"scriptDurationMs": 896.521,
"eventListeners": -7469,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 18902.15499999999,
"styleRecalcs": 140,
"styleRecalcDurationMs": 18.58099999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18623.025,
"heapDeltaBytes": -17120440,
"heapUsedBytes": 186401412,
"domNodes": -6548,
"jsHeapTotalBytes": 3850240,
"scriptDurationMs": 901.136,
"eventListeners": -7469,
"totalBlockingTimeMs": 29,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5721.0620000000745,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.29600000000003,
"layouts": 20,
"layoutDurationMs": 25.346999999999994,
"taskDurationMs": 5649.031,
"heapDeltaBytes": -37446560,
"heapUsedBytes": 167776580,
"domNodes": -6548,
"jsHeapTotalBytes": 18108416,
"scriptDurationMs": 106.54799999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 302,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5754.4829999999365,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.13200000000003,
"layouts": 20,
"layoutDurationMs": 25.591,
"taskDurationMs": 5668.647999999999,
"heapDeltaBytes": -21677204,
"heapUsedBytes": 180842488,
"domNodes": -6548,
"jsHeapTotalBytes": 18370560,
"scriptDurationMs": 105.86499999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 285,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 124.99500000001262,
"styleRecalcs": 6,
"styleRecalcDurationMs": 15.972,
"layouts": 2,
"layoutDurationMs": 1.421,
"taskDurationMs": 88.446,
"heapDeltaBytes": 3145284,
"heapUsedBytes": 71523812,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.182999999999998,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 487.41099999983817,
"styleRecalcs": 12,
"styleRecalcDurationMs": 21.283,
"layouts": 3,
"layoutDurationMs": 1.014,
"taskDurationMs": 135.27200000000002,
"heapDeltaBytes": 5050424,
"heapUsedBytes": 73855668,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.295000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16592 +/- ##
==========================================
+ Coverage 80.68% 82.29% +1.60%
==========================================
Files 2432 2023 -409
Lines 124058 116822 -7236
Branches 30999 31075 +76
==========================================
- Hits 100097 96133 -3964
+ Misses 23460 20512 -2948
+ Partials 501 177 -324
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 417 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
No blocking findings. The compacted-value branch matches the current serializer and preserves dynamic widgets that are absent from inputDefs; the regression is behavioral and has no type escapes or new public state. Local typecheck, changed-file format/ESLint, and all 23 focused tests pass. With the production file restored from main, the new test fails with ['av'] instead of retaining ['av', 'extra value']. Hosted checks are green.
…#16592) Follow-up to #15759 Preserves compacted dynamic-widget values. <details><summary>Full context for agent readers</summary> Follow-up to #15759. Addresses the deferred review note at #15759 (comment). `migrateWidgetsValues` now recognizes an already-compacted array when no legacy `forceInput` dummy can be present, preventing a serializable dynamic widget after a skipped widget from being dropped by index-based compaction. The earlier top-level review at #15759 (comment) identified blockers fixed before the source PR merged. The approval at #15759 (comment) confirms those blockers were resolved and identifies only the compacted-candidate note above as deferred follow-up work. ## Evidence - `pnpm exec vitest run src/utils/litegraphUtil.test.ts`: 23/23 passed at `305da8ff56aeacd5ba2dc859083de3ccf8466bcb`. - `pnpm typecheck`: passed at the same head. - CI at the same head: required unit, lint/format, E2E, website E2E, CLA, and CodeRabbit checks passed. </details> <!-- authored-by:agent lane-act-fe-15759-followup --> Co-authored-by: Pipeline Agent <agent@pipeline.local>
Follow-up to #15759
Preserves compacted dynamic-widget values.
Full context for agent readers
Follow-up to #15759.
Addresses the deferred review note at #15759 (comment).
migrateWidgetsValuesnow recognizes an already-compacted array when no legacyforceInputdummy can be present, preventing a serializable dynamic widget after a skipped widget from being dropped by index-based compaction.The earlier top-level review at #15759 (comment) identified blockers fixed before the source PR merged. The approval at #15759 (comment) confirms those blockers were resolved and identifies only the compacted-candidate note above as deferred follow-up work.
Evidence
pnpm exec vitest run src/utils/litegraphUtil.test.ts: 23/23 passed at305da8ff56aeacd5ba2dc859083de3ccf8466bcb.pnpm typecheck: passed at the same head.