Repository navigation
[backport cloud/1.53] fix(billing): price legacy subscription previews from the server costs - #16573
Conversation
#16517) ## Summary The subscription confirm screens rendered no amount at all whenever embedded checkout was off — a blank "Total due today" on new subscriptions and "Unavailable" on plan changes. Resolve the amount from the legacy cost fields the server always sends. ## Changes - **What**: `formatAmountDueToday` / `formatRenewalAmount` / `resolveRenewalDate` in `subscriptionQuoteFormatting.ts` resolve each figure from the exact quote when the server sent one and from the always-present legacy costs otherwise. `SubscriptionAddPaymentPreviewWorkspace` and `SubscriptionTransitionPreviewWorkspace` consume them. New `subscription.preview.renewsAtAmount` message for the case where the server supplies an amount but no renewal date. ### Root cause #14483 ("consolidate embedded checkout frontend") rewrote both quote computeds to read only the embedded-checkout field family: ```ts const totalDueToday = computed(() => previewData?.amount_due_cents === undefined ? '' : formatQuoteMoney(...) ) ``` `POST /api/billing/preview-subscribe` returns two different shapes. `packages/ingest-types` documents the split on the sibling field: `payment_method_configuration_id` is *"Present on every successful preview while embedded checkout is enabled and absent from legacy previews."* The same holds for the whole family: | field | contract | legacy preview | | --- | --- | --- | | `amount_due_cents`, `currency` | optional | absent | | `renewal_amount_cents`, `renewal_at` | optional | absent | | `cost_today_cents`, `cost_next_period_cents` | **required** | **present** | So with the flag off, `amount_due_cents` is `undefined` and `totalDueToday` short-circuits to `''`. `SubscriptionTransitionPreviewWorkspace` falls through to `subscription.preview.quoteUnavailable` and prints "Unavailable" twice. Two things widen the blast radius beyond "someone turned the flag off": - `embeddedCheckoutEnabled` resolves **fail-closed** (`resolveFailClosedBooleanFlag`), so a flag that cannot be read is treated as off and takes this same path. - `formatQuoteMoney` returns `''` when `currency` is missing, so even reading `cost_today_cents` while passing the absent `currency` through would still render blank. Note the branch here is on the **response shape**, not on the `embeddedCheckoutEnabled` prop. The shape is what the contract actually guarantees, it needs no prop threaded into `SubscriptionTransitionPreviewWorkspace`, and it stays correct if the flag is on while the backend still serves a legacy preview. `chargeCents` in the same component already branched this way (`amount_due_cents ?? cost_today_cents`) — the consolidation just missed the display computeds. The renewal **date** is deliberately not synthesized. `PreviewPlanInfo.period_end` is documented "only for current_plan" and is absent on a new-subscription preview, so the legacy path shows the server-provided renewal amount without inventing a date. ## Review Focus - `LEGACY_QUOTE_CURRENCY = 'usd'` is the one assumption added. The legacy rail carries no `currency` field because it prices in USD; this keeps that assumption in a single named constant instead of at each call site. - `SubscriptionTransitionPreviewWorkspaceReactivation.test.ts` had a test asserting "Unavailable" appeared twice for a preview with no exact quote. That test codified this bug, so it now asserts the legacy amount renders. - `cloudSubscribeDeepLink.spec.ts` already drove a legacy-shaped preview through the real checkout but only asserted the heading, which is how this reached QA. It now asserts the total. ## Tests - 8 unit tests on the pure resolvers (exact quote, legacy fallback, non-USD, missing date) - 3 component regression tests; verified they fail without the fix and pass with it - 1 E2E assertion on the existing flag-off deep-link spec ## Screenshots Captured in the running app (cloud distribution, `embedded_checked_enabled` off) — posting them in a follow-up comment. <!-- Supersedes #16515, which fixes the same bug by branching on the flag prop and drops the renewal line when the server sends no date. -->
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1890 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-02T04:00:01.428Z",
"gitSha": "1ada875685971e648e64e640e43930b9c9cddc9b",
"branch": "backport-16517-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2135.179999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.57,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.205,
"heapDeltaBytes": -12846972,
"heapUsedBytes": 56490892,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.957,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2066.394999999943,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.417000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.184,
"heapDeltaBytes": 1494688,
"heapUsedBytes": 71430476,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.155,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2083.4009999999807,
"styleRecalcs": 85,
"styleRecalcDurationMs": 54.562000000000005,
"layouts": 14,
"layoutDurationMs": 5.424,
"taskDurationMs": 1086.7879999999998,
"heapDeltaBytes": -8924128,
"heapUsedBytes": 60080264,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 182.32000000000002,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2024.6660000000247,
"styleRecalcs": 82,
"styleRecalcDurationMs": 47.904,
"layouts": 14,
"layoutDurationMs": 5.114000000000001,
"taskDurationMs": 1024.674,
"heapDeltaBytes": -6881944,
"heapUsedBytes": 62945848,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 181.416,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.5510000000104,
"styleRecalcs": 30,
"styleRecalcDurationMs": 20.686,
"layouts": 6,
"layoutDurationMs": 1.4460000000000002,
"taskDurationMs": 476.94499999999994,
"heapDeltaBytes": 4433920,
"heapUsedBytes": 74672348,
"domNodes": 75,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 15.202000000000004,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.6240000000153,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.911,
"layouts": 6,
"layoutDurationMs": 1.4300000000000002,
"taskDurationMs": 404.7820000000001,
"heapDeltaBytes": 4461616,
"heapUsedBytes": 73666852,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.855,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 757.1239999999761,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.640999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.058,
"heapDeltaBytes": 18425196,
"heapUsedBytes": 88426920,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 178.087,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 733.0620000000181,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.296000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.6959999999999,
"heapDeltaBytes": 18855748,
"heapUsedBytes": 88507304,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 182.865,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.404000000024,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.327000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.681,
"heapDeltaBytes": -9500348,
"heapUsedBytes": 86889804,
"domNodes": -272,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 41.196,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2089.0779999999722,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.404,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.189,
"heapDeltaBytes": 10956316,
"heapUsedBytes": 85193752,
"domNodes": -275,
"jsHeapTotalBytes": -344064,
"scriptDurationMs": 37.04299999999999,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3078.6640000000034,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.413,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1990.7740000000001,
"heapDeltaBytes": 16948252,
"heapUsedBytes": 93159376,
"domNodes": -276,
"jsHeapTotalBytes": -1953792,
"scriptDurationMs": 970.1949999999999,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-pan",
"durationMs": 2884.1300000000274,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.504000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1813.1650000000002,
"heapDeltaBytes": 15414580,
"heapUsedBytes": 92009116,
"domNodes": -273,
"jsHeapTotalBytes": -118784,
"scriptDurationMs": 915.8309999999999,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4074.2360000000417,
"styleRecalcs": 60,
"styleRecalcDurationMs": 13.655999999999999,
"layouts": 60,
"layoutDurationMs": 15.841000000000001,
"taskDurationMs": 2031.6490000000003,
"heapDeltaBytes": 8468376,
"heapUsedBytes": 75743280,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 908.245,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3912.1240000000626,
"styleRecalcs": 60,
"styleRecalcDurationMs": 12.204999999999997,
"layouts": 60,
"layoutDurationMs": 14.966999999999997,
"taskDurationMs": 1882.1319999999998,
"heapDeltaBytes": 9445228,
"heapUsedBytes": 76565184,
"domNodes": -280,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 887.045,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3463.1789999999683,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.843000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2283.166,
"heapDeltaBytes": 30290680,
"heapUsedBytes": 98021704,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1122.167,
"eventListeners": 190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3247.5070000000414,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.148999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2110.2129999999997,
"heapDeltaBytes": 24986336,
"heapUsedBytes": 91722732,
"domNodes": -280,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1056.875,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.4609999999793,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.7860000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 732.284,
"heapDeltaBytes": 10262628,
"heapUsedBytes": 86905136,
"domNodes": -275,
"jsHeapTotalBytes": -2179072,
"scriptDurationMs": 48.812999999999995,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2006.697000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.4380000000001,
"heapDeltaBytes": 21857140,
"heapUsedBytes": 87039396,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.327,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 703.6299999999756,
"styleRecalcs": 44,
"styleRecalcDurationMs": 10.838000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.877,
"heapDeltaBytes": 14821684,
"heapUsedBytes": 87166176,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 160.435,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 707.7340000000731,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.59,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.562,
"heapDeltaBytes": 14785908,
"heapUsedBytes": 87120740,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 157.335,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2037.3720000000048,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.773000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.655,
"heapDeltaBytes": 1398212,
"heapUsedBytes": 73525716,
"domNodes": -293,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.996,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2036.8449999999712,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.325999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.756,
"heapDeltaBytes": -8208560,
"heapUsedBytes": 63734048,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.8599999999999985,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1881.4869999999928,
"styleRecalcs": 78,
"styleRecalcDurationMs": 44.913999999999994,
"layouts": 18,
"layoutDurationMs": 7.084999999999999,
"taskDurationMs": 981.798,
"heapDeltaBytes": -9911464,
"heapUsedBytes": 62060316,
"domNodes": -299,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 126.99,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1778.214999999932,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.789,
"layouts": 18,
"layoutDurationMs": 5.572000000000001,
"taskDurationMs": 942.2019999999999,
"heapDeltaBytes": 4177236,
"heapUsedBytes": 76236720,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 118.083,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1499.2869999999812,
"styleRecalcs": 18,
"styleRecalcDurationMs": 34.285999999999994,
"layouts": 14,
"layoutDurationMs": 19.116,
"taskDurationMs": 1026.738,
"heapDeltaBytes": -7346604,
"heapUsedBytes": 87785168,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 39.188,
"eventListeners": 2383,
"totalBlockingTimeMs": 154,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 10815.181999999993,
"styleRecalcs": 245,
"styleRecalcDurationMs": 45.119,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6919.119000000001,
"heapDeltaBytes": -10585956,
"heapUsedBytes": 89173904,
"domNodes": -273,
"jsHeapTotalBytes": -1163264,
"scriptDurationMs": 3152.805,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666673,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10047.56299999997,
"styleRecalcs": 244,
"styleRecalcDurationMs": 41.221999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6596.8240000000005,
"heapDeltaBytes": -4143080,
"heapUsedBytes": 91825356,
"domNodes": -272,
"jsHeapTotalBytes": -638976,
"scriptDurationMs": 3067.118,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 21696.279000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21341.234,
"heapDeltaBytes": -31043932,
"heapUsedBytes": 179356832,
"domNodes": -6548,
"jsHeapTotalBytes": -2027520,
"scriptDurationMs": 456.9030000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 3,
"frameDurationMs": 19.44333333333343,
"p95FrameDurationMs": 33.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 19051.093000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18478.517,
"heapDeltaBytes": -33784936,
"heapUsedBytes": 176544280,
"domNodes": -6548,
"jsHeapTotalBytes": -2551808,
"scriptDurationMs": 318.49899999999997,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 26912.531000000003,
"styleRecalcs": 182,
"styleRecalcDurationMs": 26.95799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26595.2,
"heapDeltaBytes": -13830280,
"heapUsedBytes": 190628044,
"domNodes": -6548,
"jsHeapTotalBytes": -5767168,
"scriptDurationMs": 1125.053,
"eventListeners": -7467,
"totalBlockingTimeMs": 253,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 25712.53200000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.211999999999957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25368.835,
"heapDeltaBytes": -27999804,
"heapUsedBytes": 182131760,
"domNodes": -6548,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 1047.902,
"eventListeners": -7463,
"totalBlockingTimeMs": 287,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-node-resize-workload",
"durationMs": 7488.4759999999915,
"styleRecalcs": 20,
"styleRecalcDurationMs": 102.69,
"layouts": 20,
"layoutDurationMs": 34.922999999999995,
"taskDurationMs": 7383.500999999999,
"heapDeltaBytes": -37329784,
"heapUsedBytes": 172796032,
"domNodes": -6548,
"jsHeapTotalBytes": 1445888,
"scriptDurationMs": 151.021,
"eventListeners": -7471,
"totalBlockingTimeMs": 954,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 7136.699000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.55099999999999,
"layouts": 20,
"layoutDurationMs": 28.85,
"taskDurationMs": 7023.923999999999,
"heapDeltaBytes": -9011432,
"heapUsedBytes": 194058936,
"domNodes": -6548,
"jsHeapTotalBytes": 15724544,
"scriptDurationMs": 142.374,
"eventListeners": -7469,
"totalBlockingTimeMs": 588,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 134.83900000005633,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.180000000000003,
"layouts": 3,
"layoutDurationMs": 1.9210000000000003,
"taskDurationMs": 105.632,
"heapDeltaBytes": 3494540,
"heapUsedBytes": 71469336,
"domNodes": 152,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.3740000000000006,
"eventListeners": 56,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 468.20900000000165,
"styleRecalcs": 12,
"styleRecalcDurationMs": 21.060000000000002,
"layouts": 3,
"layoutDurationMs": 1.097,
"taskDurationMs": 113.75100000000002,
"heapDeltaBytes": 5059300,
"heapUsedBytes": 73331036,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.9719999999999995,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #16573 +/- ##
=============================================
Coverage ? 83.26%
=============================================
Files ? 2023
Lines ? 116976
Branches ? 32450
=============================================
Hits ? 97396
Misses ? 19224
Partials ? 356
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #16517 to
cloud/1.53.Cherry-pick of
c989dee4077e195a11dee00f31dbf532305fb3e8— applied cleanly with no conflicts, and the resulting diff is byte-identical to the commit merged tomain(9 files, +298/-50).Why this is needed on this branch
The subscription confirm screens render no amount at all whenever embedded checkout is off — a blank "Total due today" on new subscriptions, and "Unavailable" on plan changes. Any release branch shipping without this fix shows users a checkout screen with no price on it.
Root cause
#14483 ("consolidate embedded checkout frontend") rewrote both quote computeds to read only the embedded-checkout field family:
When embedded checkout is off the server never sends
amount_due_cents, so the computed resolves to''and the UI renders nothing — even though the server always sends the legacy cost fields that carry the same figure.What changes
formatAmountDueToday/formatRenewalAmount/resolveRenewalDateinsubscriptionQuoteFormatting.tsresolve each figure from the exact quote when the server sent one, and from the always-present legacy costs otherwise.SubscriptionAddPaymentPreviewWorkspaceandSubscriptionTransitionPreviewWorkspaceconsume them.subscription.preview.renewsAtAmountmessage for the case where the server supplies an amount but no renewal date.Verification
AS IS / TO BE screenshots are on the original PR: #16517
Regression coverage came across with the cherry-pick:
subscriptionQuoteFormatting.test.ts(new, 8 cases covering exact-quote / legacy-fallback / non-USD / missing-date)SubscriptionAddPaymentPreviewWorkspace.test.ts,SubscriptionTransitionPreviewWorkspace.test.ts,SubscriptionTransitionPreviewWorkspaceReactivation.test.tsbrowser_tests/tests/cloudSubscribeDeepLink.spec.ts(e2e)Unit tests were not runnable in the backport sandbox (a local happy-dom issue fails untouched pre-existing specs identically), so CI on this PR is the verifying signal.