Skip to content

[backport cloud/1.53] fix(billing): price legacy subscription previews from the server costs - #16573

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16517-to-cloud-1.53
Sep 2, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16517-to-cloud-1.53

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Backport of #16517 to cloud/1.53.

Cherry-pick of c989dee4077e195a11dee00f31dbf532305fb3e8 — applied cleanly with no conflicts, and the resulting diff is byte-identical to the commit merged to main (9 files, +298/-50).

Why this is needed on this branch

The subscription confirm screens render no amount at all whenever embedded checkout is off — a blank "Total due today" on new subscriptions, and "Unavailable" on plan changes. Any release branch shipping without this fix shows users a checkout screen with no price on it.

Root cause

#14483 ("consolidate embedded checkout frontend") rewrote both quote computeds to read only the embedded-checkout field family:

const totalDueToday = computed(() =>
  previewData?.amount_due_cents === undefined ? '' : formatQuoteMoney(...)
)

When embedded checkout is off the server never sends amount_due_cents, so the computed resolves to '' and the UI renders nothing — even though the server always sends the legacy cost fields that carry the same figure.

What changes

  • formatAmountDueToday / formatRenewalAmount / resolveRenewalDate in subscriptionQuoteFormatting.ts resolve each figure from the exact quote when the server sent one, and from the always-present legacy costs otherwise.
  • SubscriptionAddPaymentPreviewWorkspace and SubscriptionTransitionPreviewWorkspace consume them.
  • New subscription.preview.renewsAtAmount message for the case where the server supplies an amount but no renewal date.

Verification

AS IS / TO BE screenshots are on the original PR: #16517

Regression coverage came across with the cherry-pick:

  • subscriptionQuoteFormatting.test.ts (new, 8 cases covering exact-quote / legacy-fallback / non-USD / missing-date)
  • SubscriptionAddPaymentPreviewWorkspace.test.ts, SubscriptionTransitionPreviewWorkspace.test.ts, SubscriptionTransitionPreviewWorkspaceReactivation.test.ts
  • browser_tests/tests/cloudSubscribeDeepLink.spec.ts (e2e)

Unit tests were not runnable in the backport sandbox (a local happy-dom issue fails untouched pre-existing specs identically), so CI on this PR is the verifying signal.

#16517)

## Summary

The subscription confirm screens rendered no amount at all whenever
embedded checkout was off — a blank "Total due today" on new
subscriptions and "Unavailable" on plan changes. Resolve the amount from
the legacy cost fields the server always sends.

## Changes

- **What**: `formatAmountDueToday` / `formatRenewalAmount` /
`resolveRenewalDate` in `subscriptionQuoteFormatting.ts` resolve each
figure from the exact quote when the server sent one and from the
always-present legacy costs otherwise.
`SubscriptionAddPaymentPreviewWorkspace` and
`SubscriptionTransitionPreviewWorkspace` consume them. New
`subscription.preview.renewsAtAmount` message for the case where the
server supplies an amount but no renewal date.

### Root cause

#14483 ("consolidate embedded checkout frontend") rewrote both quote
computeds to read only the embedded-checkout field family:

```ts
const totalDueToday = computed(() =>
  previewData?.amount_due_cents === undefined ? '' : formatQuoteMoney(...)
)
```

`POST /api/billing/preview-subscribe` returns two different shapes.
`packages/ingest-types` documents the split on the sibling field:
`payment_method_configuration_id` is *"Present on every successful
preview while embedded checkout is enabled and absent from legacy
previews."* The same holds for the whole family:

| field | contract | legacy preview |
| --- | --- | --- |
| `amount_due_cents`, `currency` | optional | absent |
| `renewal_amount_cents`, `renewal_at` | optional | absent |
| `cost_today_cents`, `cost_next_period_cents` | **required** |
**present** |

So with the flag off, `amount_due_cents` is `undefined` and
`totalDueToday` short-circuits to `''`.
`SubscriptionTransitionPreviewWorkspace` falls through to
`subscription.preview.quoteUnavailable` and prints "Unavailable" twice.

Two things widen the blast radius beyond "someone turned the flag off":

- `embeddedCheckoutEnabled` resolves **fail-closed**
(`resolveFailClosedBooleanFlag`), so a flag that cannot be read is
treated as off and takes this same path.
- `formatQuoteMoney` returns `''` when `currency` is missing, so even
reading `cost_today_cents` while passing the absent `currency` through
would still render blank.

Note the branch here is on the **response shape**, not on the
`embeddedCheckoutEnabled` prop. The shape is what the contract actually
guarantees, it needs no prop threaded into
`SubscriptionTransitionPreviewWorkspace`, and it stays correct if the
flag is on while the backend still serves a legacy preview.
`chargeCents` in the same component already branched this way
(`amount_due_cents ?? cost_today_cents`) — the consolidation just missed
the display computeds.

The renewal **date** is deliberately not synthesized.
`PreviewPlanInfo.period_end` is documented "only for current_plan" and
is absent on a new-subscription preview, so the legacy path shows the
server-provided renewal amount without inventing a date.

## Review Focus

- `LEGACY_QUOTE_CURRENCY = 'usd'` is the one assumption added. The
legacy rail carries no `currency` field because it prices in USD; this
keeps that assumption in a single named constant instead of at each call
site.
- `SubscriptionTransitionPreviewWorkspaceReactivation.test.ts` had a
test asserting "Unavailable" appeared twice for a preview with no exact
quote. That test codified this bug, so it now asserts the legacy amount
renders.
- `cloudSubscribeDeepLink.spec.ts` already drove a legacy-shaped preview
through the real checkout but only asserted the heading, which is how
this reached QA. It now asserts the total.

## Tests

- 8 unit tests on the pure resolvers (exact quote, legacy fallback,
non-USD, missing date)
- 3 component regression tests; verified they fail without the fix and
pass with it
- 1 E2E assertion on the existing flag-off deep-link spec

## Screenshots

Captured in the running app (cloud distribution,
`embedded_checked_enabled` off) — posting them in a follow-up comment.

<!-- Supersedes #16515, which fixes the same bug by branching on the
flag prop and drops the renewal line when the server sends no date. -->
@dante01yoon dante01yoon added the backport Backporting a PR onto a release candidate label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: ff7b0f7c-b6aa-4668-8c92-3c435ec73323

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 03:46:59 AM UTC

Links

🎭 Playwright: ✅ 1890 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 154ms TBT · 83.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.3 MB heap
vue-large-graph-idle: · 52.9 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 2ms TBT · 169.7 MB heap
vue-large-graph-pan: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 270ms TBT · 177.7 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 771ms TBT · 174.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 590ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.0 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 51ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 84
canvas-mouse-sweep: task duration 1056ms
canvas-mouse-sweep: script duration 182ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.7 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -156
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 441ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.7 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 21
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 507ms
dom-widget-clipping: script duration 180ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.4 MB
dom-widget-clipping: DOM nodes 15
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 670ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.1 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -185
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1902ms
large-graph-pan: script duration 943ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 88.3 MB
large-graph-pan: DOM nodes -275
large-graph-pan: event listeners -181
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1957ms
large-graph-zoom: script duration 898ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.6 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2197ms
legacy-node-drag: script duration 1090ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 90.5 MB
legacy-node-drag: DOM nodes -140
legacy-node-drag: event listeners 189
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 2
minimap-idle: task duration 676ms
minimap-idle: script duration 44ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.9 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -168
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 480ms
subgraph-dom-widget-clipping: script duration 159ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.1 MB
subgraph-dom-widget-clipping: DOM nodes 16
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 546ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.5 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 42ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 962ms
subgraph-mouse-sweep: script duration 123ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.9 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -218
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 19ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1027ms
subgraph-transition-enter: script duration 39ms
subgraph-transition-enter: TBT 154ms
subgraph-transition-enter: heap used 83.7 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 43ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 245
viewport-pan-sweep: task duration 6758ms
viewport-pan-sweep: script duration 3110ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.3 MB
viewport-pan-sweep: DOM nodes -273
viewport-pan-sweep: event listeners -147
vue-large-graph-idle: avg frame time 19ms
vue-large-graph-idle: p95 frame time 25ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 19910ms
vue-large-graph-idle: script duration 388ms
vue-large-graph-idle: TBT 2ms
vue-large-graph-idle: heap used 169.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7472
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 26ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 182
vue-large-graph-pan: task duration 25982ms
vue-large-graph-pan: script duration 1086ms
vue-large-graph-pan: TBT 270ms
vue-large-graph-pan: heap used 177.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7465
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 32ms
vue-node-resize-workload: style recalc duration 96ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 7204ms
vue-node-resize-workload: script duration 147ms
vue-node-resize-workload: TBT 771ms
vue-node-resize-workload: heap used 174.9 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 110ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.0 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 78
Raw data
{
  "timestamp": "2026-09-02T04:00:01.428Z",
  "gitSha": "1ada875685971e648e64e640e43930b9c9cddc9b",
  "branch": "backport-16517-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2135.179999999991,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.57,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 648.205,
      "heapDeltaBytes": -12846972,
      "heapUsedBytes": 56490892,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.957,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2066.394999999943,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.417000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.184,
      "heapDeltaBytes": 1494688,
      "heapUsedBytes": 71430476,
      "domNodes": -281,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.155,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2083.4009999999807,
      "styleRecalcs": 85,
      "styleRecalcDurationMs": 54.562000000000005,
      "layouts": 14,
      "layoutDurationMs": 5.424,
      "taskDurationMs": 1086.7879999999998,
      "heapDeltaBytes": -8924128,
      "heapUsedBytes": 60080264,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 182.32000000000002,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2024.6660000000247,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 47.904,
      "layouts": 14,
      "layoutDurationMs": 5.114000000000001,
      "taskDurationMs": 1024.674,
      "heapDeltaBytes": -6881944,
      "heapUsedBytes": 62945848,
      "domNodes": -279,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 181.416,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1734.5510000000104,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 20.686,
      "layouts": 6,
      "layoutDurationMs": 1.4460000000000002,
      "taskDurationMs": 476.94499999999994,
      "heapDeltaBytes": 4433920,
      "heapUsedBytes": 74672348,
      "domNodes": 75,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 15.202000000000004,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1726.6240000000153,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.911,
      "layouts": 6,
      "layoutDurationMs": 1.4300000000000002,
      "taskDurationMs": 404.7820000000001,
      "heapDeltaBytes": 4461616,
      "heapUsedBytes": 73666852,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.855,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 757.1239999999761,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.640999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 503.058,
      "heapDeltaBytes": 18425196,
      "heapUsedBytes": 88426920,
      "domNodes": 14,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 178.087,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 733.0620000000181,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.296000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.6959999999999,
      "heapDeltaBytes": 18855748,
      "heapUsedBytes": 88507304,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 182.865,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.404000000024,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.327000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 656.681,
      "heapDeltaBytes": -9500348,
      "heapUsedBytes": 86889804,
      "domNodes": -272,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 41.196,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2089.0779999999722,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 6.404,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 684.189,
      "heapDeltaBytes": 10956316,
      "heapUsedBytes": 85193752,
      "domNodes": -275,
      "jsHeapTotalBytes": -344064,
      "scriptDurationMs": 37.04299999999999,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3078.6640000000034,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 12.413,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1990.7740000000001,
      "heapDeltaBytes": 16948252,
      "heapUsedBytes": 93159376,
      "domNodes": -276,
      "jsHeapTotalBytes": -1953792,
      "scriptDurationMs": 970.1949999999999,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2884.1300000000274,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 12.504000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1813.1650000000002,
      "heapDeltaBytes": 15414580,
      "heapUsedBytes": 92009116,
      "domNodes": -273,
      "jsHeapTotalBytes": -118784,
      "scriptDurationMs": 915.8309999999999,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4074.2360000000417,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 13.655999999999999,
      "layouts": 60,
      "layoutDurationMs": 15.841000000000001,
      "taskDurationMs": 2031.6490000000003,
      "heapDeltaBytes": 8468376,
      "heapUsedBytes": 75743280,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 908.245,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3912.1240000000626,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 12.204999999999997,
      "layouts": 60,
      "layoutDurationMs": 14.966999999999997,
      "taskDurationMs": 1882.1319999999998,
      "heapDeltaBytes": 9445228,
      "heapUsedBytes": 76565184,
      "domNodes": -280,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 887.045,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3463.1789999999683,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 6.843000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2283.166,
      "heapDeltaBytes": 30290680,
      "heapUsedBytes": 98021704,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1122.167,
      "eventListeners": 190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3247.5070000000414,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 6.148999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2110.2129999999997,
      "heapDeltaBytes": 24986336,
      "heapUsedBytes": 91722732,
      "domNodes": -280,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1056.875,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2043.4609999999793,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 3.7860000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 732.284,
      "heapDeltaBytes": 10262628,
      "heapUsedBytes": 86905136,
      "domNodes": -275,
      "jsHeapTotalBytes": -2179072,
      "scriptDurationMs": 48.812999999999995,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2006.697000000031,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.4380000000001,
      "heapDeltaBytes": 21857140,
      "heapUsedBytes": 87039396,
      "domNodes": -276,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 39.327,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 703.6299999999756,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 10.838000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.877,
      "heapDeltaBytes": 14821684,
      "heapUsedBytes": 87166176,
      "domNodes": 14,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 160.435,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 707.7340000000731,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.59,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.562,
      "heapDeltaBytes": 14785908,
      "heapUsedBytes": 87120740,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 157.335,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2037.3720000000048,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.773000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.655,
      "heapDeltaBytes": 1398212,
      "heapUsedBytes": 73525716,
      "domNodes": -293,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.996,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2036.8449999999712,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.325999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 525.756,
      "heapDeltaBytes": -8208560,
      "heapUsedBytes": 63734048,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.8599999999999985,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1881.4869999999928,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 44.913999999999994,
      "layouts": 18,
      "layoutDurationMs": 7.084999999999999,
      "taskDurationMs": 981.798,
      "heapDeltaBytes": -9911464,
      "heapUsedBytes": 62060316,
      "domNodes": -299,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 126.99,
      "eventListeners": -203,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1778.214999999932,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 38.789,
      "layouts": 18,
      "layoutDurationMs": 5.572000000000001,
      "taskDurationMs": 942.2019999999999,
      "heapDeltaBytes": 4177236,
      "heapUsedBytes": 76236720,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 118.083,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1499.2869999999812,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 34.285999999999994,
      "layouts": 14,
      "layoutDurationMs": 19.116,
      "taskDurationMs": 1026.738,
      "heapDeltaBytes": -7346604,
      "heapUsedBytes": 87785168,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 39.188,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 154,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10815.181999999993,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 45.119,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6919.119000000001,
      "heapDeltaBytes": -10585956,
      "heapUsedBytes": 89173904,
      "domNodes": -273,
      "jsHeapTotalBytes": -1163264,
      "scriptDurationMs": 3152.805,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666673,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10047.56299999997,
      "styleRecalcs": 244,
      "styleRecalcDurationMs": 41.221999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6596.8240000000005,
      "heapDeltaBytes": -4143080,
      "heapUsedBytes": 91825356,
      "domNodes": -272,
      "jsHeapTotalBytes": -638976,
      "scriptDurationMs": 3067.118,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 21696.279000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21341.234,
      "heapDeltaBytes": -31043932,
      "heapUsedBytes": 179356832,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2027520,
      "scriptDurationMs": 456.9030000000001,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 19.44333333333343,
      "p95FrameDurationMs": 33.30000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19051.093000000037,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18478.517,
      "heapDeltaBytes": -33784936,
      "heapUsedBytes": 176544280,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2551808,
      "scriptDurationMs": 318.49899999999997,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 26912.531000000003,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 26.95799999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 26595.2,
      "heapDeltaBytes": -13830280,
      "heapUsedBytes": 190628044,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5767168,
      "scriptDurationMs": 1125.053,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 253,
      "frameDurationMs": 18.33666666666662,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 25712.53200000001,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 24.211999999999957,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 25368.835,
      "heapDeltaBytes": -27999804,
      "heapUsedBytes": 182131760,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2359296,
      "scriptDurationMs": 1047.902,
      "eventListeners": -7463,
      "totalBlockingTimeMs": 287,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7488.4759999999915,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 102.69,
      "layouts": 20,
      "layoutDurationMs": 34.922999999999995,
      "taskDurationMs": 7383.500999999999,
      "heapDeltaBytes": -37329784,
      "heapUsedBytes": 172796032,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1445888,
      "scriptDurationMs": 151.021,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 954,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7136.699000000021,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 88.55099999999999,
      "layouts": 20,
      "layoutDurationMs": 28.85,
      "taskDurationMs": 7023.923999999999,
      "heapDeltaBytes": -9011432,
      "heapUsedBytes": 194058936,
      "domNodes": -6548,
      "jsHeapTotalBytes": 15724544,
      "scriptDurationMs": 142.374,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 588,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 134.83900000005633,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 20.180000000000003,
      "layouts": 3,
      "layoutDurationMs": 1.9210000000000003,
      "taskDurationMs": 105.632,
      "heapDeltaBytes": 3494540,
      "heapUsedBytes": 71469336,
      "domNodes": 152,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.3740000000000006,
      "eventListeners": 56,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 468.20900000000165,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 21.060000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.097,
      "taskDurationMs": 113.75100000000002,
      "heapDeltaBytes": 5059300,
      "heapUsedBytes": 73331036,
      "domNodes": 119,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.9719999999999995,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 47979 70463 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.3% 398
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions
github-actions Bot requested a review from DrJKL September 2, 2026 03:45
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #16573   +/-   ##
=============================================
  Coverage              ?   83.26%           
=============================================
  Files                 ?     2023           
  Lines                 ?   116976           
  Branches              ?    32450           
=============================================
  Hits                  ?    97396           
  Misses                ?    19224           
  Partials              ?      356           
Flag Coverage Δ
e2e 66.59% <ø> (?)
unit 76.51% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../subscription/utils/subscriptionQuoteFormatting.ts 100.00% <100.00%> (ø)
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 90.53% <100.00%> (ø)
...ponents/SubscriptionTransitionPreviewWorkspace.vue 91.20% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@comfy-pr-bot
comfy-pr-bot merged commit 00ce89a into cloud/1.53 Sep 2, 2026
122 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16517-to-cloud-1.53 branch September 2, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants