Skip to content

feat(billing): ended sales-managed plans get the subtitle and tile treatment - #16552

Closed
comfydesigner wants to merge 1 commit into
jaewon/fe-1962-inactive-badge-drop-ended-cardfrom
comfydesigner/fe-1987-ended-enterprise
Closed

comfydesigner wants to merge 1 commit into
jaewon/fe-1962-inactive-badge-drop-ended-cardfrom
comfydesigner/fe-1987-ended-enterprise

Conversation

@comfydesigner

@comfydesigner comfydesigner commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #16521, since it builds directly on the badge and the file it lands in.

An ended Enterprise workspace renders the Inactive badge and nothing else — no statement of what stopped, no route back, and a credits tile stripped to a bare balance. The account-manager line only exists as a run-button toast today, so the customer learns the route back by failing to run. Designs: Figma 4459-24811, section Enterprise — inactive.

Subtitle

The plan card gains one line under the header for a terminal sales-managed plan:

You can't run workflows or add new members. Contact your Comfy account manager to restore access.

Credits tile

showsInactivePlanState dropped its !isSalesManagedTier exclusion. That exclusion was right when written — the treatment sold a self-serve reactivation Enterprise doesn't have, and Enterprise kept CanTopUp in every status (#16067). Comfy-Org/cloud#8001 withholds top-up once a sales-managed subscription is terminal, so both halves of the rationale are gone. The note is tier-aware:

  • retained credits → "Spendable once your plan is restored."
  • nothing retained → "Plan credits ended with your subscription."

The parent decides when a plan is inactive (isNonCatalogPlan && isSubscriptionEnded); the tile only renders it.

Tests

One pre-existing test pinned the old exclusion verbatim ("keeps Add credits and the real balance on an inactive sales-managed plan") — rewritten to the post-8001 contract rather than deleted, with the zero-retained case alongside. The ended-Enterprise panel test gains the subtitle assertion.

  • Fixes FE-1987

Screenshot

image

…eatment

An ended Enterprise workspace showed the Inactive badge and nothing else:
no statement of what stopped, no route back, and a credits tile whose only
remaining content was a bare balance — the account-manager line existed
solely as a run-button toast, discovered by failing to run.

The plan card now carries the subtitle under the header, and the credits
tile's inactive treatment extends to terminal sales-managed plans. The
tier exclusion it drops was written when the treatment sold a self-serve
reactivation and Enterprise kept top-up in every status; cloud#8001
withholds top-up once a sales-managed subscription is terminal, so both
halves of that rationale are gone. The note copy is tier-aware: restore
via the account manager rather than Reactivate, and the zero case states
that plan credits ended.

- Fixes FE-1987
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d9a51b51-ff1a-4491-9d3b-a7958d66a648

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1891 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1870 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 12:07:49 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 109ms TBT · 98.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.8 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.5 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 2ms TBT · 164.5 MB heap
vue-node-resize-workload: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 1ms TBT · 168.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 442ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.8 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -171
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 22ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 611ms
canvas-mouse-sweep: script duration 93ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.7 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 282ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.1 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 325ms
dom-widget-clipping: script duration 109ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.7 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 475ms
large-graph-idle: script duration 24ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.9 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -166
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1195ms
large-graph-pan: script duration 561ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.7 MB
large-graph-pan: DOM nodes -125
large-graph-pan: event listeners -88
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1184ms
large-graph-zoom: script duration 503ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.1 MB
large-graph-zoom: DOM nodes 2
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 4ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1316ms
legacy-node-drag: script duration 619ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.3 MB
legacy-node-drag: DOM nodes 5
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 467ms
minimap-idle: script duration 24ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.0 MB
minimap-idle: DOM nodes -268
minimap-idle: event listeners -166
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 293ms
subgraph-dom-widget-clipping: script duration 91ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.3 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 400ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.2 MB
subgraph-idle: DOM nodes -294
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 25ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 603ms
subgraph-mouse-sweep: script duration 67ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.0 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 714ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 109ms
subgraph-transition-enter: heap used 98.3 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 21ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4145ms
viewport-pan-sweep: script duration 1812ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.8 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -167
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10535ms
vue-large-graph-idle: script duration 168ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.5 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7477
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 12ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 68
vue-large-graph-pan: task duration 13188ms
vue-large-graph-pan: script duration 615ms
vue-large-graph-pan: TBT 2ms
vue-large-graph-pan: heap used 164.5 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7473
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 18ms
vue-node-resize-workload: style recalc duration 58ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 3836ms
vue-node-resize-workload: script duration 65ms
vue-node-resize-workload: TBT 1ms
vue-node-resize-workload: heap used 168.7 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7475
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 10ms
workflow-execution: layout count 3
workflow-execution: style recalc count 6
workflow-execution: task duration 57ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.6 MB
workflow-execution: DOM nodes 115
workflow-execution: event listeners 38
Raw data
{
  "timestamp": "2026-09-02T00:11:45.313Z",
  "gitSha": "ad008f828b9e7bd716451a660eb2a12e01e7a100",
  "branch": "comfydesigner/fe-1987-ended-enterprise",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2078.1840000000216,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.483000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.676,
      "heapDeltaBytes": -10614240,
      "heapUsedBytes": 58370716,
      "domNodes": -279,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.675999999999998,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2022.4390000000767,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.655,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.10900000000004,
      "heapDeltaBytes": 1224972,
      "heapUsedBytes": 71194540,
      "domNodes": -280,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.040000000000001,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1676.670999999999,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 21.401,
      "layouts": 14,
      "layoutDurationMs": 2.412,
      "taskDurationMs": 608.834,
      "heapDeltaBytes": -8670032,
      "heapUsedBytes": 61416048,
      "domNodes": -281,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 94.10600000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1708.898999999974,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 22.295,
      "layouts": 14,
      "layoutDurationMs": 2.494,
      "taskDurationMs": 613.292,
      "heapDeltaBytes": -8456756,
      "heapUsedBytes": 61683084,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 91.13000000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1669.6719999999914,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 11.924000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.9240000000000002,
      "taskDurationMs": 275.883,
      "heapDeltaBytes": 4399992,
      "heapUsedBytes": 74721076,
      "domNodes": 79,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 7.967999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1726.7729999999801,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.86,
      "layouts": 6,
      "layoutDurationMs": 1.026,
      "taskDurationMs": 287.833,
      "heapDeltaBytes": 3877796,
      "heapUsedBytes": 68067224,
      "domNodes": 78,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 8.206000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 527.3600000000442,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 5.9460000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 333.176,
      "heapDeltaBytes": 18197372,
      "heapUsedBytes": 88024268,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 113.451,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 526.3739999999189,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.053,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 317.399,
      "heapDeltaBytes": 17551504,
      "heapUsedBytes": 87606756,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 105.248,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2029.0509999999813,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.4940000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.263,
      "heapDeltaBytes": 11152436,
      "heapUsedBytes": 86844476,
      "domNodes": -271,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 25.666,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2011.6830000000618,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.481999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.6839999999999,
      "heapDeltaBytes": -12790956,
      "heapUsedBytes": 87090068,
      "domNodes": -267,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 22.043000000000006,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2082.572999999968,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 6.724000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1130.259,
      "heapDeltaBytes": 21776236,
      "heapUsedBytes": 88847272,
      "domNodes": 10,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 541.1779999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2113.751000000093,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 9.678000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1258.8300000000002,
      "heapDeltaBytes": 8124180,
      "heapUsedBytes": 84679312,
      "domNodes": -259,
      "jsHeapTotalBytes": 143360,
      "scriptDurationMs": 580.912,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3094.1660000000297,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.458,
      "layouts": 60,
      "layoutDurationMs": 8.517999999999999,
      "taskDurationMs": 1181.0810000000001,
      "heapDeltaBytes": 8172344,
      "heapUsedBytes": 75804668,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 500.768,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3074.8609999999417,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.153,
      "layouts": 60,
      "layoutDurationMs": 8.472999999999999,
      "taskDurationMs": 1186.57,
      "heapDeltaBytes": 8193324,
      "heapUsedBytes": 75504096,
      "domNodes": -5,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 504.355,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2192.04400000001,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 3.698,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1341.536,
      "heapDeltaBytes": 18505724,
      "heapUsedBytes": 85926120,
      "domNodes": 4,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 632.953,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2181.4280000000963,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 4.093000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1290.937,
      "heapDeltaBytes": 17720040,
      "heapUsedBytes": 84613040,
      "domNodes": 6,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 605.896,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.8100000000163,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.1889999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.654,
      "heapDeltaBytes": 10803240,
      "heapUsedBytes": 87022760,
      "domNodes": -269,
      "jsHeapTotalBytes": -2179072,
      "scriptDurationMs": 23.581999999999997,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.075000000039,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 3.8989999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.991,
      "heapDeltaBytes": -14698744,
      "heapUsedBytes": 86977412,
      "domNodes": -266,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 24.582000000000008,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 481.3819999999964,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.724000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 291.511,
      "heapDeltaBytes": 14001640,
      "heapUsedBytes": 85506240,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 91.20400000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 468.54800000005525,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.949000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 294.126,
      "heapDeltaBytes": 14772708,
      "heapUsedBytes": 87170000,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 91.283,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1990.5299999999784,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.7540000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.04499999999996,
      "heapDeltaBytes": 1632716,
      "heapUsedBytes": 74065864,
      "domNodes": -294,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.255,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2003.5919999999123,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.891,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.856,
      "heapDeltaBytes": -12145724,
      "heapUsedBytes": 60478592,
      "domNodes": -293,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.1930000000000005,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.0929999999958,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 26.727999999999998,
      "layouts": 18,
      "layoutDurationMs": 3.2319999999999998,
      "taskDurationMs": 616.359,
      "heapDeltaBytes": -12512460,
      "heapUsedBytes": 59912860,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 68.223,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.9159999999974,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 23.311999999999998,
      "layouts": 18,
      "layoutDurationMs": 3.0140000000000002,
      "taskDurationMs": 588.797,
      "heapDeltaBytes": -10359124,
      "heapUsedBytes": 61750988,
      "domNodes": -295,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 65.55900000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 898.9330000000564,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 24.185000000000006,
      "layouts": 16,
      "layoutDurationMs": 10.886999999999999,
      "taskDurationMs": 714.393,
      "heapDeltaBytes": 20701428,
      "heapUsedBytes": 103083132,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 21.453,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 109,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8163.720000000012,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 20.546,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4123.527,
      "heapDeltaBytes": 13319076,
      "heapUsedBytes": 88919312,
      "domNodes": -270,
      "jsHeapTotalBytes": 143360,
      "scriptDurationMs": 1792.182,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8190.465000000017,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 20.999999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4167.118,
      "heapDeltaBytes": 13151356,
      "heapUsedBytes": 88868184,
      "domNodes": -265,
      "jsHeapTotalBytes": 405504,
      "scriptDurationMs": 1831.73,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10976.406999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10420.311,
      "heapDeltaBytes": -25778976,
      "heapUsedBytes": 175243472,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2056192,
      "scriptDurationMs": 141.742,
      "eventListeners": -7477,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11166.353999999956,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10649.978000000001,
      "heapDeltaBytes": -36061152,
      "heapUsedBytes": 173886496,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5406720,
      "scriptDurationMs": 194.81500000000003,
      "eventListeners": -7477,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14018.80299999999,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.94099999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13453.990999999998,
      "heapDeltaBytes": -30435692,
      "heapUsedBytes": 182642052,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8740864,
      "scriptDurationMs": 635.243,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13486.985000000004,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.34400000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12921.641000000001,
      "heapDeltaBytes": -52056612,
      "heapUsedBytes": 162382572,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1581056,
      "scriptDurationMs": 595.511,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4004.6709999999734,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 58.12699999999998,
      "layouts": 20,
      "layoutDurationMs": 17.598000000000003,
      "taskDurationMs": 3845.148,
      "heapDeltaBytes": -23155600,
      "heapUsedBytes": 178003932,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12541952,
      "scriptDurationMs": 59.08499999999999,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3964.046000000053,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 56.903000000000006,
      "layouts": 20,
      "layoutDurationMs": 17.417,
      "taskDurationMs": 3826.6760000000004,
      "heapDeltaBytes": -33481988,
      "heapUsedBytes": 175783880,
      "domNodes": -6548,
      "jsHeapTotalBytes": 6221824,
      "scriptDurationMs": 70.08300000000003,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 85.36700000001929,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 13.015,
      "layouts": 3,
      "layoutDurationMs": 1.334,
      "taskDurationMs": 64.50899999999999,
      "heapDeltaBytes": 3144244,
      "heapUsedBytes": 71393444,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.083999999999999,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 85.48199999995632,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 7.19,
      "layouts": 2,
      "layoutDurationMs": 0.5120000000000001,
      "taskDurationMs": 49.37399999999999,
      "heapDeltaBytes": 3239060,
      "heapUsedBytes": 70435568,
      "domNodes": 106,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.905999999999999,
      "eventListeners": 51,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                                Coverage Diff                                @@
##           jaewon/fe-1962-inactive-badge-drop-ended-card   #16552      +/-   ##
=================================================================================
- Coverage                                          82.27%   82.24%   -0.04%     
=================================================================================
  Files                                               2018     2018              
  Lines                                             116882   116605     -277     
  Branches                                           29388    29322      -66     
=================================================================================
- Hits                                               96169    95898     -271     
+ Misses                                             20538    20532       -6     
  Partials                                             175      175              
Flag Coverage Δ
unit 76.54% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...form/cloud/subscription/components/CreditsTile.vue 99.01% <100.00%> (+<0.01%) ⬆️
...e/components/SubscriptionPanelContentWorkspace.vue 96.71% <100.00%> (+0.04%) ⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfydesigner

Copy link
Copy Markdown
Contributor Author

Closing — #16520 covers this scope (ended sales-managed subtitle and credits-tile treatment, with top-up left to the server per Comfy-Org/cloud#8001). The ended-Personal badge fix from this branch is raised as a review comment there.

@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants