Repository navigation
refactor: follow-up to #16458 — drop dead optional chain - #16551
christian-byrne wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1914 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.68 MB gzip 🟢 -86 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • 🟢 -1 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 224 unchanged ⚡ Performance
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16551 +/- ##
==========================================
+ Coverage 81.11% 82.68% +1.57%
==========================================
Files 2458 2040 -418
Lines 126457 118978 -7479
Branches 33692 30053 -3639
==========================================
- Hits 102573 98379 -4194
+ Misses 23369 20419 -2950
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 423 files with indirect coverage changes 🚀 New features to boost your workflow:
|
e1db078 to
925484b
Compare
|
Removed |
|
Severity: Major What: The intended change is one line in Why this is an issue: A correct one-line fix cannot be reviewed or merged in this vehicle, and the body's scoped verification cannot speak to a diff that includes a version bump and website features. Proposed Fix: Recreate the branch from |
|
@coderabbitai review |
|
925484b to
53f7d66
Compare
|
Rebased onto current Full context for agent readersThe rebase dropped 27 commits already present on Verification:
|
|
@coderabbitai review |
|
Follow-up to #16458 — CodeJuggernaut approved with a non-blocking nit: 'the dead-optional-chain note is a non-blocking nit'. The function now returns early when `!node.graph`, so `node.graph` is guaranteed non-null by the time it reaches `node.graph?.setDirtyCanvas(true)`; the optional chain is dead.
53f7d66 to
2c32fb0
Compare
Summary
Follow-up to #16458. Addresses the non-blocking nit from CodeJuggernaut's approval (review): "the dead-optional-chain note is a non-blocking nit".
updateNodeWithServerReferencesinuseMaskEditorSaver.tsnow returns early when!node.graph(added in #16458), sonode.graphis guaranteed non-null by the laternode.graph?.setDirtyCanvas(true)call — the optional chain is dead code. Removed it.No behavior change.
Verification
pnpm test:unit src/composables/maskeditor/useMaskEditorSaver.test.ts-> 5/5 passed (including the detached-node early-return case)pnpm typecheck-> passedpnpm exec eslint-> passed