Repository navigation
[backport cloud/1.53] fix: refresh node image after mask editor save - #16540
Conversation
Mask-editor saves now replace the node output instead of leaving the pre-edit clipspace image. Regression coverage reproduces the paste, edit, and reopen failure. <details><summary>Full context for agent readers</summary> ## Summary After a mask-editor upload succeeds, the saved image is written through a replacing store call so the output store and the `node.images` mirror advance together. The loader prefers `node.images[0]`, so leaving that mirror untouched reopened the pre-edit clipspace image. In Vue-nodes mode nothing else re-syncs it, because the legacy path (`onDrawBackground` to `updatePreviews`) only runs on the canvas renderer. ## Changes - Add `replaceNodeOutputImages`, which sets a node's output to exactly the given images and syncs `node.images`. - Call it from the mask-editor save. `animated`, `video` and the other media keys are parallel to the images they were produced with, so an editor that rewrites the image list wholesale must not inherit them from the previous execution. - Leave `setNodeOutputImages` merge semantics untouched, so the clipspace paste path (`ComfyApp.pasteFromClipspace`), where images can legitimately be an animated webp, is unchanged. ## Verification - `nodeOutputStore.test.ts` and `useMaskEditorSaver.test.ts`: passed. The new store test fails against the pre-fix code. - `pnpm typecheck`, `pnpm knip`: passed. - CI green at `4fb6318df9`. Checklist: #15973 Claim and verification: #15973 (comment) Original review: #15924 (comment) Fixes #16009 </details>
🎭 Playwright: ✅ 1892 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-01T22:49:49.603Z",
"gitSha": "f29b2db3a281d6c10cd000fbc983bac46c471283",
"branch": "backport-16458-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2088.7109999999893,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.839,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.462,
"heapDeltaBytes": 13637660,
"heapUsedBytes": 82652240,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.519000000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2031.0690000000022,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.48500000000007,
"heapDeltaBytes": 13355284,
"heapUsedBytes": 82653304,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.321999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1762.5439999999912,
"styleRecalcs": 73,
"styleRecalcDurationMs": 32.377,
"layouts": 14,
"layoutDurationMs": 3.7420000000000004,
"taskDurationMs": 837.361,
"heapDeltaBytes": -7908696,
"heapUsedBytes": 61861792,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 154.387,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.4139999999943,
"styleRecalcs": 74,
"styleRecalcDurationMs": 34.035999999999994,
"layouts": 14,
"layoutDurationMs": 3.9360000000000004,
"taskDurationMs": 840.051,
"heapDeltaBytes": -8467944,
"heapUsedBytes": 61379300,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 153.642,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.9149999999768,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.281999999999996,
"layouts": 6,
"layoutDurationMs": 1.2540000000000002,
"taskDurationMs": 336.75699999999995,
"heapDeltaBytes": 4354644,
"heapUsedBytes": 74303108,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.772,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.8829999999816,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.16,
"layouts": 6,
"layoutDurationMs": 1.1160000000000003,
"taskDurationMs": 341.892,
"heapDeltaBytes": 4376344,
"heapUsedBytes": 74023296,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.350000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 657.1369999999774,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.12,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.623,
"heapDeltaBytes": 18140868,
"heapUsedBytes": 88078784,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 162.30499999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 652.8070000000525,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.432000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.959,
"heapDeltaBytes": 18086432,
"heapUsedBytes": 88089280,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 157.289,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2046.27499999998,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.810000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.919,
"heapDeltaBytes": 10726084,
"heapUsedBytes": 85795344,
"domNodes": -270,
"jsHeapTotalBytes": -2179072,
"scriptDurationMs": 35.288,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.9209999999875,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.483999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.447,
"heapDeltaBytes": -13673744,
"heapUsedBytes": 86248404,
"domNodes": -268,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 30.459,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2203.7669999999707,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.332000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.598,
"heapDeltaBytes": 24414224,
"heapUsedBytes": 89752364,
"domNodes": -273,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 848.3870000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2233.4119999999302,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.367000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1609.2620000000002,
"heapDeltaBytes": -14798416,
"heapUsedBytes": 85271112,
"domNodes": -270,
"jsHeapTotalBytes": 2539520,
"scriptDurationMs": 830.8679999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3448.0070000000183,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.955000000000002,
"layouts": 60,
"layoutDurationMs": 11.558,
"taskDurationMs": 1608.737,
"heapDeltaBytes": 8156272,
"heapUsedBytes": 75315484,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 735.156,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3464.2169999999624,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.174999999999997,
"layouts": 60,
"layoutDurationMs": 11.365,
"taskDurationMs": 1613.8000000000002,
"heapDeltaBytes": 8167288,
"heapUsedBytes": 75738080,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 758.632,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3092.5770000000057,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.77,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1851.5829999999999,
"heapDeltaBytes": 17472152,
"heapUsedBytes": 84484628,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 935.86,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 2906.281999999919,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.247000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1836.048,
"heapDeltaBytes": 17726528,
"heapUsedBytes": 84629536,
"domNodes": 2,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 922.9830000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2025.9340000000066,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.583,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.3299999999999,
"heapDeltaBytes": -14893916,
"heapUsedBytes": 87358612,
"domNodes": -269,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 26.753,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.7290000000175,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.757000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.563,
"heapDeltaBytes": -14818892,
"heapUsedBytes": 86936244,
"domNodes": -268,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 27.253,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.1110000000122,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.719,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.64900000000006,
"heapDeltaBytes": 13950876,
"heapUsedBytes": 85993468,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 142.319,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.580000000049,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.569,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.725,
"heapDeltaBytes": 14830876,
"heapUsedBytes": 87185452,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 135.83100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.2880000000073,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.191,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.169,
"heapDeltaBytes": -6454560,
"heapUsedBytes": 65129264,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 6.756999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.7800000000252,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.697000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.32499999999993,
"heapDeltaBytes": 2243728,
"heapUsedBytes": 74319176,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.364000000000002,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.0790000000093,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.73500000000001,
"layouts": 18,
"layoutDurationMs": 5.085,
"taskDurationMs": 828.087,
"heapDeltaBytes": -11959524,
"heapUsedBytes": 59830572,
"domNodes": -293,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 104.475,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.9179999999806,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.415,
"layouts": 18,
"layoutDurationMs": 5.787999999999999,
"taskDurationMs": 812.9970000000001,
"heapDeltaBytes": -9162196,
"heapUsedBytes": 62558696,
"domNodes": -297,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 107.089,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1381.6319999999678,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.912000000000003,
"layouts": 14,
"layoutDurationMs": 15.022,
"taskDurationMs": 873.4279999999999,
"heapDeltaBytes": -1670872,
"heapUsedBytes": 95468620,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 26.987000000000005,
"eventListeners": 2381,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8257.168999999976,
"styleRecalcs": 246,
"styleRecalcDurationMs": 32.487,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5566.34,
"heapDeltaBytes": -18751708,
"heapUsedBytes": 81117156,
"domNodes": -273,
"jsHeapTotalBytes": -606208,
"scriptDurationMs": 2614.913,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8315.253999999983,
"styleRecalcs": 247,
"styleRecalcDurationMs": 33.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5600.327,
"heapDeltaBytes": -10872928,
"heapUsedBytes": 88654472,
"domNodes": -269,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 2626.958,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16270.937000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15220.63,
"heapDeltaBytes": -42530040,
"heapUsedBytes": 179131932,
"domNodes": -6548,
"jsHeapTotalBytes": 2285568,
"scriptDurationMs": 237.91,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16180.552000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15220.679,
"heapDeltaBytes": -34479752,
"heapUsedBytes": 175102192,
"domNodes": -6548,
"jsHeapTotalBytes": 2564096,
"scriptDurationMs": 261.80099999999993,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20207.716000000004,
"styleRecalcs": 157,
"styleRecalcDurationMs": 16.237999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19866.883,
"heapDeltaBytes": -17061908,
"heapUsedBytes": 190853688,
"domNodes": -6548,
"jsHeapTotalBytes": -3121152,
"scriptDurationMs": 892.081,
"eventListeners": -7469,
"totalBlockingTimeMs": 82,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20747.09900000005,
"styleRecalcs": 179,
"styleRecalcDurationMs": 17.61400000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20371.533,
"heapDeltaBytes": -35716636,
"heapUsedBytes": 165996552,
"domNodes": -6548,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 917.3000000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 90,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5858.134000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.40799999999997,
"layouts": 20,
"layoutDurationMs": 21.450999999999997,
"taskDurationMs": 5724.4349999999995,
"heapDeltaBytes": -20916252,
"heapUsedBytes": 181158476,
"domNodes": -6548,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 106.34599999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 336,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5785.793000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.34399999999997,
"layouts": 20,
"layoutDurationMs": 21.15199999999999,
"taskDurationMs": 5672.664999999999,
"heapDeltaBytes": -30635528,
"heapUsedBytes": 178368768,
"domNodes": -6548,
"jsHeapTotalBytes": 9908224,
"scriptDurationMs": 100.729,
"eventListeners": -7473,
"totalBlockingTimeMs": 367,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 108.67999999993572,
"styleRecalcs": 7,
"styleRecalcDurationMs": 17.115,
"layouts": 4,
"layoutDurationMs": 1.97,
"taskDurationMs": 91.37600000000002,
"heapDeltaBytes": 3673056,
"heapUsedBytes": 67381028,
"domNodes": 195,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.499,
"eventListeners": 79,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 94.95300000003226,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.835000000000003,
"layouts": 2,
"layoutDurationMs": 1.1880000000000002,
"taskDurationMs": 71.02600000000001,
"heapDeltaBytes": 3116304,
"heapUsedBytes": 66534696,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.5329999999999995,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #16540 +/- ##
=============================================
Coverage ? 83.25%
=============================================
Files ? 2023
Lines ? 116966
Branches ? 32450
=============================================
Hits ? 97384
Misses ? 19235
Partials ? 347
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #16458 to
cloud/1.53Automatically created by backport workflow.