Skip to content

[backport cloud/1.53] fix: refresh node image after mask editor save - #16540

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16458-to-cloud-1.53
Sep 1, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16458-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16458 to cloud/1.53

Automatically created by backport workflow.

Mask-editor saves now replace the node output instead of leaving the
pre-edit clipspace image.
Regression coverage reproduces the paste, edit, and reopen failure.

<details><summary>Full context for agent readers</summary>

## Summary

After a mask-editor upload succeeds, the saved image is written through
a replacing store call so the output store and the `node.images` mirror
advance together. The loader prefers `node.images[0]`, so leaving that
mirror untouched reopened the pre-edit clipspace image. In Vue-nodes
mode nothing else re-syncs it, because the legacy path
(`onDrawBackground` to `updatePreviews`) only runs on the canvas
renderer.

## Changes

- Add `replaceNodeOutputImages`, which sets a node's output to exactly
the given images and syncs `node.images`.
- Call it from the mask-editor save. `animated`, `video` and the other
media keys are parallel to the images they were produced with, so an
editor that rewrites the image list wholesale must not inherit them from
the previous execution.
- Leave `setNodeOutputImages` merge semantics untouched, so the
clipspace paste path (`ComfyApp.pasteFromClipspace`), where images can
legitimately be an animated webp, is unchanged.

## Verification

- `nodeOutputStore.test.ts` and `useMaskEditorSaver.test.ts`: passed.
The new store test fails against the pre-fix code.
- `pnpm typecheck`, `pnpm knip`: passed.
- CI green at `4fb6318df9`.

Checklist: #15973
Claim and verification:
#15973 (comment)
Original review:
#15924 (comment)

Fixes #16009

</details>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 1, 2026
@comfy-pr-bot
comfy-pr-bot requested review from a team and jtydhr88 as code owners September 1, 2026 22:26
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 1, 2026 22:26
@christian-byrne christian-byrne self-assigned this Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1892 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1871 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/01/2026, 10:46:58 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 129ms TBT · 91.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.0 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.9 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 86ms TBT · 170.2 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 352ms TBT · 171.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 516ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 78.8 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 839ms
canvas-mouse-sweep: script duration 154ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.8 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 339ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.7 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 447ms
dom-widget-clipping: script duration 160ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.0 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 583ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.0 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -169
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1616ms
large-graph-pan: script duration 840ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.5 MB
large-graph-pan: DOM nodes -272
large-graph-pan: event listeners -153
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1611ms
large-graph-zoom: script duration 747ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.0 MB
large-graph-zoom: DOM nodes 2
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1844ms
legacy-node-drag: script duration 929ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 80.6 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 556ms
minimap-idle: script duration 27ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.1 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 399ms
subgraph-dom-widget-clipping: script duration 139ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.6 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 464ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.5 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -215
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 39ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 821ms
subgraph-mouse-sweep: script duration 106ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.4 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 873ms
subgraph-transition-enter: script duration 27ms
subgraph-transition-enter: TBT 129ms
subgraph-transition-enter: heap used 91.0 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 33ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5583ms
viewport-pan-sweep: script duration 2621ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.0 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -154
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15221ms
vue-large-graph-idle: script duration 250ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.9 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 168
vue-large-graph-pan: task duration 20119ms
vue-large-graph-pan: script duration 905ms
vue-large-graph-pan: TBT 86ms
vue-large-graph-pan: heap used 170.2 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 77ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5699ms
vue-node-resize-workload: script duration 104ms
vue-node-resize-workload: TBT 352ms
vue-node-resize-workload: heap used 171.4 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 7
workflow-execution: task duration 81ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.9 MB
workflow-execution: DOM nodes 160
workflow-execution: event listeners 52
Raw data
{
  "timestamp": "2026-09-01T22:49:49.603Z",
  "gitSha": "f29b2db3a281d6c10cd000fbc983bac46c471283",
  "branch": "backport-16458-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2088.7109999999893,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.839,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 540.462,
      "heapDeltaBytes": 13637660,
      "heapUsedBytes": 82652240,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.519000000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2031.0690000000022,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.489,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.48500000000007,
      "heapDeltaBytes": 13355284,
      "heapUsedBytes": 82653304,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.321999999999998,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1762.5439999999912,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 32.377,
      "layouts": 14,
      "layoutDurationMs": 3.7420000000000004,
      "taskDurationMs": 837.361,
      "heapDeltaBytes": -7908696,
      "heapUsedBytes": 61861792,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 154.387,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1807.4139999999943,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 34.035999999999994,
      "layouts": 14,
      "layoutDurationMs": 3.9360000000000004,
      "taskDurationMs": 840.051,
      "heapDeltaBytes": -8467944,
      "heapUsedBytes": 61379300,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 153.642,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.9149999999768,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.281999999999996,
      "layouts": 6,
      "layoutDurationMs": 1.2540000000000002,
      "taskDurationMs": 336.75699999999995,
      "heapDeltaBytes": 4354644,
      "heapUsedBytes": 74303108,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.772,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1719.8829999999816,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.16,
      "layouts": 6,
      "layoutDurationMs": 1.1160000000000003,
      "taskDurationMs": 341.892,
      "heapDeltaBytes": 4376344,
      "heapUsedBytes": 74023296,
      "domNodes": 78,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 9.350000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 657.1369999999774,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.12,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.623,
      "heapDeltaBytes": 18140868,
      "heapUsedBytes": 88078784,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 162.30499999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 652.8070000000525,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.432000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 433.959,
      "heapDeltaBytes": 18086432,
      "heapUsedBytes": 88089280,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 157.289,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2046.27499999998,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.810000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 585.919,
      "heapDeltaBytes": 10726084,
      "heapUsedBytes": 85795344,
      "domNodes": -270,
      "jsHeapTotalBytes": -2179072,
      "scriptDurationMs": 35.288,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2032.9209999999875,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.483999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 580.447,
      "heapDeltaBytes": -13673744,
      "heapUsedBytes": 86248404,
      "domNodes": -268,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 30.459,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2203.7669999999707,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.332000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1623.598,
      "heapDeltaBytes": 24414224,
      "heapUsedBytes": 89752364,
      "domNodes": -273,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 848.3870000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2233.4119999999302,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.367000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1609.2620000000002,
      "heapDeltaBytes": -14798416,
      "heapUsedBytes": 85271112,
      "domNodes": -270,
      "jsHeapTotalBytes": 2539520,
      "scriptDurationMs": 830.8679999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3448.0070000000183,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 9.955000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.558,
      "taskDurationMs": 1608.737,
      "heapDeltaBytes": 8156272,
      "heapUsedBytes": 75315484,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 735.156,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3464.2169999999624,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.174999999999997,
      "layouts": 60,
      "layoutDurationMs": 11.365,
      "taskDurationMs": 1613.8000000000002,
      "heapDeltaBytes": 8167288,
      "heapUsedBytes": 75738080,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 758.632,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3092.5770000000057,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.77,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1851.5829999999999,
      "heapDeltaBytes": 17472152,
      "heapUsedBytes": 84484628,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 935.86,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2906.281999999919,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.247000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1836.048,
      "heapDeltaBytes": 17726528,
      "heapUsedBytes": 84629536,
      "domNodes": 2,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 922.9830000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.9340000000066,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.583,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 547.3299999999999,
      "heapDeltaBytes": -14893916,
      "heapUsedBytes": 87358612,
      "domNodes": -269,
      "jsHeapTotalBytes": -569344,
      "scriptDurationMs": 26.753,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2032.7290000000175,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.757000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.563,
      "heapDeltaBytes": -14818892,
      "heapUsedBytes": 86936244,
      "domNodes": -268,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 27.253,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.1110000000122,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.719,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.64900000000006,
      "heapDeltaBytes": 13950876,
      "heapUsedBytes": 85993468,
      "domNodes": 22,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 142.319,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 561.580000000049,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.569,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.725,
      "heapDeltaBytes": 14830876,
      "heapUsedBytes": 87185452,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 135.83100000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.2880000000073,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.191,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.169,
      "heapDeltaBytes": -6454560,
      "heapUsedBytes": 65129264,
      "domNodes": -297,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 6.756999999999999,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.7800000000252,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.697000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.32499999999993,
      "heapDeltaBytes": 2243728,
      "heapUsedBytes": 74319176,
      "domNodes": -298,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.364000000000002,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1758.0790000000093,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.73500000000001,
      "layouts": 18,
      "layoutDurationMs": 5.085,
      "taskDurationMs": 828.087,
      "heapDeltaBytes": -11959524,
      "heapUsedBytes": 59830572,
      "domNodes": -293,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 104.475,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1773.9179999999806,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.415,
      "layouts": 18,
      "layoutDurationMs": 5.787999999999999,
      "taskDurationMs": 812.9970000000001,
      "heapDeltaBytes": -9162196,
      "heapUsedBytes": 62558696,
      "domNodes": -297,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 107.089,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1381.6319999999678,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.912000000000003,
      "layouts": 14,
      "layoutDurationMs": 15.022,
      "taskDurationMs": 873.4279999999999,
      "heapDeltaBytes": -1670872,
      "heapUsedBytes": 95468620,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 26.987000000000005,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 129,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8257.168999999976,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 32.487,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5566.34,
      "heapDeltaBytes": -18751708,
      "heapUsedBytes": 81117156,
      "domNodes": -273,
      "jsHeapTotalBytes": -606208,
      "scriptDurationMs": 2614.913,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8315.253999999983,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 33.211,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5600.327,
      "heapDeltaBytes": -10872928,
      "heapUsedBytes": 88654472,
      "domNodes": -269,
      "jsHeapTotalBytes": -868352,
      "scriptDurationMs": 2626.958,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16270.937000000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15220.63,
      "heapDeltaBytes": -42530040,
      "heapUsedBytes": 179131932,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2285568,
      "scriptDurationMs": 237.91,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16180.552000000034,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15220.679,
      "heapDeltaBytes": -34479752,
      "heapUsedBytes": 175102192,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2564096,
      "scriptDurationMs": 261.80099999999993,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20207.716000000004,
      "styleRecalcs": 157,
      "styleRecalcDurationMs": 16.237999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19866.883,
      "heapDeltaBytes": -17061908,
      "heapUsedBytes": 190853688,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3121152,
      "scriptDurationMs": 892.081,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 82,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20747.09900000005,
      "styleRecalcs": 179,
      "styleRecalcDurationMs": 17.61400000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20371.533,
      "heapDeltaBytes": -35716636,
      "heapUsedBytes": 165996552,
      "domNodes": -6548,
      "jsHeapTotalBytes": 483328,
      "scriptDurationMs": 917.3000000000001,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 90,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5858.134000000007,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.40799999999997,
      "layouts": 20,
      "layoutDurationMs": 21.450999999999997,
      "taskDurationMs": 5724.4349999999995,
      "heapDeltaBytes": -20916252,
      "heapUsedBytes": 181158476,
      "domNodes": -6548,
      "jsHeapTotalBytes": 17555456,
      "scriptDurationMs": 106.34599999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 336,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5785.793000000012,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.34399999999997,
      "layouts": 20,
      "layoutDurationMs": 21.15199999999999,
      "taskDurationMs": 5672.664999999999,
      "heapDeltaBytes": -30635528,
      "heapUsedBytes": 178368768,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9908224,
      "scriptDurationMs": 100.729,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 367,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 108.67999999993572,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 17.115,
      "layouts": 4,
      "layoutDurationMs": 1.97,
      "taskDurationMs": 91.37600000000002,
      "heapDeltaBytes": 3673056,
      "heapUsedBytes": 67381028,
      "domNodes": 195,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.499,
      "eventListeners": 79,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 94.95300000003226,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 13.835000000000003,
      "layouts": 2,
      "layoutDurationMs": 1.1880000000000002,
      "taskDurationMs": 71.02600000000001,
      "heapDeltaBytes": 3116304,
      "heapUsedBytes": 66534696,
      "domNodes": 125,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.5329999999999995,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #16540   +/-   ##
=============================================
  Coverage              ?   83.25%           
=============================================
  Files                 ?     2023           
  Lines                 ?   116966           
  Branches              ?    32450           
=============================================
  Hits                  ?    97384           
  Misses                ?    19235           
  Partials              ?      347           
Flag Coverage Δ
e2e 66.60% <90.00%> (?)
unit 76.51% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/maskeditor/useMaskEditorSaver.ts 94.03% <100.00%> (ø)
src/stores/nodeOutputStore.ts 89.09% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit cd7beaa into cloud/1.53 Sep 1, 2026
106 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16458-to-cloud-1.53 branch September 1, 2026 23:08
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants