Repository navigation
[backport core/1.53] fix: refresh node image after mask editor save - #16539
Conversation
Mask-editor saves now replace the node output instead of leaving the pre-edit clipspace image. Regression coverage reproduces the paste, edit, and reopen failure. <details><summary>Full context for agent readers</summary> ## Summary After a mask-editor upload succeeds, the saved image is written through a replacing store call so the output store and the `node.images` mirror advance together. The loader prefers `node.images[0]`, so leaving that mirror untouched reopened the pre-edit clipspace image. In Vue-nodes mode nothing else re-syncs it, because the legacy path (`onDrawBackground` to `updatePreviews`) only runs on the canvas renderer. ## Changes - Add `replaceNodeOutputImages`, which sets a node's output to exactly the given images and syncs `node.images`. - Call it from the mask-editor save. `animated`, `video` and the other media keys are parallel to the images they were produced with, so an editor that rewrites the image list wholesale must not inherit them from the previous execution. - Leave `setNodeOutputImages` merge semantics untouched, so the clipspace paste path (`ComfyApp.pasteFromClipspace`), where images can legitimately be an animated webp, is unchanged. ## Verification - `nodeOutputStore.test.ts` and `useMaskEditorSaver.test.ts`: passed. The new store test fails against the pre-fix code. - `pnpm typecheck`, `pnpm knip`: passed. - CI green at `4fb6318df9`. Checklist: #15973 Claim and verification: #15973 (comment) Original review: #15924 (comment) Fixes #16009 </details>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1892 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-01T22:49:37.035Z",
"gitSha": "d7e28306f041b57f353f26f05b47b2ec2e95f0eb",
"branch": "backport-16458-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.0479999999702,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.4540000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.4280000000001,
"heapDeltaBytes": -9199408,
"heapUsedBytes": 60302136,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.386000000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2055.3790000000163,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.882999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.271,
"heapDeltaBytes": -12700004,
"heapUsedBytes": 56299364,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.436,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.7540000000217,
"styleRecalcs": 74,
"styleRecalcDurationMs": 32.562,
"layouts": 14,
"layoutDurationMs": 4.289,
"taskDurationMs": 846.223,
"heapDeltaBytes": -9122828,
"heapUsedBytes": 60827952,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 137.599,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1828.7290000000667,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.57599999999999,
"layouts": 14,
"layoutDurationMs": 4.163,
"taskDurationMs": 844.193,
"heapDeltaBytes": -8116624,
"heapUsedBytes": 61377076,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 138.65000000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.491999999993,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.002999999999997,
"layouts": 6,
"layoutDurationMs": 1.218,
"taskDurationMs": 344.007,
"heapDeltaBytes": 4382744,
"heapUsedBytes": 74318024,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.616,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.3880000001,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.359000000000002,
"layouts": 6,
"layoutDurationMs": 1.0639999999999998,
"taskDurationMs": 345.265,
"heapDeltaBytes": 4360776,
"heapUsedBytes": 73312632,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.748999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 761.0930000000167,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.91,
"heapDeltaBytes": 18763780,
"heapUsedBytes": 87699884,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 168.976,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 632.5630000000046,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.284999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.9219999999999,
"heapDeltaBytes": 17808548,
"heapUsedBytes": 88067780,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 159.212,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.0919999999724,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.173,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.379,
"heapDeltaBytes": -12820064,
"heapUsedBytes": 87097524,
"domNodes": -269,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 32.288,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.1139999999978,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.319999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.2389999999999,
"heapDeltaBytes": 10736600,
"heapUsedBytes": 86161624,
"domNodes": -269,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 33.13599999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2115.6290000000126,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.309,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1495.625,
"heapDeltaBytes": 20766176,
"heapUsedBytes": 86477996,
"domNodes": -275,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 736.731,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2153.95500000011,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.709000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1497.416,
"heapDeltaBytes": 22652464,
"heapUsedBytes": 88413404,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 738.186,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3517.079000000024,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.221,
"layouts": 60,
"layoutDurationMs": 12.501999999999999,
"taskDurationMs": 1642.938,
"heapDeltaBytes": 11742884,
"heapUsedBytes": 79516672,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 742.048,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3451.4580000000024,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.718,
"layouts": 60,
"layoutDurationMs": 12.488999999999999,
"taskDurationMs": 1632.504,
"heapDeltaBytes": 9746764,
"heapUsedBytes": 76083244,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 743.2479999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3058.2379999999603,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.074999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1874.831,
"heapDeltaBytes": 17439764,
"heapUsedBytes": 85151588,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 933.2159999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3000.04100000001,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.221,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1828.3319999999999,
"heapDeltaBytes": 18189652,
"heapUsedBytes": 84929784,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 921.9040000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2081.450000000018,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.868,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.884,
"heapDeltaBytes": -14825024,
"heapUsedBytes": 87234764,
"domNodes": -271,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 34.842000000000006,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2003.2939999999826,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.405,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.773,
"heapDeltaBytes": 21733096,
"heapUsedBytes": 87705672,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.101000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.7429999999795,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.765,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.5080000000001,
"heapDeltaBytes": 14850056,
"heapUsedBytes": 86955864,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 135.73600000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.4310000000751,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.061,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.224,
"heapDeltaBytes": 14035808,
"heapUsedBytes": 85964676,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.944,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.8359999999884,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.741000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.789,
"heapDeltaBytes": -8879796,
"heapUsedBytes": 62999788,
"domNodes": -301,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.290999999999999,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.495999999961,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.29,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.623,
"heapDeltaBytes": 7024788,
"heapUsedBytes": 72415588,
"domNodes": -297,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.887999999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.920000000002,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.36,
"layouts": 18,
"layoutDurationMs": 4.803,
"taskDurationMs": 768.668,
"heapDeltaBytes": -12583540,
"heapUsedBytes": 59594224,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 95.058,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.8750000000482,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.239000000000004,
"layouts": 18,
"layoutDurationMs": 5.816,
"taskDurationMs": 795.483,
"heapDeltaBytes": -11624864,
"heapUsedBytes": 60377056,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 98.065,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.0330000000076,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.868,
"layouts": 14,
"layoutDurationMs": 14.190999999999999,
"taskDurationMs": 912.6970000000001,
"heapDeltaBytes": 21923736,
"heapUsedBytes": 104476056,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 28.661000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8342.495999999983,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.376999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5671.990999999999,
"heapDeltaBytes": 7326368,
"heapUsedBytes": 82456004,
"domNodes": -268,
"jsHeapTotalBytes": -643072,
"scriptDurationMs": 2605.9729999999995,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8549.7620000001,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5886.624000000001,
"heapDeltaBytes": -17914688,
"heapUsedBytes": 82313784,
"domNodes": -267,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 2647.435,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17965.484000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17102.929,
"heapDeltaBytes": -28574212,
"heapUsedBytes": 175703244,
"domNodes": -6548,
"jsHeapTotalBytes": -3346432,
"scriptDurationMs": 315.69199999999995,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17754.549,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17078.982999999997,
"heapDeltaBytes": -40348304,
"heapUsedBytes": 175705320,
"domNodes": -6548,
"jsHeapTotalBytes": -3837952,
"scriptDurationMs": 287.903,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22267.577999999958,
"styleRecalcs": 172,
"styleRecalcDurationMs": 20.517000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21908.445,
"heapDeltaBytes": -41912344,
"heapUsedBytes": 168285484,
"domNodes": -6548,
"jsHeapTotalBytes": -1437696,
"scriptDurationMs": 902.105,
"eventListeners": -7467,
"totalBlockingTimeMs": 144,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21359.733000000007,
"styleRecalcs": 163,
"styleRecalcDurationMs": 18.65,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21075.826,
"heapDeltaBytes": -49512068,
"heapUsedBytes": 163785016,
"domNodes": -6548,
"jsHeapTotalBytes": -7528448,
"scriptDurationMs": 917.8629999999998,
"eventListeners": -7467,
"totalBlockingTimeMs": 177,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6309.67899999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.99099999999997,
"layouts": 20,
"layoutDurationMs": 23.912000000000003,
"taskDurationMs": 6200.174,
"heapDeltaBytes": -39894308,
"heapUsedBytes": 162366692,
"domNodes": -6548,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 110.80199999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 471,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6219.785000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.515,
"layouts": 20,
"layoutDurationMs": 23.412000000000003,
"taskDurationMs": 6148.268,
"heapDeltaBytes": -17413016,
"heapUsedBytes": 185498744,
"domNodes": -6548,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 111.72500000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 495,
"frameDurationMs": 18.33666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 471.47399999994377,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.061999999999998,
"layouts": 4,
"layoutDurationMs": 2.048,
"taskDurationMs": 121.76499999999999,
"heapDeltaBytes": 5310184,
"heapUsedBytes": 73288116,
"domNodes": 154,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 11.658999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 445.9039999999277,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.111,
"layouts": 3,
"layoutDurationMs": 0.9390000000000002,
"taskDurationMs": 94.41100000000002,
"heapDeltaBytes": 5050512,
"heapUsedBytes": 72848524,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.703,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.53 #16539 +/- ##
=============================================
- Coverage 83.25% 83.25% -0.01%
=============================================
Files 2023 2023
Lines 116957 116965 +8
Branches 32447 32450 +3
=============================================
Hits 97376 97376
- Misses 19225 19242 +17
+ Partials 356 347 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #16458 to
core/1.53Automatically created by backport workflow.