Repository navigation
fix(billing): keep the total-due divider off the credits row - #16530
comfydesigner wants to merge 1 commit into
Conversation
The divider's top margin was applied only to scheduled changes. An immediate change got padding below the rule and none above it, so on a monthly plan the line sat flush against the credits row. A yearly plan hid it — refillReplacesNote fills that gap — which is why it read as correct in half the cases.
🎭 Playwright: ❌ 1752 passed, 10 failed · 3 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.67 MB gzip 🟢 -5 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • 🟢 -66 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • 🟢 -477 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 17 added / 17 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.3 MB (baseline 16.3 MB) • 🟢 -24 BBundles that do not match a named category
Status: 70 added / 70 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-01T20:34:18.739Z",
"gitSha": "c59b0077752d31a82343631d42150b2b65181e9e",
"branch": "comfydesigner/preview-divider-spacing",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2033.9779999999905,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.999999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.9509999999999,
"heapDeltaBytes": -9730188,
"heapUsedBytes": 59223180,
"domNodes": -287,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.011000000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2051.4670000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.518999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.027,
"heapDeltaBytes": 12257932,
"heapUsedBytes": 81377372,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.704000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2090.3339999999844,
"styleRecalcs": 82,
"styleRecalcDurationMs": 50.363,
"layouts": 14,
"layoutDurationMs": 5.114,
"taskDurationMs": 1058.338,
"heapDeltaBytes": 7635276,
"heapUsedBytes": 77613516,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 182.85600000000002,
"eventListeners": -189,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1923.744000000056,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.647999999999996,
"layouts": 14,
"layoutDurationMs": 4.840000000000001,
"taskDurationMs": 890.22,
"heapDeltaBytes": -6943428,
"heapUsedBytes": 63010792,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 164.413,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.2419999999806,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.217000000000002,
"layouts": 6,
"layoutDurationMs": 1.1399999999999997,
"taskDurationMs": 393.85200000000003,
"heapDeltaBytes": 3858632,
"heapUsedBytes": 68064728,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.063000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.3159999999116,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.442,
"layouts": 6,
"layoutDurationMs": 0.9970000000000002,
"taskDurationMs": 354.258,
"heapDeltaBytes": 4468660,
"heapUsedBytes": 74309568,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.580000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 681.9469999999797,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.104999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.804,
"heapDeltaBytes": 17790220,
"heapUsedBytes": 87885816,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 173.142,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 732.7050000000099,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.86,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.195,
"heapDeltaBytes": 18084404,
"heapUsedBytes": 88060616,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 160.50199999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2005.8429999999703,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.0689999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.0820000000001,
"heapDeltaBytes": 22226496,
"heapUsedBytes": 87122084,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.38099999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2058.2110000000284,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.166999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.958,
"heapDeltaBytes": -13341480,
"heapUsedBytes": 86619216,
"domNodes": -268,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 34.32599999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2295.024000000012,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.485000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1634.2320000000002,
"heapDeltaBytes": 18594272,
"heapUsedBytes": 84440260,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 813.934,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2249.9139999999898,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.801,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1610.66,
"heapDeltaBytes": 22168720,
"heapUsedBytes": 88326120,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 817.293,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3662.0360000000005,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.495999999999999,
"layouts": 60,
"layoutDurationMs": 12.621000000000002,
"taskDurationMs": 1763.0359999999998,
"heapDeltaBytes": 10356808,
"heapUsedBytes": 76502896,
"domNodes": -279,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 783.442,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3589.845999999966,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.766999999999998,
"layouts": 60,
"layoutDurationMs": 12.373999999999999,
"taskDurationMs": 1687.6390000000004,
"heapDeltaBytes": 8079016,
"heapUsedBytes": 75343268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 776.827,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3201.378000000034,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.496000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2053.653,
"heapDeltaBytes": 24088280,
"heapUsedBytes": 91371128,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1018.2439999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3144.4810000000416,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.913999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1963.492,
"heapDeltaBytes": 22282124,
"heapUsedBytes": 89185464,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 973.1460000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.5690000000277,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.221999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.6360000000001,
"heapDeltaBytes": 22223036,
"heapUsedBytes": 87355112,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 41.34299999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.8970000000154,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.827000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.8660000000001,
"heapDeltaBytes": -14833752,
"heapUsedBytes": 87085076,
"domNodes": -275,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 30.173000000000005,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 663.3499999999799,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.884,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.335,
"heapDeltaBytes": 13815348,
"heapUsedBytes": 79139136,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.75900000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.4180000000288,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.457,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.05400000000003,
"heapDeltaBytes": 14694796,
"heapUsedBytes": 86296700,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 149.64000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2012.408999999991,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.131,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.005,
"heapDeltaBytes": -6680156,
"heapUsedBytes": 65534544,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.551000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.9550000000108,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.012000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.64199999999994,
"heapDeltaBytes": 7003616,
"heapUsedBytes": 72341456,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.514,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.263999999986,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.754,
"layouts": 18,
"layoutDurationMs": 5.061999999999999,
"taskDurationMs": 869.5330000000001,
"heapDeltaBytes": -11839724,
"heapUsedBytes": 60385760,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 114.175,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.5200000000132,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.788000000000004,
"layouts": 18,
"layoutDurationMs": 5.477,
"taskDurationMs": 849.1809999999999,
"heapDeltaBytes": -11583496,
"heapUsedBytes": 60404328,
"domNodes": -301,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 112.19399999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.9830000000202,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.07,
"layouts": 15,
"layoutDurationMs": 15.461999999999996,
"taskDurationMs": 918.4580000000002,
"heapDeltaBytes": 22645736,
"heapUsedBytes": 95651560,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.871999999999996,
"eventListeners": 2381,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9056.673999999986,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.351,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6135.993,
"heapDeltaBytes": -14881188,
"heapUsedBytes": 84982132,
"domNodes": -266,
"jsHeapTotalBytes": -901120,
"scriptDurationMs": 2781.009,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8433.115000000043,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.43599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5823.509000000001,
"heapDeltaBytes": 19529028,
"heapUsedBytes": 84437884,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2752.633,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18302.729,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17553.567000000003,
"heapDeltaBytes": -34578020,
"heapUsedBytes": 175561872,
"domNodes": -6548,
"jsHeapTotalBytes": 1331200,
"scriptDurationMs": 310.869,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17115.950999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16615.660000000003,
"heapDeltaBytes": -27431648,
"heapUsedBytes": 175647964,
"domNodes": -6548,
"jsHeapTotalBytes": 1331200,
"scriptDurationMs": 301.279,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21763.19799999999,
"styleRecalcs": 178,
"styleRecalcDurationMs": 20.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21482.248,
"heapDeltaBytes": -31799188,
"heapUsedBytes": 181540656,
"domNodes": -6557,
"jsHeapTotalBytes": -8740864,
"scriptDurationMs": 1029.495,
"eventListeners": -7467,
"totalBlockingTimeMs": 75,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21444.75299999999,
"styleRecalcs": 173,
"styleRecalcDurationMs": 18.299999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21070.923,
"heapDeltaBytes": -21783904,
"heapUsedBytes": 190479904,
"domNodes": -6548,
"jsHeapTotalBytes": -602112,
"scriptDurationMs": 960.042,
"eventListeners": -7471,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6425.352999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.66000000000001,
"layouts": 20,
"layoutDurationMs": 34.80899999999999,
"taskDurationMs": 6318.496,
"heapDeltaBytes": -39600508,
"heapUsedBytes": 173426728,
"domNodes": -6548,
"jsHeapTotalBytes": 503808,
"scriptDurationMs": 120.96799999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 347,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6396.490000000085,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.83000000000001,
"layouts": 20,
"layoutDurationMs": 35.204999999999984,
"taskDurationMs": 6272.602999999999,
"heapDeltaBytes": -38574308,
"heapUsedBytes": 174537336,
"domNodes": -6548,
"jsHeapTotalBytes": -188416,
"scriptDurationMs": 114.17600000000002,
"eventListeners": -7469,
"totalBlockingTimeMs": 691,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 503.50799999989704,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.161,
"layouts": 4,
"layoutDurationMs": 2.0989999999999998,
"taskDurationMs": 134.816,
"heapDeltaBytes": 5372512,
"heapUsedBytes": 72384828,
"domNodes": 149,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.173,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 106.0059999999794,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.763,
"layouts": 3,
"layoutDurationMs": 1.8599999999999999,
"taskDurationMs": 85.01400000000001,
"heapDeltaBytes": 3106044,
"heapUsedBytes": 70675896,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.602,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe Total Due section in the subscription transition preview now applies ChangesSubscription transition preview
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change makes the divider spacing consistent for immediate billing changes without altering scheduled-change behavior; no actionable merge-blocking risk remains. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 inconclusive)
✅ Passed checks (5 passed)
Full details: Description checkExplanation The description clearly explains the cause, affected plan types, behavior change, and unaffected scheduled changes. It does not use the template headings or explicitly list breaking changes, dependencies, review focus, or screenshots, but the required change context is substantially complete. Full details: End-To-End Regression Coverage For FixesExplanation The PR metadata does not include the PR title or commit subjects. The custom check requires commit subjects or the title to identify bug-fix language, and it requires an inconclusive result when commit subjects are unavailable. The changed-file summary identifies one Full details: Website End-To-End Regression CoverageExplanation The available metadata lists one changed file, Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed-file list contains only
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16530 +/- ##
==========================================
+ Coverage 81.26% 83.26% +2.00%
==========================================
Files 2411 2023 -388
Lines 123653 117317 -6336
Branches 34547 33211 -1336
==========================================
- Hits 100487 97688 -2799
+ Misses 22563 19264 -3299
+ Partials 603 365 -238
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 421 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @comfydesigner.
Found 1 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
| ) | ||
| " | ||
| > | ||
| <div class="mt-10 flex flex-col gap-2 border-t border-border-subtle pt-6"> |
There was a problem hiding this comment.
🟢 Low — Collapsing the cn() call to a static class drops the !isImmediate guard, so mt-10 now also applies on the immediate-change path where it previously did not. Since the preceding block already contributes pt-10 there, immediate previews gain an extra 2.5rem of vertical space, which contradicts the adjacent comment describing the Figma 5344-35724 layout — restore the conditional unless the spacing change is intended. Raised by 3 of 8 reviewers (kimi-k3-max adversarial, kimi-k3-max edge-case, gemini-3.1-pro edge-case).
There was a problem hiding this comment.
Deliberate — the immediate path is where the cramping was reported (the staging screenshot in #proj-billing), so gaining mt-10 there is the fix, not a side effect. A rendered before/after pair is being added to the description per the human review's same request.
dante01yoon
left a comment
There was a problem hiding this comment.
Approving. The reasoning in the description checks out against the code.
Verified:
pt-6only pads below the rule, so with!isImmediate && 'mt-10'an immediate change genuinely had no space above the border. Real bug, not a speculative one.- The yearly-plan masking explanation holds:
refillReplacesNoterenders at line 121, above this block, which is why the gap looked fine on yearly. - Scheduled changes are unaffected — they already resolved to
mt-10, so this is a strict superset and cannot regress that path. cnis still used at line 45, so dropping it here leaves no unused import.
One non-blocking note in the diff.
| ) | ||
| " | ||
| > | ||
| <div class="mt-10 flex flex-col gap-2 border-t border-border-subtle pt-6"> |
There was a problem hiding this comment.
suggestion (non-blocking): This is a purely visual change and the description argues it from the class strings rather than from a rendered result — which is also how the original slipped through review. Could you attach an AS IS / TO BE screenshot of the monthly immediate-change preview? A one-line spacing fix is exactly the kind of change where a screenshot is cheaper than re-deriving the box model, and it would let the next reader confirm the Figma 5344-35724 intent without rebuilding the branch.
Not blocking the merge — the change is a strict superset of the previous behavior for scheduled changes, so the downside risk is bounded.
There was a problem hiding this comment.
Rendered pair captured from the Storybook story (NotCancelled, the immediate path): before, the divider strikes directly under the credits-refill row with Total due cramped beneath; after, the row block gets its mt-10. Alex is attaching both images to the description.
|
Recommend closing this as obsolete. #19100 replaced the embedded checkout markup with |
The total-due divider's top margin was conditional:
A scheduled change got
mt-10; an immediate one got nothing. Sincept-6only pads below the rule, an immediate change put the line flush against the bottom of the credits row with padding on one side only.A yearly plan hides it —
refillReplacesNoterenders between the row and the divider and fills the gap — so it looked correct on yearly and cramped on monthly, which is why it survived review.The margin is now unconditional. Scheduled changes are unaffected; they already had it.