Repository navigation
fix: preserve translation request concurrency on splits - #16525
benceruleanlu wants to merge 6 commits into
Conversation
🎭 Playwright: ✅ 2249 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.36 MB gzip 🟢 -2 BDetailsSummary
Category Glance App Entry Points — 4.44 kB (baseline 4.44 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 154 kB (baseline 154 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 19 unchanged Panels & Settings — 671 kB (baseline 671 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 30 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 13 unchanged UI Components — 201 kB (baseline 201 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 3.07 MB (baseline 3.07 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 22 unchanged Utilities & Hooks — 813 kB (baseline 813 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 50 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.7 MB (baseline 18.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 346 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T22:12:33.326Z",
"gitSha": "3dba09a962f2f8f721d6958761373c5174ad0109",
"branch": "bl/i18n-truncation-concurrency",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.00400000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.275000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.6419999999999,
"heapDeltaBytes": -49681312,
"heapUsedBytes": 59997508,
"domNodes": -212,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.489000000000003,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2041.5419999999358,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.449999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.725,
"heapDeltaBytes": -49297696,
"heapUsedBytes": 61178900,
"domNodes": -212,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.730000000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1705.8319999999867,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.071,
"layouts": 12,
"layoutDurationMs": 4.41,
"taskDurationMs": 694.473,
"heapDeltaBytes": 3903308,
"heapUsedBytes": 68615460,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 157.106,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1811.3749999999982,
"styleRecalcs": 80,
"styleRecalcDurationMs": 17.212999999999997,
"layouts": 12,
"layoutDurationMs": 5.436,
"taskDurationMs": 864.2760000000001,
"heapDeltaBytes": -51575644,
"heapUsedBytes": 58915820,
"domNodes": -212,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 157.95700000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665137614678898,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6330000000262,
"styleRecalcs": 18,
"styleRecalcDurationMs": 10,
"layouts": 3,
"layoutDurationMs": 0.985,
"taskDurationMs": 422.25500000000005,
"heapDeltaBytes": -48814824,
"heapUsedBytes": 61728004,
"domNodes": -167,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 12.618999999999998,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.3430000000662,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.419,
"layouts": 3,
"layoutDurationMs": 0.7899999999999999,
"taskDurationMs": 362.23499999999996,
"heapDeltaBytes": 8641460,
"heapUsedBytes": 72357928,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.609,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 689.6709999999757,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.04,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.988,
"heapDeltaBytes": -35596816,
"heapUsedBytes": 74907396,
"domNodes": -212,
"jsHeapTotalBytes": -2097152,
"scriptDurationMs": 175.738,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414634,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 626.7100000000028,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.8209999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.313,
"heapDeltaBytes": -35234288,
"heapUsedBytes": 74974340,
"domNodes": -212,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 161.32200000000003,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1143.1559999999763,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 772.03,
"heapDeltaBytes": 14171124,
"heapUsedBytes": 93746840,
"domNodes": 0,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 65.758,
"eventListeners": 0,
"totalBlockingTimeMs": 519,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1165.1389999999537,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 774.1530000000001,
"heapDeltaBytes": 12066264,
"heapUsedBytes": 97671272,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 71.39,
"eventListeners": 0,
"totalBlockingTimeMs": 535,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 880.2699999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.0770000000005,
"heapDeltaBytes": -6330660,
"heapUsedBytes": 84942024,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 169.00299999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25.237142857142835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.4060000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.23999999999967,
"heapDeltaBytes": 20539816,
"heapUsedBytes": 107142108,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 167.24,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11226.929999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10247.894,
"heapDeltaBytes": -7163332,
"heapUsedBytes": 76458388,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 8455.54,
"eventListeners": 0,
"totalBlockingTimeMs": 1506,
"frameDurationMs": 32.605232558139534,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9590.399999999932,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.39100000000000074,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8794.149,
"heapDeltaBytes": 9085204,
"heapUsedBytes": 83297348,
"domNodes": -141,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 7173.83,
"eventListeners": -69,
"totalBlockingTimeMs": 689,
"frameDurationMs": 32.05016722408027,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10737.999000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9952.613,
"heapDeltaBytes": 4809252,
"heapUsedBytes": 88073320,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 8268.922,
"eventListeners": 0,
"totalBlockingTimeMs": 1234,
"frameDurationMs": 31.99703264094955,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10723.696000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9900.614999999998,
"heapDeltaBytes": 25077692,
"heapUsedBytes": 99788480,
"domNodes": -141,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 8253.37,
"eventListeners": -69,
"totalBlockingTimeMs": 1199,
"frameDurationMs": 32.18078078078078,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 202.1609999999896,
"styleRecalcs": 23,
"styleRecalcDurationMs": 17.779999999999998,
"layouts": 5,
"layoutDurationMs": 1.9579999999999997,
"taskDurationMs": 151.856,
"heapDeltaBytes": -10658912,
"heapUsedBytes": 75519512,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.489000000000003,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.012499999999932,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 202.79299999992872,
"styleRecalcs": 24,
"styleRecalcDurationMs": 17.096,
"layouts": 5,
"layoutDurationMs": 2.026,
"taskDurationMs": 161.35300000000004,
"heapDeltaBytes": 12227484,
"heapUsedBytes": 76940908,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.884,
"eventListeners": 202,
"totalBlockingTimeMs": 1,
"frameDurationMs": 22.21111111111107,
"p95FrameDurationMs": 66.80000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2039.386000000036,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.8520000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.066,
"heapDeltaBytes": -45155108,
"heapUsedBytes": 88415384,
"domNodes": -308,
"jsHeapTotalBytes": -5079040,
"scriptDurationMs": 36.059999999999995,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.2819999999183,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.7669999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.5029999999999,
"heapDeltaBytes": 727820,
"heapUsedBytes": 84479676,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.175,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2228.7789999999745,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.4190000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1461.7049999999997,
"heapDeltaBytes": -513084,
"heapUsedBytes": 83997400,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 842.757,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2234.4300000000885,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.61,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1416.691,
"heapDeltaBytes": 65844,
"heapUsedBytes": 83939076,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 828.9739999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665413533834588,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3688.5839999999916,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.628,
"layouts": 60,
"layoutDurationMs": 16.345,
"taskDurationMs": 1710.174,
"heapDeltaBytes": -11350792,
"heapUsedBytes": 75077564,
"domNodes": 24,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 789.497,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666063348416287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3746.6210000000046,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.451000000000002,
"layouts": 60,
"layoutDurationMs": 16.706,
"taskDurationMs": 1739.1659999999997,
"heapDeltaBytes": -10955068,
"heapUsedBytes": 74981024,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 800.012,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66577777777778,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3029.7050000000354,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.482,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1911.7250000000001,
"heapDeltaBytes": 22000552,
"heapUsedBytes": 89475236,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 963.1100000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7585635359116,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2931.8849999999657,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.494999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1892.0810000000001,
"heapDeltaBytes": 21967188,
"heapUsedBytes": 89056948,
"domNodes": -308,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 967.2789999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76114285714286,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.986999999991,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.788,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.4619999999999,
"heapDeltaBytes": 25753300,
"heapUsedBytes": 96801324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 40.37699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.230000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.4149999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.997,
"heapDeltaBytes": 25737588,
"heapUsedBytes": 97318500,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.387999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.4829999999865,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.461000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.273,
"heapDeltaBytes": 14233612,
"heapUsedBytes": 80857016,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.431,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.9319999999234,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.628,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.11899999999997,
"heapDeltaBytes": 13787528,
"heapUsedBytes": 71355704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.445,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.7369999999964,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.476000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.90299999999996,
"heapDeltaBytes": 9457660,
"heapUsedBytes": 76195220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.665999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.0489999999718,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.757,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.49300000000005,
"heapDeltaBytes": 9137420,
"heapUsedBytes": 75513864,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.231000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1713.3479999999963,
"styleRecalcs": 56,
"styleRecalcDurationMs": 15.166,
"layouts": 16,
"layoutDurationMs": 5.938000000000001,
"taskDurationMs": 800.585,
"heapDeltaBytes": 25208832,
"heapUsedBytes": 82394368,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 109.50000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.5009999999693,
"styleRecalcs": 61,
"styleRecalcDurationMs": 16.486,
"layouts": 16,
"layoutDurationMs": 6.505000000000001,
"taskDurationMs": 793.1279999999998,
"heapDeltaBytes": 130548,
"heapUsedBytes": 65833452,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.718,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.8110000000133,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.614999999999995,
"layouts": 6,
"layoutDurationMs": 14.495000000000001,
"taskDurationMs": 937.095,
"heapDeltaBytes": 33996404,
"heapUsedBytes": 113565208,
"domNodes": 14650,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 30.052999999999997,
"eventListeners": 2456,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.7169014084507,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8346.603000000016,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.596000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5139.1720000000005,
"heapDeltaBytes": -42437456,
"heapUsedBytes": 91131580,
"domNodes": -308,
"jsHeapTotalBytes": -954368,
"scriptDurationMs": 2729.8419999999996,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.732865731462926,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9535.055000000057,
"styleRecalcs": 248,
"styleRecalcDurationMs": 19.373,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5908.037,
"heapDeltaBytes": 4443724,
"heapUsedBytes": 69574132,
"domNodes": -308,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 2831.2439999999997,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69527145359019,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18822.626000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18253.579,
"heapDeltaBytes": -34491624,
"heapUsedBytes": 184279380,
"domNodes": -3047,
"jsHeapTotalBytes": 5935104,
"scriptDurationMs": 343.29299999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 6,
"frameDurationMs": 33.01035087719298,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 18596.33299999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17902.284,
"heapDeltaBytes": -34850680,
"heapUsedBytes": 185186332,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 271.53799999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.79367521367521,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 16774.850000000013,
"styleRecalcs": 113,
"styleRecalcDurationMs": 10.581000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16311.751999999999,
"heapDeltaBytes": -29189876,
"heapUsedBytes": 189396624,
"domNodes": -3046,
"jsHeapTotalBytes": 5935104,
"scriptDurationMs": 814.306,
"eventListeners": -14913,
"totalBlockingTimeMs": 17,
"frameDurationMs": 30.318083182640148,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22993.75699999996,
"styleRecalcs": 179,
"styleRecalcDurationMs": 16.862000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22657.148,
"heapDeltaBytes": -39148404,
"heapUsedBytes": 191586948,
"domNodes": -3046,
"jsHeapTotalBytes": 8818688,
"scriptDurationMs": 940.071,
"eventListeners": -14913,
"totalBlockingTimeMs": 10,
"frameDurationMs": 43.15009380863039,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6678.566000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.99699999999999,
"layouts": 20,
"layoutDurationMs": 24.344000000000005,
"taskDurationMs": 6574.035999999999,
"heapDeltaBytes": -13887764,
"heapUsedBytes": 215378656,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 112.358,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.31264367816092,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5173.195000000078,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.60300000000001,
"layouts": 20,
"layoutDurationMs": 25.159000000000002,
"taskDurationMs": 5011.521999999999,
"heapDeltaBytes": 1018952,
"heapUsedBytes": 219242188,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 96.859,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.692528735632184,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9525.252000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9154.080999999998,
"heapDeltaBytes": -30494004,
"heapUsedBytes": 184342392,
"domNodes": -3046,
"jsHeapTotalBytes": 8716288,
"scriptDurationMs": 142.05100000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.647260273972606,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9641.64900000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9343.783999999998,
"heapDeltaBytes": -37115752,
"heapUsedBytes": 183706920,
"domNodes": -3046,
"jsHeapTotalBytes": 5382144,
"scriptDurationMs": 201.12800000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 5,
"frameDurationMs": 32.43400673400673,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 122.83700000000408,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.573,
"layouts": 3,
"layoutDurationMs": 1.057,
"taskDurationMs": 86.643,
"heapDeltaBytes": 4322584,
"heapUsedBytes": 67215232,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.032000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 483.36699999993016,
"styleRecalcs": 16,
"styleRecalcDurationMs": 14.581,
"layouts": 3,
"layoutDurationMs": 1.0579999999999996,
"taskDurationMs": 219.95499999999998,
"heapDeltaBytes": -50432632,
"heapUsedBytes": 57719688,
"domNodes": -119,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 10.937,
"eventListeners": -58,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.260714285714293,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 867.8939999999784,
"styleRecalcs": 77,
"styleRecalcDurationMs": 90.71799999999999,
"layouts": 76,
"layoutDurationMs": 25.785,
"taskDurationMs": 844.128,
"heapDeltaBytes": 18241740,
"heapUsedBytes": 90995144,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 350.153,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664150943396223,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 801.1289999999462,
"styleRecalcs": 77,
"styleRecalcDurationMs": 87.714,
"layouts": 76,
"layoutDurationMs": 24.891,
"taskDurationMs": 773.073,
"heapDeltaBytes": 17547536,
"heapUsedBytes": 91951024,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 309.892,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1402.6959999999917,
"styleRecalcs": 77,
"styleRecalcDurationMs": 244.035,
"layouts": 76,
"layoutDurationMs": 28.814,
"taskDurationMs": 1378.8069999999998,
"heapDeltaBytes": 10869564,
"heapUsedBytes": 123956400,
"domNodes": 77,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 482.77299999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.5,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1413.5180000000673,
"styleRecalcs": 77,
"styleRecalcDurationMs": 255.431,
"layouts": 76,
"layoutDurationMs": 29.217,
"taskDurationMs": 1385.836,
"heapDeltaBytes": 10302800,
"heapUsedBytes": 127485500,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 482.005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.93291139240505,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (7 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 559647b5da239413188f226434ff96c96d7fd0fe
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16525 +/- ##
==========================================
+ Coverage 85.70% 86.68% +0.98%
==========================================
Files 3554 2536 -1018
Lines 170386 144044 -26342
Branches 44748 41379 -3369
==========================================
- Hits 146021 124863 -21158
+ Misses 22362 18795 -3567
+ Partials 2003 386 -1617
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
huang47
left a comment
There was a problem hiding this comment.
Nice. We can do Array.fromAsync which might be even simpler
- .github/workflows/i18n-update-website.yaml: restrict dispatch to i18n/-prefixed branches. workflow_dispatch's `branch` input controls which ref's code runs with OPENAI_API_KEY; an unrestricted free-text branch would let a dispatcher point the checkout at modified pipeline code that exfiltrates the key. - manifest.ts: reject arrays wherever a plain record is expected (manifest, entries, and each locale map) — an array previously passed the shape check and could get treated as a locale hash map. - protected-tokens.ts: compare token occurrence counts, not just identity. Deduplicating first meant a translation could drop one of two repeated tags/placeholders and still read as valid. - translate.ts: await recursive truncation-split batches sequentially instead of fanning them out with Promise.allSettled, so they stay within the configured request concurrency instead of compounding at each split depth. Matches the fix already landed for the same pattern in the app's own scripts/i18n/translate.ts (#16525). - update-translations.ts: persist manifestUpdates before the pending.length === 0 early return. Previously, a run that only established baseline hashes (nothing to actually translate) returned without saving them, so the next run would re-bootstrap against whatever the English source had become by then instead of comparing against a stable recorded hash — silently blessing a stale translation as up to date. Extracted runPipeline(argv, paths) so this is covered by an integration test using temp files. - Added tests for the createOpenAiTranslator/createOpenAiReviewer adapter boundary via a mocked fetch (JSON parsing, malformed-response retry, truncation-split, empty-batch short-circuit), not just the injected-batch-function level the existing tests covered.
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Two test nits inline, nothing blocking; the sequential split itself checks out.
| }) | ||
| ).rejects.toThrow('boom') | ||
| expect(started).toEqual([1, 2]) | ||
| expect(inFlightTaskSettled).toBe(true) |
There was a problem hiding this comment.
Severity: Minor
What: The settlement assertion passes under a pool that rejects on the first failure: the fixture's await Promise.resolve() at :349 resumes on the microtask queued before Promise.all's rejection reaction, so inFlightTaskSettled is true either way.
Why this is an issue: The body's second regression (in-flight workers settle before the error propagates) is not pinned; the timer fixture this diff replaced did tell the two pools apart.
Proposed Fix: Settle the in-flight task on a macrotask (await new Promise((resolve) => setTimeout(resolve, 0)) at :349) and keep the assertion, or push 'settled' and 'rejected' into one array from the task and the rejection handler and assert that order.
There was a problem hiding this comment.
Addressed in 2f0de54: the in-flight worker now awaits setImmediate() so it remains pending beyond the microtask that reports an early rejection. A temporary mutation that rethrows immediately from a worker now fails this assertion (false instead of true); the restored pool passes. Both focused i18n test files pass (69 tests).
There was a problem hiding this comment.
Strengthened further in 1580802: the test now holds an explicit deferred promise and drains pending jobs with a zero-time fake-clock advance, replacing the scheduling tick. It verifies that rejection remains pending until the in-flight task settles. The equivalent recursive-split regression covers a 401, an already-running sibling, and a queued request. Mutations that reject the pool or split early fail with rejected observed before release; removing the fatal gate sends 4 requests instead of 3. All 72 focused tests pass on the restored implementation.
| let activeRequests = 0 | ||
| let peakRequests = 0 | ||
| const { translate } = translatorFor(async (body, call) => { | ||
| if (call === 1) return completion('{"1": "Bonj', 'length') |
There was a problem hiding this comment.
Severity: Minor
What: The fan-out test's responder (:636-643) is the third copy of the truncated-then-halves responder already at :604-608 and :719-725.
Why this is an issue: Maintenance only; three responders drift independently when the truncation fixture changes.
Proposed Fix: One truncatedThenHalves(first, second) responder factory in the describe, used by all three, with the fan-out counter wrapped around it.
There was a problem hiding this comment.
I kept these short responders inline under the current test guidance. The three truncation scenarios check child request scoping, live-request concurrency, and per-attempt token accounting; their counters and response metadata remain local to those assertions. A shared factory would hide the response inputs without sharing lifecycle or policy, so I have left this maintenance-only suggestion unchanged.
6845e0d
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Looks good. Before this change, mapWithConcurrency capped only the root batches, and truncation splits fanned out through Promise.allSettled with no limit, so a truncated batch could exceed requestConcurrency. Each file run now owns a Semaphore that is held only around one HTTP request, not across the recursive split. That avoids the deadlock a recursive acquire would cause and still lets splits use free capacity. The sticky run.failure stops queued requests after the first fatal (non-SyntaxError) throw, while in-flight requests settle. That matches the existing mapWithConcurrency semantics.
The scheduling tests pin the behavior that matters: peak live requests equal requestConcurrency for 1/2/4 items, no queued split is sent after a 401, and in-flight work settles before the rejection. I didn't find a correctness problem.
Not run locally: the shared checkout has no node_modules. CI is green and the branch merges cleanly with main (758 commits behind, no conflicts).
Summary
Keep recursive truncation retries within each locale file's configured
requestConcurrencywhile using available capacity. Each file run owns its semaphore and fatal-failure state; the OpenAI client stays reusable across files. Queued requests stop after a fatal error, and active requests settle before rejection.Verification
pnpm test:unit scripts/i18n/translate.test.ts scripts/i18n/update-locales.test.ts scripts/i18n/update-locales.integration.test.ts --maxWorkers=1 --retry=0.11128cd109; all 20 latest workflows and five required checks pass.