Repository navigation
[cjx-10] fix: bracket direct graph imports with load hooks - #16498
Conversation
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1893 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.67 MB gzip 🔴 +143 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • 🔴 +477 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 17 added / 17 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BBundles that do not match a named category
Status: 70 added / 70 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-01T12:49:56.872Z",
"gitSha": "202bd4cf9738d39cb058cb9a063cf49a0fc7edd5",
"branch": "christian-byrne/cjx-10-appts",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2126.435000000015,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.381,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 691.392,
"heapDeltaBytes": -819952,
"heapUsedBytes": 68251788,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 13.398,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2033.8749999999663,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.253000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.412,
"heapDeltaBytes": -12074228,
"heapUsedBytes": 56943876,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.726,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.594999999988,
"styleRecalcs": 74,
"styleRecalcDurationMs": 38.536,
"layouts": 14,
"layoutDurationMs": 4.319999999999999,
"taskDurationMs": 934.431,
"heapDeltaBytes": -8226972,
"heapUsedBytes": 61664116,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 163.25,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1814.483999999993,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.077,
"layouts": 14,
"layoutDurationMs": 4.156,
"taskDurationMs": 869.664,
"heapDeltaBytes": -6834836,
"heapUsedBytes": 62736840,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 160.413,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.2110000000089,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.907999999999998,
"layouts": 6,
"layoutDurationMs": 0.9199999999999998,
"taskDurationMs": 347.528,
"heapDeltaBytes": 4368016,
"heapUsedBytes": 74532524,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.191999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.53599999993,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.279000000000003,
"layouts": 6,
"layoutDurationMs": 1.1620000000000001,
"taskDurationMs": 343.418,
"heapDeltaBytes": 4341040,
"heapUsedBytes": 74240676,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.864,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 665.7570000000419,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.379999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.04,
"heapDeltaBytes": 18451176,
"heapUsedBytes": 88378112,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 166.539,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 668.2960000000548,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.111999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.798,
"heapDeltaBytes": 17849896,
"heapUsedBytes": 87911364,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 166.488,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2030.6140000000141,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.4399999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.9119999999999,
"heapDeltaBytes": -12596760,
"heapUsedBytes": 86492852,
"domNodes": -271,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 29.813999999999993,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 1994.3850000000793,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.7919999999999,
"heapDeltaBytes": 21767880,
"heapUsedBytes": 86895800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.80899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2172.159000000022,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.386000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1564.718,
"heapDeltaBytes": 17318500,
"heapUsedBytes": 83530436,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 773.372,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2147.593000000029,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.7349999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1543.2379999999998,
"heapDeltaBytes": 17344764,
"heapUsedBytes": 83642976,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 790.731,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3561.599000000001,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.834,
"layouts": 60,
"layoutDurationMs": 11.782999999999998,
"taskDurationMs": 1703.922,
"heapDeltaBytes": 10226076,
"heapUsedBytes": 76193456,
"domNodes": -284,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 775.089,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3503.265000000056,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.761,
"layouts": 60,
"layoutDurationMs": 11.814000000000002,
"taskDurationMs": 1662.4819999999997,
"heapDeltaBytes": 7712560,
"heapUsedBytes": 75227612,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 767.014,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3075.976999999966,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1905.7310000000002,
"heapDeltaBytes": 17830548,
"heapUsedBytes": 85470364,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 955.6620000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3114.387000000079,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.3069999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1988.925,
"heapDeltaBytes": 22307464,
"heapUsedBytes": 90063392,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 975.176,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.718999999987,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.867000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.497,
"heapDeltaBytes": -14848444,
"heapUsedBytes": 87044164,
"domNodes": -271,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 30.295,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1999.5740000000524,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8190000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.9159999999999,
"heapDeltaBytes": 22185540,
"heapUsedBytes": 88151536,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.633000000000006,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.7729999999933,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.136999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.80799999999994,
"heapDeltaBytes": 14798232,
"heapUsedBytes": 87008136,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 138.52599999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.380000000001,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.106,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.873,
"heapDeltaBytes": 14066356,
"heapUsedBytes": 85693640,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.975,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.841999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.146999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.84799999999996,
"heapDeltaBytes": -8020660,
"heapUsedBytes": 64298140,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.155999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.7760000000453,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.851,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.374,
"heapDeltaBytes": -9505788,
"heapUsedBytes": 62360876,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 6.699,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.4399999999919,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.912,
"layouts": 18,
"layoutDurationMs": 5.549999999999999,
"taskDurationMs": 816.5029999999999,
"heapDeltaBytes": -10648416,
"heapUsedBytes": 61250944,
"domNodes": -296,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 110.236,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.606000000079,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.525,
"layouts": 18,
"layoutDurationMs": 4.984,
"taskDurationMs": 793.51,
"heapDeltaBytes": -11570212,
"heapUsedBytes": 60398316,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 106.03800000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.5970000000088,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.746000000000002,
"layouts": 15,
"layoutDurationMs": 15.318999999999999,
"taskDurationMs": 916.784,
"heapDeltaBytes": -9182492,
"heapUsedBytes": 86806216,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.064000000000007,
"eventListeners": 2381,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8424.481000000014,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.747,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5759.490000000001,
"heapDeltaBytes": -15201688,
"heapUsedBytes": 84910276,
"domNodes": -269,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 2682.048,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8387.90199999994,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.26800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5678.9580000000005,
"heapDeltaBytes": -15290612,
"heapUsedBytes": 84713948,
"domNodes": -271,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 2640.3289999999997,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16997.66999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16455.33,
"heapDeltaBytes": -35398828,
"heapUsedBytes": 177056640,
"domNodes": -6548,
"jsHeapTotalBytes": -5177344,
"scriptDurationMs": 264.094,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17233.204,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16586.947000000004,
"heapDeltaBytes": -27979740,
"heapUsedBytes": 175386788,
"domNodes": -6548,
"jsHeapTotalBytes": 4190208,
"scriptDurationMs": 269.747,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21314.662999999997,
"styleRecalcs": 175,
"styleRecalcDurationMs": 18.021000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20939.208000000002,
"heapDeltaBytes": -37378184,
"heapUsedBytes": 175803548,
"domNodes": -6548,
"jsHeapTotalBytes": -7884800,
"scriptDurationMs": 915.968,
"eventListeners": -7469,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21182.50400000011,
"styleRecalcs": 173,
"styleRecalcDurationMs": 18.284000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20802.800000000003,
"heapDeltaBytes": -33682536,
"heapUsedBytes": 179707096,
"domNodes": -6548,
"jsHeapTotalBytes": -9457664,
"scriptDurationMs": 971.0249999999999,
"eventListeners": -7467,
"totalBlockingTimeMs": 95,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6151.33400000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.80500000000002,
"layouts": 20,
"layoutDurationMs": 22.791999999999994,
"taskDurationMs": 6052.7210000000005,
"heapDeltaBytes": -33270980,
"heapUsedBytes": 177046096,
"domNodes": -6548,
"jsHeapTotalBytes": 7172096,
"scriptDurationMs": 108.735,
"eventListeners": -7469,
"totalBlockingTimeMs": 420,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6227.930999999899,
"styleRecalcs": 20,
"styleRecalcDurationMs": 98.82599999999996,
"layouts": 20,
"layoutDurationMs": 38.911,
"taskDurationMs": 6100.8589999999995,
"heapDeltaBytes": -40442168,
"heapUsedBytes": 173049636,
"domNodes": -6548,
"jsHeapTotalBytes": 598016,
"scriptDurationMs": 132.95800000000003,
"eventListeners": -7469,
"totalBlockingTimeMs": 380,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 109.78999999997541,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.777000000000001,
"layouts": 2,
"layoutDurationMs": 1.146,
"taskDurationMs": 78.46700000000001,
"heapDeltaBytes": 3150504,
"heapUsedBytes": 71535932,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.207000000000002,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 97.84700000000157,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.041000000000002,
"layouts": 2,
"layoutDurationMs": 0.6739999999999999,
"taskDurationMs": 65.56300000000002,
"heapDeltaBytes": 3149112,
"heapUsedBytes": 70240452,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.685,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16498 +/- ##
==========================================
- Coverage 82.25% 82.24% -0.01%
==========================================
Files 2017 2018 +1
Lines 116536 116548 +12
Branches 31039 29238 -1801
==========================================
+ Hits 95856 95860 +4
- Misses 20505 20513 +8
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Architect lens at exact head 4987eacd8ba45fa2f7327b432770d5e12ac25210; the verified authority finding is inline.
| ): Promise<void> { | ||
| // false: no workflow load follows to republish the hash. | ||
| useWorkflowService().beforeLoadNewGraph(false) | ||
| await useExtensionService().invokeExtensionsAsync('beforeLoadGraph') |
There was a problem hiding this comment.
issue: would it be safer to make this lifecycle bracket reentrant, or serialize or cancel graph loads, before exposing it here? Two overlapping loadApiJson calls both reach beforeLoadGraph, but mintPortWiring.onBeforeGraphLoad ignores a nested opener and the first afterConfigureGraph closes suppression for both. If import A pauses in nodeReplacementStore.load(), import B opens, and A then reaches the close, B's later rootGraph.add/connect/widget mutations can be minted as user ops into the bound doc while both imports interleave on the same graph.
christian-byrne
left a comment
There was a problem hiding this comment.
Review — 3 takeaways
- Bracketing is balanced: all
importA1111failure outcomes return before the pre-clear hook fires — verified against head. - F1 (minor): the intentional
afterConfigureGraph-without-beforeConfigureGraphasymmetry lives only in the PR description; add a code comment at both invocation sites so nobody "fixes" it later. - Tests are genuine: the pnginfo held-promise test actually pins the await-before-clear ordering.
Full context for agent readers
Scope reviewed
Head 4987eac vs origin/main — 4 files, +93/−13. Ran pnpm exec vitest run src/scripts/app.test.ts src/scripts/pnginfo.test.ts on head in a clean worktree: 98 passed, 1 skipped.
Findings
F1 — Minor (actionable): undocumented intentional hook asymmetry. Both new paths fire afterConfigureGraph without a preceding beforeConfigureGraph (app.ts:2139-2142 A1111, app.ts:2427-2430 API JSON). The rationale (A1111 has no mutable workflow JSON before graph construction; API JSON likewise skips the configure-input stage) exists only in the PR description. A future reader comparing against loadGraphData (which fires all four hooks, app.ts:1272/1534) will see the asymmetry as a bug and may add a synthetic beforeConfigureGraph with a fabricated payload. One-line comment at each site fixes this.
F2 — Note (left as-is): thrown import after pre-clear hook leaves hooks unbalanced. If importA1111 throws after beforeGraphClear ran (e.g. node construction), beforeLoadGraph fires with no afterLoadGraph. This exposure shape predates the PR (beforeLoadNewGraph had the same window) and matches loadGraphData's behavior on mid-load throw. Out of scope.
F3 — Positive: failure-path balance verified, not assumed. 'not-a1111' returns at pnginfo.ts:217/591 and 'core-nodes-unavailable' at :257, all before beforeGraphClear at :365 — so a failed import never fires beforeLoadGraph and the early returns in the app.ts outcome switch never fire the after-hooks. The new pnginfo test holds the pre-clear promise open and asserts graph.clear() hasn't run — a real race pin, not a smoke test.
Cross-checks done
groupNode.tsafterConfigureGraphconsumesgroupNodeReportIndicespopulated inbeforeConfigureGraph: safe on both new paths (A1111 passes[]; API JSON placeholder entries were never registered, so lookups miss and continue).agentPanel.tsafterConfigureGraph(mint-port notify) now correctly fires on direct imports — that's the point of the PR.- Hook ordering matches
loadGraphData:beforeLoadNewGraph → beforeLoadGraph → … → afterConfigureGraph → afterLoadNewGraph → afterLoadGraph; missing-node display happens afterafterConfigureGraphin both paths, so extensions can amend reports before display. loadApiJsonhas exactly one caller (handleFile,app.ts:2089) — no double-bracketing risk.
Hook flow after this PR
workflow JSON API JSON A1111
─────────────── ─────────────── ───────────────
beforeLoadNewGraph beforeLoadNewGraph beforeLoadNewGraph ┐
beforeLoadGraph beforeLoadGraph beforeLoadGraph ├ pre-clear cb
beforeConfigureGraph (skipped) (skipped) ┘ (awaited)
…configure/build… …build nodes… …build nodes…
afterConfigureGraph afterConfigureGraph afterConfigureGraph
(missing list) (missing list) ([])
afterLoadNewGraph afterLoadNewGraph afterLoadNewGraph
afterLoadGraph afterLoadGraph afterLoadGraph
Glossary
- A1111: Automatic1111 — imports generation parameters embedded in PNG metadata as a graph.
- API JSON: the flattened prompt format (
class_type+inputsper node) exported for API execution. - pre-clear hook (
beforeGraphClear): callbackimportA1111awaits immediately beforegraph.clear(). - F1..F3: findings in this review.
Review follow-up: both direct-import paths fire afterConfigureGraph without beforeConfigureGraph by design (no mutable workflow JSON goes through the configure stage). Document at the invocation sites so the asymmetry is not mistaken for a bug.
|
Bracket placement and the awaited pre-clear both read correct. One note inline about what the direct-import paths expose to extensions.
|
|
Bracket placement and the awaited pre-clear both read correct. One note below about what the direct-import paths expose to extensions. Severity: Note What: The A1111 and API JSON import paths emit Why this is an issue: In-repo the asymmetry is deliberate, documented, and harmless: Proposed Fix: State in the extension-facing docs that direct imports emit a partial hook set, so extension authors do not assume pairing. Alternatively emit |
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Approving - bracket placement and the awaited pre-clear are correct; the extension-docs note is non-blocking.
|
Follow-up already exists and covers the outstanding review item: #16507 (fix(agent): keep mint suppression active through overlapping graph loads) directly resolves the unresolved overlapping- |
|
awc-audit follow-up check for @CodeJuggernaut's approve-with-comments review: the sole item (F1 — document the intentional |
## Summary Bracket direct API JSON and A1111 graph imports with the established extension load lifecycle so graph-sensitive extensions receive the same boundaries as workflow JSON loads. ## Changes - **What**: Invoke `beforeLoadGraph`, `afterConfigureGraph`, and `afterLoadGraph` around successful direct imports; await the A1111 pre-clear callback before graph mutation. - **Breaking**: None. - **Dependencies**: None. - **Triage receipt**: Covers [`src/scripts/app.test.ts` and `src/scripts/app.ts` KEEP rows](https://github.com/christian-byrne/in-app-agent-program/blob/main/program/cj16448-triage.md#L71-L72). Directly coupled `pnginfo.ts` and its test carry the awaited callback contract. ## Review Focus - API JSON reports its collected missing-node list to `afterConfigureGraph`. - A1111 has no mutable workflow JSON before graph construction, so it emits no synthetic `beforeConfigureGraph` payload. - Selection-mode guards from the frozen branch are intentionally excluded. ## Verification - `pnpm test:unit src/scripts/app.test.ts src/scripts/pnginfo.test.ts` (98 passed, 1 skipped) - `pnpm typecheck` - `pnpm lint` (passes with existing warnings) - `pnpm knip` <!-- authored-by:agent -->
Summary
Bracket direct API JSON and A1111 graph imports with the established extension load lifecycle so graph-sensitive extensions receive the same boundaries as workflow JSON loads.
Changes
beforeLoadGraph,afterConfigureGraph, andafterLoadGrapharound successful direct imports; await the A1111 pre-clear callback before graph mutation.src/scripts/app.test.tsandsrc/scripts/app.tsKEEP rows. Directly coupledpnginfo.tsand its test carry the awaited callback contract.Review Focus
afterConfigureGraph.beforeConfigureGraphpayload.Verification
pnpm test:unit src/scripts/app.test.ts src/scripts/pnginfo.test.ts(98 passed, 1 skipped)pnpm typecheckpnpm lint(passes with existing warnings)pnpm knip