Skip to content

fix: harden asset parsing and import hooks - #16494

Open
christian-byrne wants to merge 3 commits into
Comfy-Org:mainfrom
christian-byrne:christian-byrne/op4-w3pub6
Open

christian-byrne wants to merge 3 commits into
Comfy-Org:mainfrom
christian-byrne:christian-byrne/op4-w3pub6

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Ports the disjoint asset parsing, thumbnail persistence, and async A1111 import hardening from the audited salvage ref onto current main.

Changes

  • What: Keeps valid drag-result fields when optional attachment metadata is malformed, with permanent parser coverage.
  • What: Preserves thumbnail data-URL failure coverage and awaits asynchronous pre-clear hooks before graph mutation.

Review Focus

Please check the fail-soft optional-field parsing boundary and the ordering guarantee around beforeGraphClear. The source was deduplicated against current main and open PRs #16385, #16430, and #16492; dialog-token and select-only workflow hunks were intentionally excluded.

Tests could not be executed on amp-worker-pk0z because /data had 11 MiB free and this fresh sparse checkout has no dependencies. git diff --check passes; exact-head CI is the execution gate.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 514c6bff-9aaf-4a62-abf2-3d5ba7d57442

📥 Commits

Reviewing files that changed from the base of the PR and between 5882b01 and c091e98.

📒 Files selected for processing (4)
  • src/platform/assets/schemas/mediaAssetSchema.test.ts
  • src/platform/assets/schemas/mediaAssetSchema.ts
  • src/scripts/pnginfo.test.ts
  • src/scripts/pnginfo.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Asset metadata parsing now tolerates malformed optional fields. A1111 graph import now awaits an optional asynchronous callback before clearing and rebuilding the graph. Tests cover both behaviors.

Changes

Asset parsing and graph import synchronization

Layer / File(s) Summary
Tolerant asset metadata parsing
src/platform/assets/schemas/mediaAssetSchema.ts, src/platform/assets/schemas/mediaAssetSchema.test.ts
Optional attachment, media-kind, and preview URL fields fall back to undefined when malformed. Tests cover enriched payloads, invalid base fields, and invalid JSON.
Asynchronous graph-clear coordination
src/scripts/pnginfo.ts, src/scripts/pnginfo.test.ts
importA1111 accepts an asynchronous beforeGraphClear callback and awaits it before clearing the graph. Tests verify ordering and a single graph clear.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: benceruleanlu, austinmroz, drjkl

Merge Risk: ⚪ Minimal · up to c091e

This change preserves valid asset fields when optional metadata is malformed and waits for asynchronous cleanup before replacing an imported graph. Coverage and passing CI indicate no remaining merge-blocking risk.


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The available metadata lists changes under src/ and no changes under browser_tests/. The PR description explains that tests could not run because of low disk space and missing dependencies, but it… Provide the PR title and commit subjects. Then verify whether either contains the specified bug-fix language; if so, require either a Playwright regression test under browser_tests/ or a concrete explanation for why such a test is not pra…
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Website End-To-End Regression Coverage ✅ Passed No changed file is under apps/website/src/ or apps/website/public/. The PR changes src/platform/assets/schemas/* and src/scripts/pnginfo*, so this website-specific check does not apply.
Adr Compliance For Entity/Litegraph Changes ✅ Passed PASS. The changed files do not include src/lib/litegraph/ or src/ecs/. The only potentially graph-related change is src/scripts/pnginfo.ts, which only adds an awaited beforeGraphClear callback…
Title check ✅ Passed The title clearly and concisely identifies the two main changes: hardened asset parsing and import hooks.
Description check ✅ Passed The description includes the required Summary, Changes, and Review Focus sections. It explains the functional changes, review risks, excluded scope, and test limitations. Breaking changes, dependencie…
Full details: End-To-End Regression Coverage For Fixes

Explanation

The available metadata lists changes under src/ and no changes under browser_tests/. The PR description explains that tests could not run because of low disk space and missing dependencies, but it does not clearly explain why an end-to-end regression test was not added. However, the PR title and commit subjects are not available in the review context, so the required bug-fix signal cannot be verified without guessing.

Resolution

Provide the PR title and commit subjects. Then verify whether either contains the specified bug-fix language; if so, require either a Playwright regression test under browser_tests/ or a concrete explanation for why such a test is not practical.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: 🚧 Building...

🎭 Playwright: ✅ 1916 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1895 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 9.68 MB gzip 🔴 +145 B

Details

Summary

  • Raw size: 41 MB baseline 41 MB — 🔴 +33 B
  • Gzip: 9.68 MB baseline 9.68 MB — 🔴 +145 B
  • Brotli: 6.81 MB baseline 6.81 MB — 🟢 -236 B
  • Bundles: 448 current • 448 baseline • 149 added / 149 removed

Category Glance
Data & Services 🔴 +33 B (3.59 MB) · Vendor & Third-Party ⚪ 0 B (18.1 MB) · Other ⚪ 0 B (16.4 MB) · Graph Workspace ⚪ 0 B (1.42 MB) · Panels & Settings ⚪ 0 B (621 kB) · Utilities & Hooks ⚪ 0 B (560 kB) · + 5 more

App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-bF2T30PL.js (removed) 3.74 kB — 🟢 -3.74 kB 🟢 -1.88 kB 🟢 -1.63 kB
assets/index-wWrpWYt9.js (new) — 3.74 kB 🔴 +3.74 kB 🔴 +1.88 kB 🔴 +1.62 kB

Status: 1 added / 1 removed

Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-B8Xm2sIB.js (new) — 1.41 MB 🔴 +1.41 MB 🔴 +309 kB 🔴 +232 kB
assets/GraphView-D6UJt-qQ.js (removed) 1.41 MB — 🟢 -1.41 MB 🟢 -309 kB 🟢 -231 kB
assets/WidgetCompositor-aVs0gc0r.js (removed) 8.5 kB — 🟢 -8.5 kB 🟢 -2.8 kB 🟢 -2.48 kB
assets/WidgetCompositor-CMWuxdMd.js (new) — 8.5 kB 🔴 +8.5 kB 🔴 +2.8 kB 🔴 +2.48 kB

Status: 2 added / 2 removed / 1 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-BIN1oJT9.js (new) — 25 kB 🔴 +25 kB 🔴 +6.25 kB 🔴 +5.53 kB
assets/CloudSurveyView-DKOCfLrB.js (removed) 25 kB — 🟢 -25 kB 🟢 -6.24 kB 🟢 -5.52 kB
assets/CloudLayoutView-DTB0AV7N.js (new) — 21.8 kB 🔴 +21.8 kB 🔴 +6.57 kB 🔴 +5.73 kB
assets/CloudLayoutView-qL7r7peK.js (removed) 21.8 kB — 🟢 -21.8 kB 🟢 -6.57 kB 🟢 -5.74 kB
assets/CloudLoginView-BVbQdOun.js (removed) 8.74 kB — 🟢 -8.74 kB 🟢 -2.56 kB 🟢 -2.26 kB
assets/CloudLoginView-L241WZml.js (new) — 8.74 kB 🔴 +8.74 kB 🔴 +2.56 kB 🔴 +2.26 kB
assets/UserCheckView-Dg-HxeKb.js (removed) 8.51 kB — 🟢 -8.51 kB 🟢 -2.14 kB 🟢 -1.85 kB
assets/UserCheckView-g261fRdR.js (new) — 8.51 kB 🔴 +8.51 kB 🔴 +2.14 kB 🔴 +1.85 kB
assets/useCloudAuthPage-BxzADkAX.js (removed) 7.08 kB — 🟢 -7.08 kB 🟢 -2.52 kB 🟢 -2.2 kB
assets/useCloudAuthPage-MJTnscdY.js (new) — 7.08 kB 🔴 +7.08 kB 🔴 +2.52 kB 🔴 +2.21 kB
assets/CloudSignupView-EmVkntg_.js (removed) 6.96 kB — 🟢 -6.96 kB 🟢 -2.28 kB 🟢 -1.99 kB
assets/CloudSignupView-jNxHyimD.js (new) — 6.96 kB 🔴 +6.96 kB 🔴 +2.28 kB 🔴 +1.99 kB
assets/WidgetTextPreview-BPTs6R7R.js (removed) 6.07 kB — 🟢 -6.07 kB 🟢 -2.14 kB 🟢 -1.89 kB
assets/WidgetTextPreview-mX8jQNgv.js (new) — 6.07 kB 🔴 +6.07 kB 🔴 +2.14 kB 🔴 +1.89 kB
assets/CloudSubscriptionRedirectView-Ck-uW3NF.js (removed) 5.69 kB — 🟢 -5.69 kB 🟢 -1.94 kB 🟢 -1.69 kB
assets/CloudSubscriptionRedirectView-IdWtVVbm.js (new) — 5.69 kB 🔴 +5.69 kB 🔴 +1.94 kB 🔴 +1.69 kB
assets/UserSelectView-m4p5B-C1.js (new) — 5.56 kB 🔴 +5.56 kB 🔴 +1.97 kB 🔴 +1.73 kB
assets/UserSelectView-SLDNZmfK.js (removed) 5.56 kB — 🟢 -5.56 kB 🟢 -1.97 kB 🟢 -1.73 kB
assets/CloudForgotPasswordView-BreY8EKf.js (new) — 4.97 kB 🔴 +4.97 kB 🔴 +1.73 kB 🔴 +1.49 kB
assets/CloudForgotPasswordView-DvewEr_C.js (removed) 4.97 kB — 🟢 -4.97 kB 🟢 -1.73 kB 🟢 -1.49 kB
assets/CloudAuthTimeoutView-B702emDz.js (new) — 4.43 kB 🔴 +4.43 kB 🔴 +1.54 kB 🔴 +1.33 kB
assets/CloudAuthTimeoutView-Cxdx3JPA.js (removed) 4.43 kB — 🟢 -4.43 kB 🟢 -1.54 kB 🟢 -1.34 kB
assets/OAuthLayoutView-DiIE5lo8.js (removed) 1.32 kB — 🟢 -1.32 kB 🟢 -707 B 🟢 -606 B
assets/OAuthLayoutView-yTBRiEP8.js (new) — 1.32 kB 🔴 +1.32 kB 🔴 +709 B 🔴 +597 B
assets/WidgetTextPreview-C_J4Cpbi.js (removed) 131 B — 🟢 -131 B 🟢 -100 B 🟢 -87 B
assets/WidgetTextPreview-DilGHwzy.js (new) — 131 B 🔴 +131 B 🔴 +100 B 🔴 +89 B

Status: 13 added / 13 removed / 4 unchanged

Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-BGplpd3l.js (removed) 49.4 kB — 🟢 -49.4 kB 🟢 -9.95 kB 🟢 -8.83 kB
assets/KeybindingPanel-Ja8TU5Ub.js (new) — 49.4 kB 🔴 +49.4 kB 🔴 +9.95 kB 🔴 +8.8 kB
assets/CreditsPanel-CTMpM1MQ.js (new) — 37.4 kB 🔴 +37.4 kB 🔴 +9.04 kB 🔴 +7.94 kB
assets/CreditsPanel-Dt71H8bs.js (removed) 37.4 kB — 🟢 -37.4 kB 🟢 -9.04 kB 🟢 -7.92 kB
assets/SecretsPanel-1rAzofiB.js (new) — 33.7 kB 🔴 +33.7 kB 🔴 +7.88 kB 🔴 +6.89 kB
assets/SecretsPanel-BP4mfEsJ.js (removed) 33.7 kB — 🟢 -33.7 kB 🟢 -7.87 kB 🟢 -6.9 kB
assets/AboutPanel-CdulMlw7.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.11 kB 🟢 -2.78 kB
assets/AboutPanel-CX010PJZ.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.11 kB 🔴 +2.78 kB
assets/ExtensionPanel-BailO3gi.js (removed) 9.19 kB — 🟢 -9.19 kB 🟢 -2.51 kB 🟢 -2.23 kB
assets/ExtensionPanel-iRXsCZrn.js (new) — 9.19 kB 🔴 +9.19 kB 🔴 +2.52 kB 🔴 +2.23 kB
assets/ServerConfigPanel-Cn8bATgj.js (new) — 6.09 kB 🔴 +6.09 kB 🔴 +1.95 kB 🔴 +1.73 kB
assets/ServerConfigPanel-CRbQFd3R.js (removed) 6.09 kB — 🟢 -6.09 kB 🟢 -1.95 kB 🟢 -1.73 kB
assets/UserPanel-D8MphloS.js (new) — 5.73 kB 🔴 +5.73 kB 🔴 +1.79 kB 🔴 +1.55 kB
assets/UserPanel-Di9_32Sy.js (removed) 5.73 kB — 🟢 -5.73 kB 🟢 -1.79 kB 🟢 -1.55 kB
assets/refreshRemoteConfig-0T-KQwmK.js (removed) 4.51 kB — 🟢 -4.51 kB 🟢 -1.59 kB 🟢 -1.41 kB
assets/refreshRemoteConfig-BCE3vKNk.js (new) — 4.51 kB 🔴 +4.51 kB 🔴 +1.59 kB 🔴 +1.41 kB
assets/CreditsPanel-BaUrPxLW.js (new) — 116 B 🔴 +116 B 🔴 +95 B 🔴 +88 B
assets/CreditsPanel-CUOtaDNN.js (removed) 116 B — 🟢 -116 B 🟢 -95 B 🟢 -85 B
assets/refreshRemoteConfig-Byak0C29.js (removed) 110 B — 🟢 -110 B 🟢 -89 B 🟢 -94 B
assets/refreshRemoteConfig-xrKuDstR.js (new) — 110 B 🔴 +110 B 🔴 +89 B 🔴 +86 B

Status: 10 added / 10 removed / 17 unchanged

User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SignUpForm-aMdBRmMG.js (removed) 13.3 kB — 🟢 -13.3 kB 🟢 -4.53 kB 🟢 -3.93 kB
assets/SignUpForm-c-HO2FyB.js (new) — 13.3 kB 🔴 +13.3 kB 🔴 +4.53 kB 🔴 +3.93 kB
assets/auth-DDYA_x3R.js (new) — 3.48 kB 🔴 +3.48 kB 🔴 +1.21 kB 🔴 +1.01 kB
assets/auth-wZxoR0KQ.js (removed) 3.48 kB — 🟢 -3.48 kB 🟢 -1.2 kB 🟢 -1.01 kB
assets/UpdatePasswordContent-B4d0DOMq.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -843 B 🟢 -735 B
assets/UpdatePasswordContent-DsoBUWIk.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +843 B 🔴 +736 B
assets/authStore-Cler16xz.js (removed) 126 B — 🟢 -126 B 🟢 -103 B 🟢 -105 B
assets/authStore-DrLIKW8x.js (new) — 126 B 🔴 +126 B 🔴 +103 B 🔴 +116 B
assets/workspaceAuthStore-C7r-JrF5.js (removed) 108 B — 🟢 -108 B 🟢 -99 B 🟢 -111 B
assets/workspaceAuthStore-CdOAL32j.js (new) — 108 B 🔴 +108 B 🔴 +99 B 🔴 +109 B
assets/auth-BzqSULni.js (new) — 105 B 🔴 +105 B 🔴 +96 B 🔴 +85 B
assets/auth-C-B3jXWf.js (removed) 105 B — 🟢 -105 B 🟢 -96 B 🟢 -83 B

Status: 6 added / 6 removed / 5 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-CPf-yhHw.js (removed) 90.1 kB — 🟢 -90.1 kB 🟢 -19.3 kB 🟢 -16.5 kB
assets/ComfyHubPublishDialog-p3-G_IHY.js (new) — 90.1 kB 🔴 +90.1 kB 🔴 +19.3 kB 🔴 +16.5 kB
assets/useShareDialog-D1dnA9jm.js (removed) 23.9 kB — 🟢 -23.9 kB 🟢 -5.74 kB 🟢 -5.08 kB
assets/useShareDialog-DotagPXf.js (new) — 23.9 kB 🔴 +23.9 kB 🔴 +5.74 kB 🔴 +5.08 kB
assets/feedbackDialog-BSOOBvpu.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.87 kB 🔴 +1.59 kB
assets/feedbackDialog-CERmdNIC.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.86 kB 🟢 -1.58 kB
assets/useRangeEditor-B-Ep_87d.js (new) — 3.29 kB 🔴 +3.29 kB 🔴 +1.14 kB 🔴 +1.03 kB
assets/useRangeEditor-rtcdRMBd.js (removed) 3.29 kB — 🟢 -3.29 kB 🟢 -1.14 kB 🟢 -1.03 kB
assets/useLayerEditor-DBi5BRL5.js (removed) 1.19 kB — 🟢 -1.19 kB 🟢 -560 B 🟢 -513 B
assets/useLayerEditor-EP4gqGVA.js (new) — 1.19 kB 🔴 +1.19 kB 🔴 +560 B 🔴 +507 B
assets/ComfyHubPublishDialog-BHQNLVp1.js (removed) 143 B — 🟢 -143 B 🟢 -105 B 🟢 -92 B
assets/ComfyHubPublishDialog-DoT1CywX.js (new) — 143 B 🔴 +143 B 🔴 +105 B 🔴 +89 B
assets/useSubscriptionDialog-CFl0Hj_u.js (new) — 107 B 🔴 +107 B 🔴 +101 B 🔴 +99 B
assets/useSubscriptionDialog-DLo7YvMG.js (removed) 107 B — 🟢 -107 B 🟢 -101 B 🟢 -101 B

Status: 7 added / 7 removed / 1 unchanged

UI Components — 117 kB (baseline 117 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useMoreOptionsMenu-DpfsUBMW.js (new) — 48 kB 🔴 +48 kB 🔴 +11.6 kB 🔴 +9.99 kB
assets/useMoreOptionsMenu-wTWkN4N7.js (removed) 48 kB — 🟢 -48 kB 🟢 -11.6 kB 🟢 -9.99 kB
assets/ComfyQueueButton-CVE4JIAH.js (removed) 14.6 kB — 🟢 -14.6 kB 🟢 -3.98 kB 🟢 -3.53 kB
assets/ComfyQueueButton-ZILoH98Z.js (new) — 14.6 kB 🔴 +14.6 kB 🔴 +3.98 kB 🔴 +3.53 kB
assets/useTerminalTabs-C9BByLKc.js (new) — 11.8 kB 🔴 +11.8 kB 🔴 +3.69 kB 🔴 +3.29 kB
assets/useTerminalTabs-jziGBW94.js (removed) 11.8 kB — 🟢 -11.8 kB 🟢 -3.69 kB 🟢 -3.27 kB
assets/InviteMembersForm-BXIEv6pA.js (new) — 10.2 kB 🔴 +10.2 kB 🔴 +3.1 kB 🔴 +2.78 kB
assets/InviteMembersForm-qfnALs8K.js (removed) 10.2 kB — 🟢 -10.2 kB 🟢 -3.1 kB 🟢 -2.77 kB
assets/SubscribeButton-25UpRDDm.js (removed) 2.15 kB — 🟢 -2.15 kB 🟢 -969 B 🟢 -849 B
assets/SubscribeButton-C0O3iSJZ.js (new) — 2.15 kB 🔴 +2.15 kB 🔴 +969 B 🔴 +848 B
assets/cloudFeedbackTopbarButton-1f_aRekP.js (new) — 701 B 🔴 +701 B 🔴 +420 B 🔴 +383 B
assets/cloudFeedbackTopbarButton-BBXltEQs.js (removed) 701 B — 🟢 -701 B 🟢 -421 B 🟢 -365 B
assets/ComfyQueueButton-BH5_wwc9.js (new) — 128 B 🔴 +128 B 🔴 +99 B 🔴 +90 B
assets/ComfyQueueButton-DP8ngsZ8.js (removed) 128 B — 🟢 -128 B 🟢 -99 B 🟢 -91 B

Status: 7 added / 7 removed / 8 unchanged

Data & Services — 3.59 MB (baseline 3.59 MB) • 🔴 +33 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/settingStore-CkSJDHlY.js (new) — 3.27 MB 🔴 +3.27 MB 🔴 +770 kB 🔴 +581 kB
assets/settingStore-MNhMNiGR.js (removed) 3.27 MB — 🟢 -3.27 MB 🟢 -770 kB 🟢 -581 kB
assets/api-BcR_759O.js (new) — 169 kB 🔴 +169 kB 🔴 +38.5 kB 🔴 +32.5 kB
assets/api-Cix_OohC.js (removed) 169 kB — 🟢 -169 kB 🟢 -38.5 kB 🟢 -32.5 kB
assets/load3dService-BF71LHrb.js (new) — 86.9 kB 🔴 +86.9 kB 🔴 +20.3 kB 🔴 +17.6 kB
assets/load3dService-vjZjgkBB.js (removed) 86.9 kB — 🟢 -86.9 kB 🟢 -20.3 kB 🟢 -17.6 kB
assets/releaseStore-BhymDjws.js (removed) 23.8 kB — 🟢 -23.8 kB 🟢 -7.07 kB 🟢 -6.22 kB
assets/releaseStore-Dsn2KdDm.js (new) — 23.8 kB 🔴 +23.8 kB 🔴 +7.07 kB 🔴 +6.22 kB
assets/workflowShareService-C2Lj5I66.js (new) — 16.5 kB 🔴 +16.5 kB 🔴 +4.91 kB 🔴 +4.35 kB
assets/workflowShareService-Cdc-aMQn.js (removed) 16.5 kB — 🟢 -16.5 kB 🟢 -4.91 kB 🟢 -4.34 kB
assets/keybindingService-DhpwX2e3.js (removed) 6.95 kB — 🟢 -6.95 kB 🟢 -1.75 kB 🟢 -1.51 kB
assets/keybindingService-tle3OPz5.js (new) — 6.95 kB 🔴 +6.95 kB 🔴 +1.75 kB 🔴 +1.51 kB
assets/userStore-BCAq1XYg.js (removed) 2.38 kB — 🟢 -2.38 kB 🟢 -898 B 🟢 -792 B
assets/userStore-BTMZIbaV.js (new) — 2.38 kB 🔴 +2.38 kB 🔴 +902 B 🔴 +792 B
assets/audioService-BH-zQCr5.js (removed) 1.71 kB — 🟢 -1.71 kB 🟢 -828 B 🟢 -727 B
assets/audioService-D8E5cGMQ.js (new) — 1.71 kB 🔴 +1.71 kB 🔴 +831 B 🔴 +734 B
assets/dialogService-BJYdbbmy.js (removed) 97 B — 🟢 -97 B 🟢 -96 B 🟢 -94 B
assets/dialogService-CYlMCvEF.js (new) — 97 B 🔴 +97 B 🔴 +96 B 🔴 +98 B
assets/releaseStore-BCTZ7GN9.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -85 B
assets/releaseStore-DHSPXm5_.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +83 B
assets/settingStore-DJCmLzl2.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -84 B
assets/settingStore-DNZzTfSj.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +82 B
assets/assetsStore-BOjAmq2k.js (new) — 94 B 🔴 +94 B 🔴 +92 B 🔴 +84 B
assets/assetsStore-CkgutjUH.js (removed) 94 B — 🟢 -94 B 🟢 -92 B 🟢 -85 B
assets/api-BlR9kITt.js (removed) 62 B — 🟢 -62 B 🟢 -74 B 🟢 -66 B
assets/api-DKY97HLR.js (new) — 62 B 🔴 +62 B 🔴 +74 B 🔴 +66 B

Status: 13 added / 13 removed / 3 unchanged

Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-GJsXoCtj.js (removed) 237 kB — 🟢 -237 kB 🟢 -53.1 kB 🟢 -43.2 kB
assets/useConflictDetection-kvtR8hQ4.js (new) — 237 kB 🔴 +237 kB 🔴 +53.1 kB 🔴 +43.3 kB
assets/useLayerEditorSession-DJlCfI4j.js (removed) 159 kB — 🟢 -159 kB 🟢 -40.9 kB 🟢 -34.4 kB
assets/useLayerEditorSession-eovIz4-j.js (new) — 159 kB 🔴 +159 kB 🔴 +40.9 kB 🔴 +34.4 kB
assets/useLoad3d-14AwCAti.js (removed) 26.1 kB — 🟢 -26.1 kB 🟢 -5.9 kB 🟢 -5.22 kB
assets/useLoad3d-DN2GTtBk.js (new) — 26.1 kB 🔴 +26.1 kB 🔴 +5.9 kB 🔴 +5.22 kB
assets/useLoad3dViewer-DPLld3kb.js (removed) 21.9 kB — 🟢 -21.9 kB 🟢 -5.27 kB 🟢 -4.59 kB
assets/useLoad3dViewer-pW3udKCS.js (new) — 21.9 kB 🔴 +21.9 kB 🔴 +5.27 kB 🔴 +4.6 kB
assets/useImageCrop-B13P5H2E.js (removed) 14.9 kB — 🟢 -14.9 kB 🟢 -3.42 kB 🟢 -2.99 kB
assets/useImageCrop-Ub0VKnJp.js (new) — 14.9 kB 🔴 +14.9 kB 🔴 +3.42 kB 🔴 +2.99 kB
assets/useDowngradeToPersonal-BMe8bpha.js (removed) 11 kB — 🟢 -11 kB 🟢 -2.76 kB 🟢 -2.36 kB
assets/useDowngradeToPersonal-BYl16zaK.js (new) — 11 kB 🔴 +11 kB 🔴 +2.76 kB 🔴 +2.37 kB
assets/useFeatureFlags-BDbwYo1E.js (new) — 8.04 kB 🔴 +8.04 kB 🔴 +2.21 kB 🔴 +1.88 kB
assets/useFeatureFlags-C1fsk_dL.js (removed) 8.04 kB — 🟢 -8.04 kB 🟢 -2.21 kB 🟢 -1.88 kB
assets/useExternalLink-Btn8dkX4.js (removed) 7.62 kB — 🟢 -7.62 kB 🟢 -2.56 kB 🟢 -2.18 kB
assets/useExternalLink-mlV0IHTz.js (new) — 7.62 kB 🔴 +7.62 kB 🔴 +2.56 kB 🔴 +2.18 kB
assets/usePricingTableUrlLoader-DIDcZRtS.js (removed) 4.79 kB — 🟢 -4.79 kB 🟢 -1.65 kB 🟢 -1.4 kB
assets/usePricingTableUrlLoader-lqQjiIGQ.js (new) — 4.79 kB 🔴 +4.79 kB 🔴 +1.65 kB 🔴 +1.4 kB
assets/useCompositorLayers-C4uhLC0b.js (removed) 3.65 kB — 🟢 -3.65 kB 🟢 -1.06 kB 🟢 -994 B
assets/useCompositorLayers-u5cqBFAd.js (new) — 3.65 kB 🔴 +3.65 kB 🔴 +1.06 kB 🔴 +993 B
assets/useUpstreamValue-BDs4SaRf.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -751 B 🟢 -664 B
assets/useUpstreamValue-CriiaxiU.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +752 B 🔴 +664 B
assets/useWorkspaceTierLabel-CcBwOBtB.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +843 B 🔴 +715 B
assets/useWorkspaceTierLabel-gARkxZ3w.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -842 B 🟢 -715 B
assets/useSessionCookie-CUXwJ5Ay.js (new) — 688 B 🔴 +688 B 🔴 +356 B 🔴 +307 B
assets/useSessionCookie-CxFxTqug.js (removed) 688 B — 🟢 -688 B 🟢 -351 B 🟢 -305 B
assets/useLoad3d-7oT7ZBT0.js (removed) 311 B — 🟢 -311 B 🟢 -163 B 🟢 -148 B
assets/useLoad3d-D2PkcZVm.js (new) — 311 B 🔴 +311 B 🔴 +164 B 🔴 +147 B
assets/useSessionCookie-DwtKNL4r.js (removed) 101 B — 🟢 -101 B 🟢 -86 B 🟢 -83 B
assets/useSessionCookie-k5Ujt54d.js (new) — 101 B 🔴 +101 B 🔴 +86 B 🔴 +78 B
assets/useFeatureFlags-ek2MXSBb.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -79 B
assets/useFeatureFlags-jqqum4-n.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +80 B
assets/useLoad3dViewer-BWrmu6H9.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -81 B
assets/useLoad3dViewer-Co6OBrYM.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +82 B
assets/useCurrentUser-BhNIerS3.js (removed) 93 B — 🟢 -93 B 🟢 -94 B 🟢 -89 B
assets/useCurrentUser-CMmXQHdD.js (new) — 93 B 🔴 +93 B 🔴 +94 B 🔴 +93 B

Status: 18 added / 18 removed / 18 unchanged

Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-BLTdTX8Q.js (new) — 117 kB 🔴 +117 kB 🔴 +30.6 kB 🔴 +25.9 kB
assets/core-DI_BzNdm.js (removed) 117 kB — 🟢 -117 kB 🟢 -30.6 kB 🟢 -25.9 kB
assets/WorkspaceSettingsPanelContent-CKuV7gNT.js (removed) 111 kB — 🟢 -111 kB 🟢 -21.8 kB 🟢 -18.3 kB
assets/WorkspaceSettingsPanelContent-DE5BsgIi.js (new) — 111 kB 🔴 +111 kB 🔴 +21.8 kB 🔴 +18.3 kB
assets/SubscriptionTransitionPreviewWorkspace-B0RBLP-9.js (new) — 98.5 kB 🔴 +98.5 kB 🔴 +19.1 kB 🔴 +16.1 kB
assets/SubscriptionTransitionPreviewWorkspace-BhgP-mxV.js (removed) 98.5 kB — 🟢 -98.5 kB 🟢 -19.1 kB 🟢 -16.1 kB
assets/WidgetSelect-a9wtkriB.js (new) — 88.5 kB 🔴 +88.5 kB 🔴 +20.1 kB 🔴 +17.2 kB
assets/WidgetSelect-XbYVsaHI.js (removed) 88.5 kB — 🟢 -88.5 kB 🟢 -20.1 kB 🟢 -17.1 kB
assets/WidgetVideoEdit-B0M-CDgs.js (new) — 72.7 kB 🔴 +72.7 kB 🔴 +17.2 kB 🔴 +15.1 kB
assets/WidgetVideoEdit-CFqluy83.js (removed) 72.7 kB — 🟢 -72.7 kB 🟢 -17.2 kB 🟢 -15.1 kB
assets/Load3D-DIhPK18U.js (new) — 72.2 kB 🔴 +72.2 kB 🔴 +12 kB 🔴 +10.2 kB
assets/Load3D-SUtPDjZj.js (removed) 72.2 kB — 🟢 -72.2 kB 🟢 -12 kB 🟢 -10.2 kB
assets/CameraInfo-Bh54oyul.js (new) — 67 kB 🔴 +67 kB 🔴 +14.5 kB 🔴 +12.7 kB
assets/CameraInfo-JeQl1jEL.js (removed) 67 kB — 🟢 -67 kB 🟢 -14.5 kB 🟢 -12.8 kB
assets/Preview3d-Bn-2bvNj.js (new) — 52.6 kB 🔴 +52.6 kB 🔴 +8.59 kB 🔴 +7.5 kB
assets/Preview3d-Zs8IfU1s.js (removed) 52.6 kB — 🟢 -52.6 kB 🟢 -8.6 kB 🟢 -7.5 kB
assets/SubscriptionRequiredDialogContentUnified-BDPDyuFP.js (removed) 51.5 kB — 🟢 -51.5 kB 🟢 -10.7 kB 🟢 -9.31 kB
assets/SubscriptionRequiredDialogContentUnified-D4x6tj_i.js (new) — 51.5 kB 🔴 +51.5 kB 🔴 +10.7 kB 🔴 +9.31 kB
assets/Viewport3d-BLkS_N93.js (new) — 47.5 kB 🔴 +47.5 kB 🔴 +10.1 kB 🔴 +8.91 kB
assets/Viewport3d-fjKzQFu5.js (removed) 47.5 kB — 🟢 -47.5 kB 🟢 -10.1 kB 🟢 -8.91 kB
assets/LayerEditorContent-BNpRZCLX.js (new) — 45.4 kB 🔴 +45.4 kB 🔴 +10.6 kB 🔴 +9.26 kB
assets/LayerEditorContent-Col0ljdD.js (removed) 45.4 kB — 🟢 -45.4 kB 🟢 -10.6 kB 🟢 -9.27 kB
assets/main-C9JBVrYe.js (new) — 42.8 kB 🔴 +42.8 kB 🔴 +12.8 kB 🔴 +11.1 kB
assets/main-DQG-sC1S.js (removed) 42.8 kB — 🟢 -42.8 kB 🟢 -12.8 kB 🟢 -11.1 kB
assets/WidgetBoundingBoxes-B8e521s0.js (removed) 33.7 kB — 🟢 -33.7 kB 🟢 -9.17 kB 🟢 -8.12 kB
assets/WidgetBoundingBoxes-BiJAfDr8.js (new) — 33.7 kB 🔴 +33.7 kB 🔴 +9.16 kB 🔴 +8.12 kB
assets/WidgetPainter-DXcaazp0.js (removed) 32.6 kB — 🟢 -32.6 kB 🟢 -7.88 kB 🟢 -6.97 kB
assets/WidgetPainter-RlYeIvvv.js (new) — 32.6 kB 🔴 +32.6 kB 🔴 +7.88 kB 🔴 +6.98 kB
assets/Load3dViewerContent-B0ypj7oV.js (new) — 30.6 kB 🔴 +30.6 kB 🔴 +6.21 kB 🔴 +5.37 kB
assets/Load3dViewerContent-BWtx0FzN.js (removed) 30.6 kB — 🟢 -30.6 kB 🟢 -6.21 kB 🟢 -5.38 kB
assets/SubscriptionRequiredDialogContent-Ce2KicH7.js (removed) 26.9 kB — 🟢 -26.9 kB 🟢 -6.36 kB 🟢 -5.6 kB
assets/SubscriptionRequiredDialogContent-DN9R_U1m.js (new) — 26.9 kB 🔴 +26.9 kB 🔴 +6.36 kB 🔴 +5.61 kB
assets/SubscriptionRequiredDialogContentWorkspace-CC3XvJod.js (new) — 26.5 kB 🔴 +26.5 kB 🔴 +6.02 kB 🔴 +5.29 kB
assets/SubscriptionRequiredDialogContentWorkspace-cjYY7DWf.js (removed) 26.5 kB — 🟢 -26.5 kB 🟢 -6.02 kB 🟢 -5.29 kB
assets/load3d-D-YE9Kxu.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.42 kB 🟢 -4.69 kB
assets/load3d-NsDxFMm0.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.42 kB 🔴 +4.69 kB
assets/SignInContent-C40BLpIH.js (new) — 20.6 kB 🔴 +20.6 kB 🔴 +5.19 kB 🔴 +4.54 kB
assets/SignInContent-CTNZlnoq.js (removed) 20.6 kB — 🟢 -20.6 kB 🟢 -5.19 kB 🟢 -4.54 kB
assets/CurrentUserPopoverWorkspace-C5coCWcH.js (new) — 17.3 kB 🔴 +17.3 kB 🔴 +4.02 kB 🔴 +3.54 kB
assets/CurrentUserPopoverWorkspace-mP4XubHo.js (removed) 17.3 kB — 🟢 -17.3 kB 🟢 -4.02 kB 🟢 -3.53 kB
assets/WidgetRecordAudio-CcrUYq3M.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.6 kB 🟢 -4.1 kB
assets/WidgetRecordAudio-CVf-fLxo.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.6 kB 🔴 +4.1 kB
assets/WidgetInputNumber-B6gvAXbF.js (removed) 13.9 kB — 🟢 -13.9 kB 🟢 -3.63 kB 🟢 -3.21 kB
assets/WidgetInputNumber-C00KbUp6.js (new) — 13.9 kB 🔴 +13.9 kB 🔴 +3.63 kB 🔴 +3.21 kB
assets/WidgetRange-BCtK-4CA.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +3.55 kB 🔴 +3.13 kB
assets/WidgetRange-CL_sr5iM.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -3.55 kB 🟢 -3.12 kB
assets/WaveAudioPlayer-4YMSPAW5.js (removed) 12.9 kB — 🟢 -12.9 kB 🟢 -3.49 kB 🟢 -3.04 kB
assets/WaveAudioPlayer-CZWwTaEj.js (new) — 12.9 kB 🔴 +12.9 kB 🔴 +3.49 kB 🔴 +3.05 kB
assets/WidgetCurve-HMOdLcsO.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.48 kB 🟢 -3.13 kB
assets/WidgetCurve-xchzRjTV.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.48 kB 🔴 +3.13 kB
assets/GlobalToast-CE6beZIX.js (removed) 10.9 kB — 🟢 -10.9 kB 🟢 -3.72 kB 🟢 -3.22 kB
assets/GlobalToast-CnWS7mJ1.js (new) — 10.9 kB 🔴 +10.9 kB 🔴 +3.72 kB 🔴 +3.22 kB
assets/TeamWorkspacesDialogContent-D_JGOwLM.js (removed) 10.3 kB — 🟢 -10.3 kB 🟢 -2.97 kB 🟢 -2.63 kB
assets/TeamWorkspacesDialogContent-pPzF31v8.js (new) — 10.3 kB 🔴 +10.3 kB 🔴 +2.97 kB 🔴 +2.63 kB
assets/onboardingCloudRoutes-CS-OCGXq.js (new) — 9.77 kB 🔴 +9.77 kB 🔴 +2.88 kB 🔴 +2.46 kB
assets/onboardingCloudRoutes-Hg43c8KR.js (removed) 9.77 kB — 🟢 -9.77 kB 🟢 -2.87 kB 🟢 -2.47 kB
assets/Load3DConfiguration-Cu2DeHIZ.js (new) — 8.91 kB 🔴 +8.91 kB 🔴 +2.61 kB 🔴 +2.31 kB
assets/Load3DConfiguration-D2duSUoq.js (removed) 8.91 kB — 🟢 -8.91 kB 🟢 -2.61 kB 🟢 -2.31 kB
assets/WidgetImageCrop-CdKR_Yd9.js (removed) 8.49 kB — 🟢 -8.49 kB 🟢 -2.65 kB 🟢 -2.34 kB
assets/WidgetImageCrop-CXKdcGRp.js (new) — 8.49 kB 🔴 +8.49 kB 🔴 +2.65 kB 🔴 +2.33 kB
assets/SetMemberCreditLimitDialogContent-DE8p_cmT.js (new) — 8.47 kB 🔴 +8.47 kB 🔴 +2.34 kB 🔴 +2.05 kB
assets/SetMemberCreditLimitDialogContent-DyZSuQzW.js (removed) 8.47 kB — 🟢 -8.47 kB 🟢 -2.34 kB 🟢 -2.05 kB
assets/nodeTemplates-Be2PPBm4.js (removed) 8.32 kB — 🟢 -8.32 kB 🟢 -2.85 kB 🟢 -2.51 kB
assets/nodeTemplates-D0rCVB2-.js (new) — 8.32 kB 🔴 +8.32 kB 🔴 +2.85 kB 🔴 +2.52 kB
assets/WorkspaceSwitcherPopover-BHHPoqcd.js (new) — 8.01 kB 🔴 +8.01 kB 🔴 +2.38 kB 🔴 +2.11 kB
assets/WorkspaceSwitcherPopover-Dv6TI-ai.js (removed) 8.01 kB — 🟢 -8.01 kB 🟢 -2.38 kB 🟢 -2.11 kB
assets/NightlySurveyController-B77hvrch.js (removed) 7.5 kB — 🟢 -7.5 kB 🟢 -2.56 kB 🟢 -2.25 kB
assets/NightlySurveyController-y_8ZiEMv.js (new) — 7.5 kB 🔴 +7.5 kB 🔴 +2.56 kB 🔴 +2.26 kB
assets/CloudRunButtonWrapper-BnpOHWc5.js (new) — 7.44 kB 🔴 +7.44 kB 🔴 +2.35 kB 🔴 +2.06 kB
assets/CloudRunButtonWrapper-DluGNWmX.js (removed) 7.44 kB — 🟢 -7.44 kB 🟢 -2.35 kB 🟢 -2.06 kB
assets/LayoutDefault-C41iltEp.js (new) — 7.41 kB 🔴 +7.41 kB 🔴 +2.44 kB 🔴 +2.14 kB
assets/LayoutDefault-DhSO0b7D.js (removed) 7.41 kB — 🟢 -7.41 kB 🟢 -2.44 kB 🟢 -2.13 kB
assets/missingModelMetadata-C5M3JciU.js (new) — 6.52 kB 🔴 +6.52 kB 🔴 +2.22 kB 🔴 +1.94 kB
assets/missingModelMetadata-Ccm2aafM.js (removed) 6.52 kB — 🟢 -6.52 kB 🟢 -2.22 kB 🟢 -1.94 kB
assets/WidgetWithControl-BpEajfan.js (removed) 6.47 kB — 🟢 -6.47 kB 🟢 -2.64 kB 🟢 -2.34 kB
assets/WidgetWithControl-FsBNhLSi.js (new) — 6.47 kB 🔴 +6.47 kB 🔴 +2.65 kB 🔴 +2.34 kB
assets/CancelSubscriptionDialogContent-CG4h4lZv.js (new) — 6.05 kB 🔴 +6.05 kB 🔴 +2.01 kB 🔴 +1.76 kB
assets/CancelSubscriptionDialogContent-wbvDfDuS.js (removed) 6.05 kB — 🟢 -6.05 kB 🟢 -2.01 kB 🟢 -1.76 kB
assets/load3dPreviewExtensions-Ceno8SSk.js (new) — 5.88 kB 🔴 +5.88 kB 🔴 +1.81 kB 🔴 +1.6 kB
assets/load3dPreviewExtensions-ICLroH0F.js (removed) 5.88 kB — 🟢 -5.88 kB 🟢 -1.81 kB 🟢 -1.6 kB
assets/ApiNodesSignInContent-KUhD4kz1.js (removed) 5.68 kB — 🟢 -5.68 kB 🟢 -2.02 kB 🟢 -1.79 kB
assets/ApiNodesSignInContent-zuTCoMf5.js (new) — 5.68 kB 🔴 +5.68 kB 🔴 +2.02 kB 🔴 +1.79 kB
assets/launchCancellationFlow-CuN1jZ5p.js (removed) 5.18 kB — 🟢 -5.18 kB 🟢 -1.78 kB 🟢 -1.55 kB
assets/launchCancellationFlow-DoFz40NJ.js (new) — 5.18 kB 🔴 +5.18 kB 🔴 +1.78 kB 🔴 +1.56 kB
assets/CreateWorkspaceDialogContent-BRsVETnr.js (removed) 5.12 kB — 🟢 -5.12 kB 🟢 -1.79 kB 🟢 -1.55 kB
assets/CreateWorkspaceDialogContent-CCEJlQtp.js (new) — 5.12 kB 🔴 +5.12 kB 🔴 +1.79 kB 🔴 +1.55 kB
assets/ChangeMemberRoleDialogContent-CYIpNl3w.js (removed) 4.97 kB — 🟢 -4.97 kB 🟢 -1.64 kB 🟢 -1.42 kB
assets/ChangeMemberRoleDialogContent-kJ3R8rOu.js (new) — 4.97 kB 🔴 +4.97 kB 🔴 +1.64 kB 🔴 +1.43 kB
assets/InviteMemberDialogContent-BvkStPzM.js (new) — 4.94 kB 🔴 +4.94 kB 🔴 +1.63 kB 🔴 +1.42 kB
assets/InviteMemberDialogContent-fQLQ1bdh.js (removed) 4.94 kB — 🟢 -4.94 kB 🟢 -1.63 kB 🟢 -1.42 kB
assets/EditWorkspaceDialogContent-_psoVqZb.js (removed) 4.94 kB — 🟢 -4.94 kB 🟢 -1.76 kB 🟢 -1.52 kB
assets/EditWorkspaceDialogContent-D0uJaOk2.js (new) — 4.94 kB 🔴 +4.94 kB 🔴 +1.76 kB 🔴 +1.52 kB
assets/WidgetTextarea-BppWsWLL.js (removed) 4.83 kB — 🟢 -4.83 kB 🟢 -1.89 kB 🟢 -1.64 kB
assets/WidgetTextarea-DI50WjgU.js (new) — 4.83 kB 🔴 +4.83 kB 🔴 +1.89 kB 🔴 +1.64 kB
assets/saveMesh-Do8Qp_Br.js (removed) 4.72 kB — 🟢 -4.72 kB 🟢 -1.51 kB 🟢 -1.33 kB
assets/saveMesh-DVElfdst.js (new) — 4.72 kB 🔴 +4.72 kB 🔴 +1.51 kB 🔴 +1.34 kB
assets/ValueControlPopover-Brf73jTf.js (new) — 4.49 kB 🔴 +4.49 kB 🔴 +1.55 kB 🔴 +1.38 kB
assets/ValueControlPopover-GXZArPV1.js (removed) 4.49 kB — 🟢 -4.49 kB 🟢 -1.55 kB 🟢 -1.38 kB
assets/DeleteWorkspaceDialogContent-Cwc6ZSkl.js (new) — 3.85 kB 🔴 +3.85 kB 🔴 +1.44 kB 🔴 +1.24 kB
assets/DeleteWorkspaceDialogContent-CWj6i4yD.js (removed) 3.85 kB — 🟢 -3.85 kB 🟢 -1.44 kB 🟢 -1.24 kB
assets/RemoveMemberDialogContent-CieBL5ig.js (new) — 3.76 kB 🔴 +3.76 kB 🔴 +1.38 kB 🔴 +1.19 kB
assets/RemoveMemberDialogContent-DBOEVkP-.js (removed) 3.76 kB — 🟢 -3.76 kB 🟢 -1.38 kB 🟢 -1.19 kB
assets/RevokeInviteDialogContent-2bvqWWEd.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.39 kB 🔴 +1.21 kB
assets/RevokeInviteDialogContent-BjGHihud.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.39 kB 🟢 -1.21 kB
assets/LeaveWorkspaceDialogContent-Bi083oAH.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.38 kB 🔴 +1.19 kB
assets/LeaveWorkspaceDialogContent-DqLituT0.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.39 kB 🟢 -1.19 kB
assets/InviteMemberUpsellDialogContent-Du3N0OwI.js (removed) 3.47 kB — 🟢 -3.47 kB 🟢 -1.24 kB 🟢 -1.09 kB
assets/InviteMemberUpsellDialogContent-vrQ7GrmD.js (new) — 3.47 kB 🔴 +3.47 kB 🔴 +1.24 kB 🔴 +1.09 kB
assets/Media3DTop-B37A5mB3.js (new) — 3.21 kB 🔴 +3.21 kB 🔴 +1.27 kB 🔴 +1.1 kB
assets/Media3DTop-cJPzSqg9.js (removed) 3.21 kB — 🟢 -3.21 kB 🟢 -1.27 kB 🟢 -1.1 kB
assets/load3dAdvanced-Ci3mekEx.js (new) — 2.82 kB 🔴 +2.82 kB 🔴 +1.1 kB 🔴 +955 B
assets/load3dAdvanced-Cs2Tt_Ov.js (removed) 2.82 kB — 🟢 -2.82 kB 🟢 -1.09 kB 🟢 -951 B
assets/LocalRunButtonWrapper-7RNTQsIm.js (new) — 2.49 kB 🔴 +2.49 kB 🔴 +1.14 kB 🔴 +996 B
assets/LocalRunButtonWrapper-uJP6eFkW.js (removed) 2.49 kB — 🟢 -2.49 kB 🟢 -1.14 kB 🟢 -1 kB
assets/SubscribeToRun-9jk9nGYt.js (removed) 2.39 kB — 🟢 -2.39 kB 🟢 -1.04 kB 🟢 -909 B
assets/SubscribeToRun-DFGdaH1U.js (new) — 2.39 kB 🔴 +2.39 kB 🔴 +1.04 kB 🔴 +914 B
assets/MediaAudioTop-CeiXWr-p.js (removed) 1.62 kB — 🟢 -1.62 kB 🟢 -809 B 🟢 -667 B
assets/MediaAudioTop-udL5XKfS.js (new) — 1.62 kB 🔴 +1.62 kB 🔴 +809 B 🔴 +669 B
assets/paymentReturnUrl-Dceg3uOK.js (new) — 1.58 kB 🔴 +1.58 kB 🔴 +787 B 🔴 +623 B
assets/paymentReturnUrl-DlOvuAGL.js (removed) 1.58 kB — 🟢 -1.58 kB 🟢 -785 B 🟢 -622 B
assets/cameraInfo-BqRS12ux.js (removed) 1.1 kB — 🟢 -1.1 kB 🟢 -572 B 🟢 -501 B
assets/cameraInfo-Dx_I1mik.js (new) — 1.1 kB 🔴 +1.1 kB 🔴 +572 B 🔴 +492 B
assets/Load3DAdvanced-CK6ziaK0.js (new) — 761 B 🔴 +761 B 🔴 +423 B 🔴 +361 B
assets/Load3DAdvanced-UPWWWrlR.js (removed) 761 B — 🟢 -761 B 🟢 -423 B 🟢 -360 B
assets/nightlyBadges-BNWT1-hz.js (new) — 411 B 🔴 +411 B 🔴 +273 B 🔴 +272 B
assets/nightlyBadges-C_A319Ho.js (removed) 411 B — 🟢 -411 B 🟢 -272 B 🟢 -228 B
assets/Load3dViewerContent-C9aRSE-y.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +91 B
assets/Load3dViewerContent-DYFNdGsW.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -109 B
assets/missingModelMetadata-9TMUFC6l.js (new) — 125 B 🔴 +125 B 🔴 +103 B 🔴 +105 B
assets/missingModelMetadata-Bje_G2dj.js (removed) 125 B — 🟢 -125 B 🟢 -103 B 🟢 -96 B
assets/Load3DAdvanced-B6d3ekjb.js (new) — 122 B 🔴 +122 B 🔴 +97 B 🔴 +87 B
assets/Load3DAdvanced-qMTeSSOH.js (removed) 122 B — 🟢 -122 B 🟢 -97 B 🟢 -87 B
assets/LayoutDefault-BKAWwFmw.js (new) — 119 B 🔴 +119 B 🔴 +92 B 🔴 +83 B
assets/LayoutDefault-qVic2b0i.js (removed) 119 B — 🟢 -119 B 🟢 -92 B 🟢 -90 B
assets/WidgetLegacy-B3vyqHhM.js (new) — 117 B 🔴 +117 B 🔴 +106 B 🔴 +103 B
assets/WidgetLegacy-X6qKbbBA.js (removed) 117 B — 🟢 -117 B 🟢 -106 B 🟢 -101 B
assets/workflowDraftStoreV2-DN-DE2RU.js (new) — 112 B 🔴 +112 B 🔴 +101 B 🔴 +110 B
assets/workflowDraftStoreV2-DsIMI4_T.js (removed) 112 B — 🟢 -112 B 🟢 -101 B 🟢 -116 B
assets/CameraInfo-BEatwDNS.js (removed) 110 B — 🟢 -110 B 🟢 -93 B 🟢 -90 B
assets/CameraInfo-CWL3ttmz.js (new) — 110 B 🔴 +110 B 🔴 +93 B 🔴 +92 B
assets/Load3D-BfSHJyY4.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -86 B
assets/Load3D-Ds_lKH2q.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +96 B
assets/changeTracker-BbBDOo9o.js (new) — 92 B 🔴 +92 B 🔴 +94 B 🔴 +93 B
assets/changeTracker-CA4_6p6_.js (removed) 92 B — 🟢 -92 B 🟢 -94 B 🟢 -85 B

Status: 72 added / 72 removed / 224 unchanged

⚡ Performance

⏳ Performance tests in progress…

…ssetSchema test

- Export persistThumbnailFromDataUrl (fetches data URL → Blob → delegates to persistThumbnail)
- Fix formatting of as const each block in mediaAssetSchema.test.ts
@codecov

codecov Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #16494      +/-   ##
==========================================
+ Coverage   82.25%   82.52%   +0.26%     
==========================================
  Files        2017     2033      +16     
  Lines      116536   118025    +1489     
  Branches    31039    30154     -885     
==========================================
+ Hits        95856    97397    +1541     
+ Misses      20505    20451      -54     
- Partials      175      177       +2     
Flag Coverage Δ
e2e 66.66% <50.00%> (-1.46%) ⬇️
unit 76.82% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/assets/schemas/mediaAssetSchema.ts 100.00% <100.00%> (ø)
src/scripts/pnginfo.ts 68.07% <100.00%> (ø)

... and 225 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne marked this pull request as ready for review September 1, 2026 22:13
@christian-byrne
christian-byrne requested a review from a team September 1, 2026 22:13
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Lifecycle update (cheap-drain lane, act-fe-16494-cifix):

Draft PR undrafted → ready for review. All CI green (79 pass / 15 skip / 0 fail).

Prior state: 17 failing checks (draft). Root cause: CI failures resolved. Current head passes lint-and-format, scan, setup, storybook-build, custom_nodes_e2e (all 7 shards), playwright (all variants), perf-tests, ecosystem-matrix (all shards).

Assignees: benjcooley + ryan-di + CodeJuggernaut (roster triple-assign).

Ready for human review.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

CI green — root-cause fixes for 17 failing checks.

Two issues fixed in b205fde:

  1. Missing persistThumbnailFromDataUrl export in assetPreviewUtil.ts — new test imported it but only persistThumbnail (Blob-based) existed. Added exported wrapper that fetches data URL → Blob → delegates.
  2. Format fix in mediaAssetSchema.test.ts — as const each-block needed reformatting (fork PR could not auto-fix).

All 79 checks passing, 0 failures, 0 pending.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Every thumbnail caller already hands persistThumbnail a Blob, so the
data-URL wrapper had no callers outside its own test.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at c091e98. The PR body says the tests could not be run on the worker, so I ran them here: the three touched suites pass (27 tests), the whole src/platform/assets tree passes (52 files, 776 tests), and vue-tsc is clean.

issue: persistThumbnailFromDataUrl had no callers. Every thumbnail producer on main (saveMesh.ts, useLoad3d.ts, useLoad3dViewer.ts, modelThumbnail.ts) already hands persistThumbnail a Blob from canvas.toBlob, so the data-URL wrapper existed only so its ported test would compile (that is what b205fde added it for). Fixed in c091e98 by removing the function and assetPreviewUtil.persistFromDataUrl.test.ts; assetPreviewUtil.ts is now identical to main.

The fail-soft parsing change is worth keeping. MediaAssetCard.vue dragStart writes attachment_ref from getAssetUrlFilename, which can be an empty string, and under the old intersection schema that single field failed the whole payload so getDroppedAsset fell back to the uri-only path with no media_kind or preview_url. With .extend plus .catch(undefined) the base item survives and only the bad field is dropped, which is what the new it.for cases pin. Switching .and to .extend is safe here because zResultItem is a plain z.object, so key stripping behaves the same either way.

One open question inline on the beforeGraphClear widening.

Comment thread src/scripts/pnginfo.ts
graph: LGraph,
parameters: string,
beforeGraphClear?: () => void
beforeGraphClear?: () => void | Promise<void>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: the only caller, app.ts around line 2102, passes a synchronous hook that calls beforeLoadNewGraph and canvas.setGraph inline, so nothing on main needs the Promise return yet. Is an async caller coming in a later port, or is this widening speculative? Awaiting a sync hook also inserts a microtask yield between the hook and graph.clear(); harmless today, but if the intent is only to future-proof it may be simpler to land the widening together with the caller that needs it.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants