Skip to content

[backport cloud/1.53] fix(billing): keep the pending checkout pointer until the operation is terminal - #16457

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16120-to-cloud-1.53
Sep 1, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16120-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16120 to cloud/1.53

Automatically created by backport workflow.

…s terminal (#16120)

## Summary

The stored `comfy:pending-subscription-checkout` pointer was dropped
after a single resume attempt, so a customer who reloaded twice during a
3DS challenge lost the handle to their own in-flight subscription
operation and then hit `SUBSCRIPTION_CHANGE_IN_PROGRESS` with nothing to
resume or cancel. Fixes FE-1921.

## Changes

- **What**: Clear the pointer only once the billing operation reaches a
status that is terminal for client polling — `succeeded`, `failed`, or
`reconciliation_needed` — replacing the blanket `finally` in
`resumePendingCheckout` and `advanceToSuccessOnOperation`. `pending` and
`timeout` now retain it: a client-side timeout is this tab giving up
rather than the server finishing, and an operation awaiting bank
authentication stays pending for hours.
- **What**: `billingOperationStore.pollOnce` now checks `response.status
=== 'reconciliation_needed'` regardless of `embeddedCheckoutEnabled`.
Previously this whole branch was flag-gated, so a `status:
'reconciliation_needed'` response on the legacy (flag-off) path fell
through to `scheduleNextPoll` and only ever resolved as a client
`timeout`. With the terminal-status set above now retaining the pointer
on `timeout`, that would have re-polled an already-settled operation to
timeout on every reload for the rest of the session — the same defect
this PR fixes, inverted. Moving the `status` check outside the flag gate
resolves it as `reconciliation_needed` immediately on both paths, and
surfaces `handleReconciliationNeeded`'s
`stage:'failed'`/`failure_category:'reconciliation_needed'` telemetry on
the legacy path for the first time. `authentication_state ===
'reconciliation_needed'` remains flag-gated: with the flag off the
frontend doesn't read `authentication_state` at all, matching existing
behavior for every other value of that field.

## Review Focus

- Both call sites lost their `try/finally`, so a throw from
`startOperation` also leaves the pointer in place now. That is
deliberate, for the same reason `timeout` does, but it is a change in
failure handling worth a look.
- `reconciliation_needed` is grouped with the terminal statuses on
purpose. The operation contract calls it terminal for client polling,
and `handleReconciliationNeeded` stops polling and resolves, so
retaining the pointer would re-poll a settled operation and re-emit its
failure telemetry on every reload.
- FE-1921's second half — recovering the blocking operation id from the
409 body — is deliberately not in this PR. Attributing that operation's
outcome to the selection the server just rejected would render the
success screen with the wrong tier and cycle, and BE-10062 has not yet
defined what the refusal returns. It lands with that ticket.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 1, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 1, 2026 03:11
@github-actions

github-actions Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/01/2026, 03:13:07 AM UTC

Links

🎭 Playwright: ✅ 1890 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 135ms TBT · 81.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.8 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 3ms TBT · 167.0 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 122ms TBT · 164.3 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 394ms TBT · 166.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 530ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 58.4 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -171
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 42ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 900ms
canvas-mouse-sweep: script duration 164ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 60.8 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -154
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 360ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.1 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 451ms
dom-widget-clipping: script duration 162ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.0 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 634ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.3 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -184
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1655ms
large-graph-pan: script duration 828ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.7 MB
large-graph-pan: DOM nodes -277
large-graph-pan: event listeners -74
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1686ms
large-graph-zoom: script duration 769ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.7 MB
large-graph-zoom: DOM nodes 2
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1947ms
legacy-node-drag: script duration 964ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 548ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.8 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -170
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 428ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.3 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 515ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.4 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -231
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 41ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 854ms
subgraph-mouse-sweep: script duration 114ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.8 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -200
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 941ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 135ms
subgraph-transition-enter: heap used 81.7 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5832ms
viewport-pan-sweep: script duration 2691ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.8 MB
viewport-pan-sweep: DOM nodes -273
viewport-pan-sweep: event listeners -167
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16575ms
vue-large-graph-idle: script duration 295ms
vue-large-graph-idle: TBT 3ms
vue-large-graph-idle: heap used 167.0 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 176
vue-large-graph-pan: task duration 20951ms
vue-large-graph-pan: script duration 948ms
vue-large-graph-pan: TBT 122ms
vue-large-graph-pan: heap used 164.3 MB
vue-large-graph-pan: DOM nodes -6551
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 83ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6133ms
vue-node-resize-workload: script duration 123ms
vue-node-resize-workload: TBT 394ms
vue-node-resize-workload: heap used 166.0 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 3
workflow-execution: style recalc count 6
workflow-execution: task duration 77ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.5 MB
workflow-execution: DOM nodes 108
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-01T03:25:13.853Z",
  "gitSha": "88eaf52bcf713713c9495423eff62230245f0056",
  "branch": "backport-16120-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2075.02199999999,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.639999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 553.109,
      "heapDeltaBytes": -11343172,
      "heapUsedBytes": 57713308,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.16,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2028.7199999999075,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.599999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.366,
      "heapDeltaBytes": 1971736,
      "heapUsedBytes": 64819496,
      "domNodes": -283,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.373999999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1936.1170000000243,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 44.07600000000001,
      "layouts": 14,
      "layoutDurationMs": 4.645,
      "taskDurationMs": 902.0930000000001,
      "heapDeltaBytes": -7660944,
      "heapUsedBytes": 62135940,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 165.65400000000002,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1851.4940000000024,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.179,
      "layouts": 14,
      "layoutDurationMs": 4.436000000000001,
      "taskDurationMs": 898.5300000000001,
      "heapDeltaBytes": -4819772,
      "heapUsedBytes": 65267508,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 161.70600000000002,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.5059999999862,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.323,
      "layouts": 6,
      "layoutDurationMs": 1.0060000000000002,
      "taskDurationMs": 359.51099999999997,
      "heapDeltaBytes": 4443980,
      "heapUsedBytes": 74592040,
      "domNodes": 78,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.622,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.4309999999386,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.419,
      "layouts": 6,
      "layoutDurationMs": 1.198,
      "taskDurationMs": 361.18000000000006,
      "heapDeltaBytes": 4459284,
      "heapUsedBytes": 74549068,
      "domNodes": 77,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 10.629,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 658.9599999999791,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.111000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.438,
      "heapDeltaBytes": 17802728,
      "heapUsedBytes": 88072028,
      "domNodes": 16,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 159.59599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 664.574000000016,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.192,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.55999999999995,
      "heapDeltaBytes": 18110488,
      "heapUsedBytes": 88017456,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 163.604,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2067.198000000019,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.905999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 632.977,
      "heapDeltaBytes": -9882792,
      "heapUsedBytes": 83720432,
      "domNodes": -274,
      "jsHeapTotalBytes": 3887104,
      "scriptDurationMs": 34.447,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2070.4030000000557,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 10.746000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 634.745,
      "heapDeltaBytes": -10995580,
      "heapUsedBytes": 84762636,
      "domNodes": -270,
      "jsHeapTotalBytes": 4149248,
      "scriptDurationMs": 34.230999999999995,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2419.7750000000156,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.247000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1669.4060000000002,
      "heapDeltaBytes": 21531824,
      "heapUsedBytes": 87284036,
      "domNodes": -273,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 830.254,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2259.241000000088,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 9.005000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1641.568,
      "heapDeltaBytes": 22678616,
      "heapUsedBytes": 88162464,
      "domNodes": -280,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 825.4549999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3538.5410000000093,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.734999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.03,
      "taskDurationMs": 1691.781,
      "heapDeltaBytes": 11722564,
      "heapUsedBytes": 79141072,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 771.518,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3498.8970000000563,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.835999999999999,
      "layouts": 60,
      "layoutDurationMs": 11.664000000000001,
      "taskDurationMs": 1679.8539999999998,
      "heapDeltaBytes": 8515288,
      "heapUsedBytes": 75424852,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 767.3670000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3140.2989999999704,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.993999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1951.295,
      "heapDeltaBytes": 17445132,
      "heapUsedBytes": 84661264,
      "domNodes": 0,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 957.9270000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3103.8959999999634,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.11,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1942.198,
      "heapDeltaBytes": 21455460,
      "heapUsedBytes": 89213368,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 970.737,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.297999999992,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.4449999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 550.0949999999999,
      "heapDeltaBytes": 21452952,
      "heapUsedBytes": 86627912,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.211999999999996,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2006.3390000000254,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.6839999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.992,
      "heapDeltaBytes": 21851068,
      "heapUsedBytes": 87057092,
      "domNodes": -269,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 27.572,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 605.515999999966,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.263,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 421.767,
      "heapDeltaBytes": 14376224,
      "heapUsedBytes": 86245644,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 143.302,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 622.6379999999381,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.408000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.3450000000001,
      "heapDeltaBytes": 14373144,
      "heapUsedBytes": 86329648,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 144.888,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2037.8960000000461,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.402999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.1429999999999,
      "heapDeltaBytes": 6544916,
      "heapUsedBytes": 71696864,
      "domNodes": -296,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 7.806,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.2679999999873,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.573000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.059,
      "heapDeltaBytes": 6891092,
      "heapUsedBytes": 71747652,
      "domNodes": -296,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.716000000000001,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1741.6719999999941,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 44.81,
      "layouts": 18,
      "layoutDurationMs": 6.12,
      "taskDurationMs": 865.593,
      "heapDeltaBytes": -11054688,
      "heapUsedBytes": 61013424,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 114.95000000000002,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.5239999999976,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 37.799,
      "layouts": 18,
      "layoutDurationMs": 5.628,
      "taskDurationMs": 842.8259999999999,
      "heapDeltaBytes": -11929500,
      "heapUsedBytes": 60109800,
      "domNodes": -300,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 112.83000000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1421.8270000000075,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 31.651999999999994,
      "layouts": 14,
      "layoutDurationMs": 15.620000000000003,
      "taskDurationMs": 940.5020000000002,
      "heapDeltaBytes": -7427552,
      "heapUsedBytes": 85720160,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 30.613999999999994,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8448.916999999994,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 33.287,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5785.490000000001,
      "heapDeltaBytes": 12414200,
      "heapUsedBytes": 88169000,
      "domNodes": -272,
      "jsHeapTotalBytes": -1429504,
      "scriptDurationMs": 2682.41,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8711.317000000008,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.636,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5878.019,
      "heapDeltaBytes": 14777216,
      "heapUsedBytes": 89758184,
      "domNodes": -273,
      "jsHeapTotalBytes": 1191936,
      "scriptDurationMs": 2699.991,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16826.17799999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16321.8,
      "heapDeltaBytes": -34675800,
      "heapUsedBytes": 175168176,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5267456,
      "scriptDurationMs": 317.415,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17523.473999999966,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16828.892000000003,
      "heapDeltaBytes": -38237584,
      "heapUsedBytes": 174987964,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8577024,
      "scriptDurationMs": 272.455,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20958.417999999994,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 17.69000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20550.797,
      "heapDeltaBytes": -49918680,
      "heapUsedBytes": 162399748,
      "domNodes": -6552,
      "jsHeapTotalBytes": -6225920,
      "scriptDurationMs": 909.4599999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 81,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21746.196000000054,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 19.299999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21350.426000000003,
      "heapDeltaBytes": -31229952,
      "heapUsedBytes": 182087616,
      "domNodes": -6549,
      "jsHeapTotalBytes": -7528448,
      "scriptDurationMs": 987.338,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 162,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6215.015999999991,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.98099999999997,
      "layouts": 20,
      "layoutDurationMs": 21.78699999999999,
      "taskDurationMs": 6096.302000000001,
      "heapDeltaBytes": -28300000,
      "heapUsedBytes": 174808288,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9576448,
      "scriptDurationMs": 136.37699999999998,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 441,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6309.605999999917,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.16799999999996,
      "layouts": 20,
      "layoutDurationMs": 28.663999999999994,
      "taskDurationMs": 6169.854,
      "heapDeltaBytes": -34654176,
      "heapUsedBytes": 173273256,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4907008,
      "scriptDurationMs": 109.606,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 347,
      "frameDurationMs": 18.329999999999988,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 112.25600000000213,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 13.462000000000002,
      "layouts": 3,
      "layoutDurationMs": 0.968,
      "taskDurationMs": 80.769,
      "heapDeltaBytes": 3244832,
      "heapUsedBytes": 70790964,
      "domNodes": 110,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 6.765000000000001,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 110.96199999997225,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 11.551,
      "layouts": 2,
      "layoutDurationMs": 0.8600000000000001,
      "taskDurationMs": 73.67099999999999,
      "heapDeltaBytes": 3145788,
      "heapUsedBytes": 70743192,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.510999999999999,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions
github-actions Bot requested a review from DrJKL September 1, 2026 03:11
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...orm/workspace/utils/pendingSubscriptionCheckout.ts 80.00% 1 Missing ⚠️
@@              Coverage Diff               @@
##           cloud/1.53   #16457      +/-   ##
==============================================
+ Coverage       81.28%   83.26%   +1.97%     
==============================================
  Files            2411     2023     -388     
  Lines          123651   116957    -6694     
  Branches        33960    33033     -927     
==============================================
- Hits           100513    97384    -3129     
+ Misses          22535    19218    -3317     
+ Partials          603      355     -248     
Flag Coverage Δ
e2e 66.62% <8.33%> (-0.02%) ⬇️
unit 76.50% <100.00%> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../subscription/composables/useSubscriptionDialog.ts 91.26% <100.00%> (-0.09%) ⬇️
...m/workspace/composables/useSubscriptionCheckout.ts 89.15% <100.00%> (-0.02%) ⬇️
...platform/workspace/stores/billingOperationStore.ts 92.82% <100.00%> (ø)
...orm/workspace/utils/pendingSubscriptionCheckout.ts 89.55% <80.00%> (-0.78%) ⬇️

... and 396 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 47dc994 into cloud/1.53 Sep 1, 2026
108 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16120-to-cloud-1.53 branch September 1, 2026 03:46
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants