Skip to content

[backport cloud/1.52] fix(billing): keep the pending checkout pointer until the operation is terminal - #16455

Merged
comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16120-to-cloud-1.52
Sep 1, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16120-to-cloud-1.52

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16120 to cloud/1.52

Automatically created by backport workflow.

…s terminal (#16120)

## Summary

The stored `comfy:pending-subscription-checkout` pointer was dropped
after a single resume attempt, so a customer who reloaded twice during a
3DS challenge lost the handle to their own in-flight subscription
operation and then hit `SUBSCRIPTION_CHANGE_IN_PROGRESS` with nothing to
resume or cancel. Fixes FE-1921.

## Changes

- **What**: Clear the pointer only once the billing operation reaches a
status that is terminal for client polling — `succeeded`, `failed`, or
`reconciliation_needed` — replacing the blanket `finally` in
`resumePendingCheckout` and `advanceToSuccessOnOperation`. `pending` and
`timeout` now retain it: a client-side timeout is this tab giving up
rather than the server finishing, and an operation awaiting bank
authentication stays pending for hours.
- **What**: `billingOperationStore.pollOnce` now checks `response.status
=== 'reconciliation_needed'` regardless of `embeddedCheckoutEnabled`.
Previously this whole branch was flag-gated, so a `status:
'reconciliation_needed'` response on the legacy (flag-off) path fell
through to `scheduleNextPoll` and only ever resolved as a client
`timeout`. With the terminal-status set above now retaining the pointer
on `timeout`, that would have re-polled an already-settled operation to
timeout on every reload for the rest of the session — the same defect
this PR fixes, inverted. Moving the `status` check outside the flag gate
resolves it as `reconciliation_needed` immediately on both paths, and
surfaces `handleReconciliationNeeded`'s
`stage:'failed'`/`failure_category:'reconciliation_needed'` telemetry on
the legacy path for the first time. `authentication_state ===
'reconciliation_needed'` remains flag-gated: with the flag off the
frontend doesn't read `authentication_state` at all, matching existing
behavior for every other value of that field.

## Review Focus

- Both call sites lost their `try/finally`, so a throw from
`startOperation` also leaves the pointer in place now. That is
deliberate, for the same reason `timeout` does, but it is a change in
failure handling worth a look.
- `reconciliation_needed` is grouped with the terminal statuses on
purpose. The operation contract calls it terminal for client polling,
and `handleReconciliationNeeded` stops polling and resolves, so
retaining the pointer would re-poll a settled operation and re-emit its
failure telemetry on every reload.
- FE-1921's second half — recovering the blocking operation id from the
409 body — is deliberately not in this PR. Attributing that operation's
outcome to the selection the server just rejected would render the
success screen with the wrong tier and cycle, and BE-10062 has not yet
defined what the refusal returns. It lands with that ticket.
@github-actions

github-actions Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/01/2026, 03:12:44 AM UTC

Links

🎭 Playwright: ✅ 1985 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1964 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 106ms TBT · 84.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.8 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 38ms TBT · 184.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 420ms
canvas-idle: script duration 6ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.2 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -167
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 26ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 72
canvas-mouse-sweep: task duration 701ms
canvas-mouse-sweep: script duration 76ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.1 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -151
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 284ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 63.1 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 282ms
dom-widget-clipping: script duration 40ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.1 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 509ms
large-graph-idle: script duration 14ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 66.3 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 16ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 968ms
large-graph-pan: script duration 259ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 78.8 MB
large-graph-pan: DOM nodes -278
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1163ms
large-graph-zoom: script duration 301ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 60.5 MB
large-graph-zoom: DOM nodes -288
large-graph-zoom: event listeners -183
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1073ms
legacy-node-drag: script duration 327ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 66.6 MB
legacy-node-drag: DOM nodes 14
legacy-node-drag: event listeners 185
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 506ms
minimap-idle: script duration 13ms
minimap-idle: TBT 0ms
minimap-idle: heap used 65.3 MB
minimap-idle: DOM nodes -281
minimap-idle: event listeners -164
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 295ms
subgraph-dom-widget-clipping: script duration 85ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.0 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 5ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 405ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.3 MB
subgraph-idle: DOM nodes -284
subgraph-idle: event listeners -151
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 648ms
subgraph-mouse-sweep: script duration 63ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.9 MB
subgraph-mouse-sweep: DOM nodes -281
subgraph-mouse-sweep: event listeners -167
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 9ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 707ms
subgraph-transition-enter: script duration 12ms
subgraph-transition-enter: TBT 106ms
subgraph-transition-enter: heap used 84.7 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3336ms
viewport-pan-sweep: script duration 816ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 70.7 MB
viewport-pan-sweep: DOM nodes -278
viewport-pan-sweep: event listeners -148
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12435ms
vue-large-graph-idle: script duration 99ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 161.8 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16393
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 95
vue-large-graph-pan: task duration 15288ms
vue-large-graph-pan: script duration 404ms
vue-large-graph-pan: TBT 38ms
vue-large-graph-pan: heap used 184.1 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16390
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 16
workflow-execution: task duration 93ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 64.4 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-09-01T03:22:30.424Z",
  "gitSha": "045dd7f9c0b5c8bd08866ead8d3a7c24a5d0f623",
  "branch": "backport-16120-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2020.7980000000134,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.718000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 420.416,
      "heapDeltaBytes": -6653948,
      "heapUsedBytes": 55836968,
      "domNodes": -281,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 6.163,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2015.3889999999706,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.922999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 419.25100000000003,
      "heapDeltaBytes": -349080,
      "heapUsedBytes": 62036432,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.271000000000001,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1758.2709999999793,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 29.790000000000003,
      "layouts": 12,
      "layoutDurationMs": 2.9190000000000005,
      "taskDurationMs": 768.2679999999999,
      "heapDeltaBytes": 17762692,
      "heapUsedBytes": 80122376,
      "domNodes": -282,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 84.23700000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1702.8080000000045,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 21.852000000000004,
      "layouts": 12,
      "layoutDurationMs": 2.28,
      "taskDurationMs": 633.57,
      "heapDeltaBytes": -6566824,
      "heapUsedBytes": 56316560,
      "domNodes": -282,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 68.42499999999998,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1670.4499999999598,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 13.084999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.6259999999999999,
      "taskDurationMs": 291.497,
      "heapDeltaBytes": 3284640,
      "heapUsedBytes": 66166024,
      "domNodes": 79,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 8.092,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1672.0379999999295,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 11.446000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.526,
      "taskDurationMs": 275.722,
      "heapDeltaBytes": 2888164,
      "heapUsedBytes": 66175860,
      "domNodes": 78,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 7.6819999999999995,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 487.39700000004405,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.085000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 272.19000000000005,
      "heapDeltaBytes": 10934916,
      "heapUsedBytes": 73432828,
      "domNodes": 18,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 38.634,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 501.1470000000031,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.9449999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 291.02399999999994,
      "heapDeltaBytes": 10871048,
      "heapUsedBytes": 73540104,
      "domNodes": 20,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 42.349,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.722999999985,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.644999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 509.675,
      "heapDeltaBytes": -12517012,
      "heapUsedBytes": 64819948,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 16.121999999999996,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.7229999999945,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.104,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.857,
      "heapDeltaBytes": -2903096,
      "heapUsedBytes": 74270220,
      "domNodes": -273,
      "jsHeapTotalBytes": -532480,
      "scriptDurationMs": 12.680999999999997,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2107.3470000000043,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 17.034,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 971.46,
      "heapDeltaBytes": 12946604,
      "heapUsedBytes": 90959252,
      "domNodes": -284,
      "jsHeapTotalBytes": 4673536,
      "scriptDurationMs": 257.90799999999996,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2092.0039999999744,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.94,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 965.0210000000002,
      "heapDeltaBytes": -4287260,
      "heapUsedBytes": 74233444,
      "domNodes": -271,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 259.427,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3117.0459999999593,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.947999999999999,
      "layouts": 60,
      "layoutDurationMs": 8.106,
      "taskDurationMs": 1148.8170000000002,
      "heapDeltaBytes": -15293992,
      "heapUsedBytes": 63422660,
      "domNodes": -288,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 293.586,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3119.004000000018,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.237,
      "layouts": 60,
      "layoutDurationMs": 8.09,
      "taskDurationMs": 1176.905,
      "heapDeltaBytes": -15318700,
      "heapUsedBytes": 63405984,
      "domNodes": -287,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 307.831,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2108.526999999981,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.9030000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1078.9119999999998,
      "heapDeltaBytes": -17552680,
      "heapUsedBytes": 69877136,
      "domNodes": 14,
      "jsHeapTotalBytes": 8687616,
      "scriptDurationMs": 334.156,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2103.2670000000735,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.948000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1066.4909999999998,
      "heapDeltaBytes": -17509004,
      "heapUsedBytes": 69889644,
      "domNodes": 14,
      "jsHeapTotalBytes": 9736192,
      "scriptDurationMs": 320.295,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2014.5330000000286,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.955999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.36,
      "heapDeltaBytes": -12377128,
      "heapUsedBytes": 65958740,
      "domNodes": -285,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 12.860000000000003,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2036.0170000000153,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.431000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 503.96,
      "heapDeltaBytes": -12270976,
      "heapUsedBytes": 70971472,
      "domNodes": -276,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 12.944,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 506.5479999999525,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.415,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 303.986,
      "heapDeltaBytes": 11930008,
      "heapUsedBytes": 74437092,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 86.211,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 512.4510000000555,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 6.105999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 286.576,
      "heapDeltaBytes": 11751040,
      "heapUsedBytes": 74503624,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 83.29800000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.9380000000046,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.597000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.23600000000005,
      "heapDeltaBytes": 18528316,
      "heapUsedBytes": 80957800,
      "domNodes": -284,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 5.826999999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1992.9469999999583,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.919,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.27099999999996,
      "heapDeltaBytes": -6891356,
      "heapUsedBytes": 55970876,
      "domNodes": -283,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 6.092999999999997,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.3460000000296,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 26.467000000000002,
      "layouts": 16,
      "layoutDurationMs": 3.4939999999999998,
      "taskDurationMs": 649.194,
      "heapDeltaBytes": 18894560,
      "heapUsedBytes": 81825716,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 61.915,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.5009999999693,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 26.04,
      "layouts": 16,
      "layoutDurationMs": 3.352,
      "taskDurationMs": 646.758,
      "heapDeltaBytes": -529596,
      "heapUsedBytes": 62691108,
      "domNodes": -282,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 63.222,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 898.4220000000391,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 24.444000000000006,
      "layouts": 15,
      "layoutDurationMs": 9.445,
      "taskDurationMs": 706.596,
      "heapDeltaBytes": -6144324,
      "heapUsedBytes": 88842516,
      "domNodes": 13673,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 12.117999999999997,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 106,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8088.354999999979,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.888,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3354.468,
      "heapDeltaBytes": -5812156,
      "heapUsedBytes": 70529828,
      "domNodes": -282,
      "jsHeapTotalBytes": 4935680,
      "scriptDurationMs": 816.3320000000001,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8104.755000000068,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 36.457,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3316.814,
      "heapDeltaBytes": 202764,
      "heapUsedBytes": 77667956,
      "domNodes": -273,
      "jsHeapTotalBytes": -569344,
      "scriptDurationMs": 815.197,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12850.797,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12351.531,
      "heapDeltaBytes": -36439232,
      "heapUsedBytes": 176018316,
      "domNodes": -8312,
      "jsHeapTotalBytes": -30449664,
      "scriptDurationMs": 96.62099999999998,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13050.475000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12517.612,
      "heapDeltaBytes": -53332668,
      "heapUsedBytes": 163250592,
      "domNodes": -8312,
      "jsHeapTotalBytes": -18898944,
      "scriptDurationMs": 101.145,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15794.144999999957,
      "styleRecalcs": 93,
      "styleRecalcDurationMs": 15.548000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15216.715999999999,
      "heapDeltaBytes": -18968532,
      "heapUsedBytes": 193065364,
      "domNodes": -8312,
      "jsHeapTotalBytes": -17195008,
      "scriptDurationMs": 393.948,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 71,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16003.702000000088,
      "styleRecalcs": 96,
      "styleRecalcDurationMs": 15.154,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15359.083999999999,
      "heapDeltaBytes": -32809948,
      "heapUsedBytes": 192950936,
      "domNodes": -8312,
      "jsHeapTotalBytes": -17412096,
      "scriptDurationMs": 413.59700000000004,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 459.7269999999867,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 18.628,
      "layouts": 3,
      "layoutDurationMs": 1.126,
      "taskDurationMs": 108.366,
      "heapDeltaBytes": 5250996,
      "heapUsedBytes": 68089112,
      "domNodes": 150,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.061999999999998,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 434.6490000000358,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 14.225999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.6529999999999999,
      "taskDurationMs": 77.733,
      "heapDeltaBytes": 4991380,
      "heapUsedBytes": 66986244,
      "domNodes": 123,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.5180000000000025,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@github-actions
github-actions Bot requested a review from DrJKL September 1, 2026 03:11
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...orm/workspace/utils/pendingSubscriptionCheckout.ts 80.00% 1 Missing ⚠️
@@              Coverage Diff               @@
##           cloud/1.52   #16455      +/-   ##
==============================================
+ Coverage       79.63%   82.02%   +2.39%     
==============================================
  Files            2242     1912     -330     
  Lines          115074   110076    -4998     
  Branches        33391    31715    -1676     
==============================================
- Hits            91642    90293    -1349     
+ Misses          22952    19441    -3511     
+ Partials          480      342     -138     
Flag Coverage Δ
e2e 66.09% <8.33%> (-0.04%) ⬇️
unit 74.05% <100.00%> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../subscription/composables/useSubscriptionDialog.ts 91.26% <100.00%> (-0.09%) ⬇️
...m/workspace/composables/useSubscriptionCheckout.ts 89.15% <100.00%> (-0.02%) ⬇️
...platform/workspace/stores/billingOperationStore.ts 92.82% <100.00%> (ø)
...orm/workspace/utils/pendingSubscriptionCheckout.ts 89.55% <80.00%> (-0.78%) ⬇️

... and 338 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot added this pull request to the merge queue Sep 1, 2026
Merged via the queue into cloud/1.52 with commit 4e01a48 Sep 1, 2026
90 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16120-to-cloud-1.52 branch September 1, 2026 04:10
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants