Repository navigation
fix(billing): drop the state card once a subscription has ended - #16442
comfydesigner wants to merge 1 commit into
Conversation
The amber card fired for cancelled and ended alike. Cancelled earns it: the plan is still running and the card names the date features stop. Ended does not — the panel heading, the plan status and the credits tile already say so, and a fourth telling in alarm colour outranks the payment-failed banner while carrying less urgency. Gates the card on cancelled-but-still-running and removes the ended strings, which no longer have a caller.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1892 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.63 MB gzip 🟢 -289 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 16 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.2 MB (baseline 16.2 MB) • 🟢 -1.97 kBBundles that do not match a named category
Status: 92 added / 92 removed / 202 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-01T00:19:40.624Z",
"gitSha": "9290479c40a6a651ee676bd08cd5511bdd6c7c7c",
"branch": "comfydesigner/drop-ended-state-card",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.6079999999338,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.259,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.137,
"heapDeltaBytes": -7481072,
"heapUsedBytes": 56703820,
"domNodes": -282,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.100999999999999,
"eventListeners": -215,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2003.1360000000404,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.702999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.752,
"heapDeltaBytes": 5776256,
"heapUsedBytes": 69569084,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.9499999999999975,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1894.2439999999579,
"styleRecalcs": 69,
"styleRecalcDurationMs": 21.203,
"layouts": 14,
"layoutDurationMs": 3.1990000000000003,
"taskDurationMs": 745.63,
"heapDeltaBytes": 23821496,
"heapUsedBytes": 88562696,
"domNodes": 52,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 92.22,
"eventListeners": 6,
"totalBlockingTimeMs": 155,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1738.4859999999662,
"styleRecalcs": 74,
"styleRecalcDurationMs": 22.85,
"layouts": 14,
"layoutDurationMs": 3.161,
"taskDurationMs": 594.039,
"heapDeltaBytes": 2856316,
"heapUsedBytes": 72028984,
"domNodes": -278,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 88.435,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.305999999935,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.052000000000001,
"layouts": 6,
"layoutDurationMs": 1.0139999999999998,
"taskDurationMs": 246.29999999999998,
"heapDeltaBytes": 4116712,
"heapUsedBytes": 73513528,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.339999999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.2290000000057,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.198,
"layouts": 6,
"layoutDurationMs": 0.852,
"taskDurationMs": 238.058,
"heapDeltaBytes": 3815488,
"heapUsedBytes": 68095600,
"domNodes": 77,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7.970999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 577.2379999999657,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.183,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.099,
"heapDeltaBytes": 17807724,
"heapUsedBytes": 87712460,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 96.954,
"eventListeners": 0,
"totalBlockingTimeMs": 41,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 519.5700000000443,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.018000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.287,
"heapDeltaBytes": 17848268,
"heapUsedBytes": 87930724,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 101.524,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2018.318000000022,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.725000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.729,
"heapDeltaBytes": -13129820,
"heapUsedBytes": 86559788,
"domNodes": -266,
"jsHeapTotalBytes": -1613824,
"scriptDurationMs": 22.091,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.0690000000022,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.6679999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.551,
"heapDeltaBytes": -12811408,
"heapUsedBytes": 86939348,
"domNodes": -266,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 27.61999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2058.6530000000494,
"styleRecalcs": 64,
"styleRecalcDurationMs": 5.811,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1012.911,
"heapDeltaBytes": 22705032,
"heapUsedBytes": 88747328,
"domNodes": -7,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 483.771,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2075.4670000000033,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1050.6129999999998,
"heapDeltaBytes": 23025508,
"heapUsedBytes": 88893784,
"domNodes": -272,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 494.804,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3041.317000000049,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.7390000000000025,
"layouts": 60,
"layoutDurationMs": 8.622000000000002,
"taskDurationMs": 1082.1520000000003,
"heapDeltaBytes": 9149856,
"heapUsedBytes": 75601000,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 449.881,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3070.6279999999424,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.658,
"layouts": 60,
"layoutDurationMs": 9.584999999999999,
"taskDurationMs": 1133.439,
"heapDeltaBytes": 8494876,
"heapUsedBytes": 75852316,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 478.30400000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2132.1380000000545,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.535000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1192.444,
"heapDeltaBytes": 18626056,
"heapUsedBytes": 86037916,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 556.6340000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2137.646000000018,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.433000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1194.235,
"heapDeltaBytes": 17713384,
"heapUsedBytes": 84316144,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 550.057,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.765999999895,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.9839999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.65999999999997,
"heapDeltaBytes": 22071072,
"heapUsedBytes": 87870668,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.537999999999993,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2029.5139999999492,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.490999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.41299999999995,
"heapDeltaBytes": 10403364,
"heapUsedBytes": 86999756,
"domNodes": -269,
"jsHeapTotalBytes": -1388544,
"scriptDurationMs": 19.485999999999997,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 425.0450000000683,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.050000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 265.309,
"heapDeltaBytes": 14049648,
"heapUsedBytes": 86012928,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 83.142,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 442.17700000001514,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.223999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.948,
"heapDeltaBytes": 14276200,
"heapUsedBytes": 86083420,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 83.54899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1990.2650000000222,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.219,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.185,
"heapDeltaBytes": 4638184,
"heapUsedBytes": 76902104,
"domNodes": -298,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.648999999999999,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2002.4140000000443,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.802000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.945,
"heapDeltaBytes": -9260948,
"heapUsedBytes": 62692812,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.206999999999998,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.7010000000328,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.185999999999996,
"layouts": 18,
"layoutDurationMs": 2.9090000000000003,
"taskDurationMs": 557.928,
"heapDeltaBytes": 2558444,
"heapUsedBytes": 74989900,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 61.809000000000005,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.200000000047,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.647000000000002,
"layouts": 18,
"layoutDurationMs": 4.409000000000001,
"taskDurationMs": 592.588,
"heapDeltaBytes": -11754020,
"heapUsedBytes": 60110852,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 71.39,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.2470000000067,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.134999999999994,
"layouts": 16,
"layoutDurationMs": 9.459999999999999,
"taskDurationMs": 642.522,
"heapDeltaBytes": -1806936,
"heapUsedBytes": 95540280,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 20.185000000000002,
"eventListeners": 2381,
"totalBlockingTimeMs": 88,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8171.058000000016,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.25,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3800.5739999999996,
"heapDeltaBytes": -14249320,
"heapUsedBytes": 80214812,
"domNodes": -266,
"jsHeapTotalBytes": 4378624,
"scriptDurationMs": 1630.768,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8132.97799999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 25.51,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3781.743,
"heapDeltaBytes": -9740368,
"heapUsedBytes": 90195800,
"domNodes": -266,
"jsHeapTotalBytes": -864256,
"scriptDurationMs": 1675.535,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10261.257000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9274.406,
"heapDeltaBytes": -34642756,
"heapUsedBytes": 181674788,
"domNodes": -6548,
"jsHeapTotalBytes": 9433088,
"scriptDurationMs": 134.4,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 9956.961999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8926.972,
"heapDeltaBytes": -35034408,
"heapUsedBytes": 174156836,
"domNodes": -6548,
"jsHeapTotalBytes": -8028160,
"scriptDurationMs": 143.215,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666673,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12790.947000000073,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.02399999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12088.100999999999,
"heapDeltaBytes": -21718132,
"heapUsedBytes": 182541220,
"domNodes": -6548,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 612.8359999999999,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12739.684000000012,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.941000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12000.473,
"heapDeltaBytes": -43463156,
"heapUsedBytes": 164220056,
"domNodes": -6548,
"jsHeapTotalBytes": -2904064,
"scriptDurationMs": 622.501,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3676.2220000000525,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.515999999999984,
"layouts": 20,
"layoutDurationMs": 19.439999999999998,
"taskDurationMs": 3535.0409999999997,
"heapDeltaBytes": -32926888,
"heapUsedBytes": 181519124,
"domNodes": -6548,
"jsHeapTotalBytes": 12861440,
"scriptDurationMs": 53.26299999999999,
"eventListeners": -7475,
"totalBlockingTimeMs": 52,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3552.599999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.301000000000016,
"layouts": 20,
"layoutDurationMs": 18.338999999999995,
"taskDurationMs": 3402.887,
"heapDeltaBytes": -10660996,
"heapUsedBytes": 178196720,
"domNodes": -6548,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 51.629000000000005,
"eventListeners": -7475,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 453.5710000000108,
"styleRecalcs": 17,
"styleRecalcDurationMs": 17.116,
"layouts": 5,
"layoutDurationMs": 1.841,
"taskDurationMs": 99.268,
"heapDeltaBytes": 5353752,
"heapUsedBytes": 68800460,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.928,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 462.9019999999855,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.602,
"layouts": 3,
"layoutDurationMs": 2.032,
"taskDurationMs": 100.612,
"heapDeltaBytes": 5267168,
"heapUsedBytes": 72800664,
"domNodes": 150,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.507000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (19)
💤 Files with no reviewable changes (14)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe subscription panel now hides its state card after a subscription ends. It retains the cancellation card while cancellation is still running, updates localized keys, and adjusts component and browser tests. ChangesSubscription state handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This removes a redundant ended-subscription notice while preserving the notice for cancelled plans that are still running; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list and PR description are available, and the PR changes Full details: Website End-To-End Regression CoverageExplanation The changed-file list contains browser tests, locale files, and workspace subscription component files under Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed-file list contains subscription UI, tests, and locale files only. It contains no files under Full details: Description checkExplanation The description explains the motivation, implementation, affected locales, tests, and linked issue. It does not use every template heading, but it provides the required change and review context and is mostly complete.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16442 +/- ##
==========================================
+ Coverage 81.25% 83.25% +2.00%
==========================================
Files 2403 2022 -381
Lines 123470 116944 -6526
Branches 34516 32447 -2069
==========================================
- Hits 100322 97366 -2956
+ Misses 22555 19222 -3333
+ Partials 593 356 -237
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 391 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…(FE-1962) (Comfy-Org#16521) Closes FE-1962. ## Why this is needed `SubscriptionPanelContentWorkspace.vue` shows an amber card above the plan panel for a cancelled **or** an ended subscription. Cancelled earns it: the plan is still running and the card names the date features stop — a heads-up with a deadline. Ended does not. By then the panel heading, the plan status and the credits tile all say the plan is over, and the card is a fourth telling of the same fact. ## Root cause The gate never distinguished "winding down" from "already over": ```ts const showSubscriptionStateCard = computed( () => isSubscriptionCancelled.value || isSubscriptionEnded.value ) ``` It is the wrong treatment, not merely redundant: - `border-warning-background` over `bg-warning-background/20` makes it the **loudest element in the settings panel**, which puts a terminal, non-actionable state *above the payment-failed banner* in the visual hierarchy. - It pairs that warning fill with `pi-info-circle` — the icon our own convention reserves for notices rather than problems. The sibling `BillingStatusBanner` follows that convention correctly: a muted circle for `ending`, amber triangles only for paused / payment-failed / out-of-credits. This card is the outlier. - It has **no design of record.** No workspace-settings frame in the Figma file contains it; it was built without one. ## How this changes ```ts const showSubscriptionStateCard = computed( () => isSubscriptionCancelled.value && !isSubscriptionEnded.value ) ``` The ended state is carried by a `planStatusBadge` on the plan name instead — **Inactive** (`secondary`) once the subscription has ended, **Canceled** (`warn`) while a cancelled plan is still running. That includes an ended Personal workspace: when it cannot self-serve it falls through to the subscribed branch, which without the badge rendered the old paid plan name, its monthly price and a Cancel plan entry with nothing marking it ended. `subscription.canceledCard.endedTitle` and `endedDescription` lose their only caller and are removed from all locales; the remaining description collapses to the with-date / without-date pair. The badge keys on the server's subscription state; no frontend-composed status is introduced. ## AS IS / TO BE Captured in the real app (`pnpm dev:cloud`), not Storybook. The workspace is a sales-managed Enterprise team whose subscription has **ended** — the state this PR changes. Billing endpoints are mocked through the repo's own `CloudWorkspaceMockHelper` with `ENDED_ENTERPRISE_STATUS`, so the panel renders off the server's `subscription_status`, not a hand-set frontend flag. ### Ended subscription — the state this changes | AS IS | TO BE | | --- | --- | | <img width="575" alt="AS IS — amber ended-subscription card above the plan" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/635e5f05a65800eb9327787fcfe4aefc6040aa77/as-is-ended.png"> | <img width="575" alt="TO BE — Inactive badge on the plan name, no card" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/635e5f05a65800eb9327787fcfe4aefc6040aa77/to-be-ended.png"> | | The amber card is the loudest thing in the panel, for a state that is terminal and offers no action. The plan row beneath it and the credits tile already carry the same fact. | The plan name takes an `Inactive` badge (`secondary`). Same fact, stated once, at the weight a settled state deserves. | ### Cancelled but still running — unchanged <img width="575" alt="Cancelled plan still running — card and Canceled badge both retained" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/635e5f05a65800eb9327787fcfe4aefc6040aa77/unchanged-cancelled-running.png"> The heads-up with a deadline is the case that earns the card, and it keeps it. Captures of this state before and after the change are byte-identical (`md5 ca6f9e18afc520029f6b68d02653d6af`), so the amber treatment moved off the ended state without being weakened where it belongs. ## Test coverage Four unit assertions and two Playwright specs had used the card's title as a proxy for "the workspace is in the ended state" rather than testing the card itself. They now assert its **absence**, and a new test pins that a cancelled-but-still-running plan keeps the card — otherwise nothing stops the card being gated away entirely later. - `SubscriptionPanelContentWorkspace.test.ts` — badge label and severity via `data-testid="plan-status-badge"`; card absent when ended, with and without an end date; card retained for cancelled-and-running; ended Enterprise marked inactive without the card. - `browser_tests/tests/dialogs/creditsTile.spec.ts`, `enterpriseTierCloud.spec.ts` — updated off the card copy. Verified locally on this branch: - **Unit** — 59/59 in `SubscriptionPanelContentWorkspace.test.ts`, and 1395/1395 across `src/platform/workspace` for collateral. - **E2E** — 17/17 in the two touched cloud specs (`creditsTile`, `enterpriseTierCloud`), run against `pnpm dev:cloud` with `PLAYWRIGHT_TEST_URL=http://localhost:5173`. The `@cloud` project needs no local ComfyUI backend: `CloudWorkspaceMockHelper` mocks the workspace, billing and auth endpoints. An earlier revision of this description said otherwise — that was wrong. - **Static** — `pnpm typecheck` and `eslint` clean on the changed files. - **i18n** — `endedTitle` / `endedDescription` have no remaining references in `src` or `browser_tests`; `subscription.inactive.badge` is present and translated in all 15 locales, nesting into the existing `subscription.inactive` group. ## Notes for review - Refers to the design prototype Comfy-Org#16442 rather than building on it, per our convention. - **Comfy-Org#16520 / FE-1961 touches the same file.** Both branches add a plan status badge to `SubscriptionPanelContentWorkspace.vue` and will conflict; they also introduce the badge string under different keys (`subscription.inactive.badge` here, `subscription.inactiveBadge` there). Whichever merges second should rebase and collapse the two keys into one. FE-1961 is the larger change, so merging it first and rebasing this one is the cheaper order. - **PR Comfy-Org#16515 is currently mis-linked to FE-1962** in Linear ("FE-1962 fix(billing): restore legacy subscription quote display"). Its diff is the legacy quote-preview fix and shares no files with this ticket. That attachment and title prefix want correcting — this PR is the actual FE-1962 work.
The amber state card above the plan panel fired for cancelled and ended alike:
Cancelled earns it. The plan is still running, and the card names the date features stop — that is a heads-up with a deadline.
Ended does not. By then the panel heading, the plan status and the credits tile all say the plan is over, and the card is a fourth telling of the same fact. It is also the loudest element in the settings panel — an amber border over a 20% amber fill — which puts a terminal, non-actionable state above the payment-failed banner in the visual hierarchy. It pairs that fill with
pi-info-circle, the icon our own convention reserves for notices rather than problems.It also has no design of record: no Figma frame for the workspace settings panel includes it.
Change
Gates the card on cancelled-but-still-running.
endedTitleandendedDescriptionlose their only caller and are removed from all 15 locales.Tests
Four unit assertions used the card's copy as a proxy for "we are in the ended state" and now assert its absence; the ended-copy test becomes a removal test, and a new test pins that a cancelled plan still shows the card while it runs. Two Playwright specs updated the same way.