Repository navigation
feat(billing): fold the plans link into the Plan & Credits footer row - #16436
Conversation
Moves 'View more details about plans & pricing' out of its own block above the footer and into the footer's action row as 'Plans & pricing', styled like its neighbours. Drops the divider above the row, and removes 'Learn more', which did not lead to a useful resource. Gated by a showPlansLink prop with a viewPlans emit, mirroring the existing showUsageActivity pattern so the pricing-surface permission stays with the panel that owns it.
🎭 Playwright: ✅ 1888 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.63 MB gzip 🔴 +27 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 16 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.2 MB (baseline 16.2 MB) • 🟢 -377 BBundles that do not match a named category
Status: 78 added / 78 removed / 216 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-31T23:32:41.213Z",
"gitSha": "aad9640e0d0e3711bd14111a3e0280ca1726860e",
"branch": "comfydesigner/plan-credits-footer",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.3649999999657,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.84,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.021,
"heapDeltaBytes": -783588,
"heapUsedBytes": 68621532,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.249,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2031.8469999999706,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.94,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.2810000000001,
"heapDeltaBytes": -12386788,
"heapUsedBytes": 56926796,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.822999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2067.506999999978,
"styleRecalcs": 80,
"styleRecalcDurationMs": 44.602000000000004,
"layouts": 14,
"layoutDurationMs": 4.831,
"taskDurationMs": 1038.488,
"heapDeltaBytes": -6419728,
"heapUsedBytes": 63509808,
"domNodes": -283,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 173.86599999999999,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1863.3250000000317,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.036,
"layouts": 14,
"layoutDurationMs": 4.737,
"taskDurationMs": 883.3879999999999,
"heapDeltaBytes": -6168936,
"heapUsedBytes": 63280984,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 149.05900000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1680.3039999999783,
"styleRecalcs": 29,
"styleRecalcDurationMs": 16.687,
"layouts": 6,
"layoutDurationMs": 1.218,
"taskDurationMs": 397.79400000000004,
"heapDeltaBytes": 4647016,
"heapUsedBytes": 74433752,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.916999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.1619999999411,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.402,
"layouts": 6,
"layoutDurationMs": 1.106,
"taskDurationMs": 375.686,
"heapDeltaBytes": 4410448,
"heapUsedBytes": 74209372,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.894000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 692.9910000000064,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.9399999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.30499999999995,
"heapDeltaBytes": 18681216,
"heapUsedBytes": 81989648,
"domNodes": 14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 155.12599999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 680.6480000000192,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.274,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.826,
"heapDeltaBytes": 18803040,
"heapUsedBytes": 88094164,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 159.743,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.3909999999905,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.480000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.4910000000001,
"heapDeltaBytes": -13417952,
"heapUsedBytes": 86649872,
"domNodes": -268,
"jsHeapTotalBytes": -1613824,
"scriptDurationMs": 35.277,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2052.7989999999363,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.487000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.921,
"heapDeltaBytes": -13733944,
"heapUsedBytes": 86287216,
"domNodes": -268,
"jsHeapTotalBytes": -1613824,
"scriptDurationMs": 34.004999999999995,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2183.962000000008,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.628000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1584.804,
"heapDeltaBytes": 22092824,
"heapUsedBytes": 88047920,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 765.957,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2290.797999999995,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.813000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1688.5379999999998,
"heapDeltaBytes": -16335100,
"heapUsedBytes": 84658848,
"domNodes": -272,
"jsHeapTotalBytes": -1126400,
"scriptDurationMs": 784.942,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3611.479000000031,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.176999999999996,
"layouts": 60,
"layoutDurationMs": 13.373999999999999,
"taskDurationMs": 1726.336,
"heapDeltaBytes": 8164472,
"heapUsedBytes": 75815384,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 776.798,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3626.2140000000045,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.980999999999998,
"layouts": 60,
"layoutDurationMs": 13.513,
"taskDurationMs": 1732.6309999999999,
"heapDeltaBytes": 8774152,
"heapUsedBytes": 75787356,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 772.22,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3094.8430000000258,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.478999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1950.7,
"heapDeltaBytes": 24338164,
"heapUsedBytes": 92049208,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 979.84,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3107.5289999999995,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.495,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1907.104,
"heapDeltaBytes": 17420648,
"heapUsedBytes": 85036208,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 939.0029999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.7930000000033,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3180000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.8399999999999,
"heapDeltaBytes": -13974716,
"heapUsedBytes": 86488948,
"domNodes": -270,
"jsHeapTotalBytes": -1613824,
"scriptDurationMs": 40.867,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.8419999999314,
"styleRecalcs": 4,
"styleRecalcDurationMs": 5.462999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.162,
"heapDeltaBytes": -14583324,
"heapUsedBytes": 87498496,
"domNodes": -270,
"jsHeapTotalBytes": -1351680,
"scriptDurationMs": 34.458000000000006,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.2839999999687,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.168,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.73099999999994,
"heapDeltaBytes": 14103804,
"heapUsedBytes": 85940252,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.876,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.6840000000011,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.639999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.12600000000003,
"heapDeltaBytes": 13720268,
"heapUsedBytes": 85561316,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 143.31000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.316000000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.421,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.067,
"heapDeltaBytes": -9067156,
"heapUsedBytes": 63006100,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 8.243999999999998,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.4119999998984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.4860000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.022,
"heapDeltaBytes": -8660156,
"heapUsedBytes": 63227012,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.743,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.229000000048,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.477999999999994,
"layouts": 18,
"layoutDurationMs": 5.7909999999999995,
"taskDurationMs": 854.6270000000001,
"heapDeltaBytes": -12000620,
"heapUsedBytes": 59870140,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 113.69600000000003,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.3480000000263,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.596,
"layouts": 18,
"layoutDurationMs": 5.861999999999999,
"taskDurationMs": 839.1519999999999,
"heapDeltaBytes": -11364532,
"heapUsedBytes": 60621052,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 109.33500000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1414.7939999999153,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.910999999999994,
"layouts": 14,
"layoutDurationMs": 14.373999999999999,
"taskDurationMs": 983.0589999999999,
"heapDeltaBytes": 210828,
"heapUsedBytes": 97311640,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 32.414,
"eventListeners": 2381,
"totalBlockingTimeMs": 127,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8400.79000000003,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.419999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5741.249,
"heapDeltaBytes": -11322340,
"heapUsedBytes": 88504872,
"domNodes": -271,
"jsHeapTotalBytes": -864256,
"scriptDurationMs": 2562.986,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8516.814999999951,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.952,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5757.790999999999,
"heapDeltaBytes": -19548132,
"heapUsedBytes": 79816600,
"domNodes": -266,
"jsHeapTotalBytes": -1126400,
"scriptDurationMs": 2575.3749999999995,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18008.080000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17598.886,
"heapDeltaBytes": -33460212,
"heapUsedBytes": 176153384,
"domNodes": -6548,
"jsHeapTotalBytes": -2220032,
"scriptDurationMs": 300.64000000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18166.390999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17587.947999999997,
"heapDeltaBytes": -43866948,
"heapUsedBytes": 165464684,
"domNodes": -6548,
"jsHeapTotalBytes": -3870720,
"scriptDurationMs": 309.72099999999995,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22215.300999999956,
"styleRecalcs": 167,
"styleRecalcDurationMs": 23.19199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21943.794,
"heapDeltaBytes": -22395912,
"heapUsedBytes": 180839880,
"domNodes": -6548,
"jsHeapTotalBytes": 2494464,
"scriptDurationMs": 934.226,
"eventListeners": -7471,
"totalBlockingTimeMs": 156,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22640.934000000016,
"styleRecalcs": 171,
"styleRecalcDurationMs": 22.765000000000036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22329.565,
"heapDeltaBytes": -16472704,
"heapUsedBytes": 180718048,
"domNodes": -6548,
"jsHeapTotalBytes": 3850240,
"scriptDurationMs": 940.2660000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 116,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6561.335999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.58499999999997,
"layouts": 20,
"layoutDurationMs": 26.344000000000005,
"taskDurationMs": 6496.3240000000005,
"heapDeltaBytes": -21209996,
"heapUsedBytes": 188895836,
"domNodes": -6548,
"jsHeapTotalBytes": 11673600,
"scriptDurationMs": 122.29,
"eventListeners": -7471,
"totalBlockingTimeMs": 528,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6537.933000000066,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.67600000000002,
"layouts": 20,
"layoutDurationMs": 25.842000000000002,
"taskDurationMs": 6451.735000000001,
"heapDeltaBytes": -11097280,
"heapUsedBytes": 193091432,
"domNodes": -6548,
"jsHeapTotalBytes": 8724480,
"scriptDurationMs": 121.45200000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 497,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 109.37799999999243,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.2,
"layouts": 2,
"layoutDurationMs": 1.31,
"taskDurationMs": 74.51699999999998,
"heapDeltaBytes": 3142796,
"heapUsedBytes": 70760720,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.241999999999999,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 456.92700000006425,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.108999999999995,
"layouts": 3,
"layoutDurationMs": 0.99,
"taskDurationMs": 110.10700000000001,
"heapDeltaBytes": 5050544,
"heapUsedBytes": 72816576,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.789,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe subscription footer replaces the “Learn more” documentation link with an optional “Plans & pricing” link. The workspace subscription panel controls its visibility and handles the new ChangesSubscription footer plans link
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR makes a localized Plan & Credits footer layout and copy change; no actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant User
participant SubscriptionFooterLinks
participant SubscriptionPanelContentWorkspace
User->>SubscriptionFooterLinks: Click Plans & pricing
SubscriptionFooterLinks->>SubscriptionPanelContentWorkspace: Emit viewPlans
SubscriptionPanelContentWorkspace->>SubscriptionPanelContentWorkspace: Run handleViewMoreDetails
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description includes the required Summary, Changes, and Review Focus sections. It explains the functional changes, breaking-change status, dependency impact, consumer scope, and relevant implementation details. Full details: End-To-End Regression Coverage For FixesExplanation The changed-file information is available, but the PR title and commit subjects are not provided. The check requires a title or commit subject to establish bug-fix language, so the result cannot be determined without guessing. Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed files are locale, subscription component, and subscription test files. None are under
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16436 +/- ##
==========================================
+ Coverage 81.24% 83.26% +2.01%
==========================================
Files 2403 2022 -381
Lines 123470 116946 -6524
Branches 33920 32481 -1439
==========================================
- Hits 100317 97370 -2947
+ Misses 22553 19220 -3333
+ Partials 600 356 -244
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 400 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Status note (for tomorrow): Plan & Credits footer — divider removed, "Learn more" removed, and the plans link folded into the footer row as "Plans & pricing". CodeRabbit approved, no findings; smallest of the four and independently mergeable. |
dante01yoon
left a comment
There was a problem hiding this comment.
Approving. This is a presentation change with no business logic moved into the client, which is the thing I was looking for.
What I checked:
- The gate stayed put.
canOpenPricingSurfacestill comes fromuseWorkspaceUIand is still evaluated inSubscriptionPanelContentWorkspace, now passed down as:show-plans-linkinstead of wrapping an inline block.SubscriptionFooterLinksgains a boolean prop and aviewPlansemit and decides nothing — mirroringshowUsageActivityexactly as the description says. No policy inference moved into the shared footer. - The other consumer is safe.
showPlansLinkdefaults tofalse, soPlanCreditsPanelContentrenders unchanged apart from the divider/padding, which the description scopes deliberately. handleLearnMoreClickis genuinely still needed. ConfirmedApiNodesSignInContentstill calls it, so keeping it inuseSubscriptionActionswhile dropping the footer button is correct rather than dead code.- Orphaned strings.
subscription.learnMoreandsubscription.viewMoreDetailsPlanshave no remaining callers. - No conflict with my in-flight PRs, which I checked because we're both editing this file: #16436 touches only
SubscriptionPanelContentWorkspace.vueL382-403, while #16520 and #16521 touch L55-90, L220-236, L314-320 and L493+. Disjoint hunks, and theen/main.jsonkey removals are in different regions. No merge-order coordination needed.
One non-blocking note below.
Validation I did not run: no local unit run or app capture for this one — the change is markup plus prop plumbing and the updated SubscriptionFooterLinks.test.ts covers the new emit path, so I reviewed it by reading rather than executing. Flagging so you know the approval rests on reading, not a green local run.
| > | ||
| <div class="flex items-center justify-between pt-3 pb-6"> | ||
| <div class="flex gap-2"> | ||
| <Button |
There was a problem hiding this comment.
nit-pick (non-blocking): pb-6 lands on the shared root, so it reaches PlanCreditsPanelContent too. That reads intentional given both consumers are workspace Plan & Credits, and the description says as much — just noting it's the one change here that isn't gated by a prop, so if the two panels ever want different footer spacing this is the line that will need splitting.
Also worth knowing (pre-existing, not introduced here): SubscriptionPanelContentWorkspace passes class="mt-auto pt-6", which merges onto this root alongside pt-3. Two competing pt-* utilities resolve by stylesheet order rather than intent. Not yours to fix in this PR, but since you're already tidying this row it might be a cheap one to collapse.
There was a problem hiding this comment.
Both read right. The pb-6 on the root is intentional — both consumers are workspace Plan & Credits and want the same landing — and agreed it's the line to split if they ever diverge.
Good spot on the competing pt-*: today pt-6 wins purely by stylesheet order. Holding the collapse out of this PR since it's approved and the fix is pre-existing scope — the intent-preserving version (root drops pt-3, the local consumer passes it explicitly, rendered output unchanged) is a two-line follow-up once this lands.
Summary
Tidies the Plan & Credits footer: the plans link joins the footer's action row instead of sitting in its own block above it, the divider goes, and "Learn more" is removed.
Changes
SubscriptionFooterLinksgainsshowPlansLink+ aviewPlansemit, mirroring the existingshowUsageActivityprop so thecanOpenPricingSurfacegate and handler stay with the panel that owns them.subscription.plansAndPricing), styled identically to its neighbours —text-xs text-text-secondarywith an external-link icon — rather than the longer standalone phrasing.border-tdivider above the row.handleLearnMoreClickstays inuseSubscriptionActions—ApiNodesSignInContentstill uses it.subscription.learnMoreandsubscription.viewMoreDetailsPlansstrings.showPlansLinkdefaults tofalse, so the other consumer is unaffected.Review Focus
SubscriptionFooterLinkshas two consumers (SubscriptionPanelContentWorkspace,PlanCreditsPanelContent), both workspace Plan & Credits — the divider removal is scoped to those.