Skip to content

[agent-v1 16/18] feat(agent): canvas navigation and selection persistence - #16424

Closed
CodeJuggernaut wants to merge 11 commits into
nathaniel/agent-v1/15-lifetime-adapterfrom
nathaniel/agent-v1/16-canvas-navigation
Closed

CodeJuggernaut wants to merge 11 commits into
nathaniel/agent-v1/15-lifetime-adapterfrom
nathaniel/agent-v1/16-canvas-navigation

Conversation

@CodeJuggernaut

@CodeJuggernaut CodeJuggernaut commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Slice 16 of the agent-v1 extraction ladder (stacked on #16318).

Canvas navigation for the agent: the graph-canvas anchor contract (GRAPH_CANVAS_ANCHOR) with toast positioning against the canvas panel, the splitter overlay tests, node pointer-interaction updates for selection mode, and selection persistence across workflow loads via the extension's beforeLoadGraph/afterLoadGraph hooks (all agent chunks loaded dynamically past the cloud guard, keeping OSS builds agent-free).

Already restacked onto current main - the diff shows only this slice's own delta.

  • Refs: none

Review-audit deltas (salvage matrix): items found during the slicing and review audits that did not make it through the integration merge (#16198).

Canvas-navigation cut: anchor positioning contract, selection persistence across loads, binding tests.

Lands the slice-16 canvas-navigation surface on the post-cascade
tip. Core: the NodeSelectionModeBanner pair at canonical bytes,
GraphCanvas wiring, the toast-layer hide rule with GlobalToast's
hold-and-replay deferral and four tests, the agent.nodeSelection
locale block, and the delete-guard WHY comment.

Consumer sweep, derived from the store's canonical importer graph:
splitter panels, top-menu action bars, side toolbar, node switch
popup, and release toast all hide or defer during the mode; vue
nodes gain the in-mode outline, header checkbox, pointer guards,
context-menu suppression, and forceDisabled widget plumbing; the
canvas-info overlay suppresses via the existing watch idiom with
the mode as an explicit source (the watchEffect form regressed the
slot-read reactivity pin - its failing test is the receipt).
agentNodeSelectionStore's provisional comments restore to
canonical as their forward references resolve (comment-only diff).

Kept against canonical: main-era select-only guards and tests, the
element-tracking family, the workspace-inset toast fallback
(composed with the agent anchor as one seam), and every base-side
chain fix. Promoted, not cut: the extension's selection-persistence
hooks statically import across the cloud-guard chunk boundary this
lineage keeps dynamic - needs a ruling. Local gates only: no CI
runs on this branch by design.
Review findings on the slice-16 cut, fixed in place: lift the
canonical NodeWidgets non-interactivity test so the pointer-events
arm is bound (mutant-red verified); drop the redundant
vi.clearAllMocks that turned pnpm lint red under
comfy/no-redundant-vitest-cleanup (restoreMocks is global); delete
the merge-artifact duplicate of the splitter overflow test; add
forceDisabled binding tests at the computeProcessedWidgets level
(mutant-red verified; the composable wiring line remains covered
only transitively, matching canonical); assert the selection
restore reads the per-workflow key; reword the agentPanel.ts
header comment to carve out the deliberately static
agentNodeSelectionStore import.

Census corrections, superseding the prior hand-back wording: 17 of
30 files are byte-identical to canonical, not 14; the
DockedAgentPanel mount IS present in GraphCanvas (component-is
form) - what the cut omits is canonical's static-import form and
the linearMode slot-sync watch, so the toast anchor's
docked-agent-panel fallback is live in graph view; three sites
gained the isActive arm in useNodePointerInteractions (lines
56/71/150), not only the toggle-path multiSelect. The prior
message's "needs a ruling" on the extension seam is stale: the
shipped code resolves it - only agentPanelStore crosses the
cloud-guard boundary via await import(), the rest are core-side
statics. Deferred-toast single-remove replay and the anchor-seam
row crossing are canonical-shape/disclosed, unchanged. Local gates
only: no CI runs on this branch by design.
…dapter' into hub-16-step

# Conflicts:
#	src/assets/css/style.css
#	src/components/LiteGraphCanvasSplitterOverlay.test.ts
#	src/components/graph/GraphCanvas.vue
#	src/components/graph/NodeSelectionModeBanner.test.ts
#	src/components/toast/GlobalToast.test.ts
#	src/components/toast/GlobalToast.vue
#	src/extensions/core/agentPanel.ts
#	src/locales/en/main.json
#	src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts
@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 8ba994a7-8c95-4abc-bd4e-574a6acd98c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/01/2026, 12:25:57 PM UTC

Links

🎭 Playwright: ✅ 1888 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1867 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 141ms TBT · 84.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.2 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 101ms TBT · 176.5 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 371ms TBT · 169.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 506ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.8 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 943ms
canvas-mouse-sweep: script duration 169ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.8 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -156
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 361ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 458ms
dom-widget-clipping: script duration 162ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.0 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 598ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.7 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -169
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1624ms
large-graph-pan: script duration 795ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.9 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -89
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1689ms
large-graph-zoom: script duration 758ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.8 MB
large-graph-zoom: DOM nodes -139
large-graph-zoom: event listeners -70
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1905ms
legacy-node-drag: script duration 934ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 88.3 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 554ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.3 MB
minimap-idle: DOM nodes -275
minimap-idle: event listeners -90
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 409ms
subgraph-dom-widget-clipping: script duration 138ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.4 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 492ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.3 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -215
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 815ms
subgraph-mouse-sweep: script duration 107ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.8 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 970ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 141ms
subgraph-transition-enter: heap used 84.4 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 33ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 245
viewport-pan-sweep: task duration 5720ms
viewport-pan-sweep: script duration 2597ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.4 MB
viewport-pan-sweep: DOM nodes -273
viewport-pan-sweep: event listeners -59
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16824ms
vue-large-graph-idle: script duration 309ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.2 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 164
vue-large-graph-pan: task duration 20475ms
vue-large-graph-pan: script duration 902ms
vue-large-graph-pan: TBT 101ms
vue-large-graph-pan: heap used 176.5 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 83ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6131ms
vue-node-resize-workload: script duration 126ms
vue-node-resize-workload: TBT 371ms
vue-node-resize-workload: heap used 169.2 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 4
workflow-execution: style recalc count 12
workflow-execution: task duration 108ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.4 MB
workflow-execution: DOM nodes 175
workflow-execution: event listeners 89
Raw data
{
  "timestamp": "2026-09-01T12:37:51.817Z",
  "gitSha": "cf301f6767304b6ac29fae904bd6d67d16feaa6d",
  "branch": "nathaniel/agent-v1/16-canvas-navigation",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2054.930000000013,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 11.957,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 517.489,
      "heapDeltaBytes": -107052,
      "heapUsedBytes": 69885748,
      "domNodes": -279,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 9.354999999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.5740000000396,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 493.90999999999997,
      "heapDeltaBytes": -11430492,
      "heapUsedBytes": 57573920,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.43,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2054.0710000000217,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 50.327000000000005,
      "layouts": 14,
      "layoutDurationMs": 5.467,
      "taskDurationMs": 1014.737,
      "heapDeltaBytes": -8540876,
      "heapUsedBytes": 61606148,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 181.617,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1835.3839999999764,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 37.136,
      "layouts": 14,
      "layoutDurationMs": 4.17,
      "taskDurationMs": 871.0590000000001,
      "heapDeltaBytes": -9863996,
      "heapUsedBytes": 59654764,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 155.698,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1719.996999999978,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 18.757999999999996,
      "layouts": 6,
      "layoutDurationMs": 1.1400000000000001,
      "taskDurationMs": 366.593,
      "heapDeltaBytes": 4404980,
      "heapUsedBytes": 74354228,
      "domNodes": 78,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.505,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1717.6430000000664,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.429,
      "layouts": 6,
      "layoutDurationMs": 1.266,
      "taskDurationMs": 354.766,
      "heapDeltaBytes": 4342012,
      "heapUsedBytes": 74278640,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.985000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 663.2290000000012,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.113,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 469.83399999999995,
      "heapDeltaBytes": 18166800,
      "heapUsedBytes": 88004844,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 165.268,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 648.119999999949,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.681,
      "heapDeltaBytes": 18463968,
      "heapUsedBytes": 88081124,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 159.378,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.7730000000251,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.808,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 594.1200000000001,
      "heapDeltaBytes": 10967368,
      "heapUsedBytes": 86139720,
      "domNodes": -271,
      "jsHeapTotalBytes": -860160,
      "scriptDurationMs": 34.94,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2046.9769999999698,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.771999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 602.0790000000001,
      "heapDeltaBytes": -12983932,
      "heapUsedBytes": 87247940,
      "domNodes": -267,
      "jsHeapTotalBytes": -1609728,
      "scriptDurationMs": 35.276,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2258.4920000000466,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.700000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1571.9250000000002,
      "heapDeltaBytes": 21968888,
      "heapUsedBytes": 87723172,
      "domNodes": -272,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 768.987,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2279.543999999987,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.157000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1675.5729999999999,
      "heapDeltaBytes": -13519492,
      "heapUsedBytes": 83968864,
      "domNodes": -276,
      "jsHeapTotalBytes": 712704,
      "scriptDurationMs": 820.405,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3520.557999999994,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.948,
      "layouts": 60,
      "layoutDurationMs": 12.869000000000002,
      "taskDurationMs": 1663.1499999999999,
      "heapDeltaBytes": 10346956,
      "heapUsedBytes": 76605460,
      "domNodes": -277,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 735.254,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3598.5279999999875,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.758000000000003,
      "layouts": 60,
      "layoutDurationMs": 13.057999999999998,
      "taskDurationMs": 1714.8759999999997,
      "heapDeltaBytes": 8436704,
      "heapUsedBytes": 76123288,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 780.818,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3016.1070000000336,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.712000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1891.8059999999998,
      "heapDeltaBytes": 24884120,
      "heapUsedBytes": 91677176,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 933.711,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3082.559999999944,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.744999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1917.4940000000001,
      "heapDeltaBytes": 26078028,
      "heapUsedBytes": 93421248,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 933.371,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2036.6039999999543,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.3870000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 581.3779999999999,
      "heapDeltaBytes": 10255076,
      "heapUsedBytes": 87050816,
      "domNodes": -274,
      "jsHeapTotalBytes": -1908736,
      "scriptDurationMs": 31.671000000000006,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2002.884999999992,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.3169999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.6560000000001,
      "heapDeltaBytes": 21797124,
      "heapUsedBytes": 87585116,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.375000000000007,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 580.6929999999966,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.606999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.471,
      "heapDeltaBytes": 13548840,
      "heapUsedBytes": 85589684,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 137.68,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 572.7749999999787,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.836,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.231,
      "heapDeltaBytes": 14756660,
      "heapUsedBytes": 87121984,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 137.518,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.5429999999847,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.164000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.91799999999995,
      "heapDeltaBytes": -7627500,
      "heapUsedBytes": 64366864,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.407000000000002,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.6620000000821,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.641,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.358,
      "heapDeltaBytes": 3006968,
      "heapUsedBytes": 68325564,
      "domNodes": -297,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.517,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.8850000000093,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 36.123999999999995,
      "layouts": 18,
      "layoutDurationMs": 5.073,
      "taskDurationMs": 814.191,
      "heapDeltaBytes": 3423680,
      "heapUsedBytes": 75417376,
      "domNodes": -295,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 106.27000000000001,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1741.8709999999464,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 36.995,
      "layouts": 18,
      "layoutDurationMs": 5.824,
      "taskDurationMs": 814.991,
      "heapDeltaBytes": -9383832,
      "heapUsedBytes": 62558628,
      "domNodes": -296,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 107.46,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1433.8520000000017,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 33.3,
      "layouts": 14,
      "layoutDurationMs": 15.893999999999998,
      "taskDurationMs": 969.8090000000002,
      "heapDeltaBytes": -7267312,
      "heapUsedBytes": 88483156,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 31.33799999999999,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8399.338,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 33.461,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5713.889,
      "heapDeltaBytes": 23490152,
      "heapUsedBytes": 88552904,
      "domNodes": -273,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 2597.904,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8547.651000000087,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 32.805,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5725.607,
      "heapDeltaBytes": 19088160,
      "heapUsedBytes": 84154972,
      "domNodes": -273,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 2596.838,
      "eventListeners": 22,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17351.608,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16733.582,
      "heapDeltaBytes": -33971412,
      "heapUsedBytes": 176470592,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1052672,
      "scriptDurationMs": 300.48699999999997,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17666.969999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16914.202,
      "heapDeltaBytes": -33776900,
      "heapUsedBytes": 174141840,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2904064,
      "scriptDurationMs": 317.966,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20754.623999999978,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 17.716999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20415.625,
      "heapDeltaBytes": -24760656,
      "heapUsedBytes": 180118356,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7761920,
      "scriptDurationMs": 920.605,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 7,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20869.572999999946,
      "styleRecalcs": 164,
      "styleRecalcDurationMs": 17.769000000000034,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20533.763,
      "heapDeltaBytes": -26254900,
      "heapUsedBytes": 190007564,
      "domNodes": -6548,
      "jsHeapTotalBytes": 720896,
      "scriptDurationMs": 884.237,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 195,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6242.499000000009,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.01399999999998,
      "layouts": 20,
      "layoutDurationMs": 22.635,
      "taskDurationMs": 6170.077,
      "heapDeltaBytes": -19000580,
      "heapUsedBytes": 181445316,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12746752,
      "scriptDurationMs": 112.508,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 383,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6224.567999999977,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.235,
      "layouts": 20,
      "layoutDurationMs": 22.614999999999995,
      "taskDurationMs": 6092.594,
      "heapDeltaBytes": -37200752,
      "heapUsedBytes": 173355368,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3510272,
      "scriptDurationMs": 140.16600000000003,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 359,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 129.61800000005042,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 20.964,
      "layouts": 4,
      "layoutDurationMs": 2.0619999999999994,
      "taskDurationMs": 103.61000000000001,
      "heapDeltaBytes": 3828476,
      "heapUsedBytes": 71137332,
      "domNodes": 227,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.648,
      "eventListeners": 79,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 479.89800000004834,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 22.82,
      "layouts": 4,
      "layoutDurationMs": 1.723,
      "taskDurationMs": 111.68,
      "heapDeltaBytes": 5049836,
      "heapUsedBytes": 72370492,
      "domNodes": 123,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 8.251,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48050 70508 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.7% 391
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.5% 251
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 31, 2026
@codecov

codecov Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                            Coverage Diff                             @@
##           nathaniel/agent-v1/15-lifetime-adapter   #16424      +/-   ##
==========================================================================
+ Coverage                                   83.25%   83.26%   +0.01%     
==========================================================================
  Files                                        2025     2025              
  Lines                                      117465   117495      +30     
  Branches                                    32612    33209     +597     
==========================================================================
+ Hits                                        97801    97838      +37     
+ Misses                                      19311    19304       -7     
  Partials                                      353      353              
Flag Coverage Δ
e2e 66.63% <63.88%> (-0.03%) ⬇️
unit 76.55% <95.45%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/toast/GlobalToast.vue 92.85% <100.00%> (+0.54%) ⬆️
src/constants/splitterConstants.ts 100.00% <100.00%> (ø)
src/extensions/core/agentPanel.ts 94.28% <100.00%> (+33.41%) ⬆️
...tform/settings/composables/useLitegraphSettings.ts 100.00% <100.00%> (ø)
...erer/extensions/vueNodes/components/LGraphNode.vue 85.19% <100.00%> (+0.16%) ⬆️
...erer/extensions/vueNodes/components/NodeHeader.vue 84.61% <100.00%> (+4.05%) ⬆️
...rer/extensions/vueNodes/components/NodeWidgets.vue 78.26% <100.00%> (+0.98%) ⬆️
...vueNodes/composables/processedWidgetRenderModel.ts 97.15% <100.00%> (+0.01%) ⬆️
...vueNodes/composables/useNodePointerInteractions.ts 94.31% <100.00%> (-0.19%) ⬇️
...nsions/vueNodes/composables/useProcessedWidgets.ts 90.62% <100.00%> (+0.30%) ⬆️
... and 1 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 4
🟡 Medium 4
🟢 Low 2

Panel: 8/8 reviewers contributed findings.

// First handle the standard right-click behavior (selection)
handleNodeRightClick(event as PointerEvent, nodeData.id)

if (agentNodeSelectionStore.isActive) return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — The guard is placed after handleNodeRightClick, so it only suppresses the options menu, not the selection side effect: for an unselected node that handler calls handleNodeSelect with multiSelect false (a plain right-click carries no modifier), which runs canvas.deselectAll() then select(node). Since canvas selection is the pick basket while the mode is active, one right-click discards every node the user has staged — move the agentNodeSelectionStore.isActive return above the handleNodeRightClick call. Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

nodeData.resizable !== false &&
!isSelectMode
!isSelectMode &&
!agentNodeSelectionStore.isActive

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — Selection mode strips resize handles, alt-clone, the context menu, widget pointer events and title editing, but NodeSlots and NodeFooter are untouched: InputSlot/OutputSlot bind @​pointerdown to useSlotLinkInteraction, which is not gated on isActive — it stopPropagation()s (so no node is picked) and starts a link drag that rewires the graph on release, and ctrl/cmd+alt on a slot disconnects immediately. Footer tabs keep their own pointer-events-auto, and "enter subgraph" navigates the canvas, which trips AgentPanelRoot's workflow/graph watcher and tears the mode down mid-pick. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case).

])
if (!useAgentPanelStore().isOpen) return

useAgentNodeSelectionStore().beginWorkflowLoad()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — beginWorkflowLoad() is a one-way latch cleared only by the success path of afterLoadGraph, with no try/finally: app.ts skips both after-hooks when graph configure throws (loadGraphData resolves false after only beforeLoadGraph), and invokeExtensionsAsync swallows a rejection from these import()s or from getNodeByLocatorId/selectItems — chunk-fetch failures and ad blockers being exactly what this file's comments anticipate. One malformed workflow then leaves isLoadingWorkflow true for the rest of the session, permanently pausing selection tracking (isPaused) and disabling the workflow-switch teardown. Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).

toast.removeAllGroups()
// Held messages were cleared too - replaying them on exit would resurrect
// exactly what the caller just dismissed.
deferredMessages = []

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — The remove-all path clears deferredMessages, but the per-message path does not: toastStore.messagesToRemove is drained with toast.remove(message), a no-op for a message PrimeVue never received, so a message removed during the mode is still replayed on exit. billingOperationStore does add(processing) → remove(processing) → add(actionRequired) with the same object identity, and refreshComboInNodes adds a progress toast and removes it in a finally — both resurrect stale toasts that no later remove will ever match. Filter deferredMessages in the messagesToRemove watcher too. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).

Comment thread src/assets/css/style.css
and is unaffected. Toggled by agentNodeSelectionStore. */
.node-selection-active .p-toast {
visibility: hidden;
display: none;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — This hides every toast container document-wide, but only messages routed through toastStore are deferred by GlobalToast. Roughly 35 modules call useToast().add() directly (useReconnectingNotification, useCopyToClipboard, useSubscriptionCheckout, useResubscribe, and AgentPanelRoot itself), so a connection-lost, auth, or billing error raised while picking renders into a display: none container and is auto-removed by its own life timer without ever being seen. Deferring at the toast service would cover every caller. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case).

* Messages raised while node selection mode is active. The mode hides the whole
* toast layer, and adding to a hidden layer would let anything carrying a `life`
* expire unseen - so they are held here and replayed on exit. Messages without a
* `life` are sticky in PrimeVue, so errors already on screen survive the hide

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — The "messages without a life are sticky" premise does not hold: PrimeVue's ToastMessage schedules removal after message.life || 3000 unless the message sets sticky: true, and no call site here sets sticky. A toast already on screen when the mode is entered therefore runs out its default life behind the hidden layer and is never replayed, since only messages raised during the mode are deferred — the exact loss this queue exists to prevent. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

if (isPinned()) return

if (agentNodeSelectionStore.isActive) return
if (isPinned() || agentNodeSelectionStore.isActive) return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — In selection mode onPointerdown returns before dragGuard.recordStart(event), so onPointerup has nothing to discriminate a click from a drag and never verifies that the press started on this node: press-move-release over a node toggles it, and a pointerup landing on a node after a pan or box-drag begun elsewhere toggles that node too. Record the pointerdown (or require a matching down on this node) before returning. Raised by 2 of 8 reviewers (gemini-3.1-pro edge-case, gpt-5.6-sol-max edge-case).


const multiSelect =
agentNodeSelectionStore.isActive || isMultiSelectKey(event)
isMultiSelectKey(event) || agentNodeSelectionStore.isActive

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — onPointerup still early-returns for pinned nodes above this point, so a pinned node cannot be picked by clicking its body during selection mode — the header checkbox becomes the only way to reach it, even though the mode is purely additive selection and never moves the node. That pinned guard should not apply while agentNodeSelectionStore.isActive. Raised by 1 of 8 reviewers (gemini-3.1-pro edge-case).

if (agentNodeSelectionStore.isActive) deferredMessages.push(message)
else toast.add(message)
if (agentNodeSelectionStore.isActive) {
deferredMessages.push(message)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The queue has no cap, no dedupe, and ignores each message's life, while the mode can stay active indefinitely; a repeating source (reconnect loop, failing poll, per-node execution errors) accumulates entries and then flushes all of them to the screen in one synchronous burst on exit. A drop-oldest cap or dedupe by summary would bound both the growth and the flood. Raised by 4 of 8 reviewers (gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max adversarial).

rootGraph: app.isGraphReady ? app.rootGraph : null,
ui
ui,
forceDisabled: agentNodeSelectionStore.isActive

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — forceDisabled is injected inside the shared composable, so it disables widgets for every host of these processed widgets — src/components/builder/AppModeWidgetList.vue and the right-side-panel parameter tabs included — not just canvas nodes. Passing the flag from the graph-node call site keeps the blast radius equal to the intent. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Sep 2, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Round 2 — ledger: 10 prior finding(s) across 1 round(s) (10 never answered).

Found 10 finding(s).

Severity Count
🟠 High 5
🟡 Medium 5

Panel: 8/8 reviewers contributed findings.


The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:

src/scripts/app.ts:2112 — 🟠 High — This A1111 branch and loadApiJson below still tear down and rebuild the whole root graph, but no longer invoke beforeLoadGraph/beforeConfigureGraph/afterConfigureGraph/afterLoadGraph — and beforeLoadGraph was also dropped from ComfyExtension in src/types/comfy.ts while src/extensions/core/agentPanel.ts still registers it. Two consequences: mintPortWiring's load bracket (opened only via those hooks) never opens, so the clear-and-rebuild is observed by the mint ports as human edits and pushed into the bound CRDT doc; and custom-node extensions relying on beforeConfigureGraph/afterConfigureGraph for widget/missing-node fixups silently stop running for API-format and A1111 imports. Raised by 6 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, gemini-3.1-pro adversarial, gemini-3.1-pro edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max edge-case).

src/lib/litegraph/src/LGraph.ts:2841 — 🟠 High — The counter restore no longer routes through observeNodeId/observeLinkId, so nothing validates workflow-supplied values: a state.lastNodeId that is a non-numeric string makes Math.max return NaN, and since toNodeId(NaN) stringifies to "NaN", every node minted afterwards gets the same id and collides — while zGraphState types these as plain z.number(), so a fractional value validates and yields fractional ids. The set last_node_id/set last_link_id setters just above lost their Number() coercion plus integer check (the untyped 0.4 configure loop feeds them raw JSON), and observeLinkId in idAllocation.ts lost its Number.isInteger guard, so a fractional or huge link id is absorbed verbatim. Raised by 5 of 8 reviewers (gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max edge-case).

src/components/topbar/WorkflowTabs.vue:223 — 🟡 Medium — Dropping the try/catch that bumped selectionRevision (together with the :key remount on SelectButton) removes the only recovery from a failed open: PrimeVue's editable holder shadows modelValue in a local d_value it writes on click and resyncs only when modelValue actually changes, so when openWorkflow rejects the store and canvas stay on the previous workflow while the tab strip keeps highlighting the one that failed to load — and the user then edits and queues under the wrong tab label. The rejection now also escapes the click handler as an unhandled promise rejection, and the regression test pinning aria-pressed reverting was deleted in the same change. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gemini-3.1-pro edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).

src/platform/assets/schemas/mediaAssetSchema.ts:57 — 🟡 Medium — Replacing zResultItem.extend({ ... .catch(undefined) }) with an intersection of plain .optional() fields drops the per-field fallback, so one malformed optional extra now rejects the entire drag payload: an empty attachment_ref fails min(1), an unknown media_kind fails the enum, and a relative or empty preview_url fails z.string().url() even though producers such as assetMappers.ts and useWidgetSelectItems.ts emit relative /api/view?... paths. parseAssetInfo swallows the failure, so getDroppedAsset loses ref/kind/previewUrl and the drop silently no-ops; the deleted mediaAssetSchema.test.ts pinned exactly this lenient per-field behavior. Raised by 7 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gemini-3.1-pro edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).

src/components/ui/dialog/dialog.variants.ts:17 — 🟡 Medium — The maximized: false width term lost --workspace-inset-right (w-[calc(100vw-1rem)]) while the horizontal placement still shifts left by half that inset, so with a right-docked surface (the agent panel this PR is about) a non-maximized dialog is sized for the full viewport but centered in the reduced workspace: its right edge lands under the panel and its left edge goes off-screen by the same inset/2, putting edge controls out of reach. The same non-inset cap was re-inlined into dialogService.ts's HUG_CONTENT_CLASS and useModelUpload.ts while showLayoutDialog kept the inset-aware version, and dialog.variants.test.ts, which pinned the inset term on every cap, was deleted. Raised by 6 of 8 reviewers (gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).

// First handle the standard right-click behavior (selection)
handleNodeRightClick(event as PointerEvent, nodeData.id)

if (agentNodeSelectionStore.isActive) return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — Still present and never answered from round 1: this guard sits after handleNodeRightClick, so it suppresses only the options menu, not the selection side effect. For an unselected node that handler calls handleNodeSelect with multiSelect false (a plain right-click carries no modifier), which runs canvas.deselectAll() then select(node), and since canvas selection is the pick basket while the mode is active, one right-click discards every node the user has staged. Move the agentNodeSelectionStore.isActive return above the handleNodeRightClick call. Raised by 3 of 8 reviewers (kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

nodeData.resizable !== false &&
!isSelectMode
!isSelectMode &&
!agentNodeSelectionStore.isActive

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — Still unanswered from round 1: selection mode gates resize handles here (and elsewhere alt-clone, the context menu, widget pointer events and title editing), but NodeSlots and NodeFooter are untouched. Slot pointerdown reaches useSlotLinkInteraction, which has no isActive/isSelectOnly guard — it stopPropagation()s so no node is picked, then starts a link drag that rewires the graph on release, and ctrl/cmd+alt on a slot disconnects immediately; the footer keeps its own pointer-events-auto, and "enter subgraph" changes canvasStore.currentGraph, tripping AgentPanelRoot's workflow/graph watcher and tearing the mode down mid-pick. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial).

toast.removeAllGroups()
// Held messages were cleared too - replaying them on exit would resurrect
// exactly what the caller just dismissed.
deferredMessages = []

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — This round added the deferredMessages = [] clear to the remove-all path but left the per-message path untouched: the messagesToRemove watcher above drains with toast.remove(message), a no-op for a message PrimeVue never received, so a message added and then removed during the mode is still replayed on exit. billingOperationStore does add(processing) → remove(processing) → add(actionRequired) with the same object identity, and refreshComboInNodes removes its progress toast in a finally — both resurrect a stale toast no later remove can match. Filter deferredMessages in the messagesToRemove watcher too. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).

if (isPinned()) return

if (agentNodeSelectionStore.isActive) return
if (isPinned() || agentNodeSelectionStore.isActive) return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Still unanswered from round 1 (merging the two guards preserved the ordering): in selection mode onPointerdown returns before dragGuard.recordStart(event), so onPointerup has nothing to discriminate a click from a drag and never verifies the press started on this node. Press-move-release over a node toggles it, and a pointerup landing on a node after a canvas pan or box-drag begun elsewhere toggles that node too. Record the pointerdown (or require a matching down on this node) before returning. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).

Comment thread src/assets/css/style.css
and is unaffected. Toggled by agentNodeSelectionStore. */
.node-selection-active .p-toast {
visibility: hidden;
display: none;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Switching visibility: hidden to display: none does not close the round-1 gap: this hides every toast container document-wide, but only messages routed through toastStore are deferred by GlobalToast. The many modules calling useToast().add() directly — useReconnectingNotification, useCopyToClipboard, useSubscriptionCheckout, useResubscribe, and AgentPanelRoot's own attachment-error handler (life: 5000) — render into the hidden container and are auto-removed by their own life timer, so a connection-lost, auth, or billing error raised while picking is never seen. Deferring inside the toast service (or a useToast wrapper) would cover every caller. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).

@christian-byrne

Copy link
Copy Markdown
Contributor

This slice is reference-only. Accepted work is routed to #16401 and #16340.

Full context for agent readers

Per Christian's main-target close ruling, #16424 (16 — canvas navigation and selection persistence) is no longer a landing vehicle. It remains readable implementation and review provenance. Broad selection-mode blocking was deliberately rejected. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path.

Decision record.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components cursor-review Trigger multi-model Cursor agent review on this PR preview risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants