Repository navigation
[agent-v1 16/18] feat(agent): canvas navigation and selection persistence - #16424
CodeJuggernaut wants to merge 11 commits into
Conversation
Lands the slice-16 canvas-navigation surface on the post-cascade tip. Core: the NodeSelectionModeBanner pair at canonical bytes, GraphCanvas wiring, the toast-layer hide rule with GlobalToast's hold-and-replay deferral and four tests, the agent.nodeSelection locale block, and the delete-guard WHY comment. Consumer sweep, derived from the store's canonical importer graph: splitter panels, top-menu action bars, side toolbar, node switch popup, and release toast all hide or defer during the mode; vue nodes gain the in-mode outline, header checkbox, pointer guards, context-menu suppression, and forceDisabled widget plumbing; the canvas-info overlay suppresses via the existing watch idiom with the mode as an explicit source (the watchEffect form regressed the slot-read reactivity pin - its failing test is the receipt). agentNodeSelectionStore's provisional comments restore to canonical as their forward references resolve (comment-only diff). Kept against canonical: main-era select-only guards and tests, the element-tracking family, the workspace-inset toast fallback (composed with the agent anchor as one seam), and every base-side chain fix. Promoted, not cut: the extension's selection-persistence hooks statically import across the cloud-guard chunk boundary this lineage keeps dynamic - needs a ruling. Local gates only: no CI runs on this branch by design.
Review findings on the slice-16 cut, fixed in place: lift the canonical NodeWidgets non-interactivity test so the pointer-events arm is bound (mutant-red verified); drop the redundant vi.clearAllMocks that turned pnpm lint red under comfy/no-redundant-vitest-cleanup (restoreMocks is global); delete the merge-artifact duplicate of the splitter overflow test; add forceDisabled binding tests at the computeProcessedWidgets level (mutant-red verified; the composable wiring line remains covered only transitively, matching canonical); assert the selection restore reads the per-workflow key; reword the agentPanel.ts header comment to carve out the deliberately static agentNodeSelectionStore import. Census corrections, superseding the prior hand-back wording: 17 of 30 files are byte-identical to canonical, not 14; the DockedAgentPanel mount IS present in GraphCanvas (component-is form) - what the cut omits is canonical's static-import form and the linearMode slot-sync watch, so the toast anchor's docked-agent-panel fallback is live in graph view; three sites gained the isActive arm in useNodePointerInteractions (lines 56/71/150), not only the toggle-path multiSelect. The prior message's "needs a ruling" on the extension seam is stale: the shipped code resolves it - only agentPanelStore crosses the cloud-guard boundary via await import(), the rest are core-side statics. Deferred-toast single-remove replay and the anchor-seam row crossing are canonical-shape/disclosed, unchanged. Local gates only: no CI runs on this branch by design.
…dapter' into hub-16-step # Conflicts: # src/assets/css/style.css # src/components/LiteGraphCanvasSplitterOverlay.test.ts # src/components/graph/GraphCanvas.vue # src/components/graph/NodeSelectionModeBanner.test.ts # src/components/toast/GlobalToast.test.ts # src/components/toast/GlobalToast.vue # src/extensions/core/agentPanel.ts # src/locales/en/main.json # src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts
…dapter' into hub-16-step
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1888 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-01T12:37:51.817Z",
"gitSha": "cf301f6767304b6ac29fae904bd6d67d16feaa6d",
"branch": "nathaniel/agent-v1/16-canvas-navigation",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.930000000013,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.489,
"heapDeltaBytes": -107052,
"heapUsedBytes": 69885748,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.354999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2038.5740000000396,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.90999999999997,
"heapDeltaBytes": -11430492,
"heapUsedBytes": 57573920,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.43,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2054.0710000000217,
"styleRecalcs": 82,
"styleRecalcDurationMs": 50.327000000000005,
"layouts": 14,
"layoutDurationMs": 5.467,
"taskDurationMs": 1014.737,
"heapDeltaBytes": -8540876,
"heapUsedBytes": 61606148,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 181.617,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1835.3839999999764,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.136,
"layouts": 14,
"layoutDurationMs": 4.17,
"taskDurationMs": 871.0590000000001,
"heapDeltaBytes": -9863996,
"heapUsedBytes": 59654764,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 155.698,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.996999999978,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.757999999999996,
"layouts": 6,
"layoutDurationMs": 1.1400000000000001,
"taskDurationMs": 366.593,
"heapDeltaBytes": 4404980,
"heapUsedBytes": 74354228,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.505,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.6430000000664,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.429,
"layouts": 6,
"layoutDurationMs": 1.266,
"taskDurationMs": 354.766,
"heapDeltaBytes": 4342012,
"heapUsedBytes": 74278640,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.985000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 663.2290000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.83399999999995,
"heapDeltaBytes": 18166800,
"heapUsedBytes": 88004844,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 165.268,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 648.119999999949,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.681,
"heapDeltaBytes": 18463968,
"heapUsedBytes": 88081124,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 159.378,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.7730000000251,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.808,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.1200000000001,
"heapDeltaBytes": 10967368,
"heapUsedBytes": 86139720,
"domNodes": -271,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 34.94,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2046.9769999999698,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.771999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.0790000000001,
"heapDeltaBytes": -12983932,
"heapUsedBytes": 87247940,
"domNodes": -267,
"jsHeapTotalBytes": -1609728,
"scriptDurationMs": 35.276,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2258.4920000000466,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.700000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1571.9250000000002,
"heapDeltaBytes": 21968888,
"heapUsedBytes": 87723172,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 768.987,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2279.543999999987,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.157000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1675.5729999999999,
"heapDeltaBytes": -13519492,
"heapUsedBytes": 83968864,
"domNodes": -276,
"jsHeapTotalBytes": 712704,
"scriptDurationMs": 820.405,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3520.557999999994,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.948,
"layouts": 60,
"layoutDurationMs": 12.869000000000002,
"taskDurationMs": 1663.1499999999999,
"heapDeltaBytes": 10346956,
"heapUsedBytes": 76605460,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 735.254,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3598.5279999999875,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.758000000000003,
"layouts": 60,
"layoutDurationMs": 13.057999999999998,
"taskDurationMs": 1714.8759999999997,
"heapDeltaBytes": 8436704,
"heapUsedBytes": 76123288,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 780.818,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3016.1070000000336,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.712000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1891.8059999999998,
"heapDeltaBytes": 24884120,
"heapUsedBytes": 91677176,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 933.711,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3082.559999999944,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.744999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1917.4940000000001,
"heapDeltaBytes": 26078028,
"heapUsedBytes": 93421248,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 933.371,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.6039999999543,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.3870000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.3779999999999,
"heapDeltaBytes": 10255076,
"heapUsedBytes": 87050816,
"domNodes": -274,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 31.671000000000006,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2002.884999999992,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.3169999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.6560000000001,
"heapDeltaBytes": 21797124,
"heapUsedBytes": 87585116,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.375000000000007,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.6929999999966,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.606999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.471,
"heapDeltaBytes": 13548840,
"heapUsedBytes": 85589684,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 137.68,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.7749999999787,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.231,
"heapDeltaBytes": 14756660,
"heapUsedBytes": 87121984,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 137.518,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.5429999999847,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.164000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.91799999999995,
"heapDeltaBytes": -7627500,
"heapUsedBytes": 64366864,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.407000000000002,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.6620000000821,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.641,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.358,
"heapDeltaBytes": 3006968,
"heapUsedBytes": 68325564,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.517,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.8850000000093,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.123999999999995,
"layouts": 18,
"layoutDurationMs": 5.073,
"taskDurationMs": 814.191,
"heapDeltaBytes": 3423680,
"heapUsedBytes": 75417376,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 106.27000000000001,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.8709999999464,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.995,
"layouts": 18,
"layoutDurationMs": 5.824,
"taskDurationMs": 814.991,
"heapDeltaBytes": -9383832,
"heapUsedBytes": 62558628,
"domNodes": -296,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 107.46,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.8520000000017,
"styleRecalcs": 18,
"styleRecalcDurationMs": 33.3,
"layouts": 14,
"layoutDurationMs": 15.893999999999998,
"taskDurationMs": 969.8090000000002,
"heapDeltaBytes": -7267312,
"heapUsedBytes": 88483156,
"domNodes": 13671,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.33799999999999,
"eventListeners": 2381,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8399.338,
"styleRecalcs": 245,
"styleRecalcDurationMs": 33.461,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5713.889,
"heapDeltaBytes": 23490152,
"heapUsedBytes": 88552904,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2597.904,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8547.651000000087,
"styleRecalcs": 245,
"styleRecalcDurationMs": 32.805,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5725.607,
"heapDeltaBytes": 19088160,
"heapUsedBytes": 84154972,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2596.838,
"eventListeners": 22,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17351.608,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16733.582,
"heapDeltaBytes": -33971412,
"heapUsedBytes": 176470592,
"domNodes": -6548,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 300.48699999999997,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17666.969999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16914.202,
"heapDeltaBytes": -33776900,
"heapUsedBytes": 174141840,
"domNodes": -6548,
"jsHeapTotalBytes": -2904064,
"scriptDurationMs": 317.966,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20754.623999999978,
"styleRecalcs": 163,
"styleRecalcDurationMs": 17.716999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20415.625,
"heapDeltaBytes": -24760656,
"heapUsedBytes": 180118356,
"domNodes": -6548,
"jsHeapTotalBytes": -7761920,
"scriptDurationMs": 920.605,
"eventListeners": -7469,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20869.572999999946,
"styleRecalcs": 164,
"styleRecalcDurationMs": 17.769000000000034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20533.763,
"heapDeltaBytes": -26254900,
"heapUsedBytes": 190007564,
"domNodes": -6548,
"jsHeapTotalBytes": 720896,
"scriptDurationMs": 884.237,
"eventListeners": -7467,
"totalBlockingTimeMs": 195,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6242.499000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.01399999999998,
"layouts": 20,
"layoutDurationMs": 22.635,
"taskDurationMs": 6170.077,
"heapDeltaBytes": -19000580,
"heapUsedBytes": 181445316,
"domNodes": -6548,
"jsHeapTotalBytes": 12746752,
"scriptDurationMs": 112.508,
"eventListeners": -7473,
"totalBlockingTimeMs": 383,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6224.567999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.235,
"layouts": 20,
"layoutDurationMs": 22.614999999999995,
"taskDurationMs": 6092.594,
"heapDeltaBytes": -37200752,
"heapUsedBytes": 173355368,
"domNodes": -6548,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 140.16600000000003,
"eventListeners": -7469,
"totalBlockingTimeMs": 359,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 129.61800000005042,
"styleRecalcs": 10,
"styleRecalcDurationMs": 20.964,
"layouts": 4,
"layoutDurationMs": 2.0619999999999994,
"taskDurationMs": 103.61000000000001,
"heapDeltaBytes": 3828476,
"heapUsedBytes": 71137332,
"domNodes": 227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.648,
"eventListeners": 79,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 479.89800000004834,
"styleRecalcs": 14,
"styleRecalcDurationMs": 22.82,
"layouts": 4,
"layoutDurationMs": 1.723,
"taskDurationMs": 111.68,
"heapDeltaBytes": 5049836,
"heapUsedBytes": 72370492,
"domNodes": 123,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.251,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-v1/15-lifetime-adapter #16424 +/- ##
==========================================================================
+ Coverage 83.25% 83.26% +0.01%
==========================================================================
Files 2025 2025
Lines 117465 117495 +30
Branches 32612 33209 +597
==========================================================================
+ Hits 97801 97838 +37
+ Misses 19311 19304 -7
Partials 353 353
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 4 |
| 🟡 Medium | 4 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
| // First handle the standard right-click behavior (selection) | ||
| handleNodeRightClick(event as PointerEvent, nodeData.id) | ||
|
|
||
| if (agentNodeSelectionStore.isActive) return |
There was a problem hiding this comment.
🟠 High — The guard is placed after handleNodeRightClick, so it only suppresses the options menu, not the selection side effect: for an unselected node that handler calls handleNodeSelect with multiSelect false (a plain right-click carries no modifier), which runs canvas.deselectAll() then select(node). Since canvas selection is the pick basket while the mode is active, one right-click discards every node the user has staged — move the agentNodeSelectionStore.isActive return above the handleNodeRightClick call. Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| nodeData.resizable !== false && | ||
| !isSelectMode | ||
| !isSelectMode && | ||
| !agentNodeSelectionStore.isActive |
There was a problem hiding this comment.
🟠 High — Selection mode strips resize handles, alt-clone, the context menu, widget pointer events and title editing, but NodeSlots and NodeFooter are untouched: InputSlot/OutputSlot bind @pointerdown to useSlotLinkInteraction, which is not gated on isActive — it stopPropagation()s (so no node is picked) and starts a link drag that rewires the graph on release, and ctrl/cmd+alt on a slot disconnects immediately. Footer tabs keep their own pointer-events-auto, and "enter subgraph" navigates the canvas, which trips AgentPanelRoot's workflow/graph watcher and tears the mode down mid-pick. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case).
| ]) | ||
| if (!useAgentPanelStore().isOpen) return | ||
|
|
||
| useAgentNodeSelectionStore().beginWorkflowLoad() |
There was a problem hiding this comment.
🟠 High — beginWorkflowLoad() is a one-way latch cleared only by the success path of afterLoadGraph, with no try/finally: app.ts skips both after-hooks when graph configure throws (loadGraphData resolves false after only beforeLoadGraph), and invokeExtensionsAsync swallows a rejection from these import()s or from getNodeByLocatorId/selectItems — chunk-fetch failures and ad blockers being exactly what this file's comments anticipate. One malformed workflow then leaves isLoadingWorkflow true for the rest of the session, permanently pausing selection tracking (isPaused) and disabling the workflow-switch teardown. Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
| toast.removeAllGroups() | ||
| // Held messages were cleared too - replaying them on exit would resurrect | ||
| // exactly what the caller just dismissed. | ||
| deferredMessages = [] |
There was a problem hiding this comment.
🟠 High — The remove-all path clears deferredMessages, but the per-message path does not: toastStore.messagesToRemove is drained with toast.remove(message), a no-op for a message PrimeVue never received, so a message removed during the mode is still replayed on exit. billingOperationStore does add(processing) → remove(processing) → add(actionRequired) with the same object identity, and refreshComboInNodes adds a progress toast and removes it in a finally — both resurrect stale toasts that no later remove will ever match. Filter deferredMessages in the messagesToRemove watcher too. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
| and is unaffected. Toggled by agentNodeSelectionStore. */ | ||
| .node-selection-active .p-toast { | ||
| visibility: hidden; | ||
| display: none; |
There was a problem hiding this comment.
🟡 Medium — This hides every toast container document-wide, but only messages routed through toastStore are deferred by GlobalToast. Roughly 35 modules call useToast().add() directly (useReconnectingNotification, useCopyToClipboard, useSubscriptionCheckout, useResubscribe, and AgentPanelRoot itself), so a connection-lost, auth, or billing error raised while picking renders into a display: none container and is auto-removed by its own life timer without ever being seen. Deferring at the toast service would cover every caller. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case).
| * Messages raised while node selection mode is active. The mode hides the whole | ||
| * toast layer, and adding to a hidden layer would let anything carrying a `life` | ||
| * expire unseen - so they are held here and replayed on exit. Messages without a | ||
| * `life` are sticky in PrimeVue, so errors already on screen survive the hide |
There was a problem hiding this comment.
🟡 Medium — The "messages without a life are sticky" premise does not hold: PrimeVue's ToastMessage schedules removal after message.life || 3000 unless the message sets sticky: true, and no call site here sets sticky. A toast already on screen when the mode is entered therefore runs out its default life behind the hidden layer and is never replayed, since only messages raised during the mode are deferred — the exact loss this queue exists to prevent. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| if (isPinned()) return | ||
|
|
||
| if (agentNodeSelectionStore.isActive) return | ||
| if (isPinned() || agentNodeSelectionStore.isActive) return |
There was a problem hiding this comment.
🟡 Medium — In selection mode onPointerdown returns before dragGuard.recordStart(event), so onPointerup has nothing to discriminate a click from a drag and never verifies that the press started on this node: press-move-release over a node toggles it, and a pointerup landing on a node after a pan or box-drag begun elsewhere toggles that node too. Record the pointerdown (or require a matching down on this node) before returning. Raised by 2 of 8 reviewers (gemini-3.1-pro edge-case, gpt-5.6-sol-max edge-case).
|
|
||
| const multiSelect = | ||
| agentNodeSelectionStore.isActive || isMultiSelectKey(event) | ||
| isMultiSelectKey(event) || agentNodeSelectionStore.isActive |
There was a problem hiding this comment.
🟡 Medium — onPointerup still early-returns for pinned nodes above this point, so a pinned node cannot be picked by clicking its body during selection mode — the header checkbox becomes the only way to reach it, even though the mode is purely additive selection and never moves the node. That pinned guard should not apply while agentNodeSelectionStore.isActive. Raised by 1 of 8 reviewers (gemini-3.1-pro edge-case).
| if (agentNodeSelectionStore.isActive) deferredMessages.push(message) | ||
| else toast.add(message) | ||
| if (agentNodeSelectionStore.isActive) { | ||
| deferredMessages.push(message) |
There was a problem hiding this comment.
🟢 Low — The queue has no cap, no dedupe, and ignores each message's life, while the mode can stay active indefinitely; a repeating source (reconnect loop, failing poll, per-node execution errors) accumulates entries and then flushes all of them to the screen in one synchronous burst on exit. A drop-oldest cap or dedupe by summary would bound both the growth and the flood. Raised by 4 of 8 reviewers (gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max adversarial).
| rootGraph: app.isGraphReady ? app.rootGraph : null, | ||
| ui | ||
| ui, | ||
| forceDisabled: agentNodeSelectionStore.isActive |
There was a problem hiding this comment.
🟢 Low — forceDisabled is injected inside the shared composable, so it disables widgets for every host of these processed widgets — src/components/builder/AppModeWidgetList.vue and the right-side-panel parameter tabs included — not just canvas nodes. Passing the flag from the graph-node call site keeps the blast radius equal to the intent. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 10 prior finding(s) across 1 round(s) (10 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 5 |
| 🟡 Medium | 5 |
Panel: 8/8 reviewers contributed findings.
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
src/scripts/app.ts:2112— 🟠 High — This A1111 branch andloadApiJsonbelow still tear down and rebuild the whole root graph, but no longer invokebeforeLoadGraph/beforeConfigureGraph/afterConfigureGraph/afterLoadGraph— andbeforeLoadGraphwas also dropped fromComfyExtensioninsrc/types/comfy.tswhilesrc/extensions/core/agentPanel.tsstill registers it. Two consequences:mintPortWiring's load bracket (opened only via those hooks) never opens, so the clear-and-rebuild is observed by the mint ports as human edits and pushed into the bound CRDT doc; and custom-node extensions relying onbeforeConfigureGraph/afterConfigureGraphfor widget/missing-node fixups silently stop running for API-format and A1111 imports. Raised by 6 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, gemini-3.1-pro adversarial, gemini-3.1-pro edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max edge-case).
src/lib/litegraph/src/LGraph.ts:2841— 🟠 High — The counter restore no longer routes throughobserveNodeId/observeLinkId, so nothing validates workflow-supplied values: astate.lastNodeIdthat is a non-numeric string makesMath.maxreturn NaN, and sincetoNodeId(NaN)stringifies to"NaN", every node minted afterwards gets the same id and collides — whilezGraphStatetypes these as plainz.number(), so a fractional value validates and yields fractional ids. Theset last_node_id/set last_link_idsetters just above lost theirNumber()coercion plus integer check (the untyped 0.4 configure loop feeds them raw JSON), andobserveLinkIdinidAllocation.tslost itsNumber.isIntegerguard, so a fractional or huge link id is absorbed verbatim. Raised by 5 of 8 reviewers (gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max edge-case).
src/components/topbar/WorkflowTabs.vue:223— 🟡 Medium — Dropping thetry/catchthat bumpedselectionRevision(together with the:keyremount onSelectButton) removes the only recovery from a failed open: PrimeVue's editable holder shadowsmodelValuein a locald_valueit writes on click and resyncs only whenmodelValueactually changes, so whenopenWorkflowrejects the store and canvas stay on the previous workflow while the tab strip keeps highlighting the one that failed to load — and the user then edits and queues under the wrong tab label. The rejection now also escapes the click handler as an unhandled promise rejection, and the regression test pinningaria-pressedreverting was deleted in the same change. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gemini-3.1-pro edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
src/platform/assets/schemas/mediaAssetSchema.ts:57— 🟡 Medium — ReplacingzResultItem.extend({ ... .catch(undefined) })with an intersection of plain.optional()fields drops the per-field fallback, so one malformed optional extra now rejects the entire drag payload: an emptyattachment_reffailsmin(1), an unknownmedia_kindfails the enum, and a relative or emptypreview_urlfailsz.string().url()even though producers such asassetMappers.tsanduseWidgetSelectItems.tsemit relative/api/view?...paths.parseAssetInfoswallows the failure, sogetDroppedAssetlosesref/kind/previewUrland the drop silently no-ops; the deletedmediaAssetSchema.test.tspinned exactly this lenient per-field behavior. Raised by 7 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gemini-3.1-pro edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
src/components/ui/dialog/dialog.variants.ts:17— 🟡 Medium — Themaximized: falsewidth term lost--workspace-inset-right(w-[calc(100vw-1rem)]) while the horizontal placement still shifts left by half that inset, so with a right-docked surface (the agent panel this PR is about) a non-maximized dialog is sized for the full viewport but centered in the reduced workspace: its right edge lands under the panel and its left edge goes off-screen by the same inset/2, putting edge controls out of reach. The same non-inset cap was re-inlined intodialogService.ts'sHUG_CONTENT_CLASSanduseModelUpload.tswhileshowLayoutDialogkept the inset-aware version, anddialog.variants.test.ts, which pinned the inset term on every cap, was deleted. Raised by 6 of 8 reviewers (gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
| // First handle the standard right-click behavior (selection) | ||
| handleNodeRightClick(event as PointerEvent, nodeData.id) | ||
|
|
||
| if (agentNodeSelectionStore.isActive) return |
There was a problem hiding this comment.
🟠 High — Still present and never answered from round 1: this guard sits after handleNodeRightClick, so it suppresses only the options menu, not the selection side effect. For an unselected node that handler calls handleNodeSelect with multiSelect false (a plain right-click carries no modifier), which runs canvas.deselectAll() then select(node), and since canvas selection is the pick basket while the mode is active, one right-click discards every node the user has staged. Move the agentNodeSelectionStore.isActive return above the handleNodeRightClick call. Raised by 3 of 8 reviewers (kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| nodeData.resizable !== false && | ||
| !isSelectMode | ||
| !isSelectMode && | ||
| !agentNodeSelectionStore.isActive |
There was a problem hiding this comment.
🟠 High — Still unanswered from round 1: selection mode gates resize handles here (and elsewhere alt-clone, the context menu, widget pointer events and title editing), but NodeSlots and NodeFooter are untouched. Slot pointerdown reaches useSlotLinkInteraction, which has no isActive/isSelectOnly guard — it stopPropagation()s so no node is picked, then starts a link drag that rewires the graph on release, and ctrl/cmd+alt on a slot disconnects immediately; the footer keeps its own pointer-events-auto, and "enter subgraph" changes canvasStore.currentGraph, tripping AgentPanelRoot's workflow/graph watcher and tearing the mode down mid-pick. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial).
| toast.removeAllGroups() | ||
| // Held messages were cleared too - replaying them on exit would resurrect | ||
| // exactly what the caller just dismissed. | ||
| deferredMessages = [] |
There was a problem hiding this comment.
🟠 High — This round added the deferredMessages = [] clear to the remove-all path but left the per-message path untouched: the messagesToRemove watcher above drains with toast.remove(message), a no-op for a message PrimeVue never received, so a message added and then removed during the mode is still replayed on exit. billingOperationStore does add(processing) → remove(processing) → add(actionRequired) with the same object identity, and refreshComboInNodes removes its progress toast in a finally — both resurrect a stale toast no later remove can match. Filter deferredMessages in the messagesToRemove watcher too. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).
| if (isPinned()) return | ||
|
|
||
| if (agentNodeSelectionStore.isActive) return | ||
| if (isPinned() || agentNodeSelectionStore.isActive) return |
There was a problem hiding this comment.
🟡 Medium — Still unanswered from round 1 (merging the two guards preserved the ordering): in selection mode onPointerdown returns before dragGuard.recordStart(event), so onPointerup has nothing to discriminate a click from a drag and never verifies the press started on this node. Press-move-release over a node toggles it, and a pointerup landing on a node after a canvas pan or box-drag begun elsewhere toggles that node too. Record the pointerdown (or require a matching down on this node) before returning. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).
| and is unaffected. Toggled by agentNodeSelectionStore. */ | ||
| .node-selection-active .p-toast { | ||
| visibility: hidden; | ||
| display: none; |
There was a problem hiding this comment.
🟡 Medium — Switching visibility: hidden to display: none does not close the round-1 gap: this hides every toast container document-wide, but only messages routed through toastStore are deferred by GlobalToast. The many modules calling useToast().add() directly — useReconnectingNotification, useCopyToClipboard, useSubscriptionCheckout, useResubscribe, and AgentPanelRoot's own attachment-error handler (life: 5000) — render into the hidden container and are auto-removed by their own life timer, so a connection-lost, auth, or billing error raised while picking is never seen. Deferring inside the toast service (or a useToast wrapper) would cover every caller. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).
|
This slice is reference-only. Accepted work is routed to #16401 and #16340. Full context for agent readersPer Christian's main-target close ruling, #16424 (16 — canvas navigation and selection persistence) is no longer a landing vehicle. It remains readable implementation and review provenance. Broad selection-mode blocking was deliberately rejected. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path. |
Slice 16 of the agent-v1 extraction ladder (stacked on #16318).
Canvas navigation for the agent: the graph-canvas anchor contract (GRAPH_CANVAS_ANCHOR) with toast positioning against the canvas panel, the splitter overlay tests, node pointer-interaction updates for selection mode, and selection persistence across workflow loads via the extension's beforeLoadGraph/afterLoadGraph hooks (all agent chunks loaded dynamically past the cloud guard, keeping OSS builds agent-free).
Already restacked onto current main - the diff shows only this slice's own delta.
Review-audit deltas (salvage matrix): items found during the slicing and review audits that did not make it through the integration merge (#16198).
Canvas-navigation cut: anchor positioning contract, selection persistence across loads, binding tests.