Skip to content

[backport cloud/1.52] feat: open Settings on Plans & Credits from a ?settings= deep link - #16418

Closed
dante01yoon wants to merge 3 commits into
cloud/1.52from
version-bump-cloud-1-52-1.52.7-backport15808.0
Closed

dante01yoon wants to merge 3 commits into
cloud/1.52from
version-bump-cloud-1-52-1.52.7-backport15808.0

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Summary

Backports #15808 to cloud/1.52 so ?settings=plan-credits works in the frontend release currently promoted to Cloud production.

Why

cloud/1.52 branched before #15808 merged, and the original backport labels only covered 1.51. As a result, Cloud production currently strips or ignores the deep-link intent and does not open Plans & Credits.

Slack context: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1788190186965279?thread_ts=1787597535.486829&cid=C0BNGQG2LCW

Changes

Verification

  • 18 targeted unit/integration tests passed
  • pnpm typecheck passed
  • pnpm typecheck:browser passed
  • ESLint/Oxlint/oxfmt passed for changed files
  • pnpm knip passed

Screenshots

Behavior and UI are unchanged from #15808; see the original PR for AS IS / TO BE evidence.

…15808)

Manual backport to cloud/1.52.

(cherry picked from commit 22024b3)
@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 6dae4d43-a9d9-44c1-bf8d-fff29f17a2b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ❌ Failed

Details

⏰ Completed at: 08/31/2026, 09:04:28 PM UTC

Links

🎭 Playwright: 🕵🏻 0 passed, 0 failed

📊 Browser Reports
  • chromium: ❌ Deployment failed
  • chromium-2x: ❌ Deployment failed
  • chromium-0.5x: ❌ Deployment failed
  • mobile-chrome: ❌ Deployment failed

🎨 Chromatic Visual Tests

@github-actions
github-actions Bot requested a review from DrJKL August 31, 2026 20:57
@comfy-pr-bot
comfy-pr-bot requested review from a team, comfyui-wiki and ltdrdata as code owners August 31, 2026 21:02
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 31, 2026
@dante01yoon
dante01yoon deleted the version-bump-cloud-1-52-1.52.7-backport15808.0 branch August 31, 2026 21:14
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants